From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Richard Henderson" <richard.henderson@linaro.org>,
"Dapeng Mi" <dapeng1.mi@intel.com>,
"Sean Christopherson" <seanjc@google.com>,
"Bin Meng" <bin.meng@windriver.com>,
"Zhuocheng Ding" <zhuocheng.ding@intel.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Zhenyu Wang" <zhenyu.z.wang@intel.com>,
qemu-riscv@nongnu.org,
"Alistair Francis" <alistair.francis@wdc.com>,
"Zhao Liu" <zhao1.liu@intel.com>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Robert Hoo" <robert.hu@linux.intel.com>,
"Yanan Wang" <wangyanan55@huawei.com>,
qemu-arm@nongnu.org, "Peter Maydell" <peter.maydell@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Like Xu" <like.xu.linux@gmail.com>,
"Alistair Francis" <alistair@alistair23.me>,
"Zhao Liu" <zhao1.liu@linux.intel.com>,
"Eduardo Habkost" <eduardo@habkost.net>
Subject: [PATCH 5/5] hw/riscv: Restrict CPU clusters to the expected type
Date: Thu, 16 Feb 2023 15:23:38 +0100 [thread overview]
Message-ID: <20230216142338.82982-6-philmd@linaro.org> (raw)
In-Reply-To: <20230216142338.82982-1-philmd@linaro.org>
Microchip PolarFire SoC expects U51/U54 cores,
the SiFive Freedom board: the E31/E51 and U34/U54.
Do not allow any other CPU type by setting the cluster
'cpu-type' property.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
hw/riscv/microchip_pfsoc.c | 4 ++++
hw/riscv/sifive_u.c | 2 ++
2 files changed, 6 insertions(+)
diff --git a/hw/riscv/microchip_pfsoc.c b/hw/riscv/microchip_pfsoc.c
index 2b91e49561..658307fdfb 100644
--- a/hw/riscv/microchip_pfsoc.c
+++ b/hw/riscv/microchip_pfsoc.c
@@ -150,6 +150,8 @@ static void microchip_pfsoc_soc_instance_init(Object *obj)
object_initialize_child(obj, "e-cluster", &s->e_cluster, TYPE_CPU_CLUSTER);
qdev_prop_set_uint32(DEVICE(&s->e_cluster), "cluster-id", 0);
+ qdev_prop_set_string(DEVICE(&s->e_cluster), "cpu-type",
+ TYPE_RISCV_CPU_SIFIVE_E51);
object_initialize_child(OBJECT(&s->e_cluster), "e-cpus", &s->e_cpus,
TYPE_RISCV_HART_ARRAY);
@@ -161,6 +163,8 @@ static void microchip_pfsoc_soc_instance_init(Object *obj)
object_initialize_child(obj, "u-cluster", &s->u_cluster, TYPE_CPU_CLUSTER);
qdev_prop_set_uint32(DEVICE(&s->u_cluster), "cluster-id", 1);
+ qdev_prop_set_string(DEVICE(&s->e_cluster), "cpu-type",
+ TYPE_RISCV_CPU_SIFIVE_U54);
object_initialize_child(OBJECT(&s->u_cluster), "u-cpus", &s->u_cpus,
TYPE_RISCV_HART_ARRAY);
diff --git a/hw/riscv/sifive_u.c b/hw/riscv/sifive_u.c
index d3ab7a9cda..d0535746ca 100644
--- a/hw/riscv/sifive_u.c
+++ b/hw/riscv/sifive_u.c
@@ -763,6 +763,7 @@ static void sifive_u_soc_instance_init(Object *obj)
object_initialize_child(obj, "e-cluster", &s->e_cluster, TYPE_CPU_CLUSTER);
qdev_prop_set_uint32(DEVICE(&s->e_cluster), "cluster-id", 0);
+ qdev_prop_set_string(DEVICE(&s->e_cluster), "cpu-type", SIFIVE_E_CPU);
object_initialize_child(OBJECT(&s->e_cluster), "e-cpus", &s->e_cpus,
TYPE_RISCV_HART_ARRAY);
@@ -813,6 +814,7 @@ static void sifive_u_soc_realize(DeviceState *dev, Error **errp)
* CPU must exist and have been parented into the cluster before the
* cluster is realized.
*/
+ qdev_prop_set_string(DEVICE(&s->u_cluster), "cpu-type", s->cpu_type);
qdev_realize(DEVICE(&s->e_cluster), NULL, &error_abort);
qdev_realize(DEVICE(&s->u_cluster), NULL, &error_abort);
--
2.38.1
prev parent reply other threads:[~2023-02-16 14:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 14:23 [PATCH 0/5] hw/cpu/cluster: Restrict CPU cluster to a particular CPU type Philippe Mathieu-Daudé
2023-02-16 14:23 ` [PATCH 1/5] hw/cpu: Extend CPUState::cluster_index documentation Philippe Mathieu-Daudé
2023-02-21 17:47 ` Peter Maydell
2023-02-16 14:23 ` [PATCH 2/5] hw/cpu/cluster: Only add CPU objects to CPU cluster Philippe Mathieu-Daudé
2023-02-21 17:56 ` Peter Maydell
2023-02-16 14:23 ` [PATCH 3/5] hw/cpu/cluster: Restrict CPU cluster to a particular CPU type Philippe Mathieu-Daudé
2023-02-21 17:59 ` Peter Maydell
2023-02-16 14:23 ` [PATCH 4/5] hw/arm: Restrict CPU clusters to the expected type Philippe Mathieu-Daudé
2023-02-16 14:23 ` Philippe Mathieu-Daudé [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230216142338.82982-6-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=alistair.francis@wdc.com \
--cc=alistair@alistair23.me \
--cc=bin.meng@windriver.com \
--cc=dapeng1.mi@intel.com \
--cc=edgar.iglesias@gmail.com \
--cc=eduardo@habkost.net \
--cc=like.xu.linux@gmail.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=palmer@dabbelt.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=robert.hu@linux.intel.com \
--cc=seanjc@google.com \
--cc=wangyanan55@huawei.com \
--cc=zhao1.liu@intel.com \
--cc=zhao1.liu@linux.intel.com \
--cc=zhenyu.z.wang@intel.com \
--cc=zhuocheng.ding@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).