From: "Michael S. Tsirkin" <mst@redhat.com>
To: David Hildenbrand <david@redhat.com>
Cc: qemu-devel@nongnu.org, Stefan Hajnoczi <stefanha@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [PATCH v1 0/2] vhost: memslot handling improvements
Date: Fri, 17 Feb 2023 09:20:27 -0500 [thread overview]
Message-ID: <20230217091959-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <20230216114752.198627-1-david@redhat.com>
On Thu, Feb 16, 2023 at 12:47:50PM +0100, David Hildenbrand wrote:
> Following up on my previous work to make virtio-mem consume multiple
> memslots dynamically [1] that requires precise accounting between used vs.
> reserved memslots, I realized that vhost makes this extra hard by
> filtering out some memory region sections (so they don't consume a
> memslot) in the vhost-user case, which messes up the whole memslot
> accounting.
>
> This series fixes what I found to be broken and prepares for more work on
> [1]. Further, it cleanes up the merge checks that I consider unnecessary.
>
> [1] https://lkml.kernel.org/r/20211027124531.57561-8-david@redhat.com
>
> Cc: "Michael S. Tsirkin" <mst@redhat.com>
> Cc: Stefan Hajnoczi <stefanha@redhat.com>
> Cc: Dr. David Alan Gilbert <dgilbert@redhat.com>
Igor worked on memslots a lot previously and he asked for
a bit of time to review this, so I'll wait a bit before
applying.
> David Hildenbrand (2):
> vhost: Defer filtering memory sections until building the vhost memory
> structure
> vhost: Remove vhost_backend_can_merge() callback
>
> hw/virtio/vhost-user.c | 14 -----
> hw/virtio/vhost-vdpa.c | 1 -
> hw/virtio/vhost.c | 85 ++++++++++++++++++++-----------
> include/hw/virtio/vhost-backend.h | 4 --
> 4 files changed, 56 insertions(+), 48 deletions(-)
>
> --
> 2.39.1
next prev parent reply other threads:[~2023-02-17 14:20 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-16 11:47 [PATCH v1 0/2] vhost: memslot handling improvements David Hildenbrand
2023-02-16 11:47 ` [PATCH v1 1/2] vhost: Defer filtering memory sections until building the vhost memory structure David Hildenbrand
2023-02-16 12:04 ` Michael S. Tsirkin
2023-02-16 12:10 ` David Hildenbrand
2023-02-16 12:13 ` David Hildenbrand
2023-02-16 12:22 ` Michael S. Tsirkin
2023-02-16 12:21 ` Michael S. Tsirkin
2023-02-16 12:39 ` David Hildenbrand
2023-03-07 10:51 ` Igor Mammedov
2023-03-07 12:46 ` David Hildenbrand
2023-03-08 12:30 ` Igor Mammedov
2023-03-08 15:21 ` David Hildenbrand
2023-02-16 11:47 ` [PATCH v1 2/2] vhost: Remove vhost_backend_can_merge() callback David Hildenbrand
2023-03-07 10:25 ` Igor Mammedov
2023-03-07 11:16 ` Igor Mammedov
2023-03-07 11:24 ` David Hildenbrand
2023-02-16 16:04 ` [PATCH v1 0/2] vhost: memslot handling improvements Stefan Hajnoczi
2023-02-17 13:48 ` David Hildenbrand
2023-02-17 14:20 ` Michael S. Tsirkin [this message]
2023-02-17 14:27 ` David Hildenbrand
2023-03-07 11:14 ` Igor Mammedov
2023-03-08 10:08 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230217091959-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=david@redhat.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).