qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, peter.maydell@linaro.org, qemu-devel@nongnu.org
Subject: [PULL 08/22] parallels: Fix .bdrv_co_create(_opts) to open images with no_co_wrapper
Date: Fri, 17 Feb 2023 16:09:40 +0100	[thread overview]
Message-ID: <20230217150954.283920-8-kwolf@redhat.com> (raw)
In-Reply-To: <20230217150954.283920-1-kwolf@redhat.com>

.bdrv_co_create implementations run in a coroutine. Therefore they are
not allowed to open images directly. Fix the calls to use the
corresponding no_co_wrappers instead.

Signed-off-by: Kevin Wolf <kwolf@redhat.com>
Message-Id: <20230126172432.436111-5-kwolf@redhat.com>
Reviewed-by: Emanuele Giuseppe Esposito <eesposit@redhat.com>
Reviewed-by: Hanna Czenczek <hreitz@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 block/parallels.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/block/parallels.c b/block/parallels.c
index bbea2f2221..d4378e09de 100644
--- a/block/parallels.c
+++ b/block/parallels.c
@@ -565,13 +565,13 @@ static int coroutine_fn parallels_co_create(BlockdevCreateOptions* opts,
     }
 
     /* Create BlockBackend to write to the image */
-    bs = bdrv_open_blockdev_ref(parallels_opts->file, errp);
+    bs = bdrv_co_open_blockdev_ref(parallels_opts->file, errp);
     if (bs == NULL) {
         return -EIO;
     }
 
-    blk = blk_new_with_bs(bs, BLK_PERM_WRITE | BLK_PERM_RESIZE, BLK_PERM_ALL,
-                          errp);
+    blk = blk_co_new_with_bs(bs, BLK_PERM_WRITE | BLK_PERM_RESIZE, BLK_PERM_ALL,
+                             errp);
     if (!blk) {
         ret = -EPERM;
         goto out;
@@ -651,8 +651,8 @@ static int coroutine_fn parallels_co_create_opts(BlockDriver *drv,
         goto done;
     }
 
-    bs = bdrv_open(filename, NULL, NULL,
-                   BDRV_O_RDWR | BDRV_O_RESIZE | BDRV_O_PROTOCOL, errp);
+    bs = bdrv_co_open(filename, NULL, NULL,
+                      BDRV_O_RDWR | BDRV_O_RESIZE | BDRV_O_PROTOCOL, errp);
     if (bs == NULL) {
         ret = -EIO;
         goto done;
-- 
2.39.2



  parent reply	other threads:[~2023-02-17 15:12 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-17 15:08 [PULL 00/22] Block layer patches Kevin Wolf
2023-02-17 15:09 ` [PULL 01/22] util/qemu-thread-posix: use TSA_NO_TSA to suppress clang TSA warnings in FreeBSD Kevin Wolf
2023-02-17 15:09   ` [PULL 02/22] bsd-user/mmap: " Kevin Wolf
2023-02-17 15:09   ` [PULL 03/22] configure: Enable -Wthread-safety if present Kevin Wolf
2023-02-17 15:09   ` [PULL 04/22] curl: Fix error path in curl_open() Kevin Wolf
2023-02-17 15:09   ` [PULL 05/22] block-coroutine-wrapper: Introduce no_co_wrapper Kevin Wolf
2023-02-17 15:09   ` [PULL 06/22] block: Create no_co_wrappers for open functions Kevin Wolf
2023-02-17 15:09   ` [PULL 07/22] luks: Fix .bdrv_co_create(_opts) to open images with no_co_wrapper Kevin Wolf
2023-02-17 15:09   ` Kevin Wolf [this message]
2023-02-17 15:09   ` [PULL 09/22] qcow: " Kevin Wolf
2023-02-17 15:09   ` [PULL 10/22] qcow2: Fix open/create " Kevin Wolf
2023-02-17 15:09   ` [PULL 11/22] qed: Fix .bdrv_co_create(_opts) " Kevin Wolf
2023-02-17 15:09   ` [PULL 12/22] vdi: " Kevin Wolf
2023-02-17 15:09   ` [PULL 13/22] vhdx: " Kevin Wolf
2023-02-17 15:09   ` [PULL 14/22] vmdk: " Kevin Wolf
2023-02-17 15:09   ` [PULL 15/22] vpc: " Kevin Wolf
2023-02-17 15:09   ` [PULL 16/22] block: Fix bdrv_co_create_opts_simple() " Kevin Wolf
2023-02-17 15:09   ` [PULL 17/22] block: Assert non-coroutine context for bdrv_open_inherit() Kevin Wolf
2023-02-17 15:09   ` [PULL 18/22] block: Handle curl 7.55.0, 7.85.0 version changes Kevin Wolf
2023-02-17 15:09   ` [PULL 19/22] block: temporarily hold the new AioContext of bs_top in bdrv_append() Kevin Wolf
2023-02-17 15:09   ` [PULL 20/22] MAINTAINERS: drop Vladimir from parallels block driver Kevin Wolf
2023-02-17 15:09   ` [PULL 21/22] block/file-posix: don't use functions calling AIO_WAIT_WHILE in worker threads Kevin Wolf
2023-02-17 15:09   ` [PULL 22/22] hbitmap: fix hbitmap_status() return value for first dirty bit case Kevin Wolf
2023-02-20 17:01 ` [PULL 00/22] Block layer patches Peter Maydell
2023-02-20 19:02   ` Philippe Mathieu-Daudé
2023-02-21 11:10     ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230217150954.283920-8-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).