From: Mathis Marion <Mathis.Marion@silabs.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Laurent Vivier" <laurent@vivier.eu>
Cc: qemu-devel@nongnu.org,
"Jérôme Pouiller" <jerome.pouiller@silabs.com>,
"Mathis Marion" <mathis.marion@silabs.com>
Subject: [PATCH v2 1/4] linux-user: fix timerfd read endianness conversion
Date: Mon, 20 Feb 2023 09:58:19 +0100 [thread overview]
Message-ID: <20230220085822.626798-2-Mathis.Marion@silabs.com> (raw)
In-Reply-To: <20230220085822.626798-1-Mathis.Marion@silabs.com>
From: Mathis Marion <mathis.marion@silabs.com>
When reading the expiration count from a timerfd, the endianness of the
64bit value read is the one of the host, just as for eventfds.
Signed-off-by: Mathis Marion <mathis.marion@silabs.com>
---
linux-user/fd-trans.c | 10 +++++++---
linux-user/fd-trans.h | 1 +
linux-user/syscall.c | 8 ++++++--
3 files changed, 14 insertions(+), 5 deletions(-)
diff --git a/linux-user/fd-trans.c b/linux-user/fd-trans.c
index 7b25468d02..146aaaafaa 100644
--- a/linux-user/fd-trans.c
+++ b/linux-user/fd-trans.c
@@ -1622,7 +1622,7 @@ TargetFdTrans target_signalfd_trans = {
.host_to_target_data = host_to_target_data_signalfd,
};
-static abi_long swap_data_eventfd(void *buf, size_t len)
+static abi_long swap_data_u64(void *buf, size_t len)
{
uint64_t *counter = buf;
int i;
@@ -1640,8 +1640,12 @@ static abi_long swap_data_eventfd(void *buf, size_t len)
}
TargetFdTrans target_eventfd_trans = {
- .host_to_target_data = swap_data_eventfd,
- .target_to_host_data = swap_data_eventfd,
+ .host_to_target_data = swap_data_u64,
+ .target_to_host_data = swap_data_u64,
+};
+
+TargetFdTrans target_timerfd_trans = {
+ .host_to_target_data = swap_data_u64,
};
#if defined(CONFIG_INOTIFY) && (defined(TARGET_NR_inotify_init) || \
diff --git a/linux-user/fd-trans.h b/linux-user/fd-trans.h
index 1b9fa2041c..910faaf237 100644
--- a/linux-user/fd-trans.h
+++ b/linux-user/fd-trans.h
@@ -130,6 +130,7 @@ extern TargetFdTrans target_netlink_route_trans;
extern TargetFdTrans target_netlink_audit_trans;
extern TargetFdTrans target_signalfd_trans;
extern TargetFdTrans target_eventfd_trans;
+extern TargetFdTrans target_timerfd_trans;
#if (defined(TARGET_NR_inotify_init) && defined(__NR_inotify_init)) || \
(defined(CONFIG_INOTIFY1) && defined(TARGET_NR_inotify_init1) && \
defined(__NR_inotify_init1))
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index 1e868e9b0e..58549de125 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -13117,8 +13117,12 @@ static abi_long do_syscall1(CPUArchState *cpu_env, int num, abi_long arg1,
#if defined(TARGET_NR_timerfd_create) && defined(CONFIG_TIMERFD)
case TARGET_NR_timerfd_create:
- return get_errno(timerfd_create(arg1,
- target_to_host_bitmask(arg2, fcntl_flags_tbl)));
+ ret = get_errno(timerfd_create(arg1,
+ target_to_host_bitmask(arg2, fcntl_flags_tbl)));
+ if (ret >= 0) {
+ fd_trans_register(ret, &target_timerfd_trans);
+ }
+ return ret;
#endif
#if defined(TARGET_NR_timerfd_gettime) && defined(CONFIG_TIMERFD)
--
2.39.1
next prev parent reply other threads:[~2023-02-20 9:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-20 8:58 [PATCH v2 0/4] Missing endianness conversions in user mode Mathis Marion
2023-02-20 8:58 ` Mathis Marion [this message]
2023-03-06 21:42 ` [PATCH v2 1/4] linux-user: fix timerfd read endianness conversion Laurent Vivier
2023-03-07 9:33 ` Laurent Vivier
2023-02-20 8:58 ` [PATCH v2 2/4] linux-user: fix sockaddr_in6 endianness Mathis Marion
2023-02-20 9:06 ` Philippe Mathieu-Daudé
2023-02-20 9:09 ` Mathis MARION
2023-02-20 9:32 ` Philippe Mathieu-Daudé
2023-03-06 21:52 ` Laurent Vivier
2023-03-07 11:27 ` Mathis MARION
2023-03-07 13:37 ` Laurent Vivier
2023-02-20 8:58 ` [PATCH v2 3/4] linux-user: add target to host netlink conversions Mathis Marion
2023-02-20 9:04 ` Philippe Mathieu-Daudé
2023-03-06 22:02 ` Laurent Vivier
2023-03-07 9:32 ` Laurent Vivier
2023-02-20 8:58 ` [PATCH v2 4/4] linux-user: handle netlink flag NLA_F_NESTED Mathis Marion
2023-02-20 9:15 ` Mathis MARION
2023-04-01 9:19 ` [PATCH v2 0/4] Missing endianness conversions in user mode Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230220085822.626798-2-Mathis.Marion@silabs.com \
--to=mathis.marion@silabs.com \
--cc=jerome.pouiller@silabs.com \
--cc=laurent@vivier.eu \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).