From: Mathis Marion <Mathis.Marion@silabs.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Laurent Vivier" <laurent@vivier.eu>
Cc: qemu-devel@nongnu.org,
"Jérôme Pouiller" <jerome.pouiller@silabs.com>,
"Mathis Marion" <mathis.marion@silabs.com>
Subject: [PATCH v2 4/4] linux-user: handle netlink flag NLA_F_NESTED
Date: Mon, 20 Feb 2023 09:58:22 +0100 [thread overview]
Message-ID: <20230220085822.626798-5-Mathis.Marion@silabs.com> (raw)
In-Reply-To: <20230220085822.626798-1-Mathis.Marion@silabs.com>
From: Mathis Marion <mathis.marion@silabs.com>
Newer kernel versions require this flag to be present contrary to older
ones. Depending on the libnl version it is added or not.
Typically when using rtnl_link_inet6_set_addr_gen_mode, the netlink
packet generated may contain the following attribute:
with libnl 3.4
{nla_len=16, nla_type=IFLA_AF_SPEC},
[
{nla_len=12, nla_type=AF_INET6},
[{nla_len=5, nla_type=IFLA_INET6_ADDR_GEN_MODE}, IN6_ADDR_GEN_MODE_NONE]
]
with libnl 3.7
{nla_len=16, nla_type=NLA_F_NESTED|IFLA_AF_SPEC},
[
{nla_len=12, nla_type=NLA_F_NESTED|AF_INET6},
[{nla_len=5, nla_type=IFLA_INET6_ADDR_GEN_MODE}, IN6_ADDR_GEN_MODE_NONE]]
]
Signed-off-by: Mathis Marion <mathis.marion@silabs.com>
---
linux-user/fd-trans.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/linux-user/fd-trans.c b/linux-user/fd-trans.c
index 4852a75d9d..1fb8ef9d4e 100644
--- a/linux-user/fd-trans.c
+++ b/linux-user/fd-trans.c
@@ -1359,7 +1359,7 @@ static abi_long target_to_host_for_each_rtattr(struct rtattr *rtattr,
static abi_long target_to_host_data_spec_nlattr(struct nlattr *nlattr)
{
- switch (nlattr->nla_type) {
+ switch (nlattr->nla_type & ~NLA_F_NESTED) {
case AF_INET6:
return target_to_host_for_each_nlattr(NLA_DATA(nlattr), nlattr->nla_len,
target_to_host_data_inet6_nlattr);
@@ -1375,7 +1375,7 @@ static abi_long target_to_host_data_link_rtattr(struct rtattr *rtattr)
{
uint32_t *u32;
- switch (rtattr->rta_type) {
+ switch (rtattr->rta_type & ~NLA_F_NESTED) {
/* uint32_t */
case QEMU_IFLA_MTU:
case QEMU_IFLA_TXQLEN:
--
2.39.1
next prev parent reply other threads:[~2023-02-20 9:00 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-20 8:58 [PATCH v2 0/4] Missing endianness conversions in user mode Mathis Marion
2023-02-20 8:58 ` [PATCH v2 1/4] linux-user: fix timerfd read endianness conversion Mathis Marion
2023-03-06 21:42 ` Laurent Vivier
2023-03-07 9:33 ` Laurent Vivier
2023-02-20 8:58 ` [PATCH v2 2/4] linux-user: fix sockaddr_in6 endianness Mathis Marion
2023-02-20 9:06 ` Philippe Mathieu-Daudé
2023-02-20 9:09 ` Mathis MARION
2023-02-20 9:32 ` Philippe Mathieu-Daudé
2023-03-06 21:52 ` Laurent Vivier
2023-03-07 11:27 ` Mathis MARION
2023-03-07 13:37 ` Laurent Vivier
2023-02-20 8:58 ` [PATCH v2 3/4] linux-user: add target to host netlink conversions Mathis Marion
2023-02-20 9:04 ` Philippe Mathieu-Daudé
2023-03-06 22:02 ` Laurent Vivier
2023-03-07 9:32 ` Laurent Vivier
2023-02-20 8:58 ` Mathis Marion [this message]
2023-02-20 9:15 ` [PATCH v2 4/4] linux-user: handle netlink flag NLA_F_NESTED Mathis MARION
2023-04-01 9:19 ` [PATCH v2 0/4] Missing endianness conversions in user mode Michael Tokarev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230220085822.626798-5-Mathis.Marion@silabs.com \
--to=mathis.marion@silabs.com \
--cc=jerome.pouiller@silabs.com \
--cc=laurent@vivier.eu \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).