From: David Woodhouse <dwmw2@infradead.org>
To: Peter Maydell <peter.maydell@linaro.org>, qemu-devel@nongnu.org
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Paul Durrant" <paul@xen.org>,
"Joao Martins" <joao.m.martins@oracle.com>,
"Ankur Arora" <ankur.a.arora@oracle.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Thomas Huth" <thuth@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Juan Quintela" <quintela@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
"Claudio Fontana" <cfontana@suse.de>,
"Julien Grall" <julien@xen.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
armbru@redhat.com, "Stefano Stabellini" <sstabellini@kernel.org>,
vikram.garhwal@amd.com
Subject: [PATCH v12 07/60] xen-platform: exclude vfio-pci from the PCI platform unplug
Date: Mon, 20 Feb 2023 20:46:43 +0000 [thread overview]
Message-ID: <20230220204736.2639601-8-dwmw2@infradead.org> (raw)
In-Reply-To: <20230220204736.2639601-1-dwmw2@infradead.org>
From: Joao Martins <joao.m.martins@oracle.com>
Such that PCI passthrough devices work for Xen emulated guests.
Signed-off-by: Joao Martins <joao.m.martins@oracle.com>
Signed-off-by: David Woodhouse <dwmw@amazon.co.uk>
Reviewed-by: Paul Durrant <paul@xen.org>
---
hw/i386/xen/xen_platform.c | 18 +++++++++++++++---
1 file changed, 15 insertions(+), 3 deletions(-)
diff --git a/hw/i386/xen/xen_platform.c b/hw/i386/xen/xen_platform.c
index 66e6de31a6..d601a5509d 100644
--- a/hw/i386/xen/xen_platform.c
+++ b/hw/i386/xen/xen_platform.c
@@ -109,12 +109,25 @@ static void log_writeb(PCIXenPlatformState *s, char val)
#define _UNPLUG_NVME_DISKS 3
#define UNPLUG_NVME_DISKS (1u << _UNPLUG_NVME_DISKS)
+static bool pci_device_is_passthrough(PCIDevice *d)
+{
+ if (!strcmp(d->name, "xen-pci-passthrough")) {
+ return true;
+ }
+
+ if (xen_mode == XEN_EMULATE && !strcmp(d->name, "vfio-pci")) {
+ return true;
+ }
+
+ return false;
+}
+
static void unplug_nic(PCIBus *b, PCIDevice *d, void *o)
{
/* We have to ignore passthrough devices */
if (pci_get_word(d->config + PCI_CLASS_DEVICE) ==
PCI_CLASS_NETWORK_ETHERNET
- && strcmp(d->name, "xen-pci-passthrough") != 0) {
+ && !pci_device_is_passthrough(d)) {
object_unparent(OBJECT(d));
}
}
@@ -187,9 +200,8 @@ static void unplug_disks(PCIBus *b, PCIDevice *d, void *opaque)
!(flags & UNPLUG_IDE_SCSI_DISKS);
/* We have to ignore passthrough devices */
- if (!strcmp(d->name, "xen-pci-passthrough")) {
+ if (pci_device_is_passthrough(d))
return;
- }
switch (pci_get_word(d->config + PCI_CLASS_DEVICE)) {
case PCI_CLASS_STORAGE_IDE:
--
2.39.0
next prev parent reply other threads:[~2023-02-20 20:49 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-20 20:46 [PATCH v12 00/60] Xen HVM support under KVM David Woodhouse
2023-02-20 20:46 ` [PATCH v12 01/60] include: import Xen public headers to hw/xen/interface David Woodhouse
2023-02-20 20:46 ` [PATCH v12 02/60] xen: add CONFIG_XEN_BUS and CONFIG_XEN_EMU options for Xen emulation David Woodhouse
2023-02-20 20:46 ` [PATCH v12 03/60] xen: Add XEN_DISABLED mode and make it default David Woodhouse
2023-02-20 20:46 ` [PATCH v12 04/60] i386/kvm: Add xen-version KVM accelerator property and init KVM Xen support David Woodhouse
2023-02-20 20:46 ` [PATCH v12 05/60] i386/kvm: handle Xen HVM cpuid leaves David Woodhouse
2023-02-20 20:46 ` [PATCH v12 06/60] i386/hvm: Set Xen vCPU ID in KVM David Woodhouse
2023-02-20 20:46 ` David Woodhouse [this message]
2023-02-20 20:46 ` [PATCH v12 08/60] xen-platform: allow its creation with XEN_EMULATE mode David Woodhouse
2023-02-20 20:46 ` [PATCH v12 09/60] i386/xen: handle guest hypercalls David Woodhouse
2023-02-20 20:46 ` [PATCH v12 10/60] i386/xen: implement HYPERVISOR_xen_version David Woodhouse
2023-02-20 20:46 ` [PATCH v12 11/60] i386/xen: implement HYPERVISOR_sched_op, SCHEDOP_shutdown David Woodhouse
2023-02-20 20:46 ` [PATCH v12 12/60] i386/xen: Implement SCHEDOP_poll and SCHEDOP_yield David Woodhouse
2023-02-20 20:46 ` [PATCH v12 13/60] hw/xen: Add xen_overlay device for emulating shared xenheap pages David Woodhouse
2023-02-20 20:46 ` [PATCH v12 14/60] xen: Permit --xen-domid argument when accel is KVM David Woodhouse
2023-02-20 20:46 ` [PATCH v12 15/60] i386/xen: add pc_machine_kvm_type to initialize XEN_EMULATE mode David Woodhouse
2023-02-20 20:46 ` [PATCH v12 16/60] i386/xen: manage and save/restore Xen guest long_mode setting David Woodhouse
2023-02-20 20:46 ` [PATCH v12 17/60] i386/xen: implement HYPERVISOR_memory_op David Woodhouse
2023-02-20 20:46 ` [PATCH v12 18/60] i386/xen: implement XENMEM_add_to_physmap_batch David Woodhouse
2023-02-20 20:46 ` [PATCH v12 19/60] i386/xen: implement HYPERVISOR_hvm_op David Woodhouse
2023-02-20 20:46 ` [PATCH v12 20/60] i386/xen: implement HYPERVISOR_vcpu_op David Woodhouse
2023-02-20 20:46 ` [PATCH v12 21/60] i386/xen: handle VCPUOP_register_vcpu_info David Woodhouse
2023-02-20 20:46 ` [PATCH v12 22/60] i386/xen: handle VCPUOP_register_vcpu_time_info David Woodhouse
2023-02-20 20:46 ` [PATCH v12 23/60] i386/xen: handle VCPUOP_register_runstate_memory_area David Woodhouse
2023-02-20 20:47 ` [PATCH v12 24/60] i386/xen: implement HYPERVISOR_event_channel_op David Woodhouse
2023-02-20 20:47 ` [PATCH v12 25/60] i386/xen: implement HVMOP_set_evtchn_upcall_vector David Woodhouse
2023-02-20 20:47 ` [PATCH v12 26/60] i386/xen: implement HVMOP_set_param David Woodhouse
2023-02-20 20:47 ` [PATCH v12 27/60] hw/xen: Add xen_evtchn device for event channel emulation David Woodhouse
2023-02-20 20:47 ` [PATCH v12 28/60] i386/xen: Add support for Xen event channel delivery to vCPU David Woodhouse
2023-02-20 20:47 ` [PATCH v12 29/60] hw/xen: Implement EVTCHNOP_status David Woodhouse
2023-02-20 20:47 ` [PATCH v12 30/60] hw/xen: Implement EVTCHNOP_close David Woodhouse
2023-02-20 20:47 ` [PATCH v12 31/60] hw/xen: Implement EVTCHNOP_unmask David Woodhouse
2023-02-20 20:47 ` [PATCH v12 32/60] hw/xen: Implement EVTCHNOP_bind_virq David Woodhouse
2023-02-20 20:47 ` [PATCH v12 33/60] hw/xen: Implement EVTCHNOP_bind_ipi David Woodhouse
2023-02-20 20:47 ` [PATCH v12 34/60] hw/xen: Implement EVTCHNOP_send David Woodhouse
2023-02-20 20:47 ` [PATCH v12 35/60] hw/xen: Implement EVTCHNOP_alloc_unbound David Woodhouse
2023-02-20 20:47 ` [PATCH v12 36/60] hw/xen: Implement EVTCHNOP_bind_interdomain David Woodhouse
2023-02-20 20:47 ` [PATCH v12 37/60] hw/xen: Implement EVTCHNOP_bind_vcpu David Woodhouse
2023-02-20 20:47 ` [PATCH v12 38/60] hw/xen: Implement EVTCHNOP_reset David Woodhouse
2023-02-20 20:47 ` [PATCH v12 39/60] i386/xen: add monitor commands to test event injection David Woodhouse
2023-02-20 20:47 ` [PATCH v12 40/60] hw/xen: Support HVM_PARAM_CALLBACK_TYPE_GSI callback David Woodhouse
2023-02-20 20:47 ` [PATCH v12 41/60] hw/xen: Support HVM_PARAM_CALLBACK_TYPE_PCI_INTX callback David Woodhouse
2023-02-20 20:47 ` [PATCH v12 42/60] kvm/i386: Add xen-gnttab-max-frames property David Woodhouse
2023-02-20 20:47 ` [PATCH v12 43/60] hw/xen: Add xen_gnttab device for grant table emulation David Woodhouse
2023-02-20 20:47 ` [PATCH v12 44/60] hw/xen: Support mapping grant frames David Woodhouse
2023-02-20 20:47 ` [PATCH v12 45/60] i386/xen: Implement HYPERVISOR_grant_table_op and GNTTABOP_[gs]et_verson David Woodhouse
2023-02-20 20:47 ` [PATCH v12 46/60] hw/xen: Implement GNTTABOP_query_size David Woodhouse
2023-02-20 20:47 ` [PATCH v12 47/60] i386/xen: handle PV timer hypercalls David Woodhouse
2023-02-22 9:21 ` David Woodhouse
2023-02-22 12:03 ` Paul Durrant
2023-02-22 12:14 ` Paul Durrant
2023-02-22 12:51 ` David Woodhouse
2023-02-22 13:31 ` Paul Durrant
2023-02-22 13:32 ` Paul Durrant
2023-02-22 16:18 ` David Woodhouse
2023-02-20 20:47 ` [PATCH v12 48/60] i386/xen: Reserve Xen special pages for console, xenstore rings David Woodhouse
2023-02-20 20:47 ` [PATCH v12 49/60] i386/xen: handle HVMOP_get_param David Woodhouse
2023-02-20 20:47 ` [PATCH v12 50/60] hw/xen: Add backend implementation of interdomain event channel support David Woodhouse
2023-02-20 20:47 ` [PATCH v12 51/60] hw/xen: Add xen_xenstore device for xenstore emulation David Woodhouse
2023-02-20 20:47 ` [PATCH v12 52/60] hw/xen: Add basic ring handling to xenstore David Woodhouse
2023-02-20 20:47 ` [PATCH v12 53/60] hw/xen: Automatically add xen-platform PCI device for emulated Xen guests David Woodhouse
2023-02-20 20:47 ` [PATCH v12 54/60] i386/xen: Implement HYPERVISOR_physdev_op David Woodhouse
2023-02-20 20:47 ` [PATCH v12 55/60] hw/xen: Implement emulated PIRQ hypercall support David Woodhouse
2023-02-20 20:47 ` [PATCH v12 56/60] hw/xen: Support GSI mapping to PIRQ David Woodhouse
2023-02-20 20:47 ` [PATCH v12 57/60] hw/xen: Support MSI " David Woodhouse
2023-02-20 20:47 ` [PATCH v12 58/60] kvm/i386: Add xen-evtchn-max-pirq property David Woodhouse
2023-02-20 20:47 ` [PATCH v12 59/60] i386/xen: Document Xen HVM emulation David Woodhouse
2023-02-20 20:47 ` [PATCH v12 60/60] hw/xen: Subsume xen_be_register_common() into xen_be_init() David Woodhouse
2023-02-22 12:05 ` Paul Durrant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230220204736.2639601-8-dwmw2@infradead.org \
--to=dwmw2@infradead.org \
--cc=alex.bennee@linaro.org \
--cc=ankur.a.arora@oracle.com \
--cc=armbru@redhat.com \
--cc=cfontana@suse.de \
--cc=dgilbert@redhat.com \
--cc=joao.m.martins@oracle.com \
--cc=julien@xen.org \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=paul@xen.org \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=sstabellini@kernel.org \
--cc=thuth@redhat.com \
--cc=vikram.garhwal@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).