From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Markus Armbruster" <armbru@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Yonggang Luo" <luoyonggang@gmail.com>,
"Li-Wen Hsu" <lwhsu@freebsd.org>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Thomas Huth" <thuth@redhat.com>, "Ed Maste" <emaste@freebsd.org>,
"Bandan Das" <bsd@redhat.com>, "Cleber Rosa" <crosa@redhat.com>,
"Qiuhao Li" <Qiuhao.Li@outlook.com>,
qemu-block@nongnu.org, "Beraldo Leal" <bleal@redhat.com>,
"Hanna Reitz" <hreitz@redhat.com>,
qemu-arm@nongnu.org, "Michael Roth" <michael.roth@amd.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Pavel Dovgalyuk" <pavel.dovgaluk@ispras.ru>,
"Alexander Bulekov" <alxndr@bu.edu>,
"Darren Kenny" <darren.kenny@oracle.com>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Kevin Wolf" <kwolf@redhat.com>, "John Snow" <jsnow@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Daniel P. Berrangé" <berrange@redhat.com>
Subject: [PATCH v2 05/14] tests: make fp-test less chatty when running from test suite
Date: Tue, 21 Feb 2023 09:45:49 +0000 [thread overview]
Message-ID: <20230221094558.2864616-6-alex.bennee@linaro.org> (raw)
In-Reply-To: <20230221094558.2864616-1-alex.bennee@linaro.org>
As we like to run tests under CI with V=1 flags the softfloat tests
can add up to a fair amount of extra log lines. With an update to the
testfloat library we can now call fp-test with the -q flag and reduce
the output to a terse one line per function tested.
make check-softfloat V=1 | wc -l
759
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
tests/fp/fp-test.c | 19 ++++++++++++++-----
tests/fp/berkeley-testfloat-3 | 2 +-
tests/fp/meson.build | 2 +-
3 files changed, 16 insertions(+), 7 deletions(-)
diff --git a/tests/fp/fp-test.c b/tests/fp/fp-test.c
index 35829ad5f7..36b5712cda 100644
--- a/tests/fp/fp-test.c
+++ b/tests/fp/fp-test.c
@@ -106,7 +106,8 @@ static const char commands_string[] =
" -l = thoroughness level (1 (default), 2)\n"
" -r = rounding mode (even (default), zero, down, up, tieaway, odd)\n"
" Set to 'all' to test all rounding modes, if applicable\n"
- " -s = stop when a test fails";
+ " -s = stop when a test fails\n"
+ " -q = minimise noise when testing, just show each function being tested";
static void usage_complete(int argc, char *argv[])
{
@@ -190,9 +191,11 @@ static void do_testfloat(int op, int rmode, bool exact)
ab_f128M_z_bool true_ab_f128M_z_bool;
ab_f128M_z_bool subj_ab_f128M_z_bool;
- fputs(">> Testing ", stderr);
- verCases_writeFunctionName(stderr);
- fputs("\n", stderr);
+ if (verCases_verbosity) {
+ fputs(">> Testing ", stderr);
+ verCases_writeFunctionName(stderr);
+ fputs("\n", stderr);
+ }
if (!is_allowed(op, rmode)) {
not_implemented();
@@ -837,7 +840,7 @@ static void parse_args(int argc, char *argv[])
int c;
for (;;) {
- c = getopt(argc, argv, "he:f:l:r:s");
+ c = getopt(argc, argv, "he:f:l:r:sq");
if (c < 0) {
break;
}
@@ -874,9 +877,15 @@ static void parse_args(int argc, char *argv[])
}
}
break;
+ /*
+ * The following flags are declared in testfloat/source/verCases_common.c
+ */
case 's':
verCases_errorStop = true;
break;
+ case 'q':
+ verCases_verbosity = 0;
+ break;
case '?':
/* invalid option or missing argument; getopt prints error info */
exit(EXIT_FAILURE);
diff --git a/tests/fp/berkeley-testfloat-3 b/tests/fp/berkeley-testfloat-3
index 5a59dcec19..40619cbb3b 160000
--- a/tests/fp/berkeley-testfloat-3
+++ b/tests/fp/berkeley-testfloat-3
@@ -1 +1 @@
-Subproject commit 5a59dcec19327396a011a17fd924aed4fec416b3
+Subproject commit 40619cbb3bf32872df8c53cc457039229428a263
diff --git a/tests/fp/meson.build b/tests/fp/meson.build
index 312a4d301f..f9ca6a93b4 100644
--- a/tests/fp/meson.build
+++ b/tests/fp/meson.build
@@ -609,7 +609,7 @@ softfloat_tests = {
# The full test suite can take a bit of time, default to a quick run
# "-l 2 -r all" can take more than a day for some operations and is best
# run manually
-fptest_args = ['-s', '-l', '1']
+fptest_args = ['-q', '-s', '-l', '1']
fptest_rounding_args = ['-r', 'all']
# Conversion Routines:
--
2.39.1
next prev parent reply other threads:[~2023-02-21 9:47 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 9:45 [PATCH v2 00/14] testing/next: docker, avocado, unit, gitlab Alex Bennée
2023-02-21 9:45 ` [PATCH v2 01/14] block: Handle curl 7.55.0, 7.85.0 version changes Alex Bennée
2023-02-21 10:57 ` Kevin Wolf
2023-02-21 11:08 ` Alex Bennée
2023-02-21 9:45 ` [PATCH v2 02/14] tests: don't run socat tests on MacOS as well Alex Bennée
2023-02-21 9:45 ` [PATCH v2 03/14] tests: add socat dependency for tests Alex Bennée
2023-02-21 9:45 ` [PATCH v2 04/14] tests: be a bit more strict cleaning up fifos Alex Bennée
2023-02-21 10:07 ` Thomas Huth
2023-02-21 10:36 ` Philippe Mathieu-Daudé
2023-02-21 9:45 ` Alex Bennée [this message]
2023-02-21 10:04 ` [PATCH v2 05/14] tests: make fp-test less chatty when running from test suite Thomas Huth
2023-02-21 9:45 ` [PATCH v2 06/14] gitlab-ci: Use artifacts instead of dumping logs in the Cirrus-CI jobs Alex Bennée
2023-02-21 9:45 ` [PATCH v2 07/14] gitlab: extend custom runners with base_job_template Alex Bennée
2023-02-21 10:52 ` Thomas Huth
2023-02-21 9:45 ` [PATCH v2 08/14] tests: don't run benchmarks for the tsan build Alex Bennée
2023-02-21 10:54 ` Thomas Huth
2023-02-21 9:45 ` [PATCH v2 09/14] testing: update ubuntu2004 to ubuntu2204 Alex Bennée
2023-02-21 10:56 ` Thomas Huth
2023-02-21 9:45 ` [PATCH v2 10/14] tests: skip the nios2 replay_kernel test Alex Bennée
2023-02-21 9:45 ` [PATCH v2 11/14] tests: add tuxrun baseline test to avocado Alex Bennée
2023-02-21 10:17 ` Thomas Huth
2023-02-21 9:45 ` [PATCH v2 12/14] tests/docker: Use binaries for debian-tricore-cross Alex Bennée
2023-02-21 9:45 ` [PATCH v2 13/14] tests: ensure we export job results for some cross builds Alex Bennée
2023-02-21 10:11 ` Thomas Huth
2023-02-21 9:45 ` [PATCH v2 14/14] cirrus.yml: Improve the windows_msys2_task Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230221094558.2864616-6-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=Qiuhao.Li@outlook.com \
--cc=alxndr@bu.edu \
--cc=armbru@redhat.com \
--cc=aurelien@aurel32.net \
--cc=berrange@redhat.com \
--cc=bleal@redhat.com \
--cc=bsd@redhat.com \
--cc=crosa@redhat.com \
--cc=darren.kenny@oracle.com \
--cc=emaste@freebsd.org \
--cc=hreitz@redhat.com \
--cc=jsnow@redhat.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=kwolf@redhat.com \
--cc=luoyonggang@gmail.com \
--cc=lwhsu@freebsd.org \
--cc=marcandre.lureau@redhat.com \
--cc=michael.roth@amd.com \
--cc=pavel.dovgaluk@ispras.ru \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).