From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Thomas Huth" <thuth@redhat.com>,
qemu-arm@nongnu.org, qemu-riscv@nongnu.org,
qemu-s390x@nongnu.org,
"Yoshinori Sato" <ysato@users.sourceforge.jp>,
nicolas.eder@lauterbach.com, "Stafford Horne" <shorne@gmail.com>,
"Daniel Henrique Barboza" <danielhb413@gmail.com>,
"Mahmoud Mandour" <ma.mandourr@gmail.com>,
"Taylor Simpson" <tsimpson@quicinc.com>,
mads@ynddal.dk, "Marek Vasut" <marex@denx.de>,
"Artyom Tarasenko" <atar4qemu@gmail.com>,
"Alistair Francis" <alistair.francis@wdc.com>,
qemu-ppc@nongnu.org, "Yanan Wang" <wangyanan55@huawei.com>,
"Sunil Muthuswamy" <sunilmut@microsoft.com>,
"Cédric Le Goater" <clg@kaod.org>,
"Eduardo Habkost" <eduardo@habkost.net>,
"Bin Meng" <bin.meng@windriver.com>,
"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Marcel Apfelbaum" <marcel.apfelbaum@gmail.com>,
"Laurent Vivier" <laurent@vivier.eu>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Michael Rolnik" <mrolnik@gmail.com>,
"Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Xiaojuan Yang" <yangxiaojuan@loongson.cn>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Alexandre Iooss" <erdnaxe@crans.org>,
"Chris Wulff" <crwulff@gmail.com>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Greg Kurz" <groug@kaod.org>,
"David Hildenbrand" <david@redhat.com>,
"Song Gao" <gaosong@loongson.cn>,
"Ilya Leoshkevich" <iii@linux.ibm.com>,
"Max Filippov" <jcmvbkbc@gmail.com>,
"Mark Cave-Ayland" <mark.cave-ayland@ilande.co.uk>
Subject: [PATCH v3 23/24] include: split target_long definition from cpu-defs
Date: Tue, 21 Feb 2023 22:52:26 +0000 [thread overview]
Message-ID: <20230221225227.3735319-24-alex.bennee@linaro.org> (raw)
In-Reply-To: <20230221225227.3735319-1-alex.bennee@linaro.org>
While we will continue to include this via cpu-defs it is useful to be
able to define this separately for 32 and 64 bit versions of an
otherwise target independent compilation unit.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
include/exec/cpu-defs.h | 19 +----------------
include/exec/target_long.h | 42 ++++++++++++++++++++++++++++++++++++++
2 files changed, 43 insertions(+), 18 deletions(-)
create mode 100644 include/exec/target_long.h
diff --git a/include/exec/cpu-defs.h b/include/exec/cpu-defs.h
index 21309cf567..98605dfba2 100644
--- a/include/exec/cpu-defs.h
+++ b/include/exec/cpu-defs.h
@@ -58,24 +58,7 @@
# define TARGET_TB_PCREL 0
#endif
-#define TARGET_LONG_SIZE (TARGET_LONG_BITS / 8)
-
-/* target_ulong is the type of a virtual address */
-#if TARGET_LONG_SIZE == 4
-typedef int32_t target_long;
-typedef uint32_t target_ulong;
-#define TARGET_FMT_lx "%08x"
-#define TARGET_FMT_ld "%d"
-#define TARGET_FMT_lu "%u"
-#elif TARGET_LONG_SIZE == 8
-typedef int64_t target_long;
-typedef uint64_t target_ulong;
-#define TARGET_FMT_lx "%016" PRIx64
-#define TARGET_FMT_ld "%" PRId64
-#define TARGET_FMT_lu "%" PRIu64
-#else
-#error TARGET_LONG_SIZE undefined
-#endif
+#include "exec/target_long.h"
#if !defined(CONFIG_USER_ONLY) && defined(CONFIG_TCG)
diff --git a/include/exec/target_long.h b/include/exec/target_long.h
new file mode 100644
index 0000000000..93c9472971
--- /dev/null
+++ b/include/exec/target_long.h
@@ -0,0 +1,42 @@
+/*
+ * Target Long Definitions
+ *
+ * Copyright (c) 2003 Fabrice Bellard
+ * Copyright (c) 2023 Linaro Ltd
+ *
+ * SPDX-License-Identifier: GPL-2.0-or-later
+ */
+
+#ifndef _TARGET_LONG_H_
+#define _TARGET_LONG_H_
+
+/*
+ * Usually this should only be included via cpu-defs.h however for
+ * certain cases where we want to build only two versions of a binary
+ * object we can include directly. However the build-system must
+ * ensure TARGET_LONG_BITS is defined directly.
+ */
+#ifndef TARGET_LONG_BITS
+#error TARGET_LONG_BITS not defined
+#endif
+
+#define TARGET_LONG_SIZE (TARGET_LONG_BITS / 8)
+
+/* target_ulong is the type of a virtual address */
+#if TARGET_LONG_SIZE == 4
+typedef int32_t target_long;
+typedef uint32_t target_ulong;
+#define TARGET_FMT_lx "%08x"
+#define TARGET_FMT_ld "%d"
+#define TARGET_FMT_lu "%u"
+#elif TARGET_LONG_SIZE == 8
+typedef int64_t target_long;
+typedef uint64_t target_ulong;
+#define TARGET_FMT_lx "%016" PRIx64
+#define TARGET_FMT_ld "%" PRId64
+#define TARGET_FMT_lu "%" PRIu64
+#else
+#error TARGET_LONG_SIZE undefined
+#endif
+
+#endif /* _TARGET_LONG_H_ */
--
2.39.1
next prev parent reply other threads:[~2023-02-21 22:57 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-21 22:52 [PATCH v3 00/24] gdbstub: re-organise to for better compilation behaviour Alex Bennée
2023-02-21 22:52 ` [PATCH v3 01/24] gdbstub/internals.h: clean up include guard Alex Bennée
2023-02-21 22:52 ` [PATCH v3 02/24] gdbstub: fix-up copyright and license files Alex Bennée
2023-02-21 22:52 ` [PATCH v3 03/24] gdbstub: Make syscall_complete/[gs]et_reg target-agnostic typedefs Alex Bennée
2023-02-21 22:52 ` [PATCH v3 04/24] gdbstub: define separate user/system structures Alex Bennée
2023-02-21 22:52 ` [PATCH v3 05/24] gdbstub: move GDBState to shared internals header Alex Bennée
2023-02-21 22:52 ` [PATCH v3 06/24] includes: move tb_flush into its own header Alex Bennée
2023-02-21 22:52 ` [PATCH v3 07/24] gdbstub: move fromhex/tohex routines to internals Alex Bennée
2023-02-21 22:52 ` [PATCH v3 08/24] gdbstub: make various helpers visible to the rest of the module Alex Bennée
2023-02-21 22:52 ` [PATCH v3 09/24] gdbstub: move chunk of softmmu functionality to own file Alex Bennée
2023-02-22 0:26 ` Richard Henderson
2023-02-21 22:52 ` [PATCH v3 10/24] gdbstub: move chunks of user code into own files Alex Bennée
2023-02-22 7:16 ` Richard Henderson
2023-02-21 22:52 ` [PATCH v3 11/24] gdbstub: rationalise signal mapping in softmmu Alex Bennée
2023-02-22 0:32 ` Richard Henderson
2023-02-21 22:52 ` [PATCH v3 12/24] gdbstub: abstract target specific details from gdb_put_packet_binary Alex Bennée
2023-02-21 22:52 ` [PATCH v3 13/24] gdbstub: specialise handle_query_attached Alex Bennée
2023-02-21 22:52 ` [PATCH v3 14/24] gdbstub: specialise target_memory_rw_debug Alex Bennée
2023-02-21 22:52 ` [PATCH v3 15/24] gdbstub: introduce gdb_get_max_cpus Alex Bennée
2023-02-21 22:52 ` [PATCH v3 16/24] gdbstub: specialise stub_can_reverse Alex Bennée
2023-02-21 22:52 ` [PATCH v3 17/24] gdbstub: fix address type of gdb_set_cpu_pc Alex Bennée
2023-02-21 22:52 ` [PATCH v3 18/24] gdbstub: don't use target_ulong while handling registers Alex Bennée
2023-02-22 0:51 ` Richard Henderson
2023-02-21 22:52 ` [PATCH v3 19/24] gdbstub: move register helpers into standalone include Alex Bennée
2023-02-21 22:52 ` [PATCH v3 20/24] gdbstub: move syscall handling to new file Alex Bennée
2023-02-21 22:52 ` [PATCH v3 21/24] gdbstub: only compile gdbstub twice for whole build Alex Bennée
2023-02-22 7:18 ` Richard Henderson
2023-02-21 22:52 ` [PATCH v3 22/24] testing: probe gdb for supported architectures ahead of time Alex Bennée
2023-02-22 1:10 ` Richard Henderson
2023-02-21 22:52 ` Alex Bennée [this message]
2023-02-22 1:17 ` [PATCH v3 23/24] include: split target_long definition from cpu-defs Richard Henderson
2023-02-21 22:52 ` [PATCH v3 24/24] gdbstub: split out softmmu/user specifics for syscall handling Alex Bennée
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230221225227.3735319-24-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=aleksandar.rikalo@syrmia.com \
--cc=alistair.francis@wdc.com \
--cc=atar4qemu@gmail.com \
--cc=aurelien@aurel32.net \
--cc=bin.meng@windriver.com \
--cc=clg@kaod.org \
--cc=crwulff@gmail.com \
--cc=danielhb413@gmail.com \
--cc=david@gibson.dropbear.id.au \
--cc=david@redhat.com \
--cc=edgar.iglesias@gmail.com \
--cc=eduardo@habkost.net \
--cc=erdnaxe@crans.org \
--cc=gaosong@loongson.cn \
--cc=groug@kaod.org \
--cc=iii@linux.ibm.com \
--cc=jcmvbkbc@gmail.com \
--cc=jiaxun.yang@flygoat.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=laurent@vivier.eu \
--cc=ma.mandourr@gmail.com \
--cc=mads@ynddal.dk \
--cc=marcel.apfelbaum@gmail.com \
--cc=marex@denx.de \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=mrolnik@gmail.com \
--cc=nicolas.eder@lauterbach.com \
--cc=palmer@dabbelt.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=shorne@gmail.com \
--cc=sunilmut@microsoft.com \
--cc=thuth@redhat.com \
--cc=tsimpson@quicinc.com \
--cc=wangyanan55@huawei.com \
--cc=yangxiaojuan@loongson.cn \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).