qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jason Wang <jasowang@redhat.com>
To: mst@redhat.com, peterx@redhat.com
Cc: qemu-devel@nongnu.org, eric.auger@redhat.com, viktor@daynix.com,
	lvivier@redhat.com, Jason Wang <jasowang@redhat.com>
Subject: [PATCH V2 0/5] Fix UNMAP notifier for intel-iommu
Date: Thu, 23 Feb 2023 14:59:19 +0800	[thread overview]
Message-ID: <20230223065924.42503-1-jasowang@redhat.com> (raw)

Hi All:

According to ATS, device should work if ATS is disabled. This is not
correctly implemented in the current intel-iommu since it doesn't
handle the UNMAP notifier correctly. This breaks the vhost-net +
vIOMMU without dt.

The root casue is that the when there's a device IOTLB miss (note that
it's not specific to PCI so it can work without ATS), Qemu doesn't
build the IOVA tree, so when guest start an IOTLB invalidation, Qemu
won't trigger the UNMAP notifier.

Fixing this by triggering UNMAP notifier in those cases.

Thanks

Changes since V1:

- Do not depend on the iova tree for such kind of invalidation but
  simply tries to do UNMAP for all attached IOMMU notifiers

Jason Wang (4):
  intel-iommu: fail MAP notifier without caching mode
  intel-iommu: fail DEVIOTLB_UNMAP without dt mode
  memory: introduce memory_region_unmap_iommu_notifier_range()
  smmu: switch to use memory_region_unmap_iommu_notifier_range()

Peter Xu (1):
  intel-iommu: send UNMAP notifications for domain or global inv desc

 hw/arm/smmu-common.c  | 16 +---------------
 hw/i386/intel_iommu.c | 29 ++++++++++++++++++++++++-----
 include/exec/memory.h | 10 ++++++++++
 softmmu/memory.c      | 13 +++++++++++++
 4 files changed, 48 insertions(+), 20 deletions(-)

-- 
2.25.1



             reply	other threads:[~2023-02-23  6:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-23  6:59 Jason Wang [this message]
2023-02-23  6:59 ` [PATCH V2 1/5] intel-iommu: fail MAP notifier without caching mode Jason Wang
2023-02-23  6:59 ` [PATCH V2 2/5] intel-iommu: fail DEVIOTLB_UNMAP without dt mode Jason Wang
2023-02-23  6:59 ` [PATCH V2 3/5] memory: introduce memory_region_unmap_iommu_notifier_range() Jason Wang
2023-03-07 13:19   ` Thomas Huth
2023-03-08  1:02   ` Michael S. Tsirkin
2023-03-08  5:19     ` Jason Wang
2023-02-23  6:59 ` [PATCH V2 4/5] smmu: switch to use memory_region_unmap_iommu_notifier_range() Jason Wang
2023-02-23  6:59 ` [PATCH V2 5/5] intel-iommu: send UNMAP notifications for domain or global inv desc Jason Wang
2023-02-23 15:47 ` [PATCH V2 0/5] Fix UNMAP notifier for intel-iommu Peter Xu
2023-02-24  2:54   ` Jason Wang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230223065924.42503-1-jasowang@redhat.com \
    --to=jasowang@redhat.com \
    --cc=eric.auger@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=mst@redhat.com \
    --cc=peterx@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=viktor@daynix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).