qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, John Snow <jsnow@redhat.com>
Subject: [PULL 5/8] qapi: Add minor typing workaround for 3.6
Date: Thu, 23 Feb 2023 13:23:24 +0100	[thread overview]
Message-ID: <20230223122327.1920247-6-armbru@redhat.com> (raw)
In-Reply-To: <20230223122327.1920247-1-armbru@redhat.com>

From: John Snow <jsnow@redhat.com>

Pylint under 3.6 does not believe that Collection is subscriptable at
runtime. It is, making this a Pylint
bug. https://github.com/PyCQA/pylint/issues/2377

They closed it as fixed, but that doesn't seem to be true as of Pylint
2.13.9, the latest version you can install under Python 3.6. 2.13.9 was
released 2022-05-13, about seven months after the bug was closed.

The least-annoying fix here is to just use the concret type.

Signed-off-by: John Snow <jsnow@redhat.com>
Message-Id: <20230215000011.1725012-4-jsnow@redhat.com>
[Dumbed down from Sequence[str] to List[str], commit message adjusted]
Reviewed-by: Markus Armbruster <armbru@redhat.com>
---
 scripts/qapi/expr.py | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/scripts/qapi/expr.py b/scripts/qapi/expr.py
index 5a1782b57e..358b8e2a8b 100644
--- a/scripts/qapi/expr.py
+++ b/scripts/qapi/expr.py
@@ -33,7 +33,6 @@
 
 import re
 from typing import (
-    Collection,
     Dict,
     Iterable,
     List,
@@ -195,8 +194,8 @@ def check_defn_name_str(name: str, info: QAPISourceInfo, meta: str) -> None:
 def check_keys(value: _JSONObject,
                info: QAPISourceInfo,
                source: str,
-               required: Collection[str],
-               optional: Collection[str]) -> None:
+               required: List[str],
+               optional: List[str]) -> None:
     """
     Ensure that a dict has a specific set of keys.
 
-- 
2.39.0



  parent reply	other threads:[~2023-02-23 12:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-23 12:23 [PULL 0/8] QAPI patches patches for 2023-02-23 Markus Armbruster
2023-02-23 12:23 ` [PULL 1/8] docs/devel/qapi-code-gen: Belatedly update features documentation Markus Armbruster
2023-02-23 12:23 ` [PULL 2/8] docs/devel/qapi-code-gen: Fix a missing 'may', clarify SchemaInfo Markus Armbruster
2023-02-23 12:23 ` [PULL 3/8] qapi: Update flake8 config Markus Armbruster
2023-02-23 12:23 ` [PULL 4/8] qapi: update pylint configuration Markus Armbruster
2023-02-23 12:23 ` Markus Armbruster [this message]
2023-02-23 12:23 ` [PULL 6/8] qapi/parser: add QAPIExpression type Markus Armbruster
2023-02-23 12:23 ` [PULL 7/8] qapi: remove _JSONObject Markus Armbruster
2023-02-23 12:23 ` [PULL 8/8] qapi: remove JSON value FIXME Markus Armbruster
2023-02-24 15:07 ` [PULL 0/8] QAPI patches patches for 2023-02-23 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230223122327.1920247-6-armbru@redhat.com \
    --to=armbru@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).