From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, John Snow <jsnow@redhat.com>
Subject: [PULL 7/8] qapi: remove _JSONObject
Date: Thu, 23 Feb 2023 13:23:26 +0100 [thread overview]
Message-ID: <20230223122327.1920247-8-armbru@redhat.com> (raw)
In-Reply-To: <20230223122327.1920247-1-armbru@redhat.com>
From: John Snow <jsnow@redhat.com>
We can remove this alias as it only has two usages now, and no longer
pays for the confusion of "yet another type".
Signed-off-by: John Snow <jsnow@redhat.com>
Message-Id: <20230215000011.1725012-6-jsnow@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
---
scripts/qapi/expr.py | 13 +++----------
scripts/qapi/parser.py | 5 ++---
2 files changed, 5 insertions(+), 13 deletions(-)
diff --git a/scripts/qapi/expr.py b/scripts/qapi/expr.py
index b8f905543e..ca01ea6f4a 100644
--- a/scripts/qapi/expr.py
+++ b/scripts/qapi/expr.py
@@ -47,14 +47,6 @@
from .source import QAPISourceInfo
-# Deserialized JSON objects as returned by the parser.
-# The values of this mapping are not necessary to exhaustively type
-# here (and also not practical as long as mypy lacks recursive
-# types), because the purpose of this module is to interrogate that
-# type.
-_JSONObject = Dict[str, object]
-
-
# See check_name_str(), below.
valid_name = re.compile(r'(__[a-z0-9.-]+_)?'
r'(x-)?'
@@ -191,7 +183,7 @@ def check_defn_name_str(name: str, info: QAPISourceInfo, meta: str) -> None:
info, "%s name should not end in 'List'" % meta)
-def check_keys(value: _JSONObject,
+def check_keys(value: Dict[str, object],
info: QAPISourceInfo,
source: str,
required: List[str],
@@ -255,7 +247,8 @@ def check_flags(expr: QAPIExpression) -> None:
expr.info, "flags 'allow-oob' and 'coroutine' are incompatible")
-def check_if(expr: _JSONObject, info: QAPISourceInfo, source: str) -> None:
+def check_if(expr: Dict[str, object],
+ info: QAPISourceInfo, source: str) -> None:
"""
Validate the ``if`` member of an object.
diff --git a/scripts/qapi/parser.py b/scripts/qapi/parser.py
index 50906e27d4..d570086e1a 100644
--- a/scripts/qapi/parser.py
+++ b/scripts/qapi/parser.py
@@ -42,9 +42,8 @@
_ExprValue = Union[List[object], Dict[str, object], str, bool]
-# FIXME: Consolidate and centralize definitions for _ExprValue,
-# JSONValue, and _JSONObject; currently scattered across several
-# modules.
+# FIXME: Consolidate and centralize definitions for _ExprValue and
+# JSONValue; currently scattered across several modules.
class QAPIExpression(Dict[str, object]):
--
2.39.0
next prev parent reply other threads:[~2023-02-23 12:24 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 12:23 [PULL 0/8] QAPI patches patches for 2023-02-23 Markus Armbruster
2023-02-23 12:23 ` [PULL 1/8] docs/devel/qapi-code-gen: Belatedly update features documentation Markus Armbruster
2023-02-23 12:23 ` [PULL 2/8] docs/devel/qapi-code-gen: Fix a missing 'may', clarify SchemaInfo Markus Armbruster
2023-02-23 12:23 ` [PULL 3/8] qapi: Update flake8 config Markus Armbruster
2023-02-23 12:23 ` [PULL 4/8] qapi: update pylint configuration Markus Armbruster
2023-02-23 12:23 ` [PULL 5/8] qapi: Add minor typing workaround for 3.6 Markus Armbruster
2023-02-23 12:23 ` [PULL 6/8] qapi/parser: add QAPIExpression type Markus Armbruster
2023-02-23 12:23 ` Markus Armbruster [this message]
2023-02-23 12:23 ` [PULL 8/8] qapi: remove JSON value FIXME Markus Armbruster
2023-02-24 15:07 ` [PULL 0/8] QAPI patches patches for 2023-02-23 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230223122327.1920247-8-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=jsnow@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).