qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, "Alex Bennée" <alex.bennee@linaro.org>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Thomas Huth" <thuth@redhat.com>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Daniel P. Berrangé" <berrange@redhat.com>
Subject: [PULL 03/13] tests: be a bit more strict cleaning up fifos
Date: Thu, 23 Feb 2023 15:57:10 +0000	[thread overview]
Message-ID: <20230223155720.310593-4-alex.bennee@linaro.org> (raw)
In-Reply-To: <20230223155720.310593-1-alex.bennee@linaro.org>

When we re-factored we dropped the unlink() step which turns out to be
required for rmdir to do its thing. If we had been checking the return
value we would have noticed so lets do that with this fix.

Fixes: 68406d1085 (tests/unit: cleanups for test-io-channel-command)
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Suggested-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20230221094558.2864616-5-alex.bennee@linaro.org>

diff --git a/tests/unit/test-io-channel-command.c b/tests/unit/test-io-channel-command.c
index 04b75ab3b4..c6e66a8c33 100644
--- a/tests/unit/test-io-channel-command.c
+++ b/tests/unit/test-io-channel-command.c
@@ -42,6 +42,7 @@ static void test_io_channel_command_fifo(bool async)
     g_auto(GStrv) dstargv = g_strsplit(dstargs, " ", -1);
     QIOChannel *src, *dst;
     QIOChannelTest *test;
+    int err;
 
     if (mkfifo(fifo, 0600)) {
         g_error("mkfifo: %s", strerror(errno));
@@ -61,7 +62,10 @@ static void test_io_channel_command_fifo(bool async)
     object_unref(OBJECT(src));
     object_unref(OBJECT(dst));
 
-    g_rmdir(tmpdir);
+    err = g_unlink(fifo);
+    g_assert(err == 0);
+    err = g_rmdir(tmpdir);
+    g_assert(err == 0);
 }
 
 static void test_io_channel_command_fifo_async(void)
-- 
2.39.1



  parent reply	other threads:[~2023-02-23 15:59 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-23 15:57 [PULL 00/13] testing updates (gitlab, cirrus, docker, avocado, windows) Alex Bennée
2023-02-23 15:57 ` [PULL 01/13] tests: don't run socat tests on MacOS as well Alex Bennée
2023-02-23 15:57 ` [PULL 02/13] tests: add socat dependency for tests Alex Bennée
2023-02-23 15:57 ` Alex Bennée [this message]
2023-02-23 15:57 ` [PULL 04/13] tests: make fp-test less chatty when running from test suite Alex Bennée
2023-02-23 15:57 ` [PULL 05/13] gitlab-ci: Use artifacts instead of dumping logs in the Cirrus-CI jobs Alex Bennée
2023-02-23 15:57 ` [PULL 06/13] gitlab: extend custom runners with base_job_template Alex Bennée
2023-02-23 15:57 ` [PULL 07/13] tests: don't run benchmarks for the tsan build Alex Bennée
2023-02-23 15:57 ` [PULL 08/13] testing: update ubuntu2004 to ubuntu2204 Alex Bennée
2023-02-23 15:57 ` [PULL 09/13] tests: skip the nios2 replay_kernel test Alex Bennée
2023-02-23 15:57 ` [PULL 10/13] tests: add tuxrun baseline test to avocado Alex Bennée
2023-02-23 15:57 ` [PULL 11/13] tests/docker: Use binaries for debian-tricore-cross Alex Bennée
2023-02-23 15:57 ` [PULL 12/13] tests: ensure we export job results for some cross builds Alex Bennée
2023-02-23 15:57 ` [PULL 13/13] cirrus.yml: Improve the windows_msys2_task Alex Bennée
2023-02-24 18:55 ` [PULL 00/13] testing updates (gitlab, cirrus, docker, avocado, windows) Peter Maydell
2023-02-24 19:52   ` Alex Bennée
2023-02-24 21:23     ` Philippe Mathieu-Daudé
2023-02-26 20:13       ` Peter Maydell
2023-03-01 10:02         ` Alex Bennée
2023-02-27 11:58 ` Peter Maydell
2023-02-27 14:59   ` Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230223155720.310593-4-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=berrange@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).