From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Thomas Huth" <thuth@redhat.com>,
"Janosch Frank" <frankja@linux.ibm.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH v4 3/7] dump: Correct headers included
Date: Fri, 24 Feb 2023 00:17:51 +0100 [thread overview]
Message-ID: <20230223231755.81633-4-philmd@linaro.org> (raw)
In-Reply-To: <20230223231755.81633-1-philmd@linaro.org>
"qemu/win_dump_defs.h" is only required by win_dump.c,
but win_dump.h requires "sysemu/dump.h" which declares
the DumpState type.
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
dump/win_dump.c | 1 +
dump/win_dump.h | 2 +-
2 files changed, 2 insertions(+), 1 deletion(-)
diff --git a/dump/win_dump.c b/dump/win_dump.c
index f20b6051b6..12b7da5da0 100644
--- a/dump/win_dump.c
+++ b/dump/win_dump.c
@@ -21,6 +21,7 @@
#include "qapi/qmp/qerror.h"
#include "qemu/error-report.h"
#include "hw/misc/vmcoreinfo.h"
+#include "qemu/win_dump_defs.h"
#include "win_dump.h"
static size_t win_dump_ptr_size(bool x64)
diff --git a/dump/win_dump.h b/dump/win_dump.h
index b8c25348f4..56f63683c3 100644
--- a/dump/win_dump.h
+++ b/dump/win_dump.h
@@ -11,7 +11,7 @@
#ifndef WIN_DUMP_H
#define WIN_DUMP_H
-#include "qemu/win_dump_defs.h"
+#include "sysemu/dump.h"
void create_win_dump(DumpState *s, Error **errp);
--
2.38.1
next prev parent reply other threads:[~2023-02-23 23:19 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-23 23:17 [PATCH v4 0/7] dump: Make most of it target agnostic (build once) Philippe Mathieu-Daudé
2023-02-23 23:17 ` [PATCH v4 1/7] dump: Replace tswapN() -> cpu_to_dumpN() Philippe Mathieu-Daudé
2023-02-23 23:29 ` Richard Henderson
2023-02-24 7:00 ` Thomas Huth
2023-02-23 23:17 ` [PATCH v4 2/7] dump: Replace TARGET_PAGE_SIZE -> qemu_target_page_size() Philippe Mathieu-Daudé
2023-02-23 23:30 ` Richard Henderson
2023-02-24 7:01 ` Thomas Huth
2023-02-23 23:17 ` Philippe Mathieu-Daudé [this message]
2023-02-23 23:32 ` [PATCH v4 3/7] dump: Correct headers included Richard Henderson
2023-02-24 7:02 ` Thomas Huth
2023-02-23 23:17 ` [PATCH v4 4/7] dump: Introduce win_dump_available() Philippe Mathieu-Daudé
2023-02-23 23:43 ` Richard Henderson
2023-02-24 7:08 ` Thomas Huth
2023-02-23 23:17 ` [PATCH v4 5/7] dump: Introduce create_win_dump() Philippe Mathieu-Daudé
2023-02-23 23:43 ` Richard Henderson
2023-02-24 7:08 ` Thomas Huth
2023-02-23 23:17 ` [PATCH v4 6/7] dump: Build once by adding stubs for non-x86 targets Philippe Mathieu-Daudé
2023-02-23 23:51 ` Richard Henderson
2023-02-24 6:53 ` Philippe Mathieu-Daudé
2023-02-23 23:17 ` [PATCH v4 7/7] dump: Rename x86-specific file as win_dump_x86.c Philippe Mathieu-Daudé
2023-02-23 23:22 ` Philippe Mathieu-Daudé
2023-02-23 23:52 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230223231755.81633-4-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=frankja@linux.ibm.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).