* Re: [PATCH v2] Deprecate the "-no-acpi" command line switch
2023-02-24 9:05 [PATCH v2] Deprecate the "-no-acpi" command line switch Thomas Huth
@ 2023-02-24 9:10 ` Sunil V L
2023-02-24 9:18 ` Peter Krempa
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Sunil V L @ 2023-02-24 9:10 UTC (permalink / raw)
To: Thomas Huth
Cc: qemu-devel, Paolo Bonzini, libvir-list, Shannon Zhao,
Michael S . Tsirkin, Igor Mammedov, Ani Sinha,
Jean-Philippe Brucker, Dongjiu Geng, Philippe Mathieu-Daudé,
Aurelien Jarno
On Fri, Feb 24, 2023 at 10:05:43AM +0100, Thomas Huth wrote:
> Similar to "-no-hpet", the "-no-acpi" switch is a legacy command
> line option that should be replaced with the "acpi" machine parameter
> nowadays.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> v2: Fixed stypid copy-n-paste bug (Thanks to Sunil for spotting it!)
>
> docs/about/deprecated.rst | 6 ++++++
> softmmu/vl.c | 1 +
> 2 files changed, 7 insertions(+)
>
Reviewed-by: Sunil V L <sunilvl@ventanamicro.com>
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH v2] Deprecate the "-no-acpi" command line switch
2023-02-24 9:05 [PATCH v2] Deprecate the "-no-acpi" command line switch Thomas Huth
2023-02-24 9:10 ` Sunil V L
@ 2023-02-24 9:18 ` Peter Krempa
2023-02-24 9:52 ` Philippe Mathieu-Daudé
2023-02-24 12:57 ` Igor Mammedov
3 siblings, 0 replies; 5+ messages in thread
From: Peter Krempa @ 2023-02-24 9:18 UTC (permalink / raw)
To: Thomas Huth
Cc: qemu-devel, Paolo Bonzini, Jean-Philippe Brucker, Dongjiu Geng,
Philippe Mathieu-Daudé, Michael S . Tsirkin, libvir-list,
Shannon Zhao, Sunil V L, Ani Sinha, Igor Mammedov, Aurelien Jarno
On Fri, Feb 24, 2023 at 10:05:43 +0100, Thomas Huth wrote:
> Similar to "-no-hpet", the "-no-acpi" switch is a legacy command
> line option that should be replaced with the "acpi" machine parameter
> nowadays.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> v2: Fixed stypid copy-n-paste bug (Thanks to Sunil for spotting it!)
>
> docs/about/deprecated.rst | 6 ++++++
> softmmu/vl.c | 1 +
> 2 files changed, 7 insertions(+)
For now libvirt is still using '-no-acpi' but it will be an easy fix.
I'll send patches on monday. On behalf of libvirt:
Reviewed-by: Peter Krempa <pkrempa@redhat.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] Deprecate the "-no-acpi" command line switch
2023-02-24 9:05 [PATCH v2] Deprecate the "-no-acpi" command line switch Thomas Huth
2023-02-24 9:10 ` Sunil V L
2023-02-24 9:18 ` Peter Krempa
@ 2023-02-24 9:52 ` Philippe Mathieu-Daudé
2023-02-24 12:57 ` Igor Mammedov
3 siblings, 0 replies; 5+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-02-24 9:52 UTC (permalink / raw)
To: Thomas Huth, qemu-devel, Paolo Bonzini
Cc: libvir-list, Shannon Zhao, Michael S . Tsirkin, Igor Mammedov,
Ani Sinha, Jean-Philippe Brucker, Dongjiu Geng, Aurelien Jarno,
Sunil V L
On 24/2/23 10:05, Thomas Huth wrote:
> Similar to "-no-hpet", the "-no-acpi" switch is a legacy command
> line option that should be replaced with the "acpi" machine parameter
> nowadays.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
> ---
> v2: Fixed stypid copy-n-paste bug (Thanks to Sunil for spotting it!)
>
> docs/about/deprecated.rst | 6 ++++++
> softmmu/vl.c | 1 +
> 2 files changed, 7 insertions(+)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH v2] Deprecate the "-no-acpi" command line switch
2023-02-24 9:05 [PATCH v2] Deprecate the "-no-acpi" command line switch Thomas Huth
` (2 preceding siblings ...)
2023-02-24 9:52 ` Philippe Mathieu-Daudé
@ 2023-02-24 12:57 ` Igor Mammedov
3 siblings, 0 replies; 5+ messages in thread
From: Igor Mammedov @ 2023-02-24 12:57 UTC (permalink / raw)
To: Thomas Huth
Cc: qemu-devel, Paolo Bonzini, Jean-Philippe Brucker, Dongjiu Geng,
Philippe Mathieu-Daudé, Michael S . Tsirkin, libvir-list,
Shannon Zhao, Sunil V L, Ani Sinha, Aurelien Jarno
On Fri, 24 Feb 2023 10:05:43 +0100
Thomas Huth <thuth@redhat.com> wrote:
> Similar to "-no-hpet", the "-no-acpi" switch is a legacy command
> line option that should be replaced with the "acpi" machine parameter
> nowadays.
>
> Signed-off-by: Thomas Huth <thuth@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> ---
> v2: Fixed stypid copy-n-paste bug (Thanks to Sunil for spotting it!)
>
> docs/about/deprecated.rst | 6 ++++++
> softmmu/vl.c | 1 +
> 2 files changed, 7 insertions(+)
>
> diff --git a/docs/about/deprecated.rst b/docs/about/deprecated.rst
> index ee95bcb1a6..15084f7bea 100644
> --- a/docs/about/deprecated.rst
> +++ b/docs/about/deprecated.rst
> @@ -99,6 +99,12 @@ form is preferred.
> The HPET setting has been turned into a machine property.
> Use ``-machine hpet=off`` instead.
>
> +``-no-acpi`` (since 8.0)
> +''''''''''''''''''''''''
> +
> +The ``-no-acpi`` setting has been turned into a machine property.
> +Use ``-machine acpi=off`` instead.
> +
> ``-accel hax`` (since 8.0)
> ''''''''''''''''''''''''''
>
> diff --git a/softmmu/vl.c b/softmmu/vl.c
> index 459588aa7d..a3c59b5462 100644
> --- a/softmmu/vl.c
> +++ b/softmmu/vl.c
> @@ -3271,6 +3271,7 @@ void qemu_init(int argc, char **argv)
> vnc_parse(optarg);
> break;
> case QEMU_OPTION_no_acpi:
> + warn_report("-no-acpi is deprecated, use '-machine acpi=off' instead");
> qdict_put_str(machine_opts_dict, "acpi", "off");
> break;
> case QEMU_OPTION_no_hpet:
^ permalink raw reply [flat|nested] 5+ messages in thread