From: Fabiano Rosas <farosas@suse.de>
To: qemu-devel@nongnu.org
Cc: "Thomas Huth" <thuth@redhat.com>,
"Alex Bennée" <alex.bennee@linaro.org>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>,
"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
"Beraldo Leal" <bleal@redhat.com>,
"Daniel P . Berrangé" <berrange@redhat.com>
Subject: [RFC PATCH v2 3/3] gitlab: Remove COMMON_TAG from container-template.yml
Date: Fri, 24 Feb 2023 09:52:07 -0300 [thread overview]
Message-ID: <20230224125207.19616-4-farosas@suse.de> (raw)
In-Reply-To: <20230224125207.19616-1-farosas@suse.de>
We're not using the COMMON_TAG and we cannot have a push to a
different registry than we pull from because that would get in the way
of forks testing their changes to a dockerfile.
Signed-off-by: Fabiano Rosas <farosas@suse.de>
---
.gitlab-ci.d/container-template.yml | 2 --
1 file changed, 2 deletions(-)
diff --git a/.gitlab-ci.d/container-template.yml b/.gitlab-ci.d/container-template.yml
index 31e4e36a7d..e7c1fa1522 100644
--- a/.gitlab-ci.d/container-template.yml
+++ b/.gitlab-ci.d/container-template.yml
@@ -6,13 +6,11 @@
- docker:dind
before_script:
- export TAG="$CI_REGISTRY_IMAGE/qemu/$NAME:latest"
- - export COMMON_TAG="$CI_REGISTRY/qemu-project/qemu/$NAME:latest"
- apk add python3
- docker info
- docker login $CI_REGISTRY -u "$CI_REGISTRY_USER" -p "$CI_REGISTRY_PASSWORD"
script:
- echo "TAG:$TAG"
- - echo "COMMON_TAG:$COMMON_TAG"
- docker pull "$TAG" || true
- docker build --tag "$TAG" --cache-from "$TAG"
--build-arg BUILDKIT_INLINE_CACHE=1
--
2.35.3
prev parent reply other threads:[~2023-02-24 12:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 12:52 [RFC PATCH v2 0/3] ci: Speed up container stage Fabiano Rosas
2023-02-24 12:52 ` [RFC PATCH v2 1/3] gitlab: Use plain docker in container-template.yml Fabiano Rosas
2023-02-27 11:11 ` Daniel P. Berrangé
2023-02-24 12:52 ` [RFC PATCH v2 2/3] gitlab: Cache container images Fabiano Rosas
2023-02-27 11:09 ` Daniel P. Berrangé
2023-02-24 12:52 ` Fabiano Rosas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230224125207.19616-4-farosas@suse.de \
--to=farosas@suse.de \
--cc=alex.bennee@linaro.org \
--cc=berrange@redhat.com \
--cc=bleal@redhat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=thuth@redhat.com \
--cc=wainersm@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).