qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Fiona Ebner <f.ebner@proxmox.com>
To: qemu-devel@nongnu.org
Cc: qemu-block@nongnu.org, armbru@redhat.com, eblake@redhat.com,
	hreitz@redhat.com, kwolf@redhat.com, vsementsov@yandex-team.ru,
	jsnow@redhat.com, den@virtuozzo.com, t.lamprecht@proxmox.com,
	alexander.ivanov@virtuozzo.com
Subject: [PATCH 9/9] mirror: return the total number of bytes sent upon query
Date: Fri, 24 Feb 2023 15:48:25 +0100	[thread overview]
Message-ID: <20230224144825.466375-10-f.ebner@proxmox.com> (raw)
In-Reply-To: <20230224144825.466375-1-f.ebner@proxmox.com>

This can be used by management applications starting with a job in
background mode to determine when the switch to active mode should
happen.

While the same information is already there, as the job-agnostic
@offset, it's not clear to users what the value means for mirror: it's
documentet to be relative to @len only and @len is documented to be
able to change in both directions while the job runs.

Suggested-by: Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>
Signed-off-by: Fiona Ebner <f.ebner@proxmox.com>
---
 block/mirror.c       | 6 ++++++
 qapi/block-core.json | 5 ++++-
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/block/mirror.c b/block/mirror.c
index ac83309b82..e7b4905b70 100644
--- a/block/mirror.c
+++ b/block/mirror.c
@@ -86,6 +86,9 @@ typedef struct MirrorBlockJob {
     int64_t active_write_bytes_in_flight;
     bool prepared;
     bool in_drain;
+
+    /* Additional information intended for users (returned in mirror_query) */
+    int64_t data_sent;
 } MirrorBlockJob;
 
 typedef struct MirrorBDSOpaque {
@@ -215,6 +218,7 @@ static void coroutine_fn mirror_iteration_done(MirrorOp *op, int ret)
         }
         if (!s->initial_zeroing_ongoing) {
             job_progress_update(&s->common.job, op->bytes);
+            s->data_sent += op->bytes;
         }
     }
     qemu_iovec_destroy(&op->qiov);
@@ -1259,6 +1263,7 @@ static void mirror_query(BlockJob *job, BlockJobInfo *info)
 
     info->u.mirror = (BlockJobInfoMirror) {
         .actively_synced = s->actively_synced,
+        .data_sent       = s->data_sent,
         .remaining_dirty = bdrv_get_dirty_count(s->dirty_bitmap),
     };
 }
@@ -1384,6 +1389,7 @@ do_sync_target_write(MirrorBlockJob *job, MirrorMethod method,
     job->active_write_bytes_in_flight -= bytes;
     if (ret >= 0) {
         job_progress_update(&job->common.job, bytes);
+        job->data_sent += bytes;
     } else {
         BlockErrorAction action;
 
diff --git a/qapi/block-core.json b/qapi/block-core.json
index 91594eace4..656be5ce2e 100644
--- a/qapi/block-core.json
+++ b/qapi/block-core.json
@@ -1308,12 +1308,15 @@
 # @actively-synced: Whether the source is actively synced to the target, i.e.
 #                   same data and new writes are done synchronously to both.
 #
+# @data-sent: How much data was sent in total until now.
+#
 # @remaining-dirty: How much of the source is dirty relative to the target.
 #
 # Since 8.0
 ##
 { 'struct': 'BlockJobInfoMirror',
-  'data': { 'actively-synced': 'bool', 'remaining-dirty': 'int64' } }
+  'data': { 'actively-synced': 'bool', 'data-sent': 'int64',
+            'remaining-dirty': 'int64' } }
 
 ##
 # @BlockJobInfo:
-- 
2.30.2




  parent reply	other threads:[~2023-02-24 14:51 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-24 14:48 [PATCH 0/9] mirror: allow switching from background to active mode Fiona Ebner
2023-02-24 14:48 ` [PATCH 1/9] blockjob: introduce block-job-change QMP command Fiona Ebner
2023-02-24 14:48 ` [PATCH 2/9] block/mirror: set actively_synced even after the job is ready Fiona Ebner
2023-03-01 14:34   ` Vladimir Sementsov-Ogievskiy
2023-02-24 14:48 ` [PATCH 3/9] mirror: implement mirror_change method Fiona Ebner
2023-03-01 15:18   ` Vladimir Sementsov-Ogievskiy
2023-03-02 10:00     ` Fiona Ebner
2023-02-24 14:48 ` [PATCH 4/9] qapi/block-core: use JobType for BlockJobInfo's type Fiona Ebner
2023-03-01 16:27   ` Vladimir Sementsov-Ogievskiy
2023-02-24 14:48 ` [PATCH 5/9] qapi/block-core: turn BlockJobInfo into a union Fiona Ebner
2023-03-01 16:28   ` Vladimir Sementsov-Ogievskiy
2023-02-24 14:48 ` [PATCH 6/9] blockjob: query driver-specific info via a new 'query' driver method Fiona Ebner
2023-02-24 14:48 ` [PATCH 7/9] mirror: return mirror-specific information upon query Fiona Ebner
2023-02-24 14:48 ` [PATCH 8/9] mirror: return the remaining dirty bytes " Fiona Ebner
2023-03-01 16:31   ` Vladimir Sementsov-Ogievskiy
2023-03-02 10:00     ` Fiona Ebner
2023-03-02 10:13       ` Vladimir Sementsov-Ogievskiy
2023-03-02 12:34         ` Fiona Ebner
2023-03-02 16:31           ` Vladimir Sementsov-Ogievskiy
2023-03-03  7:47             ` Fiona Ebner
2023-02-24 14:48 ` Fiona Ebner [this message]
2023-03-01 14:34 ` [PATCH 0/9] mirror: allow switching from background to active mode Vladimir Sementsov-Ogievskiy
2023-03-01 14:49   ` Fiona Ebner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230224144825.466375-10-f.ebner@proxmox.com \
    --to=f.ebner@proxmox.com \
    --cc=alexander.ivanov@virtuozzo.com \
    --cc=armbru@redhat.com \
    --cc=den@virtuozzo.com \
    --cc=eblake@redhat.com \
    --cc=hreitz@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=t.lamprecht@proxmox.com \
    --cc=vsementsov@yandex-team.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).