Re: [PATCH 1/6] hw/cxl: Move enum ret_code definition to cxl_device.h

[Jonathan Cameron via <qemu-devel@nongnu.org>]

On Tue, 21 Feb 2023 17:47:23 -0800
Ira Weiny <ira.weiny@intel.com> wrote:

> Jonathan Cameron wrote:
> > Needs tidy up and rename to something more generic now it is
> > in a header.  
> 
> I'm not opposed to this change and patch 2 but I don't see where
> CXLRetCode is being used outside of cxl-mailbox-utils.c in this series.
> 
> Despite that reservation I think this is a good clarification.
> 
> Reviewed-by: Ira Weiny <ira.weiny@intel.com>

Ah.  This is a mess due to patch reordering as this was originally
meant as a precursor for your event injection series then I had to drag
it forwards to here to avoid introducing more use of the old naming.

Let me see if I can swap it round and just do the rename in this series
and push the move back to the start of that series - which I'll post
soon.

As it's the same code changes in a different order I'll pick up your RB.
Give me a shout if you'd rather I didn't!

Thanks,

Jonathan



> 
> > 
> > Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
> > ---
> >  hw/cxl/cxl-mailbox-utils.c  | 28 ----------------------------
> >  include/hw/cxl/cxl_device.h | 28 ++++++++++++++++++++++++++++
> >  2 files changed, 28 insertions(+), 28 deletions(-)
> >