From: "Volker Rümelin" <vr_qemu@t-online.de>
To: "Gerd Hoffmann" <kraxel@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@gmail.com>
Cc: Christian Schoenebeck <qemu_oss@crudebyte.com>,
Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>,
qemu-devel@nongnu.org
Subject: [PATCH v3 11/15] audio: rename variables in audio_pcm_sw_read()
Date: Fri, 24 Feb 2023 20:05:51 +0100 [thread overview]
Message-ID: <20230224190555.7409-11-vr_qemu@t-online.de> (raw)
In-Reply-To: <fa61e27f-6c37-af55-44bc-119592240720@t-online.de>
The audio_pcm_sw_read() function uses a few very unspecific
variable names. Rename them for better readability.
ret => total_out
total => total_in
size => buf_len
samples => frames_out_max
Acked-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Reviewed-by: Marc-André Lureau <marcandre.lureau@redhat.com>
Signed-off-by: Volker Rümelin <vr_qemu@t-online.de>
---
audio/audio.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/audio/audio.c b/audio/audio.c
index 9e9c03a42e..22c36d6660 100644
--- a/audio/audio.c
+++ b/audio/audio.c
@@ -576,10 +576,10 @@ static void audio_pcm_sw_resample_in(SWVoiceIn *sw,
}
}
-static size_t audio_pcm_sw_read(SWVoiceIn *sw, void *buf, size_t size)
+static size_t audio_pcm_sw_read(SWVoiceIn *sw, void *buf, size_t buf_len)
{
HWVoiceIn *hw = sw->hw;
- size_t samples, live, ret, swlim, total;
+ size_t live, frames_out_max, swlim, total_in, total_out;
live = hw->total_samples_captured - sw->total_hw_samples_acquired;
if (!live) {
@@ -590,20 +590,20 @@ static size_t audio_pcm_sw_read(SWVoiceIn *sw, void *buf, size_t size)
return 0;
}
- samples = size / sw->info.bytes_per_frame;
+ frames_out_max = buf_len / sw->info.bytes_per_frame;
swlim = (live * sw->ratio) >> 32;
- swlim = MIN (swlim, samples);
+ swlim = MIN(swlim, frames_out_max);
- audio_pcm_sw_resample_in(sw, live, swlim, &total, &ret);
+ audio_pcm_sw_resample_in(sw, live, swlim, &total_in, &total_out);
if (!hw->pcm_ops->volume_in) {
- mixeng_volume(sw->resample_buf.buffer, ret, &sw->vol);
+ mixeng_volume(sw->resample_buf.buffer, total_out, &sw->vol);
}
+ sw->clip(buf, sw->resample_buf.buffer, total_out);
- sw->clip(buf, sw->resample_buf.buffer, ret);
- sw->total_hw_samples_acquired += total;
- return ret * sw->info.bytes_per_frame;
+ sw->total_hw_samples_acquired += total_in;
+ return total_out * sw->info.bytes_per_frame;
}
/*
--
2.35.3
next prev parent reply other threads:[~2023-02-24 19:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 19:03 [PATCH v3 00/15] audio: improve callback interface for audio frontends Volker Rümelin
2023-02-24 19:05 ` [PATCH v3 01/15] audio: change type of mix_buf and conv_buf Volker Rümelin
2023-02-24 19:05 ` [PATCH v3 02/15] audio: change type and name of the resample buffer Volker Rümelin
2023-02-24 19:05 ` [PATCH v3 03/15] audio: make the resampling code greedy Volker Rümelin
2023-02-24 19:05 ` [PATCH v3 04/15] audio: replace the resampling loop in audio_pcm_sw_write() Volker Rümelin
2023-02-24 19:05 ` [PATCH v3 05/15] audio: remove sw == NULL check Volker Rümelin
2023-02-24 19:05 ` [PATCH v3 06/15] audio: rename variables in audio_pcm_sw_write() Volker Rümelin
2023-02-24 19:05 ` [PATCH v3 07/15] audio: don't misuse audio_pcm_sw_write() Volker Rümelin
2023-02-24 19:05 ` [PATCH v3 08/15] audio: remove unused noop_conv() function Volker Rümelin
2023-02-24 19:05 ` [PATCH v3 09/15] audio: make playback packet length calculation exact Volker Rümelin
2023-02-24 19:05 ` [PATCH v3 10/15] audio: replace the resampling loop in audio_pcm_sw_read() Volker Rümelin
2023-02-24 19:05 ` Volker Rümelin [this message]
2023-02-24 19:05 ` [PATCH v3 12/15] audio: make recording packet length calculation exact Volker Rümelin
2023-02-24 19:05 ` [PATCH v3 13/15] audio: handle leftover audio frame from upsampling Volker Rümelin
2023-02-24 19:05 ` [PATCH v3 14/15] audio/audio_template: substitute sw->hw with hw Volker Rümelin
2023-02-24 19:05 ` [PATCH v3 15/15] audio: remove sw->ratio Volker Rümelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230224190555.7409-11-vr_qemu@t-online.de \
--to=vr_qemu@t-online.de \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@gmail.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=qemu-devel@nongnu.org \
--cc=qemu_oss@crudebyte.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).