From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: qemu-arm@nongnu.org, qemu-ppc@nongnu.org, qemu-riscv@nongnu.org,
qemu-s390x@nongnu.org, jcmvbkbc@gmail.com,
kbastian@mail.uni-paderborn.de, ysato@users.sourceforge.jp,
gaosong@loongson.cn, jiaxun.yang@flygoat.com,
tsimpson@quicinc.com, ale@rev.ng, mrolnik@gmail.com,
edgar.iglesias@gmail.com,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH v4 03/31] accel/tcg: Use more accurate max_insns for tb_overflow
Date: Sun, 26 Feb 2023 19:36:33 -1000 [thread overview]
Message-ID: <20230227053701.368744-4-richard.henderson@linaro.org> (raw)
In-Reply-To: <20230227053701.368744-1-richard.henderson@linaro.org>
Write back the number of insns that we attempt to translate,
so that if we longjmp out we have a more accurate limit for
the next attempt. This results in fewer restarts when some
limit is consumed by few instructions.
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
accel/tcg/translator.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/accel/tcg/translator.c b/accel/tcg/translator.c
index fac1e8c465..62e8f28025 100644
--- a/accel/tcg/translator.c
+++ b/accel/tcg/translator.c
@@ -78,7 +78,7 @@ void translator_loop(CPUState *cpu, TranslationBlock *tb, int *max_insns,
plugin_enabled = plugin_gen_tb_start(cpu, db, cflags & CF_MEMI_ONLY);
while (true) {
- db->num_insns++;
+ *max_insns = ++db->num_insns;
ops->insn_start(db, cpu);
tcg_debug_assert(db->is_jmp == DISAS_NEXT); /* no early exit */
--
2.34.1
next prev parent reply other threads:[~2023-02-27 8:20 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-27 5:36 [PATCH v4 00/31] tcg: Simplify temporary usage Richard Henderson
2023-02-27 5:36 ` [PATCH v4 01/31] tcg: Adjust TCGContext.temps_in_use check Richard Henderson
2023-02-27 5:36 ` [PATCH v4 02/31] accel/tcg: Pass max_insn to gen_intermediate_code by pointer Richard Henderson
2023-02-27 5:36 ` Richard Henderson [this message]
2023-02-27 5:36 ` [PATCH v4 04/31] tcg: Remove branch-to-next regardless of reference count Richard Henderson
2023-02-27 5:36 ` [PATCH v4 05/31] tcg: Rename TEMP_LOCAL to TEMP_TB Richard Henderson
2023-02-27 5:36 ` [PATCH v4 06/31] tcg: Use noinline for major tcg_gen_code subroutines Richard Henderson
2023-02-27 5:36 ` [PATCH v4 07/31] tcg: Add liveness_pass_0 Richard Henderson
2023-02-28 17:29 ` Alex Bennée
2023-02-27 5:36 ` [PATCH v4 08/31] tcg: Remove TEMP_NORMAL Richard Henderson
2023-02-27 5:36 ` [PATCH v4 09/31] tcg: Pass TCGTempKind to tcg_temp_new_internal Richard Henderson
2023-02-27 5:36 ` [PATCH v4 10/31] tcg: Use tcg_constant_i32 in tcg_gen_io_start Richard Henderson
2023-02-27 5:36 ` [PATCH v4 11/31] tcg: Add tcg_gen_movi_ptr Richard Henderson
2023-02-27 5:36 ` [PATCH v4 12/31] tcg: Add tcg_temp_ebb_new_{i32,i64,ptr} Richard Henderson
2023-02-27 5:36 ` [PATCH v4 13/31] tcg: Use tcg_temp_ebb_new_* in tcg/ Richard Henderson
2023-02-27 5:36 ` [PATCH v4 14/31] tcg: Use tcg_constant_ptr in do_dup Richard Henderson
2023-02-27 5:36 ` [PATCH v4 15/31] accel/tcg/plugin: Use tcg_temp_ebb_* Richard Henderson
2023-02-27 5:36 ` [PATCH v4 16/31] accel/tcg/plugin: Tidy plugin_gen_disable_mem_helpers Richard Henderson
2023-02-27 5:36 ` [PATCH v4 17/31] tcg: Don't re-use TEMP_TB temporaries Richard Henderson
2023-02-28 17:48 ` Alex Bennée
2023-02-27 5:36 ` [PATCH v4 18/31] tcg: Change default temp lifetime to TEMP_TB Richard Henderson
2023-02-27 5:36 ` [PATCH v4 19/31] target/arm: Drop copies in gen_sve_{ldr,str} Richard Henderson
2023-02-27 5:36 ` [PATCH v4 20/31] target/arm: Don't use tcg_temp_local_new_* Richard Henderson
2023-02-27 5:36 ` [PATCH v4 21/31] target/cris: Don't use tcg_temp_local_new Richard Henderson
2023-02-27 5:36 ` [PATCH v4 22/31] target/hexagon: Don't use tcg_temp_local_new_* Richard Henderson
2023-02-27 17:33 ` Taylor Simpson
2023-02-27 5:36 ` [PATCH v4 23/31] target/hexagon/idef-parser: Drop gen_tmp_local Richard Henderson
2023-02-27 7:19 ` Philippe Mathieu-Daudé
2023-02-27 17:35 ` Taylor Simpson
2023-02-27 5:36 ` [PATCH v4 24/31] target/hppa: Don't use tcg_temp_local_new Richard Henderson
2023-02-27 5:36 ` [PATCH v4 25/31] target/i386: " Richard Henderson
2023-02-27 5:36 ` [PATCH v4 26/31] target/mips: " Richard Henderson
2023-02-27 5:36 ` [PATCH v4 27/31] target/ppc: " Richard Henderson
2023-02-27 5:36 ` [PATCH v4 28/31] target/xtensa: Don't use tcg_temp_local_new_* Richard Henderson
2023-02-27 5:36 ` [PATCH v4 29/31] exec/gen-icount: Don't use tcg_temp_local_new_i32 Richard Henderson
2023-02-27 5:37 ` [PATCH v4 30/31] tcg: Remove tcg_temp_local_new_*, tcg_const_local_* Richard Henderson
2023-02-27 5:37 ` [PATCH v4 31/31] tcg: Update docs/devel/tcg-ops.rst for temporary changes Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230227053701.368744-4-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=ale@rev.ng \
--cc=edgar.iglesias@gmail.com \
--cc=gaosong@loongson.cn \
--cc=jcmvbkbc@gmail.com \
--cc=jiaxun.yang@flygoat.com \
--cc=kbastian@mail.uni-paderborn.de \
--cc=mrolnik@gmail.com \
--cc=philmd@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=tsimpson@quicinc.com \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).