qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Alex Williamson <alex.williamson@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: qemu-devel@nongnu.org, "Cédric Le Goater" <clg@redhat.com>,
	"Thomas Huth" <thuth@redhat.com>
Subject: Re: [PATCH 1/2] hw/vfio/migration: Remove unused 'exec/ram_addr.h' header
Date: Mon, 27 Feb 2023 08:46:21 -0700	[thread overview]
Message-ID: <20230227084621.15cab9da.alex.williamson@redhat.com> (raw)
In-Reply-To: <20230227103258.13295-2-philmd@linaro.org>

On Mon, 27 Feb 2023 11:32:57 +0100
Philippe Mathieu-Daudé <philmd@linaro.org> wrote:

> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>

Empty commit logs are a pet peeve of mine, there must be some sort of
motivation for the change, something that changed to make this
possible, or perhaps why this was never necessary.  Thanks,

Alex

> ---
>  hw/vfio/migration.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/hw/vfio/migration.c b/hw/vfio/migration.c
> index a2c3d9bade..f9ac074c63 100644
> --- a/hw/vfio/migration.c
> +++ b/hw/vfio/migration.c
> @@ -24,7 +24,6 @@
>  #include "migration/misc.h"
>  #include "qapi/error.h"
>  #include "exec/ramlist.h"
> -#include "exec/ram_addr.h"
>  #include "pci.h"
>  #include "trace.h"
>  #include "hw/hw.h"



  parent reply	other threads:[~2023-02-27 15:46 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-27 10:32 [PATCH 0/2] hw/vfio: Build various target-independent objects once Philippe Mathieu-Daudé
2023-02-27 10:32 ` [PATCH 1/2] hw/vfio/migration: Remove unused 'exec/ram_addr.h' header Philippe Mathieu-Daudé
2023-02-27 13:40   ` Cédric Le Goater
2023-02-27 15:46   ` Alex Williamson [this message]
2023-02-27 16:04     ` Peter Maydell
2023-02-27 16:34       ` Alex Williamson
2023-02-27 21:58         ` Philippe Mathieu-Daudé
2023-03-01 19:32       ` Thomas Huth
2023-02-27 16:24     ` Alex Bennée
2023-02-27 17:13       ` Alex Williamson
2023-03-01  7:47         ` Markus Armbruster
2023-02-27 10:32 ` [PATCH 2/2] hw/vfio: Build various target-independent objects once Philippe Mathieu-Daudé

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230227084621.15cab9da.alex.williamson@redhat.com \
    --to=alex.williamson@redhat.com \
    --cc=clg@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=thuth@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).