qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Huth <thuth@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org
Cc: "Alex Bennée" <alex.bennee@linaro.org>,
	"Laurent Vivier" <lvivier@redhat.com>
Subject: [PATCH 0/6] tests/qtest/readconfig: Test configs in docs/config/
Date: Tue, 28 Feb 2023 22:15:27 +0100	[thread overview]
Message-ID: <20230228211533.201837-1-thuth@redhat.com> (raw)

We've got a bunch of config files in our docs/config/ directory
which only get occasional manual test coverage. And we've got a
"readconfig" qtest which does not check real config files yet.
Let's bring those two areas together and check the real config
files in the readconfig qtest!

I started with ich9-ehci-uhci.cfg which is still quite easy to
test, and then went on with q35-emulated.cfg that needs a little
bit of tweaking (since it hard-codes disk image names) ... so I'd
like to get information on this approach first before I continue
with the other remaining config files in the docs/config/ directory.

Thomas Huth (6):
  tests/qtest/readconfig: Rework test_object_rng_resp into a generic
    function
  tests/qtest/readconfig: Test docs/config/ich9-ehci-uhci.cfg
  docs/config: Set the "kvm" accelerator via "[accel]" section
  tests/qtest/readconfig-test: Allow testing for arbitrary memory sizes
  tests/qtest: Move mkimg() and have_qemu_img() from libqos to libqtest
  tests/qtest/readconfig: Test docs/config/q35-emulated.cfg

 docs/config/mach-virt-graphical.cfg  |   4 +-
 docs/config/mach-virt-serial.cfg     |   4 +-
 docs/config/q35-emulated.cfg         |   2 +
 docs/config/q35-virtio-graphical.cfg |   2 +
 docs/config/q35-virtio-serial.cfg    |   2 +
 configure                            |   1 +
 tests/qtest/libqos/libqos.h          |   2 -
 tests/qtest/libqtest.h               |  21 ++++
 tests/qtest/libqos/libqos.c          |  49 +-------
 tests/qtest/libqtest.c               |  52 ++++++++
 tests/qtest/readconfig-test.c        | 175 +++++++++++++++++++++++++--
 11 files changed, 251 insertions(+), 63 deletions(-)

-- 
2.31.1



             reply	other threads:[~2023-02-28 21:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-28 21:15 Thomas Huth [this message]
2023-02-28 21:15 ` [PATCH 1/6] tests/qtest/readconfig: Rework test_object_rng_resp into a generic function Thomas Huth
2023-02-28 21:15 ` [PATCH 2/6] tests/qtest/readconfig: Test docs/config/ich9-ehci-uhci.cfg Thomas Huth
2023-02-28 21:15 ` [PATCH 3/6] docs/config: Set the "kvm" accelerator via "[accel]" section Thomas Huth
2023-02-28 21:15 ` [PATCH 4/6] tests/qtest/readconfig-test: Allow testing for arbitrary memory sizes Thomas Huth
2023-02-28 21:15 ` [PATCH 5/6] tests/qtest: Move mkimg() and have_qemu_img() from libqos to libqtest Thomas Huth
2023-02-28 21:15 ` [PATCH 6/6] tests/qtest/readconfig: Test docs/config/q35-emulated.cfg Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230228211533.201837-1-thuth@redhat.com \
    --to=thuth@redhat.com \
    --cc=alex.bennee@linaro.org \
    --cc=lvivier@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).