qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: bmeng.cn@gmail.com
To: Jason Wang <jasowang@redhat.com>, qemu-devel@nongnu.org
Cc: Bin Meng <bmeng.cn@gmail.com>, Bin Meng <bmeng@tinylab.org>
Subject: [PATCH v6 1/8] hw/net: e1000: Remove the logic of padding short frames in the receive path
Date: Wed,  1 Mar 2023 17:01:56 +0800	[thread overview]
Message-ID: <20230301090203.1601925-2-bmeng.cn@gmail.com> (raw)
In-Reply-To: <20230301090203.1601925-1-bmeng.cn@gmail.com>

From: Bin Meng <bmeng.cn@gmail.com>

Now that we have implemented unified short frames padding in the
QEMU networking codes, remove the same logic in the NIC codes.

This actually reverts commit 78aeb23eded2d0b765bf9145c71f80025b568acd.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Signed-off-by: Bin Meng <bmeng@tinylab.org>
---

 hw/net/e1000.c | 11 +----------
 1 file changed, 1 insertion(+), 10 deletions(-)

diff --git a/hw/net/e1000.c b/hw/net/e1000.c
index 7efb8a4c52..d9637cbc6d 100644
--- a/hw/net/e1000.c
+++ b/hw/net/e1000.c
@@ -908,7 +908,6 @@ e1000_receive_iov(NetClientState *nc, const struct iovec *iov, int iovcnt)
     uint16_t vlan_special = 0;
     uint8_t vlan_status = 0;
     uint8_t min_buf[MIN_BUF_SIZE];
-    struct iovec min_iov;
     uint8_t *filter_buf = iov->iov_base;
     size_t size = iov_size(iov, iovcnt);
     size_t iov_ofs = 0;
@@ -924,15 +923,7 @@ e1000_receive_iov(NetClientState *nc, const struct iovec *iov, int iovcnt)
         return 0;
     }
 
-    /* Pad to minimum Ethernet frame length */
-    if (size < sizeof(min_buf)) {
-        iov_to_buf(iov, iovcnt, 0, min_buf, size);
-        memset(&min_buf[size], 0, sizeof(min_buf) - size);
-        min_iov.iov_base = filter_buf = min_buf;
-        min_iov.iov_len = size = sizeof(min_buf);
-        iovcnt = 1;
-        iov = &min_iov;
-    } else if (iov->iov_len < MAXIMUM_ETHERNET_HDR_LEN) {
+    if (iov->iov_len < MAXIMUM_ETHERNET_HDR_LEN) {
         /* This is very unlikely, but may happen. */
         iov_to_buf(iov, iovcnt, 0, min_buf, MAXIMUM_ETHERNET_HDR_LEN);
         filter_buf = min_buf;
-- 
2.34.1



  reply	other threads:[~2023-03-01  9:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-01  9:01 [PATCH v6 0/8] net: Pad short frames for network backends bmeng.cn
2023-03-01  9:01 ` bmeng.cn [this message]
2023-03-01  9:01 ` [PATCH v6 2/8] hw/net: vmxnet3: Remove the logic of padding short frames in the receive path bmeng.cn
2023-03-01  9:01 ` [PATCH v6 3/8] hw/net: i82596: " bmeng.cn
2023-03-01  9:01 ` [PATCH v6 4/8] hw/net: ne2000: " bmeng.cn
2023-03-01  9:02 ` [PATCH v6 5/8] hw/net: pcnet: " bmeng.cn
2023-03-01  9:02 ` [PATCH v6 6/8] hw/net: rtl8139: " bmeng.cn
2023-03-01  9:02 ` [PATCH v6 7/8] hw/net: sungem: " bmeng.cn
2023-03-01  9:02 ` [PATCH v6 8/8] hw/net: sunhme: " bmeng.cn
2023-03-01  9:12 ` [PATCH v6 0/8] net: Pad short frames for network backends Cédric Le Goater
2023-03-01 10:20   ` Bin Meng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230301090203.1601925-2-bmeng.cn@gmail.com \
    --to=bmeng.cn@gmail.com \
    --cc=bmeng@tinylab.org \
    --cc=jasowang@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).