qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: bmeng.cn@gmail.com
To: Jason Wang <jasowang@redhat.com>, qemu-devel@nongnu.org
Cc: Bin Meng <bmeng.cn@gmail.com>, Bin Meng <bmeng@tinylab.org>,
	Dmitry Fleytman <dmitry.fleytman@gmail.com>
Subject: [PATCH v6 2/8] hw/net: vmxnet3: Remove the logic of padding short frames in the receive path
Date: Wed,  1 Mar 2023 17:01:57 +0800	[thread overview]
Message-ID: <20230301090203.1601925-3-bmeng.cn@gmail.com> (raw)
In-Reply-To: <20230301090203.1601925-1-bmeng.cn@gmail.com>

From: Bin Meng <bmeng.cn@gmail.com>

Now that we have implemented unified short frames padding in the
QEMU networking codes, remove the same logic in the NIC codes.

This actually reverts commit 40a87c6c9b11ef9c14e0301f76abf0eb2582f08e.

Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Signed-off-by: Bin Meng <bmeng@tinylab.org>
---

 hw/net/vmxnet3.c | 10 ----------
 1 file changed, 10 deletions(-)

diff --git a/hw/net/vmxnet3.c b/hw/net/vmxnet3.c
index 56559cda24..ea01b1f75f 100644
--- a/hw/net/vmxnet3.c
+++ b/hw/net/vmxnet3.c
@@ -40,7 +40,6 @@
 
 #define PCI_DEVICE_ID_VMWARE_VMXNET3_REVISION 0x1
 #define VMXNET3_MSIX_BAR_SIZE 0x2000
-#define MIN_BUF_SIZE 60
 
 /* Compatibility flags for migration */
 #define VMXNET3_COMPAT_FLAG_OLD_MSI_OFFSETS_BIT 0
@@ -1979,7 +1978,6 @@ vmxnet3_receive(NetClientState *nc, const uint8_t *buf, size_t size)
 {
     VMXNET3State *s = qemu_get_nic_opaque(nc);
     size_t bytes_indicated;
-    uint8_t min_buf[MIN_BUF_SIZE];
 
     if (!vmxnet3_can_receive(nc)) {
         VMW_PKPRN("Cannot receive now");
@@ -1992,14 +1990,6 @@ vmxnet3_receive(NetClientState *nc, const uint8_t *buf, size_t size)
         size -= sizeof(struct virtio_net_hdr);
     }
 
-    /* Pad to minimum Ethernet frame length */
-    if (size < sizeof(min_buf)) {
-        memcpy(min_buf, buf, size);
-        memset(&min_buf[size], 0, sizeof(min_buf) - size);
-        buf = min_buf;
-        size = sizeof(min_buf);
-    }
-
     net_rx_pkt_set_packet_type(s->rx_pkt,
         get_eth_packet_type(PKT_GET_ETH_HDR(buf)));
 
-- 
2.34.1



  parent reply	other threads:[~2023-03-01  9:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-01  9:01 [PATCH v6 0/8] net: Pad short frames for network backends bmeng.cn
2023-03-01  9:01 ` [PATCH v6 1/8] hw/net: e1000: Remove the logic of padding short frames in the receive path bmeng.cn
2023-03-01  9:01 ` bmeng.cn [this message]
2023-03-01  9:01 ` [PATCH v6 3/8] hw/net: i82596: " bmeng.cn
2023-03-01  9:01 ` [PATCH v6 4/8] hw/net: ne2000: " bmeng.cn
2023-03-01  9:02 ` [PATCH v6 5/8] hw/net: pcnet: " bmeng.cn
2023-03-01  9:02 ` [PATCH v6 6/8] hw/net: rtl8139: " bmeng.cn
2023-03-01  9:02 ` [PATCH v6 7/8] hw/net: sungem: " bmeng.cn
2023-03-01  9:02 ` [PATCH v6 8/8] hw/net: sunhme: " bmeng.cn
2023-03-01  9:12 ` [PATCH v6 0/8] net: Pad short frames for network backends Cédric Le Goater
2023-03-01 10:20   ` Bin Meng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230301090203.1601925-3-bmeng.cn@gmail.com \
    --to=bmeng.cn@gmail.com \
    --cc=bmeng@tinylab.org \
    --cc=dmitry.fleytman@gmail.com \
    --cc=jasowang@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).