From: "Michael S. Tsirkin" <mst@redhat.com>
To: Bernhard Beschow <shentey@gmail.com>
Cc: qemu-devel@nongnu.org,
Richard Henderson <richard.henderson@linaro.org>,
Marcel Apfelbaum <marcel.apfelbaum@gmail.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Eduardo Habkost <eduardo@habkost.net>
Subject: Re: [PATCH 00/12] Q35 PCI host fixes and QOM cleanup
Date: Wed, 1 Mar 2023 16:49:37 -0500 [thread overview]
Message-ID: <20230301164900-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <A090A42F-D368-4671-9C91-716DD2D7CA64@gmail.com>
On Tue, Feb 21, 2023 at 03:39:28PM +0000, Bernhard Beschow wrote:
>
>
> Am 14. Februar 2023 13:14:29 UTC schrieb Bernhard Beschow <shentey@gmail.com>:
> >This series mostly cleans up QOM-related initialization code. It also performs
> >
> >some modernization and fixing.
> >
> >
> >
> >The first patch originates from "PC and ICH9 clanups" series [1] which has been
> >
> >dropped in v3 in favor of another series [2]. Review comments in [2] suggest it
> >
> >needs more work, so bring the patch back here.
> >
> >
> >
> >Patch 2 fixes a clangd warning and patch 3 modernizes usage of the memory API.
> >
> >
> >
> >Patches 4-9 clean up initialization code.
> >
> >
> >
> >The last four patches also clean up initialization code with the last patch
> >
> >doing the actual cleanup.
> >
>
> Ping
sent some comments. Philippe was reviewing related patches maybe
he wants to poke at these too.
> >
> >
> >Based-on: <20230213162004.2797-1-shentey@gmail.com>
> >
> > "[PATCH v4 0/9] PC cleanups"
> >
> >
> >
> >Testing done:
> >
> >* `make check`
> >
> >* `make check-avocado`
> >
> >* `qemu-system-x86_64 -M q35 -m 2G -cdrom \
> >
> > manjaro-kde-21.3.2-220704-linux515.iso`
> >
> >
> >
> >[1] https://lore.kernel.org/qemu-devel/20230131115326.12454-1-shentey@gmail.com/
> >
> >[2] https://lore.kernel.org/qemu-devel/20230203180914.49112-1-philmd@linaro.org/
> >
> >
> >
> >Bernhard Beschow (12):
> >
> > hw/i386/pc_q35: Resolve redundant q35_host variable
> >
> > hw/pci-host/q35: Fix contradicting .endianness assignment
> >
> > hw/pci-host/q35: Use memory_region_set_address() also for
> >
> > tseg_blackhole
> >
> > hw/pci-host/q35: Initialize PCMachineState::bus in board code
> >
> > hw/pci-host/q35: Initialize "bypass-iommu" property from board code
> >
> > hw/pci-host/q35: Initialize properties just once
> >
> > hw/pci-host/q35: Initialize PCI hole boundaries just once
> >
> > hw/pci-host/q35: Turn PCI hole properties into class properties
> >
> > hw/pci-host/q35: Rename local variable to more idiomatic "phb"
> >
> > hw/pci-host/q35: Propagate to errp rather than doing error_fatal
> >
> > hw/pci-host/q35: Merge mch_realize() into q35_host_realize()
> >
> > hw/pci-host/q35: Move MemoryRegion pointers to host device
> >
> >
> >
> > include/hw/pci-host/q35.h | 17 +-
> >
> > hw/i386/pc_q35.c | 33 ++--
> >
> > hw/pci-host/q35.c | 325 ++++++++++++++++++--------------------
> >
> > 3 files changed, 178 insertions(+), 197 deletions(-)
> >
> >
> >
> >-- >
> >2.39.1
> >
> >
> >
next prev parent reply other threads:[~2023-03-01 21:50 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-14 13:14 [PATCH 00/12] Q35 PCI host fixes and QOM cleanup Bernhard Beschow
2023-02-14 13:14 ` [PATCH 01/12] hw/i386/pc_q35: Resolve redundant q35_host variable Bernhard Beschow
2023-02-14 13:14 ` [PATCH 02/12] hw/pci-host/q35: Fix contradicting .endianness assignment Bernhard Beschow
2023-03-01 21:43 ` Michael S. Tsirkin
2023-03-01 21:44 ` Michael S. Tsirkin
2023-02-14 13:14 ` [PATCH 03/12] hw/pci-host/q35: Use memory_region_set_address() also for tseg_blackhole Bernhard Beschow
2023-03-01 21:45 ` Michael S. Tsirkin
2023-02-14 13:14 ` [PATCH 04/12] hw/pci-host/q35: Initialize PCMachineState::bus in board code Bernhard Beschow
2023-02-14 13:14 ` [PATCH 05/12] hw/pci-host/q35: Initialize "bypass-iommu" property from " Bernhard Beschow
2023-03-01 21:46 ` Michael S. Tsirkin
2023-02-14 13:14 ` [PATCH 06/12] hw/pci-host/q35: Initialize properties just once Bernhard Beschow
2023-03-01 21:47 ` Michael S. Tsirkin
2023-02-14 13:14 ` [PATCH 07/12] hw/pci-host/q35: Initialize PCI hole boundaries " Bernhard Beschow
2023-02-14 13:14 ` [PATCH 08/12] hw/pci-host/q35: Turn PCI hole properties into class properties Bernhard Beschow
2023-02-14 13:14 ` [PATCH 09/12] hw/pci-host/q35: Rename local variable to more idiomatic "phb" Bernhard Beschow
2023-02-14 13:14 ` [PATCH 10/12] hw/pci-host/q35: Propagate to errp rather than doing error_fatal Bernhard Beschow
2023-02-14 13:14 ` [PATCH 11/12] hw/pci-host/q35: Merge mch_realize() into q35_host_realize() Bernhard Beschow
2023-02-14 13:14 ` [PATCH 12/12] hw/pci-host/q35: Move MemoryRegion pointers to host device Bernhard Beschow
2023-02-21 15:39 ` [PATCH 00/12] Q35 PCI host fixes and QOM cleanup Bernhard Beschow
2023-03-01 21:49 ` Michael S. Tsirkin [this message]
2023-03-02 21:54 ` Bernhard Beschow
2023-03-05 7:41 ` Bernhard Beschow
2023-03-01 21:50 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230301164900-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=eduardo@habkost.net \
--cc=marcel.apfelbaum@gmail.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=shentey@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).