From: Igor Mammedov <imammedo@redhat.com>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: qemu-devel@nongnu.org, ani@anisinha.ca, berrange@redhat.com
Subject: Re: [PATCH 00/33] pci(pc/q35): acpi-index support on non-hotpluggable slots
Date: Thu, 2 Mar 2023 13:07:16 +0100 [thread overview]
Message-ID: <20230302130716.5afb85a6@imammedo.users.ipa.redhat.com> (raw)
In-Reply-To: <20230302055544-mutt-send-email-mst@kernel.org>
On Thu, 2 Mar 2023 05:59:16 -0500
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> On Fri, Feb 24, 2023 at 04:37:39PM +0100, Igor Mammedov wrote:
> > Series extends acpi-index support to host-bridge(s) and bridges
> > with disabled hotplug (either explicitly or implicitly).
> > Whats new (it is still limited to 'pc' and 'q35' machines),
> > acpi-index now works for non-hotpluggable slots/nics:
> > * q35: host-bridge
> > * pc: host-bridge with disabled hotplug
> > 'PIIX4_PM.acpi-root-pci-hotplug=off'
> > * non-hotpluggable multifunction nics
> > * on non-hotpluggable slots with native hotplug (i.e. without ACPI PCI hotplug)
> > PIIX4_PM.acpi-pci-hotplug-with-bridge-support=off
> > ICH9-LPC.acpi-pci-hotplug-with-bridge-support=off
> > + pcie-root-port,hotplug=off | pci-bridge,shpc=off
> >
> > where it doesn't work (and never will):
> > * on hotplugged ports/bridges
> > * on hotpluggable ports/bridges with native hotplug
> >
> > 1-11/33: fixes for bugs or odd behavior
> > 13-23/33: non-hotplug/multifunction acpi-index enabling
> > 28-33/33: cleanups
> > all of that is peppered by extra acpi tests or extensions to existing ones
>
> dropped because viot was wrong.
> Pls rebase fix up and repost.
I'll rebase on top of your recent pull req with c471eb4f4044 commit reverted
to get properly updated tables.
Partial table rebuilds are fragile anyways, should we make rebuild ignore
checks the commit introduced?
PS:
Does the rest of the series look fine to you?
>
>
> Apropos I still think we should split up DSDT to several
> SSDTs, in a way that multiple tests share some SSDTs.
> This way it will be more common than a change only affects one table
> and it's easier to merge things.
>
> For example, how about moving CXL things to an SSDT?
>
>
> > Somewhat tested with RHEL9.0 and WS2022.
> >
> > What's in queue:
> > * PXB support
> > * microvm and arm/virt support
> > all of above only for non-hotpluggable slots as I don't really want to
> > pull there complicated APCI PCI hotplug.
> >
> > gitlab tree: https://gitlab.com/imammedo/qemu/-/tree/acpi_index_non_hotplug
> > CI: https://gitlab.com/imammedo/qemu/-/pipelines/787263630
> > it's red but only due to unrelated curl breakage in msys* targets,
> > the rest is green
> >
> > Igor Mammedov (33):
> > tests: acpi: whitelist new q35.noacpihp test and pc.hpbrroot
> > tests: acpi: add test_acpi_q35_tcg_no_acpi_hotplug test and extend
> > test_acpi_piix4_no_acpi_pci_hotplug
> > tests: acpi: update expected blobs
> > tests: acpi: whitelist q35/DSDT.multi-bridge before extending testcase
> > tests: acpi: extend multi-bridge case with case
> > 'root-port,id=HOHP,hotplug=off root-port,bus=NOHP'
> > x86: pcihp: fix missing PCNT callchain when intermediate root-port has
> > 'hotplug=off' set
> > tests: acpi: whitelist pc/DSDT.hpbrroot and pc/DSDT.hpbridge tests
> > x86: pcihp: fix missing bridge AML when intermediate root-port has
> > 'hotplug=off' set
> > tests: acpi: update expected blobs
> > pcihp: piix4: do not redirect hotplug controller to piix4 when ACPI
> > hotplug is disabled
> > pci: fix 'hotplugglable' property behavior
> > tests: acpi: whitelist DSDT blobs before isolating PCI _DSM func 0
> > prolog
> > pcihp: move PCI _DSM function 0 prolog into separate function
> > tests: acpi: update expected blobs
> > tests: acpi: whitelist DSDT before adding EDSM method
> > acpi: pci: add EDSM method to DSDT
> > tests: acpi: update expected blobs
> > tests: acpi: whitelist DSDT before adding device with acpi-index to
> > testcases
> > tests: acpi: add device with acpi-index on non-hotpluggble bus
> > acpi: pci: support acpi-index for non-hotpluggable devices
> > tests: acpi: update expected blobs
> > tests: acpi: whitelist DSDT before exposing non zero functions
> > acpi: pci: describe all functions on populated slots
> > tests: acpi: update expected blobs
> > tests: acpi: whitelist DSDT before adding non-0 function device with
> > acpi-index to testcases
> > tests: acpi: add non zero function device with acpi-index on
> > non-hotpluggble bus
> > tests: acpi: update expected blobs
> > pci: move acpi-index uniqueness check to generic PCI device code
> > acpi: pci: drop BSEL usage when deciding that device isn't
> > hotpluggable
> > acpi: pci: move BSEL into build_append_pcihp_slots()
> > acpi: pci: move out ACPI PCI hotplug generator from generic slot
> > generator build_append_pci_bus_devices()
> > pcihp: move fields enabling hotplug into AcpiPciHpState
> > pcihp: add ACPI PCI hotplug specific is_hotpluggable_bus() callback
> >
> > include/hw/acpi/ich9.h | 1 +
> > include/hw/acpi/pcihp.h | 11 +-
> > include/hw/acpi/piix4.h | 2 -
> > include/hw/hotplug.h | 2 +
> > include/hw/qdev-core.h | 13 +-
> > hw/acpi/acpi-pci-hotplug-stub.c | 9 +-
> > hw/acpi/ich9.c | 21 +-
> > hw/acpi/pci-bridge.c | 14 +-
> > hw/acpi/pcihp.c | 112 +++--------
> > hw/acpi/piix4.c | 33 ++--
> > hw/i386/acpi-build.c | 179 +++++++++++++-----
> > hw/isa/lpc_ich9.c | 1 +
> > hw/pci/pci.c | 57 ++++++
> > hw/pci/pcie_port.c | 8 +
> > tests/data/acpi/pc/DSDT | Bin 6360 -> 6488 bytes
> > tests/data/acpi/pc/DSDT.acpierst | Bin 6283 -> 6411 bytes
> > tests/data/acpi/pc/DSDT.acpihmat | Bin 7685 -> 7813 bytes
> > tests/data/acpi/pc/DSDT.bridge | Bin 12487 -> 12615 bytes
> > tests/data/acpi/pc/DSDT.cphp | Bin 6824 -> 6952 bytes
> > tests/data/acpi/pc/DSDT.dimmpxm | Bin 8014 -> 8142 bytes
> > tests/data/acpi/pc/DSDT.hpbridge | Bin 6289 -> 6451 bytes
> > tests/data/acpi/pc/DSDT.hpbrroot | Bin 3081 -> 3343 bytes
> > tests/data/acpi/pc/DSDT.ipmikcs | Bin 6432 -> 6560 bytes
> > tests/data/acpi/pc/DSDT.memhp | Bin 7719 -> 7847 bytes
> > tests/data/acpi/pc/DSDT.nohpet | Bin 6218 -> 6346 bytes
> > tests/data/acpi/pc/DSDT.numamem | Bin 6366 -> 6494 bytes
> > tests/data/acpi/pc/DSDT.roothp | Bin 9745 -> 9873 bytes
> > tests/data/acpi/q35/DSDT | Bin 8252 -> 8361 bytes
> > tests/data/acpi/q35/DSDT.acpierst | Bin 8269 -> 8378 bytes
> > tests/data/acpi/q35/DSDT.acpihmat | Bin 9577 -> 9686 bytes
> > tests/data/acpi/q35/DSDT.acpihmat-noinitiator | Bin 8531 -> 8640 bytes
> > tests/data/acpi/q35/DSDT.applesmc | Bin 8298 -> 8407 bytes
> > tests/data/acpi/q35/DSDT.bridge | Bin 11481 -> 11590 bytes
> > tests/data/acpi/q35/DSDT.core-count2 | Bin 32392 -> 32501 bytes
> > tests/data/acpi/q35/DSDT.cphp | Bin 8716 -> 8825 bytes
> > tests/data/acpi/q35/DSDT.cxl | Bin 9578 -> 9687 bytes
> > tests/data/acpi/q35/DSDT.dimmpxm | Bin 9906 -> 10015 bytes
> > tests/data/acpi/q35/DSDT.ipmibt | Bin 8327 -> 8436 bytes
> > tests/data/acpi/q35/DSDT.ipmismbus | Bin 8340 -> 8449 bytes
> > tests/data/acpi/q35/DSDT.ivrs | Bin 8269 -> 8378 bytes
> > tests/data/acpi/q35/DSDT.memhp | Bin 9611 -> 9720 bytes
> > tests/data/acpi/q35/DSDT.mmio64 | Bin 9382 -> 9491 bytes
> > tests/data/acpi/q35/DSDT.multi-bridge | Bin 12337 -> 12770 bytes
> > tests/data/acpi/q35/DSDT.noacpihp | Bin 0 -> 8248 bytes
> > tests/data/acpi/q35/DSDT.nohpet | Bin 8110 -> 8219 bytes
> > tests/data/acpi/q35/DSDT.numamem | Bin 8258 -> 8367 bytes
> > tests/data/acpi/q35/DSDT.pvpanic-isa | Bin 8353 -> 8462 bytes
> > tests/data/acpi/q35/DSDT.tis.tpm12 | Bin 8858 -> 8967 bytes
> > tests/data/acpi/q35/DSDT.tis.tpm2 | Bin 8884 -> 8993 bytes
> > tests/data/acpi/q35/DSDT.viot | Bin 9361 -> 9486 bytes
> > tests/data/acpi/q35/DSDT.xapic | Bin 35615 -> 35724 bytes
> > tests/qtest/bios-tables-test.c | 50 ++++-
> > 52 files changed, 341 insertions(+), 172 deletions(-)
> > create mode 100644 tests/data/acpi/q35/DSDT.noacpihp
> >
> > --
> > 2.39.1
>
next prev parent reply other threads:[~2023-03-02 12:07 UTC|newest]
Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-24 15:37 [PATCH 00/33] pci(pc/q35): acpi-index support on non-hotpluggable slots Igor Mammedov
2023-02-24 15:37 ` [PATCH 01/33] tests: acpi: whitelist new q35.noacpihp test and pc.hpbrroot Igor Mammedov
2023-02-24 15:37 ` [PATCH 02/33] tests: acpi: add test_acpi_q35_tcg_no_acpi_hotplug test and extend test_acpi_piix4_no_acpi_pci_hotplug Igor Mammedov
2023-02-24 15:37 ` [PATCH 03/33] tests: acpi: update expected blobs Igor Mammedov
2023-02-24 15:37 ` [PATCH 04/33] tests: acpi: whitelist q35/DSDT.multi-bridge before extending testcase Igor Mammedov
2023-02-24 15:37 ` [PATCH 05/33] tests: acpi: extend multi-bridge case with case 'root-port, id=HOHP, hotplug=off root-port, bus=NOHP' Igor Mammedov
2023-02-24 15:37 ` [PATCH 06/33] x86: pcihp: fix missing PCNT callchain when intermediate root-port has 'hotplug=off' set Igor Mammedov
2023-02-24 15:37 ` [PATCH 07/33] tests: acpi: whitelist pc/DSDT.hpbrroot and pc/DSDT.hpbridge tests Igor Mammedov
2023-02-24 15:37 ` [PATCH 08/33] x86: pcihp: fix missing bridge AML when intermediate root-port has 'hotplug=off' set Igor Mammedov
2023-02-24 15:37 ` [PATCH 09/33] tests: acpi: update expected blobs Igor Mammedov
2023-02-24 15:37 ` [PATCH 10/33] pcihp: piix4: do not redirect hotplug controller to piix4 when ACPI hotplug is disabled Igor Mammedov
2023-02-24 15:37 ` [PATCH 11/33] pci: fix 'hotplugglable' property behavior Igor Mammedov
2023-02-24 15:37 ` [PATCH 12/33] tests: acpi: whitelist DSDT blobs before isolating PCI _DSM func 0 prolog Igor Mammedov
2023-02-24 15:37 ` [PATCH 13/33] pcihp: move PCI _DSM function 0 prolog into separate function Igor Mammedov
2023-02-24 15:37 ` [PATCH 14/33] tests: acpi: update expected blobs Igor Mammedov
2023-03-02 0:27 ` Michael S. Tsirkin
2023-03-02 12:02 ` Igor Mammedov
2023-03-02 12:55 ` Fabiano Rosas
2023-03-02 14:57 ` Igor Mammedov
2023-03-02 15:43 ` Fabiano Rosas
2023-03-02 15:59 ` Igor Mammedov
2023-03-02 0:37 ` Michael S. Tsirkin
2023-02-24 15:37 ` [PATCH 15/33] tests: acpi: whitelist DSDT before adding EDSM method Igor Mammedov
2023-02-24 15:37 ` [PATCH 16/33] acpi: pci: add EDSM method to DSDT Igor Mammedov
2023-02-24 15:37 ` [PATCH 17/33] tests: acpi: update expected blobs Igor Mammedov
2023-02-24 15:37 ` [PATCH 18/33] tests: acpi: whitelist DSDT before adding device with acpi-index to testcases Igor Mammedov
2023-02-24 15:37 ` [PATCH 19/33] tests: acpi: add device with acpi-index on non-hotpluggble bus Igor Mammedov
2023-02-24 15:37 ` [PATCH 20/33] acpi: pci: support acpi-index for non-hotpluggable devices Igor Mammedov
2023-02-24 15:38 ` [PATCH 21/33] tests: acpi: update expected blobs Igor Mammedov
2023-02-24 15:38 ` [PATCH 22/33] tests: acpi: whitelist DSDT before exposing non zero functions Igor Mammedov
2023-02-24 15:38 ` [PATCH 23/33] acpi: pci: describe all functions on populated slots Igor Mammedov
2023-02-24 15:38 ` [PATCH 24/33] tests: acpi: update expected blobs Igor Mammedov
2023-02-24 15:38 ` [PATCH 25/33] tests: acpi: whitelist DSDT before adding non-0 function device with acpi-index to testcases Igor Mammedov
2023-02-24 15:38 ` [PATCH 26/33] tests: acpi: add non zero function device with acpi-index on non-hotpluggble bus Igor Mammedov
2023-02-24 15:38 ` [PATCH 27/33] tests: acpi: update expected blobs Igor Mammedov
2023-02-24 15:38 ` [PATCH 28/33] pci: move acpi-index uniqueness check to generic PCI device code Igor Mammedov
2023-02-24 15:38 ` [PATCH 29/33] acpi: pci: drop BSEL usage when deciding that device isn't hotpluggable Igor Mammedov
2023-02-24 15:38 ` [PATCH 30/33] acpi: pci: move BSEL into build_append_pcihp_slots() Igor Mammedov
2023-02-24 15:38 ` [PATCH 31/33] acpi: pci: move out ACPI PCI hotplug generator from generic slot generator build_append_pci_bus_devices() Igor Mammedov
2023-02-24 15:38 ` [PATCH 32/33] pcihp: move fields enabling hotplug into AcpiPciHpState Igor Mammedov
2023-02-24 15:38 ` [PATCH 33/33] pcihp: add ACPI PCI hotplug specific is_hotpluggable_bus() callback Igor Mammedov
2023-03-02 10:59 ` [PATCH 00/33] pci(pc/q35): acpi-index support on non-hotpluggable slots Michael S. Tsirkin
2023-03-02 12:05 ` Jonathan Cameron via
2023-03-02 12:07 ` Igor Mammedov [this message]
2023-03-02 23:21 ` Michael S. Tsirkin
2023-03-06 10:49 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230302130716.5afb85a6@imammedo.users.ipa.redhat.com \
--to=imammedo@redhat.com \
--cc=ani@anisinha.ca \
--cc=berrange@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).