From: Igor Mammedov <imammedo@redhat.com>
To: "Philippe Mathieu-Daudé" <philmd@linaro.org>
Cc: BALATON Zoltan <balaton@eik.bme.hu>,
Bernhard Beschow <shentey@gmail.com>,
qemu-devel@nongnu.org, Jiaxun Yang <jiaxun.yang@flygoat.com>,
Huacai Chen <chenhuacai@kernel.org>
Subject: Re: [PATCH 2/3] hw/isa/vt82c686: Allow PM controller to switch to ACPI mode
Date: Thu, 2 Mar 2023 15:42:09 +0100 [thread overview]
Message-ID: <20230302154209.4eda6225@imammedo.users.ipa.redhat.com> (raw)
In-Reply-To: <78bc4dd9-f713-3824-1d87-74f3011b019d@linaro.org>
On Mon, 6 Feb 2023 09:00:37 +0100
Philippe Mathieu-Daudé <philmd@linaro.org> wrote:
> On 31/1/23 15:54, BALATON Zoltan wrote:
> > On Sun, 29 Jan 2023, Bernhard Beschow wrote:
> >> Adds missing functionality the real hardware supports.
> >>
> >> Signed-off-by: Bernhard Beschow <shentey@gmail.com>
> >> ---
> >> hw/isa/vt82c686.c | 18 +++++++++++++++++-
> >> 1 file changed, 17 insertions(+), 1 deletion(-)
> >>
> >> diff --git a/hw/isa/vt82c686.c b/hw/isa/vt82c686.c
> >> index 2189be6f20..b0765d4ed8 100644
> >> --- a/hw/isa/vt82c686.c
> >> +++ b/hw/isa/vt82c686.c
> >> @@ -37,6 +37,9 @@
> >> #include "qemu/timer.h"
> >> #include "trace.h"
>
> > Why does
> > acpi_pm1_cnt_update() take two arguments for a bool value? Can these be
> > both true or false at the same time?
>
> No, this is a one-bit so boolean is enough...
one boolean would be fine unless they were both false?
>
> Maybe unfinished refactor from commit eaba51c573 ("acpi, acpi_piix,
> vt82c686: factor out PM1_CNT logic")?
>
next prev parent reply other threads:[~2023-03-02 14:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-29 21:34 [PATCH 0/3] VIA PM Improvements Bernhard Beschow
2023-01-29 21:34 ` [PATCH 1/3] hw/isa/vt82c686: Fix SCI routing Bernhard Beschow
2023-01-31 14:42 ` BALATON Zoltan
2023-02-07 23:13 ` Bernhard Beschow
2023-01-29 21:34 ` [PATCH 2/3] hw/isa/vt82c686: Allow PM controller to switch to ACPI mode Bernhard Beschow
2023-01-31 14:54 ` BALATON Zoltan
2023-02-06 8:00 ` Philippe Mathieu-Daudé
2023-02-06 8:01 ` Philippe Mathieu-Daudé
2023-03-02 14:42 ` Igor Mammedov [this message]
2023-01-29 21:34 ` [PATCH 3/3] hw/isa/vt82c686: Implement ACPI powerdown Bernhard Beschow
2023-01-31 14:58 ` BALATON Zoltan
2023-02-07 23:27 ` Bernhard Beschow
2023-01-31 14:38 ` [PATCH 0/3] VIA PM Improvements BALATON Zoltan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230302154209.4eda6225@imammedo.users.ipa.redhat.com \
--to=imammedo@redhat.com \
--cc=balaton@eik.bme.hu \
--cc=chenhuacai@kernel.org \
--cc=jiaxun.yang@flygoat.com \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=shentey@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).