From: Juan Quintela <quintela@redhat.com>
To: qemu-devel@nongnu.org
Cc: "Dr. David Alan Gilbert" <dgilbert@redhat.com>,
Juan Quintela <quintela@redhat.com>,
David Edmondson <david.edmondson@oracle.com>
Subject: [PATCH v2 2/3] migration: Update atomic stats out of the mutex
Date: Thu, 2 Mar 2023 17:21:37 +0100 [thread overview]
Message-ID: <20230302162138.10076-3-quintela@redhat.com> (raw)
In-Reply-To: <20230302162138.10076-1-quintela@redhat.com>
Reviewed-by: David Edmondson <david.edmondson@oracle.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
---
migration/multifd.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/migration/multifd.c b/migration/multifd.c
index 7cb2326d03..f558169e37 100644
--- a/migration/multifd.c
+++ b/migration/multifd.c
@@ -433,8 +433,8 @@ static int multifd_send_pages(QEMUFile *f)
transferred = ((uint64_t) pages->num) * p->page_size + p->packet_len;
qemu_file_acct_rate_limit(f, transferred);
ram_counters.multifd_bytes += transferred;
+ qemu_mutex_unlock(&p->mutex);
stat64_add(&ram_counters.transferred, transferred);
- qemu_mutex_unlock(&p->mutex);
qemu_sem_post(&p->sem);
return 1;
@@ -628,8 +628,8 @@ int multifd_send_sync_main(QEMUFile *f)
p->pending_job++;
qemu_file_acct_rate_limit(f, p->packet_len);
ram_counters.multifd_bytes += p->packet_len;
+ qemu_mutex_unlock(&p->mutex);
stat64_add(&ram_counters.transferred, p->packet_len);
- qemu_mutex_unlock(&p->mutex);
qemu_sem_post(&p->sem);
}
for (i = 0; i < migrate_multifd_channels(); i++) {
--
2.39.2
next prev parent reply other threads:[~2023-03-02 16:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-02 16:21 [PATCH v2 0/3] Migration: Make more ram_counters atomic Juan Quintela
2023-03-02 16:21 ` [PATCH v2 1/3] migration: Merge ram_counters and ram_atomic_counters Juan Quintela
2023-03-06 11:28 ` David Edmondson
2023-03-02 16:21 ` Juan Quintela [this message]
2023-03-02 16:21 ` [PATCH v2 3/3] migration: Make multifd_bytes atomic Juan Quintela
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230302162138.10076-3-quintela@redhat.com \
--to=quintela@redhat.com \
--cc=david.edmondson@oracle.com \
--cc=dgilbert@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).