* [PATCH 01/33] tests: acpi: whitelist new q35.noacpihp test and pc.hpbrroot
2023-02-24 15:37 [PATCH 00/33] pci(pc/q35): acpi-index support on non-hotpluggable slots Igor Mammedov
@ 2023-02-24 15:37 ` Igor Mammedov
2023-02-24 15:37 ` [PATCH 02/33] tests: acpi: add test_acpi_q35_tcg_no_acpi_hotplug test and extend test_acpi_piix4_no_acpi_pci_hotplug Igor Mammedov
` (32 subsequent siblings)
33 siblings, 0 replies; 46+ messages in thread
From: Igor Mammedov @ 2023-02-24 15:37 UTC (permalink / raw)
To: qemu-devel; +Cc: mst, ani, berrange
for q35.noacpihp use plain default Q35 DSDT table as a starting point.
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
tests/qtest/bios-tables-test-allowed-diff.h | 2 ++
tests/data/acpi/q35/DSDT.noacpihp | Bin 0 -> 8252 bytes
2 files changed, 2 insertions(+)
create mode 100644 tests/data/acpi/q35/DSDT.noacpihp
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
index dfb8523c8b..b2c5312871 100644
--- a/tests/qtest/bios-tables-test-allowed-diff.h
+++ b/tests/qtest/bios-tables-test-allowed-diff.h
@@ -1 +1,3 @@
/* List of comma-separated changed AML files to ignore */
+"tests/data/acpi/pc/DSDT.hpbrroot",
+"tests/data/acpi/q35/DSDT.noacpihp",
diff --git a/tests/data/acpi/q35/DSDT.noacpihp b/tests/data/acpi/q35/DSDT.noacpihp
new file mode 100644
index 0000000000000000000000000000000000000000..d68c472b460e4609a64ea67de3c4cebfca76164d
GIT binary patch
literal 8252
zcmb7JOKcm*8J^`sS}m8-l3H7~>{x`8ppO&@W#@%Hf|9#@*`iEwDLcg);8Jp0*$I$E
z5(9Ap1F`}nj!#Wk2R$-@0`%6NdaZ$8+M90;&{Ge+<XRN*DeCvn?AS9T1ynqc`_F#g
z|IatOJKu7~5B%QGON<%!tCzfHP^!M(@k;m@j4?W<U#FG1%EDd0+UOg(RK^JJ<oGeZ
zs;2uBzq;8le!mla5k>EP5*dS-ZGGk3-x|ap-Ho;wfo^WamPH3nZN48=`{ABvb-Y&D
z>^ED!U3qAkX5SM>X|rGPyUgrwwtVKU&Gs(^UgqAL%=53Tj@Gloox-B!gzbNx|8C{<
zFTc3*Ugg0r{_*R3Z(11u&f(X@@A;U%q7NhMOf+&nA6_?Z6P=%19W8!7<flcOLucZM
zTE4VJ6Qx?+e>2>B)$dk3-p71ry;JtetLT^44GJsP=}(pzvuSYX^QVJ@gTIJF=G<b=
zn)^J-B#Gf}#|wH!?tyKY;T?wp5AB;JeEFqtH>h2}p#IIaG8k0~ylT020Vk^K?XHn~
zC}<RT)%DGGsnhabFNH>R&AZ6lXFFc)LMnWkqJx8YhY;~C<2s`p;SZ>JpSjOfz?p`k
zTrqt`2{v-8a~(fu=STj`@CJ(uX@f;E8;q7e7X$zBmB0Txc<F=oXG`C<PyW?w??<EA
z``4}1eiT!YkM6$37`_a)1<LK=78`Ea7@GrjdteN14{jOOEE~jwyAflcK0CZ&&Bn!S
ziseyeEJ3^_P-ds))tPJe@oU686ghjB4H{p^`<CBDoo=sFy!h^JF_+1q*4p~T8WYC`
zj_a&wQ@fQy(2zkIL6a5p8T1dAQQ(q@SOCt8bDRgL42g;S9Gl`yV3UZL5}IP12`FbG
zBqn;pv1!hfJxDWRN@!Xz0p(1D#FSMsoGE*d;Y<n52&U{jLRDv0)0yQ=3C#+o>^wqM
z=ZvOvhBGB}M%Rf@)j6x_oYi#B>N*jsI!#Tdsp&Lzod{K(bDGXMP3N4h6QQcp(sWvy
zPD|H`P}P~!bmlajIbA10Ri~}#v^AZ!t`niEGq35)YdZ6~PK2t?c}?fMrgL7`iBQ$K
zpy^!DbS~&R5vn>JO{b&jbab5vRh<P*XF=0h&~+kIbrv<9MNMZ>*NIToxv1$})O0TD
zIuWWmT}`K}>2!6S2vwcOG@ZvZoyT;Y2vwcOHJ!&boyT>Z2vwc1F)?THS!qerxuokv
zsOmhS={%w7JfZ7EsOmh)nU!QFJjt2WWU@OcnBJ3+n0|s?)|ks0b6IC1RGFtV<|&PN
zN@pTenWr`8X^nYWXChRYPif4jH0Dz}6QRmH!<ll9Kf{@Fjz1%qa^glvOz9*mTFn)$
z=89eup{QxXKr4!YHi8yPb2Bw?jKYb5B0yOYq!GxXFi?TxH<7`JCHrTfsDM5;P=rz%
z3{+sHfhtfkPyu~xpa{_$X`lj|L{t-5rDGCPju;szLiC7ZVW0w=M2SYuBm)&t8LB#A
zpdu}2!ax-$87M;Oie#V&rA`>Az;Y%GRDqI#3Mj8h28vMXgn<eyXTm@gC>f}LawZul
zLa7r5DzKah16818paRO7WS|J;^@M>6EN8+%6(|{~fN~}oC_<?d1}d<e2?JH2WS|1d
znPi{{rA`>Az;Y%GRDqI#3Mglifg+STVW0xbnJ`cVN(L&RoJj_XQ0jz%3M^;BKouw%
zsDN@N87M-j69y`<oCyO}pk$x|%9&)K2&GOKsK9b23{-)VfeI*Rl7S+WI$@v!%b74x
z1xf}gpqxnticso=feI{V!ax-$8K{7ACK)I~sS^e&u$&14RiI>`0?L_Wpa`W-7^uK<
zCJa=8l7R{+XOe*;lsaLc0?U~&Pz6c`DxjQ628vMXgn<eyXTm@gC>f}LawZulLa7r5
zDzKah16818paRO7WS|J8P8g`bawZH^fs%m=C})y^B9uB|paRR8Fi-_b1}dPONd}5g
z>V$zJQVbN4YM=;J14XD9sKSJSDoip^g-HggFkzqy69%d<$v_n*8K}a9fhtTGsKO)z
zRhVR;3KIsZFkzqylMGa0l7T8r7$_onbzz{0aK-pwl7S+`Wso5;<=DbN5y`QIfg+M)
zO9qNijx8A|Lab9P_hF%IWDohD)qVOy`sED$RNTeZ2LAt#=03D`ci6r)w{PX#7h4-%
zcMi7OEf?mk+@~{ajxQzLV)v-c%Hq2ff4E~UFgik_ZaLgrn}yF;<eG`SAl67slnx5V
zt;J90*<2b9#V`jm%%<!Xa~JwSufq1J3!Uyp#Vz#xR={r4v9-%v7HC0(5MGzZOZ}i5
z825IPK2UjTPpVhPsvAeBURA1BdG#v#r&h1J)2mm*y*6nVYcW_aO0-+4Bb4`)@*Xem
zjg|KfDeooa{W0+t)~f#RvG<koJ}>W&mG=)R?<eJJ<K;6)C|^^`*LeBbSozu^<!ed#
z`gr;55z5z<@^xOmK32YdNcnnFzA;{Y<_P5*O8Eva-xw?3IHY_dDc>9~KYN7oO{IL3
zmv4@hZyr*<iSikmj>gM7qP(0u@M?g^T`W%OZSD+z<ncq#b&_uUF}4bNI=nATq!VpZ
z(@i{=MLiu}A|}#_wyEhRp0h<g9o{S^(uuaI=_Z~VS5Jr6jfr%kZECuS=ir#04(}in
z=|tPqbQAaWaXlSgOeWHawyEhR?$aeb9o|+Z(up=bozphOLVe9_c4|F&`x%(>Xkk9w
zZFYKXhBxnr-{%;Xt{sXOFW1)nQm5<pOYY0ud17jbVrm+E5Lr$%vOgO}Y#3oZcAt&r
zKN}9%?*=ye*MGD7Fh^J#Ew2}>`H%4zgpxD-S;K<5+i!Hlb<9`1PODrlzs#IVuZb=;
zt*bAj<$8OkTMJ}wEzA+<ZQko_mYQ$B7r%A$H>G#pc=zp_?`*&EE(;B>vvx6gX!4fT
zFut+Bu?_nc)L~l3n*BGnWrufuNI`{_yiRT1@LKDE;dR@W4XnJE>8ozAwCA;btnL>H
znf8L(S_yE!(ko%vy0zXiV@8d5_|9MD8w2Q&=wza1wM^X*8z5P?;PvXiN{y`H4*S@H
z)a!0@2HOUex$x<$FJx4qB!Jfa$D2_sX3=PQIDUd8#MT1V`zOw<UEGh{c9vuvt&lOE
z3K^#6ck9Q!z*{#Dkzso4wJXKcLCm&e<Jwn#ad^#$*|pf99f+^i?B5O}<Nh|9qIi3}
zBo{p1h>J2>x<B5E%d-9TXl^*L4p8Rnc-r~VGZQ06*FE08OMM)$n*;Rf%U4D(O~Ck_
zfy=jTrQ?Z#!AbCLZqo)?EhBcwDB%{{rb`ZO+u`bTaTB@FpPO6Lhq*oHT?%^kA;UcV
zZkfoB!Hcg?8JpNjjkgl?#&{!!d1~*%k6xvFnx1Y(yE?e9&3(GN@dUIhy+Y1185S<+
zb=aN9=3g&IV%X008}2DQJeUUhwemTZJn{4((LLp~kBKLX?+5Wo<U-E+^W8j4VUEJ*
zfWC}|@yLE;8z$Nf8#^$JeTUPJ?8k8)+eeK3hi~rj^Yk`-a6oU<^hq&o+t0+#)*r<g
z_6P0E1MCNWFU~x8?cQ_PDonD8Hd061Vi2l*D8}@&=VhQ%?2huC#|ox9F_lrfGKXQ3
z?p3Uum^S$wR+=fz7}$dh_by~Q%}$rkg=0xDNK@v+$y^WY2exqn)9;V2qI__^U!2Jp
z=sS*I>=(_9m9nsYhv+3bLrR>VJ-H0w-t+Y<p0LaOMy<Vx%YKf~V?B1VPL^g}$6vlm
zlbf@4lCEO7mkY|}zSs^9_kJ9dUljqan8D!T!K%-&yNQEy^58rjK)D;#pMY0rK5un5
zQdVTyj+fy@!aF~GAx&inNoNiEmxF&~8&&%9=*u@5%xt4Z$94K@&{xw8_g=hM_0buz
zd7XwQlBUGGPFTkpM#Lg!;C8#luHpA=ieJ@d+LtyTvlj4Dqp(aXdzQA2!@YBBo!+X<
zoxym)!SFXr!8%sHVZ5JyKW&<4cX{S>-lg_qP8R6toJZ+LX=a{vIOo}J&wJdP9O{ts
i^3*YlnPHw~26bm4s8^G5PqP)~*z^eEU7?1}@c#ikX|rko
literal 0
HcmV?d00001
--
2.39.1
^ permalink raw reply related [flat|nested] 46+ messages in thread* [PATCH 02/33] tests: acpi: add test_acpi_q35_tcg_no_acpi_hotplug test and extend test_acpi_piix4_no_acpi_pci_hotplug
2023-02-24 15:37 [PATCH 00/33] pci(pc/q35): acpi-index support on non-hotpluggable slots Igor Mammedov
2023-02-24 15:37 ` [PATCH 01/33] tests: acpi: whitelist new q35.noacpihp test and pc.hpbrroot Igor Mammedov
@ 2023-02-24 15:37 ` Igor Mammedov
2023-02-24 15:37 ` [PATCH 03/33] tests: acpi: update expected blobs Igor Mammedov
` (31 subsequent siblings)
33 siblings, 0 replies; 46+ messages in thread
From: Igor Mammedov @ 2023-02-24 15:37 UTC (permalink / raw)
To: qemu-devel; +Cc: mst, ani, berrange
test bridge AML generator with ACPI PCI hotplug disabled
(i.e. with native hotplug enabled/disabled per bridge/root port)
PS:
while at make sure that devices on pci-bridge are starting
from addr=1.0 as slot 0 is not available there and test
passes only because of a bug in ACPI hotplug that will be
fixed by follow up patch
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
tests/qtest/bios-tables-test.c | 42 +++++++++++++++++++++++++++++++---
1 file changed, 39 insertions(+), 3 deletions(-)
diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
index d29a4e47af..5128b62634 100644
--- a/tests/qtest/bios-tables-test.c
+++ b/tests/qtest/bios-tables-test.c
@@ -949,9 +949,14 @@ static void test_acpi_piix4_no_acpi_pci_hotplug(void)
data.required_struct_types_len = ARRAY_SIZE(base_required_struct_types);
test_acpi_one("-global PIIX4_PM.acpi-root-pci-hotplug=off "
"-global PIIX4_PM.acpi-pci-hotplug-with-bridge-support=off "
- "-device pci-bridge,chassis_nr=1 "
- "-device pci-testdev,bus=pci.0 "
- "-device pci-testdev,bus=pci.1", &data);
+ "-device pci-bridge,chassis_nr=1,addr=4.0 "
+ "-device pci-testdev,bus=pci.0,addr=5.0 "
+ "-device pci-testdev,bus=pci.0,addr=6.0,acpi-index=101 "
+ "-device pci-testdev,bus=pci.1,addr=1.0 "
+ "-device pci-testdev,bus=pci.1,addr=2.0,acpi-index=201 "
+ "-device pci-bridge,id=nhpbr,chassis_nr=2,shpc=off,addr=7.0 "
+ "-device pci-testdev,bus=nhpbr,addr=1.0,acpi-index=301 "
+ , &data);
free_test_data(&data);
}
@@ -1002,6 +1007,35 @@ static void test_acpi_q35_tcg_bridge(void)
free_test_data(&data);
}
+static void test_acpi_q35_tcg_no_acpi_hotplug(void)
+{
+ test_data data;
+
+ memset(&data, 0, sizeof(data));
+ data.machine = MACHINE_Q35;
+ data.variant = ".noacpihp";
+ data.required_struct_types = base_required_struct_types;
+ data.required_struct_types_len = ARRAY_SIZE(base_required_struct_types);
+ test_acpi_one("-global ICH9-LPC.acpi-pci-hotplug-with-bridge-support=off"
+ " -device pci-testdev,bus=pcie.0,acpi-index=101,addr=3.0"
+ " -device pci-bridge,chassis_nr=1,id=shpcbr,addr=4.0"
+ " -device pci-testdev,bus=shpcbr,addr=1.0,acpi-index=201"
+ " -device pci-bridge,chassis_nr=2,shpc=off,id=noshpcbr,addr=5.0"
+ " -device pci-testdev,bus=noshpcbr,addr=1.0,acpi-index=301"
+ " -device pcie-root-port,id=hprp,port=0x0,chassis=1,addr=6.0"
+ " -device pci-testdev,bus=hprp,acpi-index=401"
+ " -device pcie-root-port,id=nohprp,port=0x0,chassis=2,hotplug=off,"
+ "addr=7.0"
+ " -device pci-testdev,bus=nohprp,acpi-index=501"
+ " -device pcie-root-port,id=nohprpint,port=0x0,chassis=3,hotplug=off,"
+ "addr=8.0"
+ " -device pcie-root-port,id=hprp2,port=0x0,chassis=4,bus=nohprpint,"
+ "addr=9.0"
+ " -device pci-testdev,bus=hprp2,acpi-index=601"
+ , &data);
+ free_test_data(&data);
+}
+
static void test_acpi_q35_multif_bridge(void)
{
test_data data = {
@@ -2161,6 +2195,8 @@ int main(int argc, char *argv[])
test_acpi_q35_tcg_tpm12_tis);
}
qtest_add_func("acpi/q35/bridge", test_acpi_q35_tcg_bridge);
+ qtest_add_func("acpi/q35/no-acpi-hotplug",
+ test_acpi_q35_tcg_no_acpi_hotplug);
qtest_add_func("acpi/q35/multif-bridge",
test_acpi_q35_multif_bridge);
qtest_add_func("acpi/q35/mmio64", test_acpi_q35_tcg_mmio64);
--
2.39.1
^ permalink raw reply related [flat|nested] 46+ messages in thread* [PATCH 03/33] tests: acpi: update expected blobs
2023-02-24 15:37 [PATCH 00/33] pci(pc/q35): acpi-index support on non-hotpluggable slots Igor Mammedov
2023-02-24 15:37 ` [PATCH 01/33] tests: acpi: whitelist new q35.noacpihp test and pc.hpbrroot Igor Mammedov
2023-02-24 15:37 ` [PATCH 02/33] tests: acpi: add test_acpi_q35_tcg_no_acpi_hotplug test and extend test_acpi_piix4_no_acpi_pci_hotplug Igor Mammedov
@ 2023-02-24 15:37 ` Igor Mammedov
2023-02-24 15:37 ` [PATCH 04/33] tests: acpi: whitelist q35/DSDT.multi-bridge before extending testcase Igor Mammedov
` (30 subsequent siblings)
33 siblings, 0 replies; 46+ messages in thread
From: Igor Mammedov @ 2023-02-24 15:37 UTC (permalink / raw)
To: qemu-devel; +Cc: mst, ani, berrange
expected changes:
Basically adds devices present on root bus in form:
Device (SXX)
{
Name (_ADR, 0xYYYYYYYY) // _ADR: Address
}
On top of that For q35.noacpihp, all ACPI PCI hotplug
AML is removed and _OSC get native hotplug enabled:
CreateDWordField (Arg3, 0x04, CDW2)
CreateDWordField (Arg3, 0x08, CDW3)
Local0 = CDW3 /* \_SB_.PCI0._OSC.CDW3 */
- Local0 &= 0x1E
+ Local0 &= 0x1F
If ((Arg1 != One))
{
CDW1 |= 0x08
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
tests/qtest/bios-tables-test-allowed-diff.h | 2 --
tests/data/acpi/pc/DSDT.hpbrroot | Bin 3081 -> 3115 bytes
tests/data/acpi/q35/DSDT.noacpihp | Bin 8252 -> 7932 bytes
3 files changed, 2 deletions(-)
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
index b2c5312871..dfb8523c8b 100644
--- a/tests/qtest/bios-tables-test-allowed-diff.h
+++ b/tests/qtest/bios-tables-test-allowed-diff.h
@@ -1,3 +1 @@
/* List of comma-separated changed AML files to ignore */
-"tests/data/acpi/pc/DSDT.hpbrroot",
-"tests/data/acpi/q35/DSDT.noacpihp",
diff --git a/tests/data/acpi/pc/DSDT.hpbrroot b/tests/data/acpi/pc/DSDT.hpbrroot
index a71ed4fbaa14be655c28a5e03e50157b4476e480..d77752960285a5afa6d0c0a04e400842f6acd2ed 100644
GIT binary patch
delta 100
zcmeB_SS`Wj66_M9&BMUJ_;DlGJx(rXm6-Tor+5Kx<;|Zse=<548N_qMJGuk`Rj@Eb
YH}MA>S-=HY!2-qz6>JazgbH>B01xpO00000
delta 66
zcmZ22(J8^@66_Mf$-}_Fcyc4xJx(r1rI`3&r+5KR#m%2Me=^D$TEuh2JGuk`RWLI|
NH}MA>8NdZt7ywGL58eO(
diff --git a/tests/data/acpi/q35/DSDT.noacpihp b/tests/data/acpi/q35/DSDT.noacpihp
index d68c472b460e4609a64ea67de3c4cebfca76164d..f35338db30a44638cc3a55d2870e0e377af4246f 100644
GIT binary patch
delta 160
zcmdnv@W+<RCD<k8j~oL7<AsS_R~Y3d-Y?y}kV#F7$x(3gNf~~|$trT`TwV$>@xe~<
z0!|8(r^?wU^9LJR#B;<ux&-ksFfcPjH}MA>8NdZtAOZ*#tY86SgbFr@073;jSil6K
Lf@AYVxj04uw-F~b
delta 485
zcmexkyT^gcCD<jzMuCBWaq2{_D~xgz@0ZpK_=xDm2Rp?FIC~mIHv~8bhcI#<;Njwk
zZWI7<oPpw@3P8d|A-W;h)hnKn`veacOLQYQh~w;J;OYgGaPspFV&uL6(FWo;JNbqB
zDg=1CL?}cvI{7$zGl-}LIJ<f=MJt1N|Nj?cfK(Jz)-z@@fDDON2Z=9X5Ycu7YQj(k
zR0T4u07N7})h38IaR#^q`|>VuVVj)AP$0<6$dFLLkhnl<(&P+5VJ?9S<|m&9n^yTw
z6o2I_dDz)^Nx}m5shM0%OA-n|mNa+dFfjN7Nk)bwpq|>vNeq*dc>V(cLv12sVr^n2
zBNsbEVnJd@0s{k3uj=G1F7^T;Rwf2spgnLCAO;j9K~!xHVN{c1@)g}&BhAm~72V{;
z65tUK#1Ze|>B1Y}7hvFMV8*}^9}40*dn$P3mlWibrYjVs7U!21C8rhx<$^;Txwtvv
zor8h}dAYdU84vIr;9-=Q+$odE<suaWiYfsg$;p3Y>^Cozjb`K(;E8t+a1~*TcQr6%
F000aMj?@4E
--
2.39.1
^ permalink raw reply related [flat|nested] 46+ messages in thread* [PATCH 04/33] tests: acpi: whitelist q35/DSDT.multi-bridge before extending testcase
2023-02-24 15:37 [PATCH 00/33] pci(pc/q35): acpi-index support on non-hotpluggable slots Igor Mammedov
` (2 preceding siblings ...)
2023-02-24 15:37 ` [PATCH 03/33] tests: acpi: update expected blobs Igor Mammedov
@ 2023-02-24 15:37 ` Igor Mammedov
2023-02-24 15:37 ` [PATCH 05/33] tests: acpi: extend multi-bridge case with case 'root-port, id=HOHP, hotplug=off root-port, bus=NOHP' Igor Mammedov
` (29 subsequent siblings)
33 siblings, 0 replies; 46+ messages in thread
From: Igor Mammedov @ 2023-02-24 15:37 UTC (permalink / raw)
To: qemu-devel; +Cc: mst, ani, berrange
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
tests/qtest/bios-tables-test-allowed-diff.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
index dfb8523c8b..dabc024f53 100644
--- a/tests/qtest/bios-tables-test-allowed-diff.h
+++ b/tests/qtest/bios-tables-test-allowed-diff.h
@@ -1 +1,2 @@
/* List of comma-separated changed AML files to ignore */
+"tests/data/acpi/q35/DSDT.multi-bridge",
--
2.39.1
^ permalink raw reply related [flat|nested] 46+ messages in thread* [PATCH 05/33] tests: acpi: extend multi-bridge case with case 'root-port, id=HOHP, hotplug=off root-port, bus=NOHP'
2023-02-24 15:37 [PATCH 00/33] pci(pc/q35): acpi-index support on non-hotpluggable slots Igor Mammedov
` (3 preceding siblings ...)
2023-02-24 15:37 ` [PATCH 04/33] tests: acpi: whitelist q35/DSDT.multi-bridge before extending testcase Igor Mammedov
@ 2023-02-24 15:37 ` Igor Mammedov
2023-02-24 15:37 ` [PATCH 06/33] x86: pcihp: fix missing PCNT callchain when intermediate root-port has 'hotplug=off' set Igor Mammedov
` (28 subsequent siblings)
33 siblings, 0 replies; 46+ messages in thread
From: Igor Mammedov @ 2023-02-24 15:37 UTC (permalink / raw)
To: qemu-devel; +Cc: mst, ani, berrange
Following corner case wasn't covered:
-device pcie-root-port,id=NO_HOTPLUG,hotplug=off
-device pcie-root-port,bus=NO_HOTPLUG
when intermediate root-port has explicitly disabled hotplug,
all hierarchy below it is not described anymore (used to be
described in 7.2)
So as result we see only NO_HOTPLUG root-port described
+ Device (S50)
+ {
+ Name (_ADR, 0x000A0000) // _ADR: Address
+ }
and no children nor notification chain for them are being composed.
Follow up patches will fix missing leaf root-port descriptor
and notification chain that should accompany it.
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
tests/qtest/bios-tables-test.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
index 5128b62634..638a193e13 100644
--- a/tests/qtest/bios-tables-test.c
+++ b/tests/qtest/bios-tables-test.c
@@ -1061,7 +1061,10 @@ static void test_acpi_q35_multif_bridge(void)
" -device pci-testdev,bus=pcie.0,addr=2.4"
" -device pci-testdev,bus=pcie.0,addr=5.0"
" -device pci-testdev,bus=rp0,addr=0.0"
- " -device pci-testdev,bus=br1", &data);
+ " -device pci-testdev,bus=br1"
+ " -device pcie-root-port,id=rpnohp,chassis=8,addr=0xA.0,hotplug=off"
+ " -device pcie-root-port,id=rp3,chassis=9,bus=rpnohp"
+ , &data);
/* hotplugged bridges section */
qtest_qmp_device_add(data.qts, "pci-bridge", "hpbr1",
--
2.39.1
^ permalink raw reply related [flat|nested] 46+ messages in thread* [PATCH 06/33] x86: pcihp: fix missing PCNT callchain when intermediate root-port has 'hotplug=off' set
2023-02-24 15:37 [PATCH 00/33] pci(pc/q35): acpi-index support on non-hotpluggable slots Igor Mammedov
` (4 preceding siblings ...)
2023-02-24 15:37 ` [PATCH 05/33] tests: acpi: extend multi-bridge case with case 'root-port, id=HOHP, hotplug=off root-port, bus=NOHP' Igor Mammedov
@ 2023-02-24 15:37 ` Igor Mammedov
2023-02-24 15:37 ` [PATCH 07/33] tests: acpi: whitelist pc/DSDT.hpbrroot and pc/DSDT.hpbridge tests Igor Mammedov
` (27 subsequent siblings)
33 siblings, 0 replies; 46+ messages in thread
From: Igor Mammedov @ 2023-02-24 15:37 UTC (permalink / raw)
To: qemu-devel; +Cc: mst, ani, berrange
Beside BSEL numbers change (due to 2 extra root-ports in q35/miltibridge test),
following change is expected:
Scope (\_SB.PCI0)
{
...
+ Scope (S50)
+ {
+ Scope (S00)
+ {
+ Method (PCNT, 0, NotSerialized)
+ {
+ BNUM = Zero
+ DVNT (PCIU, One)
+ DVNT (PCID, 0x03)
+ }
+ }
+
+ Method (PCNT, 0, NotSerialized)
+ {
+ ^S00.PCNT
+ }
+ }
...
Method (PCNT, 0, NotSerialized)
{
+ ^S50.PCNT ()
^S13.PCNT ()
^S12.PCNT ()
^S11.PCNT ()
I practice [1] hasn't broke anything since on hardware side we unset
hotplug_handler on such intermediate port => hotplug behind it has
not been properly wired and as result not worked.
1)
Fixes: ddab4d3fae4e8 ("pcihp: compose PCNT callchain right before its user _GPE._E01")
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
hw/i386/acpi-build.c | 22 +++++++++++++---------
1 file changed, 13 insertions(+), 9 deletions(-)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index b67dcbbb37..c0674ae2d1 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -516,16 +516,24 @@ static bool build_append_notfication_callback(Aml *parent_scope,
PCIBus *sec;
QObject *bsel;
int nr_notifiers = 0;
+ GQueue *pcnt_bus_list = g_queue_new();
QLIST_FOREACH(sec, &bus->child, sibling) {
Aml *br_scope = aml_scope("S%.02X", sec->parent_dev->devfn);
- if (pci_bus_is_root(sec) ||
- !object_property_find(OBJECT(sec), ACPI_PCIHP_PROP_BSEL)) {
+ if (pci_bus_is_root(sec)) {
continue;
}
nr_notifiers = nr_notifiers +
build_append_notfication_callback(br_scope, sec);
- aml_append(parent_scope, br_scope);
+ /*
+ * add new child scope to parent
+ * and keep track of bus that have PCNT,
+ * bus list is used later to call children PCNTs from this level PCNT
+ */
+ if (nr_notifiers) {
+ g_queue_push_tail(pcnt_bus_list, sec);
+ aml_append(parent_scope, br_scope);
+ }
}
/*
@@ -549,17 +557,13 @@ static bool build_append_notfication_callback(Aml *parent_scope,
}
/* Notify about child bus events in any case */
- QLIST_FOREACH(sec, &bus->child, sibling) {
- if (pci_bus_is_root(sec) ||
- !object_property_find(OBJECT(sec), ACPI_PCIHP_PROP_BSEL)) {
- continue;
- }
-
+ while ((sec = g_queue_pop_head(pcnt_bus_list))) {
aml_append(method, aml_name("^S%.02X.PCNT", sec->parent_dev->devfn));
}
aml_append(parent_scope, method);
qobject_unref(bsel);
+ g_queue_free(pcnt_bus_list);
return !!nr_notifiers;
}
--
2.39.1
^ permalink raw reply related [flat|nested] 46+ messages in thread* [PATCH 07/33] tests: acpi: whitelist pc/DSDT.hpbrroot and pc/DSDT.hpbridge tests
2023-02-24 15:37 [PATCH 00/33] pci(pc/q35): acpi-index support on non-hotpluggable slots Igor Mammedov
` (5 preceding siblings ...)
2023-02-24 15:37 ` [PATCH 06/33] x86: pcihp: fix missing PCNT callchain when intermediate root-port has 'hotplug=off' set Igor Mammedov
@ 2023-02-24 15:37 ` Igor Mammedov
2023-02-24 15:37 ` [PATCH 08/33] x86: pcihp: fix missing bridge AML when intermediate root-port has 'hotplug=off' set Igor Mammedov
` (26 subsequent siblings)
33 siblings, 0 replies; 46+ messages in thread
From: Igor Mammedov @ 2023-02-24 15:37 UTC (permalink / raw)
To: qemu-devel; +Cc: mst, ani, berrange
follow up fix for missing root-port AML will affect these tests
by adding non-hotpluggable Device descriptors of colplugged
bridges when bridge hotplug is disabled.
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
tests/qtest/bios-tables-test-allowed-diff.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
index dabc024f53..a0dbb28cde 100644
--- a/tests/qtest/bios-tables-test-allowed-diff.h
+++ b/tests/qtest/bios-tables-test-allowed-diff.h
@@ -1,2 +1,5 @@
/* List of comma-separated changed AML files to ignore */
"tests/data/acpi/q35/DSDT.multi-bridge",
+"tests/data/acpi/pc/DSDT.hpbridge",
+"tests/data/acpi/pc/DSDT.hpbrroot",
+"tests/data/acpi/q35/DSDT.noacpihp",
--
2.39.1
^ permalink raw reply related [flat|nested] 46+ messages in thread* [PATCH 08/33] x86: pcihp: fix missing bridge AML when intermediate root-port has 'hotplug=off' set
2023-02-24 15:37 [PATCH 00/33] pci(pc/q35): acpi-index support on non-hotpluggable slots Igor Mammedov
` (6 preceding siblings ...)
2023-02-24 15:37 ` [PATCH 07/33] tests: acpi: whitelist pc/DSDT.hpbrroot and pc/DSDT.hpbridge tests Igor Mammedov
@ 2023-02-24 15:37 ` Igor Mammedov
2023-02-24 15:37 ` [PATCH 09/33] tests: acpi: update expected blobs Igor Mammedov
` (25 subsequent siblings)
33 siblings, 0 replies; 46+ messages in thread
From: Igor Mammedov @ 2023-02-24 15:37 UTC (permalink / raw)
To: qemu-devel; +Cc: mst, ani, berrange
(I practice [1] hasn't broke anything since on hardware side we unset
hotplug_handler on such intermediate port => hotplug behind it has
never worked)
When deciding if bridge should be described, the original
condition was
cold_plugged_bridge && pcihp_bridge_en
which was replaced [1] by
bridge has ACPI_PCIHP_PROP_BSEL
the later however is not the same thing as the original
and flips to false if intermediate bridge has hotplug
turned off (root-port with 'hotplug=off' option).
Since we already in build_pci_bridge_aml(), the question
if it's bridge is answered. Use DeviceState::hotplugged
to make decision if bridge should describe its slots.
What's left out is pcihp_bridge_en, which tells us if
ACPI bridge hotplug is enabled.
With hotplug and non hotplug part now being mostly
separated, omitting this check will only lead to
colplugged bridges describe occupied slots in case
when ACPI bridge hotplug is disabled.
Which makes behavior consistent with occupied slots
on hostbridge.
Ex (pc/DSDT.hpbrroot diff):
...
Device (S20)
{
Name (_ADR, 0x00040000) // _ADR: Address
+ Device (S08)
+ {
+ Name (_ADR, 0x00010000) // _ADR: Address
+ }
+
+ Device (S10)
+ {
+ Name (_ADR, 0x00020000) // _ADR: Address
+ }
}
...
PS:
testing shows that above doesn't affect adversely guest OS
behavior: i.e. if ACPI bridge hotplug is enabled it's
expected behaviour, and with ACPI bridge hotplug is disabled
(a.k. native hotplug), it doesn't break slot enumeration
nor native hotplug. (tested with RHEL9.0 and WS2022).
1)
Fixes: 6c36ec46b0d ("pcihp: make bridge describe itself using AcpiDevAmlIfClass:build_dev_aml")
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
hw/acpi/pci-bridge.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/acpi/pci-bridge.c b/hw/acpi/pci-bridge.c
index 5f3ee5157f..4fbf6da6ad 100644
--- a/hw/acpi/pci-bridge.c
+++ b/hw/acpi/pci-bridge.c
@@ -21,7 +21,7 @@ void build_pci_bridge_aml(AcpiDevAmlIf *adev, Aml *scope)
{
PCIBridge *br = PCI_BRIDGE(adev);
- if (object_property_find(OBJECT(&br->sec_bus), ACPI_PCIHP_PROP_BSEL)) {
+ if (!DEVICE(br)->hotplugged) {
build_append_pci_bus_devices(scope, pci_bridge_get_sec_bus(br));
}
}
--
2.39.1
^ permalink raw reply related [flat|nested] 46+ messages in thread* [PATCH 09/33] tests: acpi: update expected blobs
2023-02-24 15:37 [PATCH 00/33] pci(pc/q35): acpi-index support on non-hotpluggable slots Igor Mammedov
` (7 preceding siblings ...)
2023-02-24 15:37 ` [PATCH 08/33] x86: pcihp: fix missing bridge AML when intermediate root-port has 'hotplug=off' set Igor Mammedov
@ 2023-02-24 15:37 ` Igor Mammedov
2023-02-24 15:37 ` [PATCH 10/33] pcihp: piix4: do not redirect hotplug controller to piix4 when ACPI hotplug is disabled Igor Mammedov
` (24 subsequent siblings)
33 siblings, 0 replies; 46+ messages in thread
From: Igor Mammedov @ 2023-02-24 15:37 UTC (permalink / raw)
To: qemu-devel; +Cc: mst, ani, berrange
BNUM numbering changes across DSDT due to addition of new bridges.
Fixed missing PCI tree brunch (q35/DSDT.multi-bridge case):
// -device pcie-root-port,id=rpnohp,chassis=8,addr=0xA.0,hotplug=off
+ Device (S50)
+ {
+ Name (_ADR, 0x000A0000) // _ADR: Address
// -device pcie-root-port,id=rp3,chassis=9,bus=rpnohp
+ Device (S00)
+ {
+ Name (_ADR, Zero) // _ADR: Address
+ Name (BSEL, Zero)
+ Device (S00)
+ {
+ Name (_ADR, Zero) // _ADR: Address
+ Name (ASUN, Zero)
+ Method (_DSM, 4, Serialized) // _DSM: Device-Specific Method
+ {
+ Local0 = Package (0x02)
+ {
+ BSEL,
+ ASUN
+ }
+ Return (PDSM (Arg0, Arg1, Arg2, Arg3, Local0))
+ }
+
+ Name (_SUN, Zero) // _SUN: Slot User Number
+ Method (_EJ0, 1, NotSerialized) // _EJx: Eject Device
+ {
+ PCEJ (BSEL, _SUN)
+ }
+ }
+
+ Method (DVNT, 2, NotSerialized)
+ {
+ If ((Arg0 & One))
+ {
+ Notify (S00, Arg1)
+ }
+ }
+ }
+ }
Fixed hotplug notification for leaf root port (hotplug=on) attached to
intermediate root port (hotplug=off) (q35/DSDT.multi-bridge case)
// -device pcie-root-port,id=rpnohp,chassis=8,addr=0xA.0,hotplug=off
+ Scope (S50)
+ {
// -device pcie-root-port,id=rp3,chassis=9,bus=rpnohp
+ Scope (S00)
+ {
+ Method (PCNT, 0, NotSerialized)
+ {
+ BNUM = Zero
+ DVNT (PCIU, One)
+ DVNT (PCID, 0x03)
+ }
+ }
+
+ Method (PCNT, 0, NotSerialized)
+ {
+ ^S00.PCNT ()
+ }
+ }
...
Method (PCNT, 0, NotSerialized)
{
+ ^S50.PCNT ()
^S13.PCNT ()
Populated slots being described on coldplugged bridges even if
ACPI bridge hotplug is disabled.
(pc/DSDT.hpbridge and pc/DSDT.hpbrroot)
...
Device (S18)
{
Name (_ADR, 0x00030000) // _ADR: Address
+ Device (S08)
+ {
+ Name (_ADR, 0x00010000) // _ADR: Address
+ }
+
+ Device (S10)
+ {
+ Name (_ADR, 0x00020000) // _ADR: Address
+ }
}
...
Device (S18)
{
Name (_ADR, 0x00030000) // _ADR: Address
+ Device (S00)
+ {
+ Name (_ADR, Zero) // _ADR: Address
+ }
}
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
tests/qtest/bios-tables-test-allowed-diff.h | 4 ----
tests/data/acpi/pc/DSDT.hpbridge | Bin 6289 -> 6323 bytes
tests/data/acpi/pc/DSDT.hpbrroot | Bin 3115 -> 3166 bytes
tests/data/acpi/q35/DSDT.multi-bridge | Bin 12337 -> 12545 bytes
tests/data/acpi/q35/DSDT.noacpihp | Bin 7932 -> 8022 bytes
5 files changed, 4 deletions(-)
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
index a0dbb28cde..dfb8523c8b 100644
--- a/tests/qtest/bios-tables-test-allowed-diff.h
+++ b/tests/qtest/bios-tables-test-allowed-diff.h
@@ -1,5 +1 @@
/* List of comma-separated changed AML files to ignore */
-"tests/data/acpi/q35/DSDT.multi-bridge",
-"tests/data/acpi/pc/DSDT.hpbridge",
-"tests/data/acpi/pc/DSDT.hpbrroot",
-"tests/data/acpi/q35/DSDT.noacpihp",
diff --git a/tests/data/acpi/pc/DSDT.hpbridge b/tests/data/acpi/pc/DSDT.hpbridge
index 834c27002edbd3e2298a71c9ff1b501e3a3314f7..5dea100bc9492bb2367aac8660522201785c1efb 100644
GIT binary patch
delta 89
zcmbPexY>})CD<iovjhVJqvb}fa&9iSGcobOPVoYMr#E+Ve`ho>3^ufg=ZJT73F2X3
bU}lJJ;tw`J2rz;L3=QBam^M$~W#k3`PB0c2
delta 55
zcmdmNIMI;HCD<ioq67m2qvA%ca&9h{Q!(+uPVoXhCpUL<e`n<54>q)j=ZJT73F2X3
LVBWlmmysI)zZnl0
diff --git a/tests/data/acpi/pc/DSDT.hpbrroot b/tests/data/acpi/pc/DSDT.hpbrroot
index d77752960285a5afa6d0c0a04e400842f6acd2ed..893ab221c2cca1829937a4c26152680313633df4 100644
GIT binary patch
delta 121
zcmZ22aZiHFCD<h-j)#GPaneSvdz@Tu>M`-bPVoYMYMVcCerGf=3^p=|=ZJT72?DBN
iVTf+x4>quX3owEO3=t}rCV%HvRZs{vMyO%O)C2%vb{qNt
delta 70
zcmca7v08%5CD<iIn}>mc@#99Wdz@U(DlzfFPVoZX%9}rNerM$44>mH0=ZJT72?DBN
SnJmep%FiEcYylTyX8-`NSP<#}
diff --git a/tests/data/acpi/q35/DSDT.multi-bridge b/tests/data/acpi/q35/DSDT.multi-bridge
index 66b39be294a261a6bd991c6bcbd8e2a04a03403f..f2f60fdbb3b44ab9adb69bb36e4a80978536af9b 100644
GIT binary patch
delta 312
zcmdm((3r&K66_MfXvo08IA<eQqa05Y2V+cpuv5H1Cp+Whsd7n-?2|vrM@|luS7u}e
zu^7E4pO;shTr3|y*-t@k@(1~-$;T7|CV!W6-5jmBoSUCjgv}+)FNBH1DcIGAi)FH)
zu9T4zN3f|uJV(5vOArqO0~bSdlLLFO0aSzmtP&{Z$$}7@{9i6;v$k#wqqwtlj2_56
z0nVNV0yZFX1XO|QCeP4Q6cZ5$aP|vfh|>dU1Tle9hQ^ck>8bJ<#fvC_B@4KiCNI<%
zpL}1BALs!Pi%nm4@&bLy$u{~Nla=))CdcRtPj=B)5)e=eHZ(wJV+Sgh5OijNSpl>e
K#GJfezX$-13sfWk
delta 216
zcmZon+L*xQ66_LUXu!b0*uIggQI5;|e@uL^Q@nul|H;$kk{H=07brwdz97#sIb2?T
z@@M(D$yem%Cg&?eP4-n#Vq^fyu4H5dk}jL$6qj?Wvxu;{g!zRqaX1CL`fxErdC^V$
z!A2JG9Py4WK|Bl$tPGns=*BS$dWps8f$R!!_B0Ss4K_5Mtg5fb3St>ej?q`;F^m^c
z2ypfbVJP5YnyjxcKKZo1EYLE2eTm6B23nJ~4LB!n2C{t&BqzVnmt?a5tDW3$Py_&m
C13TgX
diff --git a/tests/data/acpi/q35/DSDT.noacpihp b/tests/data/acpi/q35/DSDT.noacpihp
index f35338db30a44638cc3a55d2870e0e377af4246f..4ea982de2df3cf7cd89cb3b4467a350eaf8f5d29 100644
GIT binary patch
delta 213
zcmexkd(Do^CD<h-OrC*(F=8Xv3mGmKwV3!|r+5J$)yaQk0_qiljSS*B;vHRrco-O1
z7^0i_gAFX;0*pWbpbCTlD>fA}!Nv$P*nldygAJepKn_qAp`RU1R<}tv*aV@O1FYTz
Op`H^({pNYHaf|>-)-eG9
delta 122
zcmca+_s5pYCD<k8j~oL7<Ase}FJ!p96k_6oo#F+Y6ej<X2?*j3HZq9kh<9`e;$dK5
jVTf)53Ru7eSiu6u2o-D)0fY*6uz(3d1;^$evT=+6@ys3p
--
2.39.1
^ permalink raw reply related [flat|nested] 46+ messages in thread* [PATCH 10/33] pcihp: piix4: do not redirect hotplug controller to piix4 when ACPI hotplug is disabled
2023-02-24 15:37 [PATCH 00/33] pci(pc/q35): acpi-index support on non-hotpluggable slots Igor Mammedov
` (8 preceding siblings ...)
2023-02-24 15:37 ` [PATCH 09/33] tests: acpi: update expected blobs Igor Mammedov
@ 2023-02-24 15:37 ` Igor Mammedov
2023-02-24 15:37 ` [PATCH 11/33] pci: fix 'hotplugglable' property behavior Igor Mammedov
` (23 subsequent siblings)
33 siblings, 0 replies; 46+ messages in thread
From: Igor Mammedov @ 2023-02-24 15:37 UTC (permalink / raw)
To: qemu-devel; +Cc: mst, ani, berrange
commit [1] added ability to disable ACPI PCI hotplug
on hostbridge but forgot to take into account that it
should disable all ACPI hotplug machinery in case both
hostbridge and bridge hotplug are disabled.
Commit [2] tried to fix that, however it forgot to
remove hotplug_handler override which hands hotplug
control over to piix4 hotplug controller
(uninitialized after [2]).
As result at the time bridge is plugged in, its default
(SHPC) hotplug handler is replaced by piix4 one in
acpi_pcihp_device_plug_cb()
...
if (!s->legacy_piix &&
...
qbus_set_hotplug_handler(BUS(sec), OBJECT(hotplug_dev));
which is acting on uninitialized s->legacy_piix value
(0 by default) that was supposed to be initialized by
acpi_pcihp_init(), that is no longer called due to
following condition being false:
piix4_acpi_system_hot_add_init()
if (s->use_acpi_hotplug_bridge || s->use_acpi_root_pci_hotplug) {
and the bridge ends up with piix4 as hotplug handler
instead of shpc one.
Followup hotplug on that bridge as result yields
piix4 specific error:
Error: Unsupported bus. Bus doesn't have property 'acpi-pcihp-bsel' set
1) 3d7e78aa777 (Introduce a new flag for i440fx to disable PCI hotplug on the root bus)
2) df4008c9c59 (piix4: don't reserve hw resources when hotplug is off globally)
Fixes: df4008c9c59 (piix4: don't reserve hw resources when hotplug is off globally)
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
hw/acpi/piix4.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c
index eac2125abd..8fc422829a 100644
--- a/hw/acpi/piix4.c
+++ b/hw/acpi/piix4.c
@@ -492,7 +492,6 @@ static void piix4_pm_realize(PCIDevice *dev, Error **errp)
piix4_acpi_system_hot_add_init(pci_address_space_io(dev),
pci_get_bus(dev), s);
- qbus_set_hotplug_handler(BUS(pci_get_bus(dev)), OBJECT(s));
piix4_pm_add_properties(s);
}
@@ -564,6 +563,7 @@ static void piix4_acpi_system_hot_add_init(MemoryRegion *parent,
if (s->use_acpi_hotplug_bridge || s->use_acpi_root_pci_hotplug) {
acpi_pcihp_init(OBJECT(s), &s->acpi_pci_hotplug, bus, parent,
s->use_acpi_hotplug_bridge, ACPI_PCIHP_ADDR_PIIX4);
+ qbus_set_hotplug_handler(BUS(pci_get_bus(PCI_DEVICE(s))), OBJECT(s));
}
s->cpu_hotplug_legacy = true;
--
2.39.1
^ permalink raw reply related [flat|nested] 46+ messages in thread* [PATCH 11/33] pci: fix 'hotplugglable' property behavior
2023-02-24 15:37 [PATCH 00/33] pci(pc/q35): acpi-index support on non-hotpluggable slots Igor Mammedov
` (9 preceding siblings ...)
2023-02-24 15:37 ` [PATCH 10/33] pcihp: piix4: do not redirect hotplug controller to piix4 when ACPI hotplug is disabled Igor Mammedov
@ 2023-02-24 15:37 ` Igor Mammedov
2023-02-24 15:37 ` [PATCH 12/33] tests: acpi: whitelist DSDT blobs before isolating PCI _DSM func 0 prolog Igor Mammedov
` (22 subsequent siblings)
33 siblings, 0 replies; 46+ messages in thread
From: Igor Mammedov @ 2023-02-24 15:37 UTC (permalink / raw)
To: qemu-devel; +Cc: mst, ani, berrange
Currently the property may flip its state
during VM bring up or just doesn't work as
the name implies.
In particular with PCIE root port that has
'hotplug={on|off}' property, and when it's
turned off, one would expect
'hotpluggable' == false
for any devices attached to it.
Which is not the case since qbus_is_hotpluggable()
used by the property just checks for presence
of any hotplug_handler set on bus.
The problem is that name BusState::hotplug_handler
from its inception is misnomer, as it handles
not only hotplug but also in many cases coldplug
as well (i.e. generic wiring interface), and
it's fine to have hotplug_handler set on bus
while it doesn't support hotplug (ex. pcie-slot
with hotplug=off).
Another case of root port flipping 'hotpluggable'
state when ACPI PCI hotplug is enabled in this
case root port with 'hotplug=off' starts as
hotpluggable and then later on, pcihp
hotplug_handler clears hotplug_handler
explicitly after checking root port's 'hotplug'
property.
So root-port hotpluggablity check sort of works
if pcihp is enabled but is broken if pcihp is
disabled.
One way to deal with the issue is to ask
hotplug_handler if bus it controls is hotpluggable
or not. To do that add is_hotpluggable_bus()
hook to HotplugHandler interface and use it in
'hotpluggable' property + teach pcie-slot to
actually look into 'hotplug' property state
before deciding if bus is hotpluggable.
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
include/hw/hotplug.h | 2 ++
include/hw/qdev-core.h | 13 ++++++++++++-
hw/pci/pcie_port.c | 8 ++++++++
3 files changed, 22 insertions(+), 1 deletion(-)
diff --git a/include/hw/hotplug.h b/include/hw/hotplug.h
index e15f59c8b3..a9840ed485 100644
--- a/include/hw/hotplug.h
+++ b/include/hw/hotplug.h
@@ -48,6 +48,7 @@ typedef void (*hotplug_fn)(HotplugHandler *plug_handler,
* @unplug: unplug callback.
* Used for device removal with devices that implement
* asynchronous and synchronous (surprise) removal.
+ * @is_hotpluggable_bus: called to check if bus/its parent allow hotplug on bus
*/
struct HotplugHandlerClass {
/* <private> */
@@ -58,6 +59,7 @@ struct HotplugHandlerClass {
hotplug_fn plug;
hotplug_fn unplug_request;
hotplug_fn unplug;
+ bool (*is_hotpluggable_bus)(HotplugHandler *plug_handler, BusState *bus);
};
/**
diff --git a/include/hw/qdev-core.h b/include/hw/qdev-core.h
index 35fddb19a6..3b3518146b 100644
--- a/include/hw/qdev-core.h
+++ b/include/hw/qdev-core.h
@@ -812,7 +812,18 @@ void qbus_set_bus_hotplug_handler(BusState *bus);
static inline bool qbus_is_hotpluggable(BusState *bus)
{
- return bus->hotplug_handler;
+ HotplugHandler *plug_handler = bus->hotplug_handler;
+ bool ret = !!plug_handler;
+
+ if (plug_handler) {
+ HotplugHandlerClass *hdc;
+
+ hdc = HOTPLUG_HANDLER_GET_CLASS(plug_handler);
+ if (hdc->is_hotpluggable_bus) {
+ ret = hdc->is_hotpluggable_bus(plug_handler, bus);
+ }
+ }
+ return ret;
}
/**
diff --git a/hw/pci/pcie_port.c b/hw/pci/pcie_port.c
index 65a397ad23..000633fec1 100644
--- a/hw/pci/pcie_port.c
+++ b/hw/pci/pcie_port.c
@@ -161,6 +161,13 @@ PCIDevice *pcie_find_port_by_pn(PCIBus *bus, uint8_t pn)
return NULL;
}
+static bool pcie_slot_is_hotpluggbale_bus(HotplugHandler *plug_handler,
+ BusState *bus)
+{
+ PCIESlot *s = PCIE_SLOT(bus->parent);
+ return s->hotplug;
+}
+
static const TypeInfo pcie_port_type_info = {
.name = TYPE_PCIE_PORT,
.parent = TYPE_PCI_BRIDGE,
@@ -188,6 +195,7 @@ static void pcie_slot_class_init(ObjectClass *oc, void *data)
hc->plug = pcie_cap_slot_plug_cb;
hc->unplug = pcie_cap_slot_unplug_cb;
hc->unplug_request = pcie_cap_slot_unplug_request_cb;
+ hc->is_hotpluggable_bus = pcie_slot_is_hotpluggbale_bus;
}
static const TypeInfo pcie_slot_type_info = {
--
2.39.1
^ permalink raw reply related [flat|nested] 46+ messages in thread* [PATCH 12/33] tests: acpi: whitelist DSDT blobs before isolating PCI _DSM func 0 prolog
2023-02-24 15:37 [PATCH 00/33] pci(pc/q35): acpi-index support on non-hotpluggable slots Igor Mammedov
` (10 preceding siblings ...)
2023-02-24 15:37 ` [PATCH 11/33] pci: fix 'hotplugglable' property behavior Igor Mammedov
@ 2023-02-24 15:37 ` Igor Mammedov
2023-02-24 15:37 ` [PATCH 13/33] pcihp: move PCI _DSM function 0 prolog into separate function Igor Mammedov
` (21 subsequent siblings)
33 siblings, 0 replies; 46+ messages in thread
From: Igor Mammedov @ 2023-02-24 15:37 UTC (permalink / raw)
To: qemu-devel; +Cc: mst, ani, berrange
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
tests/qtest/bios-tables-test-allowed-diff.h | 35 +++++++++++++++++++++
1 file changed, 35 insertions(+)
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
index dfb8523c8b..7e7745db39 100644
--- a/tests/qtest/bios-tables-test-allowed-diff.h
+++ b/tests/qtest/bios-tables-test-allowed-diff.h
@@ -1 +1,36 @@
/* List of comma-separated changed AML files to ignore */
+"tests/data/acpi/pc/DSDT",
+"tests/data/acpi/pc/DSDT.acpierst",
+"tests/data/acpi/pc/DSDT.acpihmat",
+"tests/data/acpi/pc/DSDT.bridge",
+"tests/data/acpi/pc/DSDT.cphp",
+"tests/data/acpi/pc/DSDT.dimmpxm",
+"tests/data/acpi/pc/DSDT.hpbridge",
+"tests/data/acpi/pc/DSDT.ipmikcs",
+"tests/data/acpi/pc/DSDT.memhp",
+"tests/data/acpi/pc/DSDT.nohpet",
+"tests/data/acpi/pc/DSDT.numamem",
+"tests/data/acpi/pc/DSDT.roothp",
+"tests/data/acpi/q35/DSDT",
+"tests/data/acpi/q35/DSDT.acpierst",
+"tests/data/acpi/q35/DSDT.acpihmat",
+"tests/data/acpi/q35/DSDT.acpihmat-noinitiator",
+"tests/data/acpi/q35/DSDT.applesmc",
+"tests/data/acpi/q35/DSDT.bridge",
+"tests/data/acpi/q35/DSDT.core-count2",
+"tests/data/acpi/q35/DSDT.cphp",
+"tests/data/acpi/q35/DSDT.cxl",
+"tests/data/acpi/q35/DSDT.dimmpxm",
+"tests/data/acpi/q35/DSDT.ipmibt",
+"tests/data/acpi/q35/DSDT.ipmismbus",
+"tests/data/acpi/q35/DSDT.ivrs",
+"tests/data/acpi/q35/DSDT.memhp",
+"tests/data/acpi/q35/DSDT.mmio64",
+"tests/data/acpi/q35/DSDT.multi-bridge",
+"tests/data/acpi/q35/DSDT.nohpet",
+"tests/data/acpi/q35/DSDT.numamem",
+"tests/data/acpi/q35/DSDT.pvpanic-isa",
+"tests/data/acpi/q35/DSDT.tis.tpm12",
+"tests/data/acpi/q35/DSDT.tis.tpm2",
+"tests/data/acpi/q35/DSDT.viot",
+"tests/data/acpi/q35/DSDT.xapic",
--
2.39.1
^ permalink raw reply related [flat|nested] 46+ messages in thread* [PATCH 13/33] pcihp: move PCI _DSM function 0 prolog into separate function
2023-02-24 15:37 [PATCH 00/33] pci(pc/q35): acpi-index support on non-hotpluggable slots Igor Mammedov
` (11 preceding siblings ...)
2023-02-24 15:37 ` [PATCH 12/33] tests: acpi: whitelist DSDT blobs before isolating PCI _DSM func 0 prolog Igor Mammedov
@ 2023-02-24 15:37 ` Igor Mammedov
2023-02-24 15:37 ` [PATCH 14/33] tests: acpi: update expected blobs Igor Mammedov
` (20 subsequent siblings)
33 siblings, 0 replies; 46+ messages in thread
From: Igor Mammedov @ 2023-02-24 15:37 UTC (permalink / raw)
To: qemu-devel; +Cc: mst, ani, berrange
it will be reused by follow up patches that will implement
static _DSM for non-hotpluggable devices.
no functional AML change, only context one, where 'cap' (Local1)
initialization is moved after UUID/revision checks.
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
hw/i386/acpi-build.c | 54 ++++++++++++++++++++++++--------------------
1 file changed, 30 insertions(+), 24 deletions(-)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index c0674ae2d1..cb80b7a318 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -372,6 +372,33 @@ Aml *aml_pci_device_dsm(void)
return method;
}
+static void build_append_pci_dsm_func0_common(Aml *ctx, Aml *retvar)
+{
+ Aml *UUID, *ifctx1;
+ uint8_t byte_list[1] = { 0 }; /* nothing supported yet */
+
+ aml_append(ctx, aml_store(aml_buffer(1, byte_list), retvar));
+ /*
+ * PCI Firmware Specification 3.1
+ * 4.6. _DSM Definitions for PCI
+ */
+ UUID = aml_touuid("E5C937D0-3553-4D7A-9117-EA4D19C3434D");
+ ifctx1 = aml_if(aml_lnot(aml_equal(aml_arg(0), UUID)));
+ {
+ /* call is for unsupported UUID, bail out */
+ aml_append(ifctx1, aml_return(retvar));
+ }
+ aml_append(ctx, ifctx1);
+
+ ifctx1 = aml_if(aml_lless(aml_arg(1), aml_int(2)));
+ {
+ /* call is for unsupported REV, bail out */
+ aml_append(ifctx1, aml_return(retvar));
+ }
+ aml_append(ctx, ifctx1);
+}
+
+
static void build_append_pcihp_notify_entry(Aml *method, int slot)
{
Aml *if_ctx;
@@ -569,14 +596,13 @@ static bool build_append_notfication_callback(Aml *parent_scope,
static Aml *aml_pci_pdsm(void)
{
- Aml *method, *UUID, *ifctx, *ifctx1;
+ Aml *method, *ifctx, *ifctx1;
Aml *ret = aml_local(0);
Aml *caps = aml_local(1);
Aml *acpi_index = aml_local(2);
Aml *zero = aml_int(0);
Aml *one = aml_int(1);
Aml *func = aml_arg(2);
- Aml *rev = aml_arg(1);
Aml *params = aml_arg(4);
Aml *bnum = aml_derefof(aml_index(params, aml_int(0)));
Aml *sunum = aml_derefof(aml_index(params, aml_int(1)));
@@ -586,29 +612,9 @@ static Aml *aml_pci_pdsm(void)
/* get supported functions */
ifctx = aml_if(aml_equal(func, zero));
{
- uint8_t byte_list[1] = { 0 }; /* nothing supported yet */
- aml_append(ifctx, aml_store(aml_buffer(1, byte_list), ret));
- aml_append(ifctx, aml_store(zero, caps));
-
- /*
- * PCI Firmware Specification 3.1
- * 4.6. _DSM Definitions for PCI
- */
- UUID = aml_touuid("E5C937D0-3553-4D7A-9117-EA4D19C3434D");
- ifctx1 = aml_if(aml_lnot(aml_equal(aml_arg(0), UUID)));
- {
- /* call is for unsupported UUID, bail out */
- aml_append(ifctx1, aml_return(ret));
- }
- aml_append(ifctx, ifctx1);
-
- ifctx1 = aml_if(aml_lless(rev, aml_int(2)));
- {
- /* call is for unsupported REV, bail out */
- aml_append(ifctx1, aml_return(ret));
- }
- aml_append(ifctx, ifctx1);
+ build_append_pci_dsm_func0_common(ifctx, ret);
+ aml_append(ifctx, aml_store(zero, caps));
aml_append(ifctx,
aml_store(aml_call2("AIDX", bnum, sunum), acpi_index));
/*
--
2.39.1
^ permalink raw reply related [flat|nested] 46+ messages in thread* [PATCH 14/33] tests: acpi: update expected blobs
2023-02-24 15:37 [PATCH 00/33] pci(pc/q35): acpi-index support on non-hotpluggable slots Igor Mammedov
` (12 preceding siblings ...)
2023-02-24 15:37 ` [PATCH 13/33] pcihp: move PCI _DSM function 0 prolog into separate function Igor Mammedov
@ 2023-02-24 15:37 ` Igor Mammedov
2023-03-02 0:27 ` Michael S. Tsirkin
2023-03-02 0:37 ` Michael S. Tsirkin
2023-02-24 15:37 ` [PATCH 15/33] tests: acpi: whitelist DSDT before adding EDSM method Igor Mammedov
` (19 subsequent siblings)
33 siblings, 2 replies; 46+ messages in thread
From: Igor Mammedov @ 2023-02-24 15:37 UTC (permalink / raw)
To: qemu-devel; +Cc: mst, ani, berrange
only following context change:
- Local1 = Zero
If ((Arg0 != ToUUID ("e5c937d0-3553-4d7a-9117-ea4d19c3434d") /* Device Labeling Interface */))
{
Return (Local0)
...
Return (Local0)
}
+ Local1 = Zero
Local2 = AIDX (DerefOf (Arg4 [Zero]), DerefOf (Arg4 [One]
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
tests/qtest/bios-tables-test-allowed-diff.h | 35 ------------------
tests/data/acpi/pc/DSDT | Bin 6360 -> 6360 bytes
tests/data/acpi/pc/DSDT.acpierst | Bin 6283 -> 6283 bytes
tests/data/acpi/pc/DSDT.acpihmat | Bin 7685 -> 7685 bytes
tests/data/acpi/pc/DSDT.bridge | Bin 12487 -> 12487 bytes
tests/data/acpi/pc/DSDT.cphp | Bin 6824 -> 6824 bytes
tests/data/acpi/pc/DSDT.dimmpxm | Bin 8014 -> 8014 bytes
tests/data/acpi/pc/DSDT.hpbridge | Bin 6323 -> 6323 bytes
tests/data/acpi/pc/DSDT.ipmikcs | Bin 6432 -> 6432 bytes
tests/data/acpi/pc/DSDT.memhp | Bin 7719 -> 7719 bytes
tests/data/acpi/pc/DSDT.nohpet | Bin 6218 -> 6218 bytes
tests/data/acpi/pc/DSDT.numamem | Bin 6366 -> 6366 bytes
tests/data/acpi/pc/DSDT.roothp | Bin 9745 -> 9745 bytes
tests/data/acpi/q35/DSDT | Bin 8252 -> 8252 bytes
tests/data/acpi/q35/DSDT.acpierst | Bin 8269 -> 8269 bytes
tests/data/acpi/q35/DSDT.acpihmat | Bin 9577 -> 9577 bytes
tests/data/acpi/q35/DSDT.acpihmat-noinitiator | Bin 8531 -> 8531 bytes
tests/data/acpi/q35/DSDT.applesmc | Bin 8298 -> 8298 bytes
tests/data/acpi/q35/DSDT.bridge | Bin 11481 -> 11481 bytes
tests/data/acpi/q35/DSDT.core-count2 | Bin 32392 -> 32392 bytes
tests/data/acpi/q35/DSDT.cphp | Bin 8716 -> 8716 bytes
tests/data/acpi/q35/DSDT.cxl | Bin 9578 -> 9578 bytes
tests/data/acpi/q35/DSDT.dimmpxm | Bin 9906 -> 9906 bytes
tests/data/acpi/q35/DSDT.ipmibt | Bin 8327 -> 8327 bytes
tests/data/acpi/q35/DSDT.ipmismbus | Bin 8340 -> 8340 bytes
tests/data/acpi/q35/DSDT.ivrs | Bin 8269 -> 8269 bytes
tests/data/acpi/q35/DSDT.memhp | Bin 9611 -> 9611 bytes
tests/data/acpi/q35/DSDT.mmio64 | Bin 9382 -> 9382 bytes
tests/data/acpi/q35/DSDT.multi-bridge | Bin 12545 -> 12545 bytes
tests/data/acpi/q35/DSDT.nohpet | Bin 8110 -> 8110 bytes
tests/data/acpi/q35/DSDT.numamem | Bin 8258 -> 8258 bytes
tests/data/acpi/q35/DSDT.pvpanic-isa | Bin 8353 -> 8353 bytes
tests/data/acpi/q35/DSDT.tis.tpm12 | Bin 8858 -> 8858 bytes
tests/data/acpi/q35/DSDT.tis.tpm2 | Bin 8884 -> 8884 bytes
tests/data/acpi/q35/DSDT.viot | Bin 9361 -> 9377 bytes
tests/data/acpi/q35/DSDT.xapic | Bin 35615 -> 35615 bytes
36 files changed, 35 deletions(-)
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
index 7e7745db39..dfb8523c8b 100644
--- a/tests/qtest/bios-tables-test-allowed-diff.h
+++ b/tests/qtest/bios-tables-test-allowed-diff.h
@@ -1,36 +1 @@
/* List of comma-separated changed AML files to ignore */
-"tests/data/acpi/pc/DSDT",
-"tests/data/acpi/pc/DSDT.acpierst",
-"tests/data/acpi/pc/DSDT.acpihmat",
-"tests/data/acpi/pc/DSDT.bridge",
-"tests/data/acpi/pc/DSDT.cphp",
-"tests/data/acpi/pc/DSDT.dimmpxm",
-"tests/data/acpi/pc/DSDT.hpbridge",
-"tests/data/acpi/pc/DSDT.ipmikcs",
-"tests/data/acpi/pc/DSDT.memhp",
-"tests/data/acpi/pc/DSDT.nohpet",
-"tests/data/acpi/pc/DSDT.numamem",
-"tests/data/acpi/pc/DSDT.roothp",
-"tests/data/acpi/q35/DSDT",
-"tests/data/acpi/q35/DSDT.acpierst",
-"tests/data/acpi/q35/DSDT.acpihmat",
-"tests/data/acpi/q35/DSDT.acpihmat-noinitiator",
-"tests/data/acpi/q35/DSDT.applesmc",
-"tests/data/acpi/q35/DSDT.bridge",
-"tests/data/acpi/q35/DSDT.core-count2",
-"tests/data/acpi/q35/DSDT.cphp",
-"tests/data/acpi/q35/DSDT.cxl",
-"tests/data/acpi/q35/DSDT.dimmpxm",
-"tests/data/acpi/q35/DSDT.ipmibt",
-"tests/data/acpi/q35/DSDT.ipmismbus",
-"tests/data/acpi/q35/DSDT.ivrs",
-"tests/data/acpi/q35/DSDT.memhp",
-"tests/data/acpi/q35/DSDT.mmio64",
-"tests/data/acpi/q35/DSDT.multi-bridge",
-"tests/data/acpi/q35/DSDT.nohpet",
-"tests/data/acpi/q35/DSDT.numamem",
-"tests/data/acpi/q35/DSDT.pvpanic-isa",
-"tests/data/acpi/q35/DSDT.tis.tpm12",
-"tests/data/acpi/q35/DSDT.tis.tpm2",
-"tests/data/acpi/q35/DSDT.viot",
-"tests/data/acpi/q35/DSDT.xapic",
diff --git a/tests/data/acpi/pc/DSDT b/tests/data/acpi/pc/DSDT
index 0b475fb5a966543fef2cd7672a0b198838a63151..ec133a6d3aabcfd22b7b46019338db2de255da70 100644
GIT binary patch
delta 19
acmca%c*Af*JmcgfMinN8#LcaY!Quc(l?Foq
delta 20
bcmca%c*Af*JR@@fL*nFkMwQKNj6vc6P%j3t
diff --git a/tests/data/acpi/pc/DSDT.acpierst b/tests/data/acpi/pc/DSDT.acpierst
index 17ef7caeb6fe4445f1234ff060c3db6809184ef6..2b4b7f31919f360e038e37de713639da753f13aa 100644
GIT binary patch
delta 19
acmeA+>^9sG&p0`WQH6;iadRspn>YYICk0#p
delta 20
bcmeA+>^9sG&&XWBkT^M>QDt)*Bda(7L?;Ex
diff --git a/tests/data/acpi/pc/DSDT.acpihmat b/tests/data/acpi/pc/DSDT.acpihmat
index 675b674eaa92d99513ac243a97064d369791ee53..714a123e7a500cf0f862ff6c4e9a3f50a96af056 100644
GIT binary patch
delta 19
acmZp*X|>r9&p0`WQH6;iadRtUgA4#az6Ip~
delta 20
bcmZp*X|>r9&&XWBkT^M>QDt)*W4#OjMaTwI
diff --git a/tests/data/acpi/pc/DSDT.bridge b/tests/data/acpi/pc/DSDT.bridge
index c1ce06136619f55c084a34c51997c059c29cb06a..6c0543cf75ad3e02468ed4925fd3369a183e9b45 100644
GIT binary patch
delta 19
acmX?}csy}KJmcgfMinN8#LcaYPWk{%hX#lM
delta 20
bcmX?}csy}KJR@@fL*nFkMwQKNjE?#MR9^=6
diff --git a/tests/data/acpi/pc/DSDT.cphp b/tests/data/acpi/pc/DSDT.cphp
index 754ab854dc48fc1af2d335e7269c23a056e66eb8..e1bcb0a4f3ee1269bdd5e949206b40d0e3c076e6 100644
GIT binary patch
delta 19
acmZ2sy25lrJmcgfMinN8#LcaY%8~#={{_7O
delta 20
bcmZ2sy25lrJR@@fL*nFkMwQKNj7pLKNkIlH
diff --git a/tests/data/acpi/pc/DSDT.dimmpxm b/tests/data/acpi/pc/DSDT.dimmpxm
index 170503336b3fd94cc7a4356003fa080f0ef57b01..1c90e119c5d3dc7e86d04942114e5cfe40de6039 100644
GIT binary patch
delta 19
acmX?Scg}7@JmcgfMinN8#LcaYCuIRj*#^Y`
delta 20
bcmX?Scg}7@JR@@fL*nFkMwQKNj3;CPQF#Y5
diff --git a/tests/data/acpi/pc/DSDT.hpbridge b/tests/data/acpi/pc/DSDT.hpbridge
index 5dea100bc9492bb2367aac8660522201785c1efb..04e1c20f63be7c6c574e72590332707ca410852a 100644
GIT binary patch
delta 19
acmdmNxY=++JmcgfMinN8#LcaYdg1^?7X{P+
delta 20
bcmdmNxY=++JR@@fL*nFkMwQKNjJo0gN@oT_
diff --git a/tests/data/acpi/pc/DSDT.ipmikcs b/tests/data/acpi/pc/DSDT.ipmikcs
index dd7135602709fc4a361930c74f9bebc6b32e6916..3c2aba132f10b5e4a9931877533a9d8f260b7381 100644
GIT binary patch
delta 19
acmZ2rw7_UXJmcgfMinN8#LcaYv&8{IX9gVr
delta 20
bcmZ2rw7_UXJR@@fL*nFkMwQKNjI+c6NRtMO
diff --git a/tests/data/acpi/pc/DSDT.memhp b/tests/data/acpi/pc/DSDT.memhp
index 2f895e9b385c1ae2f58c7ade4de02328b1be7356..811965f42d97adadde6e9ec6d6153e767041bc6d 100644
GIT binary patch
delta 19
acmZ2(v)pDwJmcgfMinN8#LcaYi(~*q$_7gS
delta 20
bcmZ2(v)pDwJR@@fL*nFkMwQKNj0<G|OBe>Z
diff --git a/tests/data/acpi/pc/DSDT.nohpet b/tests/data/acpi/pc/DSDT.nohpet
index c012b63ace2f359eec0368ed22ef507ee3905c78..bbf73023ade329770ff9f9ac5c897218764182b5 100644
GIT binary patch
delta 19
acmX?QaLQmqJmcgfMinN8#LcaYN5ue0UIvx`
delta 20
bcmX?QaLQmqJR@@fL*nFkMwQKNj7P)(PTB_q
diff --git a/tests/data/acpi/pc/DSDT.numamem b/tests/data/acpi/pc/DSDT.numamem
index f2ef4b97290cc58c514c3ce7fd45cb08214d7138..c5d93366a417ad1a92c01659f1db9c159caa7132 100644
GIT binary patch
delta 19
acmca-c+YS{JmcgfMinN8#LcaYk>UVKc?MMg
delta 20
bcmca-c+YS{JR@@fL*nFkMwQKNj1l4hQ6C1w
diff --git a/tests/data/acpi/pc/DSDT.roothp b/tests/data/acpi/pc/DSDT.roothp
index 657c8263f0c649abc806a67576fd74cb32af60c3..9e3d482366bd800cf987044801eebc814629b15b 100644
GIT binary patch
delta 19
acmbQ}Gtp;5JmcgfMinN8#LcaYJt_c0t_Cpx
delta 20
bcmbQ}Gtp;5JR@@fL*nFkMwQKNjNK{#N$>`r
diff --git a/tests/data/acpi/q35/DSDT b/tests/data/acpi/q35/DSDT
index d68c472b460e4609a64ea67de3c4cebfca76164d..c304e15e366d7317fd0e9db0a144f02e0437d7a1 100644
GIT binary patch
delta 19
acmdnvu*YG864PW=CKV=z#LXT|Ut|G790nW!
delta 20
bcmdnvu*YG85)*R)L*is5CY8;eOrK=|NfZW(
diff --git a/tests/data/acpi/q35/DSDT.acpierst b/tests/data/acpi/q35/DSDT.acpierst
index de7ae27125f9667d7aa7a7cc0e8210773b61a2e2..3aa5c4b3193d32bb8263a1fe06c05b714541c532 100644
GIT binary patch
delta 19
acmX@>aModi64PW=CKV=z#LXT|ta1QCqXkd^
delta 20
bcmX@>aModi5)*R)L*is5CY8;eOe}H$NxcQW
diff --git a/tests/data/acpi/q35/DSDT.acpihmat b/tests/data/acpi/q35/DSDT.acpihmat
index 48e2862257ac614b5fd6391c4ec425106c48afb1..3ffbf8f83f64144ace17ff5f06bcb4fec9df33d9 100644
GIT binary patch
delta 19
acmaFq_0nsD64PW=CKV=z#LXT|ipl^;Bn7<y
delta 20
bcmaFq_0nsD5)*R)L*is5CY8;eObW^XPl^UB
diff --git a/tests/data/acpi/q35/DSDT.acpihmat-noinitiator b/tests/data/acpi/q35/DSDT.acpihmat-noinitiator
index 30a4aa2ec8feb6012a64d476ff37b14717d20eaf..ebec32b575d310f98937fe9208f0c60349ca753d 100644
GIT binary patch
delta 19
acmccYblGWx64PW=CKV=z#LXT|-0}cJ%mrrv
delta 20
bcmccYblGWx5)*R)L*is5CY8;eOkDB+O7;cS
diff --git a/tests/data/acpi/q35/DSDT.applesmc b/tests/data/acpi/q35/DSDT.applesmc
index 84e2b5cbc4483ae93634f223160253231dcc4932..b0994644ec811b962e80f49e36e122967f5af1d1 100644
GIT binary patch
delta 19
acmaFm@XBF>64PW=CKV=z#LXT|N^$^3@dc*<
delta 20
bcmaFm@XBF>5)*R)L*is5CY8;eOp0;<PDKV4
diff --git a/tests/data/acpi/q35/DSDT.bridge b/tests/data/acpi/q35/DSDT.bridge
index e411d40fd1e297879d78dcf15486dd465ab54568..8e11b8ea4862c8ec27376703c9c43e9895ca60eb 100644
GIT binary patch
delta 19
acmcZ^c{6f@64PW=CKV=z#LXT|6SV+H$p$h2
delta 20
bcmcZ^c{6f@5)*R)L*is5CY8;eOcS&KP%Q?a
diff --git a/tests/data/acpi/q35/DSDT.core-count2 b/tests/data/acpi/q35/DSDT.core-count2
index 0603db8cc63cfc562f83e55eaf5162e7c29bf4d1..a895599c3c53c0cd0888ec166a30d6c036d26b93 100644
GIT binary patch
delta 21
ccmeD9%h>Ukaf1@mWK|{=CWge#9!w5309TO)+W-In
delta 22
dcmeD9%h>Ukaf1>Qa{)u*WF;n*&7Ms5H2`0o2T1?`
diff --git a/tests/data/acpi/q35/DSDT.cphp b/tests/data/acpi/q35/DSDT.cphp
index beeb83c33b385fc8b41d44f299b8d9ba7203d935..725998cb587c02ac963f290bac5c14d665bc85e9 100644
GIT binary patch
delta 19
acmeBi>2cYh#57rzNrj0aakB^05qSVRh6R=Y
delta 20
bcmeBi>2cYh#Kc^{kT_Y1NoBJq(_wi4LM8?T
diff --git a/tests/data/acpi/q35/DSDT.cxl b/tests/data/acpi/q35/DSDT.cxl
index 3d18b9672d124a0cf11a79e92c396a1b883d0589..04c2c66a25536854b4305787c8e0b41e96c3c133 100644
GIT binary patch
delta 19
acmaFm^~!6564PW=CKV=z#LXT|O3DC8N(I0G
delta 20
bcmaFm^~!655)*R)L*is5CY8;eOp3|?PqGFs
diff --git a/tests/data/acpi/q35/DSDT.dimmpxm b/tests/data/acpi/q35/DSDT.dimmpxm
index 99a93e12a7faac78e9524ad6758f42c5c0df18eb..ef643b4ee02cacb9a55f89b8e7f05524125515a1 100644
GIT binary patch
delta 19
acmdnwyUBNh64PW=CKV=z#LXT|St<ZQVFjN6
delta 20
bcmdnwyUBNh5)*R)L*is5CY8;eOqnVGNM8mG
diff --git a/tests/data/acpi/q35/DSDT.ipmibt b/tests/data/acpi/q35/DSDT.ipmibt
index 7f7601dbff820044aa646048c0bfe0e6324b9d0d..b136aea961c89a97db09db9b68809979564d8faf 100644
GIT binary patch
delta 19
acmZp7Y<JwC#57rzNrj0aakB@Ly&M2JVFdsH
delta 20
bcmZp7Y<JwC#Kc^{kT_Y1NoBJqlbsv@Kk)@_
diff --git a/tests/data/acpi/q35/DSDT.ipmismbus b/tests/data/acpi/q35/DSDT.ipmismbus
index 6c5d1afe443d9261d3b93801711f8d5b267696f3..0970dbd5896fc0038b1369dbbcc982ead7736ae6 100644
GIT binary patch
delta 19
acmbQ@IK^>;64PW=CKV=z#LXT|K5_s%PX#9c
delta 20
bcmbQ@IK^>;5)*R)L*is5CY8;eOx|(;LHPxh
diff --git a/tests/data/acpi/q35/DSDT.ivrs b/tests/data/acpi/q35/DSDT.ivrs
index de7ae27125f9667d7aa7a7cc0e8210773b61a2e2..3aa5c4b3193d32bb8263a1fe06c05b714541c532 100644
GIT binary patch
delta 19
acmX@>aModi64PW=CKV=z#LXT|ta1QCqXkd^
delta 20
bcmX@>aModi5)*R)L*is5CY8;eOe}H$NxcQW
diff --git a/tests/data/acpi/q35/DSDT.memhp b/tests/data/acpi/q35/DSDT.memhp
index 79bce5c8f0132e72b8e700488ea56c7593737810..9709e5a7a7edcb7509954b553f7bf29a424033db 100644
GIT binary patch
delta 19
acmeD7?)KiG#57rzNrj0aakB@LvoZiXQUxUd
delta 20
bcmeD7?)KiG#Kc^{kT_Y1NoBJqlan$4LH-4k
diff --git a/tests/data/acpi/q35/DSDT.mmio64 b/tests/data/acpi/q35/DSDT.mmio64
index c249929add97439ceb9f891d44c425311517ad18..e1cd01f2349bb8c2f7f8badad11441ffe6d57acc 100644
GIT binary patch
delta 19
acmZ4Hxy*Be64PW=CKV=z#LXT|aY_I`4+U`m
delta 20
bcmZ4Hxy*Be5)*R)L*is5CY8;eOtDG;MePOO
diff --git a/tests/data/acpi/q35/DSDT.multi-bridge b/tests/data/acpi/q35/DSDT.multi-bridge
index f2f60fdbb3b44ab9adb69bb36e4a80978536af9b..3b9dffb565833cc87bbf08dadfc1f31ac858e93b 100644
GIT binary patch
delta 19
acmZonYE0Uo#57rzNrj0aakB^0PCWoU?*+gB
delta 20
bcmZonYE0Uo#Kc^{kT_Y1NoBJq(+)iVM70Jk
diff --git a/tests/data/acpi/q35/DSDT.nohpet b/tests/data/acpi/q35/DSDT.nohpet
index 9ff9983a80a7487470ccd02ce587200444675816..2cf7f6db0fd8de357278f942a4082e714804dca9 100644
GIT binary patch
delta 19
acmZ2yzs`Px64PW=CKV=z#LXT|X|e!5<^^y7
delta 20
bcmZ2yzs`Px5)*R)L*is5CY8;eOsTQ}MZg8#
diff --git a/tests/data/acpi/q35/DSDT.numamem b/tests/data/acpi/q35/DSDT.numamem
index 1e7c45ef3ccb000a06f64152622b4bd27916d181..310e3d5053b90863f96c29dd69a514b4999b4a19 100644
GIT binary patch
delta 19
acmX@)aL8eU64PW=CKV=z#LXT|zhnVJ00u4q
delta 20
bcmX@)aL8eU5)*R)L*is5CY8;eOh07-N(2U+
diff --git a/tests/data/acpi/q35/DSDT.pvpanic-isa b/tests/data/acpi/q35/DSDT.pvpanic-isa
index ed47451c44e3041e5b7fed55de7b6ef1aca54350..6672b6fa05c8ee30a8ea4ab0931d59c1315a4e9c 100644
GIT binary patch
delta 19
acmZ4JxX^Kf64PW=CKV=z#LXT|k#Yb%Jq1nx
delta 20
bcmZ4JxX^Kf5)*R)L*is5CY8;eOc8PbL;(f7
diff --git a/tests/data/acpi/q35/DSDT.tis.tpm12 b/tests/data/acpi/q35/DSDT.tis.tpm12
index efc2efc19f00ca7564467756616da44f5fd71cfe..eae2dc599331516e11632356f05d7831d1fa1e6a 100644
GIT binary patch
delta 19
acmbQ`I?Hu~64PW=CKV=z#LXT|K?(poy#+%6
delta 20
bcmbQ`I?Hu~5)*R)L*is5CY8;eOo0jjLwg0W
diff --git a/tests/data/acpi/q35/DSDT.tis.tpm2 b/tests/data/acpi/q35/DSDT.tis.tpm2
index 675339715f72b4400445ce8c0dd12f416aa0efb0..68c6a7d244cfc78efa6b9cd1385f2134ca149ad7 100644
GIT binary patch
delta 19
acmdnuy2W*a64PW=CKV=z#LXT|ISK$knFWym
delta 20
bcmdnuy2W*a5)*R)L*is5CY8;eOxX$mM~emj
diff --git a/tests/data/acpi/q35/DSDT.viot b/tests/data/acpi/q35/DSDT.viot
index eeb40b360f7c1de93501e1ddcd7dab306a51113b..4d2937a87c4a39993eaa756f02d59ef35a08f1c2 100644
GIT binary patch
delta 118
zcmbQ}xzLl#CD<iop$Y>7Bf~~6A4W#e$>EGUg}4G-f_-@x_^?gRVki(~W@Jd1tjeTf
z%#c{%=;;#C+>yh;03;Y0k`^dUs-2v~Fgc0mKM*j~CNd`0CRQ?Xu`@tu*2#rT1{@36
QCuec7E@9lfkm-XW0I$^}K>z>%
delta 101
zcmZ4JInk5LCD<ioq6z~8qtiw%A4W!z$>EGUML7dpf_-@xxUfymVki(~W@JbxU`U*-
z#H6C(=;;#C+>yh;03;Y0k`_o!s-2v~Fgc0mKM*j~CNd`0CRQ?Xu}`jKGT6M4>4PEw
DoVXuG
diff --git a/tests/data/acpi/q35/DSDT.xapic b/tests/data/acpi/q35/DSDT.xapic
index 3aa86f07243f0449c7dc245650715d729744e3ee..e9b4881bdc72eb7c59dcf258c1a98363b46bfbcd 100644
GIT binary patch
delta 21
dcmbO~jcNWgrVUC=lU12im>3c_doW$^002#l2H*ey
delta 22
ecmbO~jcNWgrVUC=%moaIla-iMHhVH%>i_^$`Ug$`
--
2.39.1
^ permalink raw reply related [flat|nested] 46+ messages in thread* Re: [PATCH 14/33] tests: acpi: update expected blobs
2023-02-24 15:37 ` [PATCH 14/33] tests: acpi: update expected blobs Igor Mammedov
@ 2023-03-02 0:27 ` Michael S. Tsirkin
2023-03-02 12:02 ` Igor Mammedov
2023-03-02 0:37 ` Michael S. Tsirkin
1 sibling, 1 reply; 46+ messages in thread
From: Michael S. Tsirkin @ 2023-03-02 0:27 UTC (permalink / raw)
To: Igor Mammedov; +Cc: qemu-devel, ani, berrange
On Fri, Feb 24, 2023 at 04:37:53PM +0100, Igor Mammedov wrote:
> only following context change:
> - Local1 = Zero
> If ((Arg0 != ToUUID ("e5c937d0-3553-4d7a-9117-ea4d19c3434d") /* Device Labeling Interface */))
> {
> Return (Local0)
> ...
> Return (Local0)
> }
>
> + Local1 = Zero
> Local2 = AIDX (DerefOf (Arg4 [Zero]), DerefOf (Arg4 [One]
>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Nope:
diff -ru -N -IDisassembly -IChecksum '-I* Length ' old/asl/tests/data/acpi/q35/DSDT.viot.dsl new/asl/tests/data/acpi/q35/DSDT.viot.dsl
:--- old/asl/tests/data/acpi/q35/DSDT.viot.dsl 2023-03-01 19:22:57.636454958 -0500
:+++ new/asl/tests/data/acpi/q35/DSDT.viot.dsl 2023-03-01 19:22:58.451460462 -0500
:@@ -148,7 +148,6 @@
{
0x00 // .
}
- Local1 = Zero
If ((Arg0 != ToUUID ("e5c937d0-3553-4d7a-9117-ea4d19c3434d") /* Device Labeling Interface */))
{
Return (Local0)
:@@ -159,12 +158,14 @@
Return (Local0)
}
+ Local1 = Zero
Local2 = AIDX (DerefOf (Arg4 [Zero]), DerefOf (Arg4 [One]
))
If (!((Local2 == Zero) | (Local2 == 0xFFFFFFFF)))
{
Local1 |= One
Local1 |= (One << 0x07)
+ Local1 |= (One << 0x05)
}
Local0 [Zero] = Local1
and the funny thing is, the second change is in the expected
file but not in the code so this patch causes the test to fail.
> ---
> tests/qtest/bios-tables-test-allowed-diff.h | 35 ------------------
> tests/data/acpi/pc/DSDT | Bin 6360 -> 6360 bytes
> tests/data/acpi/pc/DSDT.acpierst | Bin 6283 -> 6283 bytes
> tests/data/acpi/pc/DSDT.acpihmat | Bin 7685 -> 7685 bytes
> tests/data/acpi/pc/DSDT.bridge | Bin 12487 -> 12487 bytes
> tests/data/acpi/pc/DSDT.cphp | Bin 6824 -> 6824 bytes
> tests/data/acpi/pc/DSDT.dimmpxm | Bin 8014 -> 8014 bytes
> tests/data/acpi/pc/DSDT.hpbridge | Bin 6323 -> 6323 bytes
> tests/data/acpi/pc/DSDT.ipmikcs | Bin 6432 -> 6432 bytes
> tests/data/acpi/pc/DSDT.memhp | Bin 7719 -> 7719 bytes
> tests/data/acpi/pc/DSDT.nohpet | Bin 6218 -> 6218 bytes
> tests/data/acpi/pc/DSDT.numamem | Bin 6366 -> 6366 bytes
> tests/data/acpi/pc/DSDT.roothp | Bin 9745 -> 9745 bytes
> tests/data/acpi/q35/DSDT | Bin 8252 -> 8252 bytes
> tests/data/acpi/q35/DSDT.acpierst | Bin 8269 -> 8269 bytes
> tests/data/acpi/q35/DSDT.acpihmat | Bin 9577 -> 9577 bytes
> tests/data/acpi/q35/DSDT.acpihmat-noinitiator | Bin 8531 -> 8531 bytes
> tests/data/acpi/q35/DSDT.applesmc | Bin 8298 -> 8298 bytes
> tests/data/acpi/q35/DSDT.bridge | Bin 11481 -> 11481 bytes
> tests/data/acpi/q35/DSDT.core-count2 | Bin 32392 -> 32392 bytes
> tests/data/acpi/q35/DSDT.cphp | Bin 8716 -> 8716 bytes
> tests/data/acpi/q35/DSDT.cxl | Bin 9578 -> 9578 bytes
> tests/data/acpi/q35/DSDT.dimmpxm | Bin 9906 -> 9906 bytes
> tests/data/acpi/q35/DSDT.ipmibt | Bin 8327 -> 8327 bytes
> tests/data/acpi/q35/DSDT.ipmismbus | Bin 8340 -> 8340 bytes
> tests/data/acpi/q35/DSDT.ivrs | Bin 8269 -> 8269 bytes
> tests/data/acpi/q35/DSDT.memhp | Bin 9611 -> 9611 bytes
> tests/data/acpi/q35/DSDT.mmio64 | Bin 9382 -> 9382 bytes
> tests/data/acpi/q35/DSDT.multi-bridge | Bin 12545 -> 12545 bytes
> tests/data/acpi/q35/DSDT.nohpet | Bin 8110 -> 8110 bytes
> tests/data/acpi/q35/DSDT.numamem | Bin 8258 -> 8258 bytes
> tests/data/acpi/q35/DSDT.pvpanic-isa | Bin 8353 -> 8353 bytes
> tests/data/acpi/q35/DSDT.tis.tpm12 | Bin 8858 -> 8858 bytes
> tests/data/acpi/q35/DSDT.tis.tpm2 | Bin 8884 -> 8884 bytes
> tests/data/acpi/q35/DSDT.viot | Bin 9361 -> 9377 bytes
> tests/data/acpi/q35/DSDT.xapic | Bin 35615 -> 35615 bytes
> 36 files changed, 35 deletions(-)
>
> diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
> index 7e7745db39..dfb8523c8b 100644
> --- a/tests/qtest/bios-tables-test-allowed-diff.h
> +++ b/tests/qtest/bios-tables-test-allowed-diff.h
> @@ -1,36 +1 @@
> /* List of comma-separated changed AML files to ignore */
> -"tests/data/acpi/pc/DSDT",
> -"tests/data/acpi/pc/DSDT.acpierst",
> -"tests/data/acpi/pc/DSDT.acpihmat",
> -"tests/data/acpi/pc/DSDT.bridge",
> -"tests/data/acpi/pc/DSDT.cphp",
> -"tests/data/acpi/pc/DSDT.dimmpxm",
> -"tests/data/acpi/pc/DSDT.hpbridge",
> -"tests/data/acpi/pc/DSDT.ipmikcs",
> -"tests/data/acpi/pc/DSDT.memhp",
> -"tests/data/acpi/pc/DSDT.nohpet",
> -"tests/data/acpi/pc/DSDT.numamem",
> -"tests/data/acpi/pc/DSDT.roothp",
> -"tests/data/acpi/q35/DSDT",
> -"tests/data/acpi/q35/DSDT.acpierst",
> -"tests/data/acpi/q35/DSDT.acpihmat",
> -"tests/data/acpi/q35/DSDT.acpihmat-noinitiator",
> -"tests/data/acpi/q35/DSDT.applesmc",
> -"tests/data/acpi/q35/DSDT.bridge",
> -"tests/data/acpi/q35/DSDT.core-count2",
> -"tests/data/acpi/q35/DSDT.cphp",
> -"tests/data/acpi/q35/DSDT.cxl",
> -"tests/data/acpi/q35/DSDT.dimmpxm",
> -"tests/data/acpi/q35/DSDT.ipmibt",
> -"tests/data/acpi/q35/DSDT.ipmismbus",
> -"tests/data/acpi/q35/DSDT.ivrs",
> -"tests/data/acpi/q35/DSDT.memhp",
> -"tests/data/acpi/q35/DSDT.mmio64",
> -"tests/data/acpi/q35/DSDT.multi-bridge",
> -"tests/data/acpi/q35/DSDT.nohpet",
> -"tests/data/acpi/q35/DSDT.numamem",
> -"tests/data/acpi/q35/DSDT.pvpanic-isa",
> -"tests/data/acpi/q35/DSDT.tis.tpm12",
> -"tests/data/acpi/q35/DSDT.tis.tpm2",
> -"tests/data/acpi/q35/DSDT.viot",
> -"tests/data/acpi/q35/DSDT.xapic",
> diff --git a/tests/data/acpi/pc/DSDT b/tests/data/acpi/pc/DSDT
> index 0b475fb5a966543fef2cd7672a0b198838a63151..ec133a6d3aabcfd22b7b46019338db2de255da70 100644
> GIT binary patch
> delta 19
> acmca%c*Af*JmcgfMinN8#LcaY!Quc(l?Foq
>
> delta 20
> bcmca%c*Af*JR@@fL*nFkMwQKNj6vc6P%j3t
>
> diff --git a/tests/data/acpi/pc/DSDT.acpierst b/tests/data/acpi/pc/DSDT.acpierst
> index 17ef7caeb6fe4445f1234ff060c3db6809184ef6..2b4b7f31919f360e038e37de713639da753f13aa 100644
> GIT binary patch
> delta 19
> acmeA+>^9sG&p0`WQH6;iadRspn>YYICk0#p
>
> delta 20
> bcmeA+>^9sG&&XWBkT^M>QDt)*Bda(7L?;Ex
>
> diff --git a/tests/data/acpi/pc/DSDT.acpihmat b/tests/data/acpi/pc/DSDT.acpihmat
> index 675b674eaa92d99513ac243a97064d369791ee53..714a123e7a500cf0f862ff6c4e9a3f50a96af056 100644
> GIT binary patch
> delta 19
> acmZp*X|>r9&p0`WQH6;iadRtUgA4#az6Ip~
>
> delta 20
> bcmZp*X|>r9&&XWBkT^M>QDt)*W4#OjMaTwI
>
> diff --git a/tests/data/acpi/pc/DSDT.bridge b/tests/data/acpi/pc/DSDT.bridge
> index c1ce06136619f55c084a34c51997c059c29cb06a..6c0543cf75ad3e02468ed4925fd3369a183e9b45 100644
> GIT binary patch
> delta 19
> acmX?}csy}KJmcgfMinN8#LcaYPWk{%hX#lM
>
> delta 20
> bcmX?}csy}KJR@@fL*nFkMwQKNjE?#MR9^=6
>
> diff --git a/tests/data/acpi/pc/DSDT.cphp b/tests/data/acpi/pc/DSDT.cphp
> index 754ab854dc48fc1af2d335e7269c23a056e66eb8..e1bcb0a4f3ee1269bdd5e949206b40d0e3c076e6 100644
> GIT binary patch
> delta 19
> acmZ2sy25lrJmcgfMinN8#LcaY%8~#={{_7O
>
> delta 20
> bcmZ2sy25lrJR@@fL*nFkMwQKNj7pLKNkIlH
>
> diff --git a/tests/data/acpi/pc/DSDT.dimmpxm b/tests/data/acpi/pc/DSDT.dimmpxm
> index 170503336b3fd94cc7a4356003fa080f0ef57b01..1c90e119c5d3dc7e86d04942114e5cfe40de6039 100644
> GIT binary patch
> delta 19
> acmX?Scg}7@JmcgfMinN8#LcaYCuIRj*#^Y`
>
> delta 20
> bcmX?Scg}7@JR@@fL*nFkMwQKNj3;CPQF#Y5
>
> diff --git a/tests/data/acpi/pc/DSDT.hpbridge b/tests/data/acpi/pc/DSDT.hpbridge
> index 5dea100bc9492bb2367aac8660522201785c1efb..04e1c20f63be7c6c574e72590332707ca410852a 100644
> GIT binary patch
> delta 19
> acmdmNxY=++JmcgfMinN8#LcaYdg1^?7X{P+
>
> delta 20
> bcmdmNxY=++JR@@fL*nFkMwQKNjJo0gN@oT_
>
> diff --git a/tests/data/acpi/pc/DSDT.ipmikcs b/tests/data/acpi/pc/DSDT.ipmikcs
> index dd7135602709fc4a361930c74f9bebc6b32e6916..3c2aba132f10b5e4a9931877533a9d8f260b7381 100644
> GIT binary patch
> delta 19
> acmZ2rw7_UXJmcgfMinN8#LcaYv&8{IX9gVr
>
> delta 20
> bcmZ2rw7_UXJR@@fL*nFkMwQKNjI+c6NRtMO
>
> diff --git a/tests/data/acpi/pc/DSDT.memhp b/tests/data/acpi/pc/DSDT.memhp
> index 2f895e9b385c1ae2f58c7ade4de02328b1be7356..811965f42d97adadde6e9ec6d6153e767041bc6d 100644
> GIT binary patch
> delta 19
> acmZ2(v)pDwJmcgfMinN8#LcaYi(~*q$_7gS
>
> delta 20
> bcmZ2(v)pDwJR@@fL*nFkMwQKNj0<G|OBe>Z
>
> diff --git a/tests/data/acpi/pc/DSDT.nohpet b/tests/data/acpi/pc/DSDT.nohpet
> index c012b63ace2f359eec0368ed22ef507ee3905c78..bbf73023ade329770ff9f9ac5c897218764182b5 100644
> GIT binary patch
> delta 19
> acmX?QaLQmqJmcgfMinN8#LcaYN5ue0UIvx`
>
> delta 20
> bcmX?QaLQmqJR@@fL*nFkMwQKNj7P)(PTB_q
>
> diff --git a/tests/data/acpi/pc/DSDT.numamem b/tests/data/acpi/pc/DSDT.numamem
> index f2ef4b97290cc58c514c3ce7fd45cb08214d7138..c5d93366a417ad1a92c01659f1db9c159caa7132 100644
> GIT binary patch
> delta 19
> acmca-c+YS{JmcgfMinN8#LcaYk>UVKc?MMg
>
> delta 20
> bcmca-c+YS{JR@@fL*nFkMwQKNj1l4hQ6C1w
>
> diff --git a/tests/data/acpi/pc/DSDT.roothp b/tests/data/acpi/pc/DSDT.roothp
> index 657c8263f0c649abc806a67576fd74cb32af60c3..9e3d482366bd800cf987044801eebc814629b15b 100644
> GIT binary patch
> delta 19
> acmbQ}Gtp;5JmcgfMinN8#LcaYJt_c0t_Cpx
>
> delta 20
> bcmbQ}Gtp;5JR@@fL*nFkMwQKNjNK{#N$>`r
>
> diff --git a/tests/data/acpi/q35/DSDT b/tests/data/acpi/q35/DSDT
> index d68c472b460e4609a64ea67de3c4cebfca76164d..c304e15e366d7317fd0e9db0a144f02e0437d7a1 100644
> GIT binary patch
> delta 19
> acmdnvu*YG864PW=CKV=z#LXT|Ut|G790nW!
>
> delta 20
> bcmdnvu*YG85)*R)L*is5CY8;eOrK=|NfZW(
>
> diff --git a/tests/data/acpi/q35/DSDT.acpierst b/tests/data/acpi/q35/DSDT.acpierst
> index de7ae27125f9667d7aa7a7cc0e8210773b61a2e2..3aa5c4b3193d32bb8263a1fe06c05b714541c532 100644
> GIT binary patch
> delta 19
> acmX@>aModi64PW=CKV=z#LXT|ta1QCqXkd^
>
> delta 20
> bcmX@>aModi5)*R)L*is5CY8;eOe}H$NxcQW
>
> diff --git a/tests/data/acpi/q35/DSDT.acpihmat b/tests/data/acpi/q35/DSDT.acpihmat
> index 48e2862257ac614b5fd6391c4ec425106c48afb1..3ffbf8f83f64144ace17ff5f06bcb4fec9df33d9 100644
> GIT binary patch
> delta 19
> acmaFq_0nsD64PW=CKV=z#LXT|ipl^;Bn7<y
>
> delta 20
> bcmaFq_0nsD5)*R)L*is5CY8;eObW^XPl^UB
>
> diff --git a/tests/data/acpi/q35/DSDT.acpihmat-noinitiator b/tests/data/acpi/q35/DSDT.acpihmat-noinitiator
> index 30a4aa2ec8feb6012a64d476ff37b14717d20eaf..ebec32b575d310f98937fe9208f0c60349ca753d 100644
> GIT binary patch
> delta 19
> acmccYblGWx64PW=CKV=z#LXT|-0}cJ%mrrv
>
> delta 20
> bcmccYblGWx5)*R)L*is5CY8;eOkDB+O7;cS
>
> diff --git a/tests/data/acpi/q35/DSDT.applesmc b/tests/data/acpi/q35/DSDT.applesmc
> index 84e2b5cbc4483ae93634f223160253231dcc4932..b0994644ec811b962e80f49e36e122967f5af1d1 100644
> GIT binary patch
> delta 19
> acmaFm@XBF>64PW=CKV=z#LXT|N^$^3@dc*<
>
> delta 20
> bcmaFm@XBF>5)*R)L*is5CY8;eOp0;<PDKV4
>
> diff --git a/tests/data/acpi/q35/DSDT.bridge b/tests/data/acpi/q35/DSDT.bridge
> index e411d40fd1e297879d78dcf15486dd465ab54568..8e11b8ea4862c8ec27376703c9c43e9895ca60eb 100644
> GIT binary patch
> delta 19
> acmcZ^c{6f@64PW=CKV=z#LXT|6SV+H$p$h2
>
> delta 20
> bcmcZ^c{6f@5)*R)L*is5CY8;eOcS&KP%Q?a
>
> diff --git a/tests/data/acpi/q35/DSDT.core-count2 b/tests/data/acpi/q35/DSDT.core-count2
> index 0603db8cc63cfc562f83e55eaf5162e7c29bf4d1..a895599c3c53c0cd0888ec166a30d6c036d26b93 100644
> GIT binary patch
> delta 21
> ccmeD9%h>Ukaf1@mWK|{=CWge#9!w5309TO)+W-In
>
> delta 22
> dcmeD9%h>Ukaf1>Qa{)u*WF;n*&7Ms5H2`0o2T1?`
>
> diff --git a/tests/data/acpi/q35/DSDT.cphp b/tests/data/acpi/q35/DSDT.cphp
> index beeb83c33b385fc8b41d44f299b8d9ba7203d935..725998cb587c02ac963f290bac5c14d665bc85e9 100644
> GIT binary patch
> delta 19
> acmeBi>2cYh#57rzNrj0aakB^05qSVRh6R=Y
>
> delta 20
> bcmeBi>2cYh#Kc^{kT_Y1NoBJq(_wi4LM8?T
>
> diff --git a/tests/data/acpi/q35/DSDT.cxl b/tests/data/acpi/q35/DSDT.cxl
> index 3d18b9672d124a0cf11a79e92c396a1b883d0589..04c2c66a25536854b4305787c8e0b41e96c3c133 100644
> GIT binary patch
> delta 19
> acmaFm^~!6564PW=CKV=z#LXT|O3DC8N(I0G
>
> delta 20
> bcmaFm^~!655)*R)L*is5CY8;eOp3|?PqGFs
>
> diff --git a/tests/data/acpi/q35/DSDT.dimmpxm b/tests/data/acpi/q35/DSDT.dimmpxm
> index 99a93e12a7faac78e9524ad6758f42c5c0df18eb..ef643b4ee02cacb9a55f89b8e7f05524125515a1 100644
> GIT binary patch
> delta 19
> acmdnwyUBNh64PW=CKV=z#LXT|St<ZQVFjN6
>
> delta 20
> bcmdnwyUBNh5)*R)L*is5CY8;eOqnVGNM8mG
>
> diff --git a/tests/data/acpi/q35/DSDT.ipmibt b/tests/data/acpi/q35/DSDT.ipmibt
> index 7f7601dbff820044aa646048c0bfe0e6324b9d0d..b136aea961c89a97db09db9b68809979564d8faf 100644
> GIT binary patch
> delta 19
> acmZp7Y<JwC#57rzNrj0aakB@Ly&M2JVFdsH
>
> delta 20
> bcmZp7Y<JwC#Kc^{kT_Y1NoBJqlbsv@Kk)@_
>
> diff --git a/tests/data/acpi/q35/DSDT.ipmismbus b/tests/data/acpi/q35/DSDT.ipmismbus
> index 6c5d1afe443d9261d3b93801711f8d5b267696f3..0970dbd5896fc0038b1369dbbcc982ead7736ae6 100644
> GIT binary patch
> delta 19
> acmbQ@IK^>;64PW=CKV=z#LXT|K5_s%PX#9c
>
> delta 20
> bcmbQ@IK^>;5)*R)L*is5CY8;eOx|(;LHPxh
>
> diff --git a/tests/data/acpi/q35/DSDT.ivrs b/tests/data/acpi/q35/DSDT.ivrs
> index de7ae27125f9667d7aa7a7cc0e8210773b61a2e2..3aa5c4b3193d32bb8263a1fe06c05b714541c532 100644
> GIT binary patch
> delta 19
> acmX@>aModi64PW=CKV=z#LXT|ta1QCqXkd^
>
> delta 20
> bcmX@>aModi5)*R)L*is5CY8;eOe}H$NxcQW
>
> diff --git a/tests/data/acpi/q35/DSDT.memhp b/tests/data/acpi/q35/DSDT.memhp
> index 79bce5c8f0132e72b8e700488ea56c7593737810..9709e5a7a7edcb7509954b553f7bf29a424033db 100644
> GIT binary patch
> delta 19
> acmeD7?)KiG#57rzNrj0aakB@LvoZiXQUxUd
>
> delta 20
> bcmeD7?)KiG#Kc^{kT_Y1NoBJqlan$4LH-4k
>
> diff --git a/tests/data/acpi/q35/DSDT.mmio64 b/tests/data/acpi/q35/DSDT.mmio64
> index c249929add97439ceb9f891d44c425311517ad18..e1cd01f2349bb8c2f7f8badad11441ffe6d57acc 100644
> GIT binary patch
> delta 19
> acmZ4Hxy*Be64PW=CKV=z#LXT|aY_I`4+U`m
>
> delta 20
> bcmZ4Hxy*Be5)*R)L*is5CY8;eOtDG;MePOO
>
> diff --git a/tests/data/acpi/q35/DSDT.multi-bridge b/tests/data/acpi/q35/DSDT.multi-bridge
> index f2f60fdbb3b44ab9adb69bb36e4a80978536af9b..3b9dffb565833cc87bbf08dadfc1f31ac858e93b 100644
> GIT binary patch
> delta 19
> acmZonYE0Uo#57rzNrj0aakB^0PCWoU?*+gB
>
> delta 20
> bcmZonYE0Uo#Kc^{kT_Y1NoBJq(+)iVM70Jk
>
> diff --git a/tests/data/acpi/q35/DSDT.nohpet b/tests/data/acpi/q35/DSDT.nohpet
> index 9ff9983a80a7487470ccd02ce587200444675816..2cf7f6db0fd8de357278f942a4082e714804dca9 100644
> GIT binary patch
> delta 19
> acmZ2yzs`Px64PW=CKV=z#LXT|X|e!5<^^y7
>
> delta 20
> bcmZ2yzs`Px5)*R)L*is5CY8;eOsTQ}MZg8#
>
> diff --git a/tests/data/acpi/q35/DSDT.numamem b/tests/data/acpi/q35/DSDT.numamem
> index 1e7c45ef3ccb000a06f64152622b4bd27916d181..310e3d5053b90863f96c29dd69a514b4999b4a19 100644
> GIT binary patch
> delta 19
> acmX@)aL8eU64PW=CKV=z#LXT|zhnVJ00u4q
>
> delta 20
> bcmX@)aL8eU5)*R)L*is5CY8;eOh07-N(2U+
>
> diff --git a/tests/data/acpi/q35/DSDT.pvpanic-isa b/tests/data/acpi/q35/DSDT.pvpanic-isa
> index ed47451c44e3041e5b7fed55de7b6ef1aca54350..6672b6fa05c8ee30a8ea4ab0931d59c1315a4e9c 100644
> GIT binary patch
> delta 19
> acmZ4JxX^Kf64PW=CKV=z#LXT|k#Yb%Jq1nx
>
> delta 20
> bcmZ4JxX^Kf5)*R)L*is5CY8;eOc8PbL;(f7
>
> diff --git a/tests/data/acpi/q35/DSDT.tis.tpm12 b/tests/data/acpi/q35/DSDT.tis.tpm12
> index efc2efc19f00ca7564467756616da44f5fd71cfe..eae2dc599331516e11632356f05d7831d1fa1e6a 100644
> GIT binary patch
> delta 19
> acmbQ`I?Hu~64PW=CKV=z#LXT|K?(poy#+%6
>
> delta 20
> bcmbQ`I?Hu~5)*R)L*is5CY8;eOo0jjLwg0W
>
> diff --git a/tests/data/acpi/q35/DSDT.tis.tpm2 b/tests/data/acpi/q35/DSDT.tis.tpm2
> index 675339715f72b4400445ce8c0dd12f416aa0efb0..68c6a7d244cfc78efa6b9cd1385f2134ca149ad7 100644
> GIT binary patch
> delta 19
> acmdnuy2W*a64PW=CKV=z#LXT|ISK$knFWym
>
> delta 20
> bcmdnuy2W*a5)*R)L*is5CY8;eOxX$mM~emj
>
> diff --git a/tests/data/acpi/q35/DSDT.viot b/tests/data/acpi/q35/DSDT.viot
> index eeb40b360f7c1de93501e1ddcd7dab306a51113b..4d2937a87c4a39993eaa756f02d59ef35a08f1c2 100644
> GIT binary patch
> delta 118
> zcmbQ}xzLl#CD<iop$Y>7Bf~~6A4W#e$>EGUg}4G-f_-@x_^?gRVki(~W@Jd1tjeTf
> z%#c{%=;;#C+>yh;03;Y0k`^dUs-2v~Fgc0mKM*j~CNd`0CRQ?Xu`@tu*2#rT1{@36
> QCuec7E@9lfkm-XW0I$^}K>z>%
>
> delta 101
> zcmZ4JInk5LCD<ioq6z~8qtiw%A4W!z$>EGUML7dpf_-@xxUfymVki(~W@JbxU`U*-
> z#H6C(=;;#C+>yh;03;Y0k`_o!s-2v~Fgc0mKM*j~CNd`0CRQ?Xu}`jKGT6M4>4PEw
> DoVXuG
>
> diff --git a/tests/data/acpi/q35/DSDT.xapic b/tests/data/acpi/q35/DSDT.xapic
> index 3aa86f07243f0449c7dc245650715d729744e3ee..e9b4881bdc72eb7c59dcf258c1a98363b46bfbcd 100644
> GIT binary patch
> delta 21
> dcmbO~jcNWgrVUC=lU12im>3c_doW$^002#l2H*ey
>
> delta 22
> ecmbO~jcNWgrVUC=%moaIla-iMHhVH%>i_^$`Ug$`
>
> --
> 2.39.1
^ permalink raw reply [flat|nested] 46+ messages in thread* Re: [PATCH 14/33] tests: acpi: update expected blobs
2023-03-02 0:27 ` Michael S. Tsirkin
@ 2023-03-02 12:02 ` Igor Mammedov
2023-03-02 12:55 ` Fabiano Rosas
0 siblings, 1 reply; 46+ messages in thread
From: Igor Mammedov @ 2023-03-02 12:02 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: qemu-devel, ani, berrange, farosas, thuth
On Wed, 1 Mar 2023 19:27:33 -0500
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> On Fri, Feb 24, 2023 at 04:37:53PM +0100, Igor Mammedov wrote:
> > only following context change:
> > - Local1 = Zero
> > If ((Arg0 != ToUUID ("e5c937d0-3553-4d7a-9117-ea4d19c3434d") /* Device Labeling Interface */))
> > {
> > Return (Local0)
> > ...
> > Return (Local0)
> > }
> >
> > + Local1 = Zero
> > Local2 = AIDX (DerefOf (Arg4 [Zero]), DerefOf (Arg4 [One]
> >
> > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
>
> Nope:
>
> diff -ru -N -IDisassembly -IChecksum '-I* Length ' old/asl/tests/data/acpi/q35/DSDT.viot.dsl new/asl/tests/data/acpi/q35/DSDT.viot.dsl
> :--- old/asl/tests/data/acpi/q35/DSDT.viot.dsl 2023-03-01 19:22:57.636454958 -0500
> :+++ new/asl/tests/data/acpi/q35/DSDT.viot.dsl 2023-03-01 19:22:58.451460462 -0500
> :@@ -148,7 +148,6 @@
> {
> 0x00 // .
> }
> - Local1 = Zero
> If ((Arg0 != ToUUID ("e5c937d0-3553-4d7a-9117-ea4d19c3434d") /* Device Labeling Interface */))
> {
> Return (Local0)
> :@@ -159,12 +158,14 @@
> Return (Local0)
> }
>
> + Local1 = Zero
> Local2 = AIDX (DerefOf (Arg4 [Zero]), DerefOf (Arg4 [One]
> ))
> If (!((Local2 == Zero) | (Local2 == 0xFFFFFFFF)))
> {
> Local1 |= One
> Local1 |= (One << 0x07)
> + Local1 |= (One << 0x05)
> }
>
> Local0 [Zero] = Local1
>
>
> and the funny thing is, the second change is in the expected
> file but not in the code so this patch causes the test to fail.
above diff is remnants of some old version of the patch before
patches were reshuffled.
for some reason q35/viot test gets skipped => no table rebuild => stale DSDT.viot table
reverting recently merged commit c471eb4f40, I can get q35/viot test back:
commit c471eb4f40445908c1be7bb11a37ac676a0edae7
Author: Fabiano Rosas <farosas@suse.de>
Date: Wed Feb 8 16:46:57 2023 -0300
tests/qtest: Check for devices in bios-tables-test
so checks aren't working as expected on my host for some reason
>
>
> > ---
> > tests/qtest/bios-tables-test-allowed-diff.h | 35 ------------------
> > tests/data/acpi/pc/DSDT | Bin 6360 -> 6360 bytes
> > tests/data/acpi/pc/DSDT.acpierst | Bin 6283 -> 6283 bytes
> > tests/data/acpi/pc/DSDT.acpihmat | Bin 7685 -> 7685 bytes
> > tests/data/acpi/pc/DSDT.bridge | Bin 12487 -> 12487 bytes
> > tests/data/acpi/pc/DSDT.cphp | Bin 6824 -> 6824 bytes
> > tests/data/acpi/pc/DSDT.dimmpxm | Bin 8014 -> 8014 bytes
> > tests/data/acpi/pc/DSDT.hpbridge | Bin 6323 -> 6323 bytes
> > tests/data/acpi/pc/DSDT.ipmikcs | Bin 6432 -> 6432 bytes
> > tests/data/acpi/pc/DSDT.memhp | Bin 7719 -> 7719 bytes
> > tests/data/acpi/pc/DSDT.nohpet | Bin 6218 -> 6218 bytes
> > tests/data/acpi/pc/DSDT.numamem | Bin 6366 -> 6366 bytes
> > tests/data/acpi/pc/DSDT.roothp | Bin 9745 -> 9745 bytes
> > tests/data/acpi/q35/DSDT | Bin 8252 -> 8252 bytes
> > tests/data/acpi/q35/DSDT.acpierst | Bin 8269 -> 8269 bytes
> > tests/data/acpi/q35/DSDT.acpihmat | Bin 9577 -> 9577 bytes
> > tests/data/acpi/q35/DSDT.acpihmat-noinitiator | Bin 8531 -> 8531 bytes
> > tests/data/acpi/q35/DSDT.applesmc | Bin 8298 -> 8298 bytes
> > tests/data/acpi/q35/DSDT.bridge | Bin 11481 -> 11481 bytes
> > tests/data/acpi/q35/DSDT.core-count2 | Bin 32392 -> 32392 bytes
> > tests/data/acpi/q35/DSDT.cphp | Bin 8716 -> 8716 bytes
> > tests/data/acpi/q35/DSDT.cxl | Bin 9578 -> 9578 bytes
> > tests/data/acpi/q35/DSDT.dimmpxm | Bin 9906 -> 9906 bytes
> > tests/data/acpi/q35/DSDT.ipmibt | Bin 8327 -> 8327 bytes
> > tests/data/acpi/q35/DSDT.ipmismbus | Bin 8340 -> 8340 bytes
> > tests/data/acpi/q35/DSDT.ivrs | Bin 8269 -> 8269 bytes
> > tests/data/acpi/q35/DSDT.memhp | Bin 9611 -> 9611 bytes
> > tests/data/acpi/q35/DSDT.mmio64 | Bin 9382 -> 9382 bytes
> > tests/data/acpi/q35/DSDT.multi-bridge | Bin 12545 -> 12545 bytes
> > tests/data/acpi/q35/DSDT.nohpet | Bin 8110 -> 8110 bytes
> > tests/data/acpi/q35/DSDT.numamem | Bin 8258 -> 8258 bytes
> > tests/data/acpi/q35/DSDT.pvpanic-isa | Bin 8353 -> 8353 bytes
> > tests/data/acpi/q35/DSDT.tis.tpm12 | Bin 8858 -> 8858 bytes
> > tests/data/acpi/q35/DSDT.tis.tpm2 | Bin 8884 -> 8884 bytes
> > tests/data/acpi/q35/DSDT.viot | Bin 9361 -> 9377 bytes
> > tests/data/acpi/q35/DSDT.xapic | Bin 35615 -> 35615 bytes
> > 36 files changed, 35 deletions(-)
> >
> > diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
> > index 7e7745db39..dfb8523c8b 100644
> > --- a/tests/qtest/bios-tables-test-allowed-diff.h
> > +++ b/tests/qtest/bios-tables-test-allowed-diff.h
> > @@ -1,36 +1 @@
> > /* List of comma-separated changed AML files to ignore */
> > -"tests/data/acpi/pc/DSDT",
> > -"tests/data/acpi/pc/DSDT.acpierst",
> > -"tests/data/acpi/pc/DSDT.acpihmat",
> > -"tests/data/acpi/pc/DSDT.bridge",
> > -"tests/data/acpi/pc/DSDT.cphp",
> > -"tests/data/acpi/pc/DSDT.dimmpxm",
> > -"tests/data/acpi/pc/DSDT.hpbridge",
> > -"tests/data/acpi/pc/DSDT.ipmikcs",
> > -"tests/data/acpi/pc/DSDT.memhp",
> > -"tests/data/acpi/pc/DSDT.nohpet",
> > -"tests/data/acpi/pc/DSDT.numamem",
> > -"tests/data/acpi/pc/DSDT.roothp",
> > -"tests/data/acpi/q35/DSDT",
> > -"tests/data/acpi/q35/DSDT.acpierst",
> > -"tests/data/acpi/q35/DSDT.acpihmat",
> > -"tests/data/acpi/q35/DSDT.acpihmat-noinitiator",
> > -"tests/data/acpi/q35/DSDT.applesmc",
> > -"tests/data/acpi/q35/DSDT.bridge",
> > -"tests/data/acpi/q35/DSDT.core-count2",
> > -"tests/data/acpi/q35/DSDT.cphp",
> > -"tests/data/acpi/q35/DSDT.cxl",
> > -"tests/data/acpi/q35/DSDT.dimmpxm",
> > -"tests/data/acpi/q35/DSDT.ipmibt",
> > -"tests/data/acpi/q35/DSDT.ipmismbus",
> > -"tests/data/acpi/q35/DSDT.ivrs",
> > -"tests/data/acpi/q35/DSDT.memhp",
> > -"tests/data/acpi/q35/DSDT.mmio64",
> > -"tests/data/acpi/q35/DSDT.multi-bridge",
> > -"tests/data/acpi/q35/DSDT.nohpet",
> > -"tests/data/acpi/q35/DSDT.numamem",
> > -"tests/data/acpi/q35/DSDT.pvpanic-isa",
> > -"tests/data/acpi/q35/DSDT.tis.tpm12",
> > -"tests/data/acpi/q35/DSDT.tis.tpm2",
> > -"tests/data/acpi/q35/DSDT.viot",
> > -"tests/data/acpi/q35/DSDT.xapic",
> > diff --git a/tests/data/acpi/pc/DSDT b/tests/data/acpi/pc/DSDT
> > index 0b475fb5a966543fef2cd7672a0b198838a63151..ec133a6d3aabcfd22b7b46019338db2de255da70 100644
> > GIT binary patch
> > delta 19
> > acmca%c*Af*JmcgfMinN8#LcaY!Quc(l?Foq
> >
> > delta 20
> > bcmca%c*Af*JR@@fL*nFkMwQKNj6vc6P%j3t
> >
> > diff --git a/tests/data/acpi/pc/DSDT.acpierst b/tests/data/acpi/pc/DSDT.acpierst
> > index 17ef7caeb6fe4445f1234ff060c3db6809184ef6..2b4b7f31919f360e038e37de713639da753f13aa 100644
> > GIT binary patch
> > delta 19
> > acmeA+>^9sG&p0`WQH6;iadRspn>YYICk0#p
> >
> > delta 20
> > bcmeA+>^9sG&&XWBkT^M>QDt)*Bda(7L?;Ex
> >
> > diff --git a/tests/data/acpi/pc/DSDT.acpihmat b/tests/data/acpi/pc/DSDT.acpihmat
> > index 675b674eaa92d99513ac243a97064d369791ee53..714a123e7a500cf0f862ff6c4e9a3f50a96af056 100644
> > GIT binary patch
> > delta 19
> > acmZp*X|>r9&p0`WQH6;iadRtUgA4#az6Ip~
> >
> > delta 20
> > bcmZp*X|>r9&&XWBkT^M>QDt)*W4#OjMaTwI
> >
> > diff --git a/tests/data/acpi/pc/DSDT.bridge b/tests/data/acpi/pc/DSDT.bridge
> > index c1ce06136619f55c084a34c51997c059c29cb06a..6c0543cf75ad3e02468ed4925fd3369a183e9b45 100644
> > GIT binary patch
> > delta 19
> > acmX?}csy}KJmcgfMinN8#LcaYPWk{%hX#lM
> >
> > delta 20
> > bcmX?}csy}KJR@@fL*nFkMwQKNjE?#MR9^=6
> >
> > diff --git a/tests/data/acpi/pc/DSDT.cphp b/tests/data/acpi/pc/DSDT.cphp
> > index 754ab854dc48fc1af2d335e7269c23a056e66eb8..e1bcb0a4f3ee1269bdd5e949206b40d0e3c076e6 100644
> > GIT binary patch
> > delta 19
> > acmZ2sy25lrJmcgfMinN8#LcaY%8~#={{_7O
> >
> > delta 20
> > bcmZ2sy25lrJR@@fL*nFkMwQKNj7pLKNkIlH
> >
> > diff --git a/tests/data/acpi/pc/DSDT.dimmpxm b/tests/data/acpi/pc/DSDT.dimmpxm
> > index 170503336b3fd94cc7a4356003fa080f0ef57b01..1c90e119c5d3dc7e86d04942114e5cfe40de6039 100644
> > GIT binary patch
> > delta 19
> > acmX?Scg}7@JmcgfMinN8#LcaYCuIRj*#^Y`
> >
> > delta 20
> > bcmX?Scg}7@JR@@fL*nFkMwQKNj3;CPQF#Y5
> >
> > diff --git a/tests/data/acpi/pc/DSDT.hpbridge b/tests/data/acpi/pc/DSDT.hpbridge
> > index 5dea100bc9492bb2367aac8660522201785c1efb..04e1c20f63be7c6c574e72590332707ca410852a 100644
> > GIT binary patch
> > delta 19
> > acmdmNxY=++JmcgfMinN8#LcaYdg1^?7X{P+
> >
> > delta 20
> > bcmdmNxY=++JR@@fL*nFkMwQKNjJo0gN@oT_
> >
> > diff --git a/tests/data/acpi/pc/DSDT.ipmikcs b/tests/data/acpi/pc/DSDT.ipmikcs
> > index dd7135602709fc4a361930c74f9bebc6b32e6916..3c2aba132f10b5e4a9931877533a9d8f260b7381 100644
> > GIT binary patch
> > delta 19
> > acmZ2rw7_UXJmcgfMinN8#LcaYv&8{IX9gVr
> >
> > delta 20
> > bcmZ2rw7_UXJR@@fL*nFkMwQKNjI+c6NRtMO
> >
> > diff --git a/tests/data/acpi/pc/DSDT.memhp b/tests/data/acpi/pc/DSDT.memhp
> > index 2f895e9b385c1ae2f58c7ade4de02328b1be7356..811965f42d97adadde6e9ec6d6153e767041bc6d 100644
> > GIT binary patch
> > delta 19
> > acmZ2(v)pDwJmcgfMinN8#LcaYi(~*q$_7gS
> >
> > delta 20
> > bcmZ2(v)pDwJR@@fL*nFkMwQKNj0<G|OBe>Z
> >
> > diff --git a/tests/data/acpi/pc/DSDT.nohpet b/tests/data/acpi/pc/DSDT.nohpet
> > index c012b63ace2f359eec0368ed22ef507ee3905c78..bbf73023ade329770ff9f9ac5c897218764182b5 100644
> > GIT binary patch
> > delta 19
> > acmX?QaLQmqJmcgfMinN8#LcaYN5ue0UIvx`
> >
> > delta 20
> > bcmX?QaLQmqJR@@fL*nFkMwQKNj7P)(PTB_q
> >
> > diff --git a/tests/data/acpi/pc/DSDT.numamem b/tests/data/acpi/pc/DSDT.numamem
> > index f2ef4b97290cc58c514c3ce7fd45cb08214d7138..c5d93366a417ad1a92c01659f1db9c159caa7132 100644
> > GIT binary patch
> > delta 19
> > acmca-c+YS{JmcgfMinN8#LcaYk>UVKc?MMg
> >
> > delta 20
> > bcmca-c+YS{JR@@fL*nFkMwQKNj1l4hQ6C1w
> >
> > diff --git a/tests/data/acpi/pc/DSDT.roothp b/tests/data/acpi/pc/DSDT.roothp
> > index 657c8263f0c649abc806a67576fd74cb32af60c3..9e3d482366bd800cf987044801eebc814629b15b 100644
> > GIT binary patch
> > delta 19
> > acmbQ}Gtp;5JmcgfMinN8#LcaYJt_c0t_Cpx
> >
> > delta 20
> > bcmbQ}Gtp;5JR@@fL*nFkMwQKNjNK{#N$>`r
> >
> > diff --git a/tests/data/acpi/q35/DSDT b/tests/data/acpi/q35/DSDT
> > index d68c472b460e4609a64ea67de3c4cebfca76164d..c304e15e366d7317fd0e9db0a144f02e0437d7a1 100644
> > GIT binary patch
> > delta 19
> > acmdnvu*YG864PW=CKV=z#LXT|Ut|G790nW!
> >
> > delta 20
> > bcmdnvu*YG85)*R)L*is5CY8;eOrK=|NfZW(
> >
> > diff --git a/tests/data/acpi/q35/DSDT.acpierst b/tests/data/acpi/q35/DSDT.acpierst
> > index de7ae27125f9667d7aa7a7cc0e8210773b61a2e2..3aa5c4b3193d32bb8263a1fe06c05b714541c532 100644
> > GIT binary patch
> > delta 19
> > acmX@>aModi64PW=CKV=z#LXT|ta1QCqXkd^
> >
> > delta 20
> > bcmX@>aModi5)*R)L*is5CY8;eOe}H$NxcQW
> >
> > diff --git a/tests/data/acpi/q35/DSDT.acpihmat b/tests/data/acpi/q35/DSDT.acpihmat
> > index 48e2862257ac614b5fd6391c4ec425106c48afb1..3ffbf8f83f64144ace17ff5f06bcb4fec9df33d9 100644
> > GIT binary patch
> > delta 19
> > acmaFq_0nsD64PW=CKV=z#LXT|ipl^;Bn7<y
> >
> > delta 20
> > bcmaFq_0nsD5)*R)L*is5CY8;eObW^XPl^UB
> >
> > diff --git a/tests/data/acpi/q35/DSDT.acpihmat-noinitiator b/tests/data/acpi/q35/DSDT.acpihmat-noinitiator
> > index 30a4aa2ec8feb6012a64d476ff37b14717d20eaf..ebec32b575d310f98937fe9208f0c60349ca753d 100644
> > GIT binary patch
> > delta 19
> > acmccYblGWx64PW=CKV=z#LXT|-0}cJ%mrrv
> >
> > delta 20
> > bcmccYblGWx5)*R)L*is5CY8;eOkDB+O7;cS
> >
> > diff --git a/tests/data/acpi/q35/DSDT.applesmc b/tests/data/acpi/q35/DSDT.applesmc
> > index 84e2b5cbc4483ae93634f223160253231dcc4932..b0994644ec811b962e80f49e36e122967f5af1d1 100644
> > GIT binary patch
> > delta 19
> > acmaFm@XBF>64PW=CKV=z#LXT|N^$^3@dc*<
> >
> > delta 20
> > bcmaFm@XBF>5)*R)L*is5CY8;eOp0;<PDKV4
> >
> > diff --git a/tests/data/acpi/q35/DSDT.bridge b/tests/data/acpi/q35/DSDT.bridge
> > index e411d40fd1e297879d78dcf15486dd465ab54568..8e11b8ea4862c8ec27376703c9c43e9895ca60eb 100644
> > GIT binary patch
> > delta 19
> > acmcZ^c{6f@64PW=CKV=z#LXT|6SV+H$p$h2
> >
> > delta 20
> > bcmcZ^c{6f@5)*R)L*is5CY8;eOcS&KP%Q?a
> >
> > diff --git a/tests/data/acpi/q35/DSDT.core-count2 b/tests/data/acpi/q35/DSDT.core-count2
> > index 0603db8cc63cfc562f83e55eaf5162e7c29bf4d1..a895599c3c53c0cd0888ec166a30d6c036d26b93 100644
> > GIT binary patch
> > delta 21
> > ccmeD9%h>Ukaf1@mWK|{=CWge#9!w5309TO)+W-In
> >
> > delta 22
> > dcmeD9%h>Ukaf1>Qa{)u*WF;n*&7Ms5H2`0o2T1?`
> >
> > diff --git a/tests/data/acpi/q35/DSDT.cphp b/tests/data/acpi/q35/DSDT.cphp
> > index beeb83c33b385fc8b41d44f299b8d9ba7203d935..725998cb587c02ac963f290bac5c14d665bc85e9 100644
> > GIT binary patch
> > delta 19
> > acmeBi>2cYh#57rzNrj0aakB^05qSVRh6R=Y
> >
> > delta 20
> > bcmeBi>2cYh#Kc^{kT_Y1NoBJq(_wi4LM8?T
> >
> > diff --git a/tests/data/acpi/q35/DSDT.cxl b/tests/data/acpi/q35/DSDT.cxl
> > index 3d18b9672d124a0cf11a79e92c396a1b883d0589..04c2c66a25536854b4305787c8e0b41e96c3c133 100644
> > GIT binary patch
> > delta 19
> > acmaFm^~!6564PW=CKV=z#LXT|O3DC8N(I0G
> >
> > delta 20
> > bcmaFm^~!655)*R)L*is5CY8;eOp3|?PqGFs
> >
> > diff --git a/tests/data/acpi/q35/DSDT.dimmpxm b/tests/data/acpi/q35/DSDT.dimmpxm
> > index 99a93e12a7faac78e9524ad6758f42c5c0df18eb..ef643b4ee02cacb9a55f89b8e7f05524125515a1 100644
> > GIT binary patch
> > delta 19
> > acmdnwyUBNh64PW=CKV=z#LXT|St<ZQVFjN6
> >
> > delta 20
> > bcmdnwyUBNh5)*R)L*is5CY8;eOqnVGNM8mG
> >
> > diff --git a/tests/data/acpi/q35/DSDT.ipmibt b/tests/data/acpi/q35/DSDT.ipmibt
> > index 7f7601dbff820044aa646048c0bfe0e6324b9d0d..b136aea961c89a97db09db9b68809979564d8faf 100644
> > GIT binary patch
> > delta 19
> > acmZp7Y<JwC#57rzNrj0aakB@Ly&M2JVFdsH
> >
> > delta 20
> > bcmZp7Y<JwC#Kc^{kT_Y1NoBJqlbsv@Kk)@_
> >
> > diff --git a/tests/data/acpi/q35/DSDT.ipmismbus b/tests/data/acpi/q35/DSDT.ipmismbus
> > index 6c5d1afe443d9261d3b93801711f8d5b267696f3..0970dbd5896fc0038b1369dbbcc982ead7736ae6 100644
> > GIT binary patch
> > delta 19
> > acmbQ@IK^>;64PW=CKV=z#LXT|K5_s%PX#9c
> >
> > delta 20
> > bcmbQ@IK^>;5)*R)L*is5CY8;eOx|(;LHPxh
> >
> > diff --git a/tests/data/acpi/q35/DSDT.ivrs b/tests/data/acpi/q35/DSDT.ivrs
> > index de7ae27125f9667d7aa7a7cc0e8210773b61a2e2..3aa5c4b3193d32bb8263a1fe06c05b714541c532 100644
> > GIT binary patch
> > delta 19
> > acmX@>aModi64PW=CKV=z#LXT|ta1QCqXkd^
> >
> > delta 20
> > bcmX@>aModi5)*R)L*is5CY8;eOe}H$NxcQW
> >
> > diff --git a/tests/data/acpi/q35/DSDT.memhp b/tests/data/acpi/q35/DSDT.memhp
> > index 79bce5c8f0132e72b8e700488ea56c7593737810..9709e5a7a7edcb7509954b553f7bf29a424033db 100644
> > GIT binary patch
> > delta 19
> > acmeD7?)KiG#57rzNrj0aakB@LvoZiXQUxUd
> >
> > delta 20
> > bcmeD7?)KiG#Kc^{kT_Y1NoBJqlan$4LH-4k
> >
> > diff --git a/tests/data/acpi/q35/DSDT.mmio64 b/tests/data/acpi/q35/DSDT.mmio64
> > index c249929add97439ceb9f891d44c425311517ad18..e1cd01f2349bb8c2f7f8badad11441ffe6d57acc 100644
> > GIT binary patch
> > delta 19
> > acmZ4Hxy*Be64PW=CKV=z#LXT|aY_I`4+U`m
> >
> > delta 20
> > bcmZ4Hxy*Be5)*R)L*is5CY8;eOtDG;MePOO
> >
> > diff --git a/tests/data/acpi/q35/DSDT.multi-bridge b/tests/data/acpi/q35/DSDT.multi-bridge
> > index f2f60fdbb3b44ab9adb69bb36e4a80978536af9b..3b9dffb565833cc87bbf08dadfc1f31ac858e93b 100644
> > GIT binary patch
> > delta 19
> > acmZonYE0Uo#57rzNrj0aakB^0PCWoU?*+gB
> >
> > delta 20
> > bcmZonYE0Uo#Kc^{kT_Y1NoBJq(+)iVM70Jk
> >
> > diff --git a/tests/data/acpi/q35/DSDT.nohpet b/tests/data/acpi/q35/DSDT.nohpet
> > index 9ff9983a80a7487470ccd02ce587200444675816..2cf7f6db0fd8de357278f942a4082e714804dca9 100644
> > GIT binary patch
> > delta 19
> > acmZ2yzs`Px64PW=CKV=z#LXT|X|e!5<^^y7
> >
> > delta 20
> > bcmZ2yzs`Px5)*R)L*is5CY8;eOsTQ}MZg8#
> >
> > diff --git a/tests/data/acpi/q35/DSDT.numamem b/tests/data/acpi/q35/DSDT.numamem
> > index 1e7c45ef3ccb000a06f64152622b4bd27916d181..310e3d5053b90863f96c29dd69a514b4999b4a19 100644
> > GIT binary patch
> > delta 19
> > acmX@)aL8eU64PW=CKV=z#LXT|zhnVJ00u4q
> >
> > delta 20
> > bcmX@)aL8eU5)*R)L*is5CY8;eOh07-N(2U+
> >
> > diff --git a/tests/data/acpi/q35/DSDT.pvpanic-isa b/tests/data/acpi/q35/DSDT.pvpanic-isa
> > index ed47451c44e3041e5b7fed55de7b6ef1aca54350..6672b6fa05c8ee30a8ea4ab0931d59c1315a4e9c 100644
> > GIT binary patch
> > delta 19
> > acmZ4JxX^Kf64PW=CKV=z#LXT|k#Yb%Jq1nx
> >
> > delta 20
> > bcmZ4JxX^Kf5)*R)L*is5CY8;eOc8PbL;(f7
> >
> > diff --git a/tests/data/acpi/q35/DSDT.tis.tpm12 b/tests/data/acpi/q35/DSDT.tis.tpm12
> > index efc2efc19f00ca7564467756616da44f5fd71cfe..eae2dc599331516e11632356f05d7831d1fa1e6a 100644
> > GIT binary patch
> > delta 19
> > acmbQ`I?Hu~64PW=CKV=z#LXT|K?(poy#+%6
> >
> > delta 20
> > bcmbQ`I?Hu~5)*R)L*is5CY8;eOo0jjLwg0W
> >
> > diff --git a/tests/data/acpi/q35/DSDT.tis.tpm2 b/tests/data/acpi/q35/DSDT.tis.tpm2
> > index 675339715f72b4400445ce8c0dd12f416aa0efb0..68c6a7d244cfc78efa6b9cd1385f2134ca149ad7 100644
> > GIT binary patch
> > delta 19
> > acmdnuy2W*a64PW=CKV=z#LXT|ISK$knFWym
> >
> > delta 20
> > bcmdnuy2W*a5)*R)L*is5CY8;eOxX$mM~emj
> >
> > diff --git a/tests/data/acpi/q35/DSDT.viot b/tests/data/acpi/q35/DSDT.viot
> > index eeb40b360f7c1de93501e1ddcd7dab306a51113b..4d2937a87c4a39993eaa756f02d59ef35a08f1c2 100644
> > GIT binary patch
> > delta 118
> > zcmbQ}xzLl#CD<iop$Y>7Bf~~6A4W#e$>EGUg}4G-f_-@x_^?gRVki(~W@Jd1tjeTf
> > z%#c{%=;;#C+>yh;03;Y0k`^dUs-2v~Fgc0mKM*j~CNd`0CRQ?Xu`@tu*2#rT1{@36
> > QCuec7E@9lfkm-XW0I$^}K>z>%
> >
> > delta 101
> > zcmZ4JInk5LCD<ioq6z~8qtiw%A4W!z$>EGUML7dpf_-@xxUfymVki(~W@JbxU`U*-
> > z#H6C(=;;#C+>yh;03;Y0k`_o!s-2v~Fgc0mKM*j~CNd`0CRQ?Xu}`jKGT6M4>4PEw
> > DoVXuG
> >
> > diff --git a/tests/data/acpi/q35/DSDT.xapic b/tests/data/acpi/q35/DSDT.xapic
> > index 3aa86f07243f0449c7dc245650715d729744e3ee..e9b4881bdc72eb7c59dcf258c1a98363b46bfbcd 100644
> > GIT binary patch
> > delta 21
> > dcmbO~jcNWgrVUC=lU12im>3c_doW$^002#l2H*ey
> >
> > delta 22
> > ecmbO~jcNWgrVUC=%moaIla-iMHhVH%>i_^$`Ug$`
> >
> > --
> > 2.39.1
>
^ permalink raw reply [flat|nested] 46+ messages in thread* Re: [PATCH 14/33] tests: acpi: update expected blobs
2023-03-02 12:02 ` Igor Mammedov
@ 2023-03-02 12:55 ` Fabiano Rosas
2023-03-02 14:57 ` Igor Mammedov
0 siblings, 1 reply; 46+ messages in thread
From: Fabiano Rosas @ 2023-03-02 12:55 UTC (permalink / raw)
To: Igor Mammedov, Michael S. Tsirkin; +Cc: qemu-devel, ani, berrange, thuth
Igor Mammedov <imammedo@redhat.com> writes:
> On Wed, 1 Mar 2023 19:27:33 -0500
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
>
>> On Fri, Feb 24, 2023 at 04:37:53PM +0100, Igor Mammedov wrote:
>> > only following context change:
>> > - Local1 = Zero
>> > If ((Arg0 != ToUUID ("e5c937d0-3553-4d7a-9117-ea4d19c3434d") /* Device Labeling Interface */))
>> > {
>> > Return (Local0)
>> > ...
>> > Return (Local0)
>> > }
>> >
>> > + Local1 = Zero
>> > Local2 = AIDX (DerefOf (Arg4 [Zero]), DerefOf (Arg4 [One]
>> >
>> > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
>>
>> Nope:
>>
>> diff -ru -N -IDisassembly -IChecksum '-I* Length ' old/asl/tests/data/acpi/q35/DSDT.viot.dsl new/asl/tests/data/acpi/q35/DSDT.viot.dsl
>> :--- old/asl/tests/data/acpi/q35/DSDT.viot.dsl 2023-03-01 19:22:57.636454958 -0500
>> :+++ new/asl/tests/data/acpi/q35/DSDT.viot.dsl 2023-03-01 19:22:58.451460462 -0500
>> :@@ -148,7 +148,6 @@
>> {
>> 0x00 // .
>> }
>> - Local1 = Zero
>> If ((Arg0 != ToUUID ("e5c937d0-3553-4d7a-9117-ea4d19c3434d") /* Device Labeling Interface */))
>> {
>> Return (Local0)
>> :@@ -159,12 +158,14 @@
>> Return (Local0)
>> }
>>
>> + Local1 = Zero
>> Local2 = AIDX (DerefOf (Arg4 [Zero]), DerefOf (Arg4 [One]
>> ))
>> If (!((Local2 == Zero) | (Local2 == 0xFFFFFFFF)))
>> {
>> Local1 |= One
>> Local1 |= (One << 0x07)
>> + Local1 |= (One << 0x05)
>> }
>>
>> Local0 [Zero] = Local1
>>
>>
>> and the funny thing is, the second change is in the expected
>> file but not in the code so this patch causes the test to fail.
>
> above diff is remnants of some old version of the patch before
> patches were reshuffled.
>
> for some reason q35/viot test gets skipped => no table rebuild => stale DSDT.viot table
>
> reverting recently merged commit c471eb4f40, I can get q35/viot test back:
>
> commit c471eb4f40445908c1be7bb11a37ac676a0edae7
> Author: Fabiano Rosas <farosas@suse.de>
> Date: Wed Feb 8 16:46:57 2023 -0300
>
> tests/qtest: Check for devices in bios-tables-test
>
> so checks aren't working as expected on my host for some reason
>
Was this a legitimate skip or do we have a bug in the way we check for
devices? I.e. did you have CONFIG_VIRTIO_IOMMU in the build?
If we avoid the checks during rebuild and a device is not present in the
build anyway, then that QEMU invocation would crash.
^ permalink raw reply [flat|nested] 46+ messages in thread* Re: [PATCH 14/33] tests: acpi: update expected blobs
2023-03-02 12:55 ` Fabiano Rosas
@ 2023-03-02 14:57 ` Igor Mammedov
2023-03-02 15:43 ` Fabiano Rosas
0 siblings, 1 reply; 46+ messages in thread
From: Igor Mammedov @ 2023-03-02 14:57 UTC (permalink / raw)
To: Fabiano Rosas; +Cc: Michael S. Tsirkin, qemu-devel, ani, berrange, thuth
On Thu, 02 Mar 2023 09:55:24 -0300
Fabiano Rosas <farosas@suse.de> wrote:
> Igor Mammedov <imammedo@redhat.com> writes:
>
> > On Wed, 1 Mar 2023 19:27:33 -0500
> > "Michael S. Tsirkin" <mst@redhat.com> wrote:
> >
> >> On Fri, Feb 24, 2023 at 04:37:53PM +0100, Igor Mammedov wrote:
> >> > only following context change:
> >> > - Local1 = Zero
> >> > If ((Arg0 != ToUUID ("e5c937d0-3553-4d7a-9117-ea4d19c3434d") /* Device Labeling Interface */))
> >> > {
> >> > Return (Local0)
> >> > ...
> >> > Return (Local0)
> >> > }
> >> >
> >> > + Local1 = Zero
> >> > Local2 = AIDX (DerefOf (Arg4 [Zero]), DerefOf (Arg4 [One]
> >> >
> >> > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> >>
> >> Nope:
> >>
> >> diff -ru -N -IDisassembly -IChecksum '-I* Length ' old/asl/tests/data/acpi/q35/DSDT.viot.dsl new/asl/tests/data/acpi/q35/DSDT.viot.dsl
> >> :--- old/asl/tests/data/acpi/q35/DSDT.viot.dsl 2023-03-01 19:22:57.636454958 -0500
> >> :+++ new/asl/tests/data/acpi/q35/DSDT.viot.dsl 2023-03-01 19:22:58.451460462 -0500
> >> :@@ -148,7 +148,6 @@
> >> {
> >> 0x00 // .
> >> }
> >> - Local1 = Zero
> >> If ((Arg0 != ToUUID ("e5c937d0-3553-4d7a-9117-ea4d19c3434d") /* Device Labeling Interface */))
> >> {
> >> Return (Local0)
> >> :@@ -159,12 +158,14 @@
> >> Return (Local0)
> >> }
> >>
> >> + Local1 = Zero
> >> Local2 = AIDX (DerefOf (Arg4 [Zero]), DerefOf (Arg4 [One]
> >> ))
> >> If (!((Local2 == Zero) | (Local2 == 0xFFFFFFFF)))
> >> {
> >> Local1 |= One
> >> Local1 |= (One << 0x07)
> >> + Local1 |= (One << 0x05)
> >> }
> >>
> >> Local0 [Zero] = Local1
> >>
> >>
> >> and the funny thing is, the second change is in the expected
> >> file but not in the code so this patch causes the test to fail.
> >
> > above diff is remnants of some old version of the patch before
> > patches were reshuffled.
> >
> > for some reason q35/viot test gets skipped => no table rebuild => stale DSDT.viot table
> >
> > reverting recently merged commit c471eb4f40, I can get q35/viot test back:
> >
> > commit c471eb4f40445908c1be7bb11a37ac676a0edae7
> > Author: Fabiano Rosas <farosas@suse.de>
> > Date: Wed Feb 8 16:46:57 2023 -0300
> >
> > tests/qtest: Check for devices in bios-tables-test
> >
> > so checks aren't working as expected on my host for some reason
> >
>
> Was this a legitimate skip or do we have a bug in the way we check for
> devices? I.e. did you have CONFIG_VIRTIO_IOMMU in the build?
config should be there since with your patch reverted viot test runs and passes just fine
so I'd assume it is a bug somewhere in check code
> If we avoid the checks during rebuild and a device is not present in the
> build anyway, then that QEMU invocation would crash.
I'd take crash anytime vs watching over for successful SKIP,
so we wouldn't end up with stale tables when they should be actually updated
like it happened in this case.
^ permalink raw reply [flat|nested] 46+ messages in thread* Re: [PATCH 14/33] tests: acpi: update expected blobs
2023-03-02 14:57 ` Igor Mammedov
@ 2023-03-02 15:43 ` Fabiano Rosas
2023-03-02 15:59 ` Igor Mammedov
0 siblings, 1 reply; 46+ messages in thread
From: Fabiano Rosas @ 2023-03-02 15:43 UTC (permalink / raw)
To: Igor Mammedov; +Cc: Michael S. Tsirkin, qemu-devel, ani, berrange, thuth
Igor Mammedov <imammedo@redhat.com> writes:
> On Thu, 02 Mar 2023 09:55:24 -0300
> Fabiano Rosas <farosas@suse.de> wrote:
>
>> Igor Mammedov <imammedo@redhat.com> writes:
>>
>> > On Wed, 1 Mar 2023 19:27:33 -0500
>> > "Michael S. Tsirkin" <mst@redhat.com> wrote:
>> >
>> >> On Fri, Feb 24, 2023 at 04:37:53PM +0100, Igor Mammedov wrote:
>> >> > only following context change:
>> >> > - Local1 = Zero
>> >> > If ((Arg0 != ToUUID ("e5c937d0-3553-4d7a-9117-ea4d19c3434d") /* Device Labeling Interface */))
>> >> > {
>> >> > Return (Local0)
>> >> > ...
>> >> > Return (Local0)
>> >> > }
>> >> >
>> >> > + Local1 = Zero
>> >> > Local2 = AIDX (DerefOf (Arg4 [Zero]), DerefOf (Arg4 [One]
>> >> >
>> >> > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
>> >>
>> >> Nope:
>> >>
>> >> diff -ru -N -IDisassembly -IChecksum '-I* Length ' old/asl/tests/data/acpi/q35/DSDT.viot.dsl new/asl/tests/data/acpi/q35/DSDT.viot.dsl
>> >> :--- old/asl/tests/data/acpi/q35/DSDT.viot.dsl 2023-03-01 19:22:57.636454958 -0500
>> >> :+++ new/asl/tests/data/acpi/q35/DSDT.viot.dsl 2023-03-01 19:22:58.451460462 -0500
>> >> :@@ -148,7 +148,6 @@
>> >> {
>> >> 0x00 // .
>> >> }
>> >> - Local1 = Zero
>> >> If ((Arg0 != ToUUID ("e5c937d0-3553-4d7a-9117-ea4d19c3434d") /* Device Labeling Interface */))
>> >> {
>> >> Return (Local0)
>> >> :@@ -159,12 +158,14 @@
>> >> Return (Local0)
>> >> }
>> >>
>> >> + Local1 = Zero
>> >> Local2 = AIDX (DerefOf (Arg4 [Zero]), DerefOf (Arg4 [One]
>> >> ))
>> >> If (!((Local2 == Zero) | (Local2 == 0xFFFFFFFF)))
>> >> {
>> >> Local1 |= One
>> >> Local1 |= (One << 0x07)
>> >> + Local1 |= (One << 0x05)
>> >> }
>> >>
>> >> Local0 [Zero] = Local1
>> >>
>> >>
>> >> and the funny thing is, the second change is in the expected
>> >> file but not in the code so this patch causes the test to fail.
>> >
>> > above diff is remnants of some old version of the patch before
>> > patches were reshuffled.
>> >
>> > for some reason q35/viot test gets skipped => no table rebuild => stale DSDT.viot table
>> >
>> > reverting recently merged commit c471eb4f40, I can get q35/viot test back:
>> >
>> > commit c471eb4f40445908c1be7bb11a37ac676a0edae7
>> > Author: Fabiano Rosas <farosas@suse.de>
>> > Date: Wed Feb 8 16:46:57 2023 -0300
>> >
>> > tests/qtest: Check for devices in bios-tables-test
>> >
>> > so checks aren't working as expected on my host for some reason
>> >
>>
>> Was this a legitimate skip or do we have a bug in the way we check for
>> devices? I.e. did you have CONFIG_VIRTIO_IOMMU in the build?
>
> config should be there since with your patch reverted viot test runs and passes just fine
> so I'd assume it is a bug somewhere in check code
>
Probably easier to just revert the patch then. We have stopped building
bios-tables-test.c when CONFIG_PARALLEL is not present, so the build
--without-default-devices is already covered.
We would only need those checks if PCI_DEVICES=n or one of the
individual CONFIGs, which we have discussed previously that is not worth
the effort to keep track of.
^ permalink raw reply [flat|nested] 46+ messages in thread* Re: [PATCH 14/33] tests: acpi: update expected blobs
2023-03-02 15:43 ` Fabiano Rosas
@ 2023-03-02 15:59 ` Igor Mammedov
0 siblings, 0 replies; 46+ messages in thread
From: Igor Mammedov @ 2023-03-02 15:59 UTC (permalink / raw)
To: Fabiano Rosas; +Cc: Michael S. Tsirkin, qemu-devel, ani, berrange, thuth
On Thu, 02 Mar 2023 12:43:11 -0300
Fabiano Rosas <farosas@suse.de> wrote:
> Igor Mammedov <imammedo@redhat.com> writes:
>
> > On Thu, 02 Mar 2023 09:55:24 -0300
> > Fabiano Rosas <farosas@suse.de> wrote:
> >
> >> Igor Mammedov <imammedo@redhat.com> writes:
> >>
> >> > On Wed, 1 Mar 2023 19:27:33 -0500
> >> > "Michael S. Tsirkin" <mst@redhat.com> wrote:
> >> >
> >> >> On Fri, Feb 24, 2023 at 04:37:53PM +0100, Igor Mammedov wrote:
> >> >> > only following context change:
> >> >> > - Local1 = Zero
> >> >> > If ((Arg0 != ToUUID ("e5c937d0-3553-4d7a-9117-ea4d19c3434d") /* Device Labeling Interface */))
> >> >> > {
> >> >> > Return (Local0)
> >> >> > ...
> >> >> > Return (Local0)
> >> >> > }
> >> >> >
> >> >> > + Local1 = Zero
> >> >> > Local2 = AIDX (DerefOf (Arg4 [Zero]), DerefOf (Arg4 [One]
> >> >> >
> >> >> > Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> >> >>
> >> >> Nope:
> >> >>
> >> >> diff -ru -N -IDisassembly -IChecksum '-I* Length ' old/asl/tests/data/acpi/q35/DSDT.viot.dsl new/asl/tests/data/acpi/q35/DSDT.viot.dsl
> >> >> :--- old/asl/tests/data/acpi/q35/DSDT.viot.dsl 2023-03-01 19:22:57.636454958 -0500
> >> >> :+++ new/asl/tests/data/acpi/q35/DSDT.viot.dsl 2023-03-01 19:22:58.451460462 -0500
> >> >> :@@ -148,7 +148,6 @@
> >> >> {
> >> >> 0x00 // .
> >> >> }
> >> >> - Local1 = Zero
> >> >> If ((Arg0 != ToUUID ("e5c937d0-3553-4d7a-9117-ea4d19c3434d") /* Device Labeling Interface */))
> >> >> {
> >> >> Return (Local0)
> >> >> :@@ -159,12 +158,14 @@
> >> >> Return (Local0)
> >> >> }
> >> >>
> >> >> + Local1 = Zero
> >> >> Local2 = AIDX (DerefOf (Arg4 [Zero]), DerefOf (Arg4 [One]
> >> >> ))
> >> >> If (!((Local2 == Zero) | (Local2 == 0xFFFFFFFF)))
> >> >> {
> >> >> Local1 |= One
> >> >> Local1 |= (One << 0x07)
> >> >> + Local1 |= (One << 0x05)
> >> >> }
> >> >>
> >> >> Local0 [Zero] = Local1
> >> >>
> >> >>
> >> >> and the funny thing is, the second change is in the expected
> >> >> file but not in the code so this patch causes the test to fail.
> >> >
> >> > above diff is remnants of some old version of the patch before
> >> > patches were reshuffled.
> >> >
> >> > for some reason q35/viot test gets skipped => no table rebuild => stale DSDT.viot table
> >> >
> >> > reverting recently merged commit c471eb4f40, I can get q35/viot test back:
> >> >
> >> > commit c471eb4f40445908c1be7bb11a37ac676a0edae7
> >> > Author: Fabiano Rosas <farosas@suse.de>
> >> > Date: Wed Feb 8 16:46:57 2023 -0300
> >> >
> >> > tests/qtest: Check for devices in bios-tables-test
> >> >
> >> > so checks aren't working as expected on my host for some reason
> >> >
> >>
> >> Was this a legitimate skip or do we have a bug in the way we check for
> >> devices? I.e. did you have CONFIG_VIRTIO_IOMMU in the build?
> >
> > config should be there since with your patch reverted viot test runs and passes just fine
> > so I'd assume it is a bug somewhere in check code
> >
>
> Probably easier to just revert the patch then. We have stopped building
> bios-tables-test.c when CONFIG_PARALLEL is not present, so the build
> --without-default-devices is already covered.
>
> We would only need those checks if PCI_DEVICES=n or one of the
> individual CONFIGs, which we have discussed previously that is not worth
> the effort to keep track of.
>
ok, then I'll include revert in on respin
^ permalink raw reply [flat|nested] 46+ messages in thread
* Re: [PATCH 14/33] tests: acpi: update expected blobs
2023-02-24 15:37 ` [PATCH 14/33] tests: acpi: update expected blobs Igor Mammedov
2023-03-02 0:27 ` Michael S. Tsirkin
@ 2023-03-02 0:37 ` Michael S. Tsirkin
1 sibling, 0 replies; 46+ messages in thread
From: Michael S. Tsirkin @ 2023-03-02 0:37 UTC (permalink / raw)
To: Igor Mammedov; +Cc: qemu-devel, ani, berrange
On Fri, Feb 24, 2023 at 04:37:53PM +0100, Igor Mammedov wrote:
> only following context change:
> - Local1 = Zero
> If ((Arg0 != ToUUID ("e5c937d0-3553-4d7a-9117-ea4d19c3434d") /* Device Labeling Interface */))
> {
> Return (Local0)
> ...
> Return (Local0)
> }
>
> + Local1 = Zero
> Local2 = AIDX (DerefOf (Arg4 [Zero]), DerefOf (Arg4 [One]
>
> Signed-off-by: Igor Mammedov <imammedo@redhat.com>
> ---
> tests/qtest/bios-tables-test-allowed-diff.h | 35 ------------------
> tests/data/acpi/pc/DSDT | Bin 6360 -> 6360 bytes
> tests/data/acpi/pc/DSDT.acpierst | Bin 6283 -> 6283 bytes
> tests/data/acpi/pc/DSDT.acpihmat | Bin 7685 -> 7685 bytes
> tests/data/acpi/pc/DSDT.bridge | Bin 12487 -> 12487 bytes
> tests/data/acpi/pc/DSDT.cphp | Bin 6824 -> 6824 bytes
> tests/data/acpi/pc/DSDT.dimmpxm | Bin 8014 -> 8014 bytes
> tests/data/acpi/pc/DSDT.hpbridge | Bin 6323 -> 6323 bytes
> tests/data/acpi/pc/DSDT.ipmikcs | Bin 6432 -> 6432 bytes
> tests/data/acpi/pc/DSDT.memhp | Bin 7719 -> 7719 bytes
> tests/data/acpi/pc/DSDT.nohpet | Bin 6218 -> 6218 bytes
> tests/data/acpi/pc/DSDT.numamem | Bin 6366 -> 6366 bytes
> tests/data/acpi/pc/DSDT.roothp | Bin 9745 -> 9745 bytes
> tests/data/acpi/q35/DSDT | Bin 8252 -> 8252 bytes
> tests/data/acpi/q35/DSDT.acpierst | Bin 8269 -> 8269 bytes
> tests/data/acpi/q35/DSDT.acpihmat | Bin 9577 -> 9577 bytes
> tests/data/acpi/q35/DSDT.acpihmat-noinitiator | Bin 8531 -> 8531 bytes
> tests/data/acpi/q35/DSDT.applesmc | Bin 8298 -> 8298 bytes
> tests/data/acpi/q35/DSDT.bridge | Bin 11481 -> 11481 bytes
> tests/data/acpi/q35/DSDT.core-count2 | Bin 32392 -> 32392 bytes
> tests/data/acpi/q35/DSDT.cphp | Bin 8716 -> 8716 bytes
> tests/data/acpi/q35/DSDT.cxl | Bin 9578 -> 9578 bytes
> tests/data/acpi/q35/DSDT.dimmpxm | Bin 9906 -> 9906 bytes
> tests/data/acpi/q35/DSDT.ipmibt | Bin 8327 -> 8327 bytes
> tests/data/acpi/q35/DSDT.ipmismbus | Bin 8340 -> 8340 bytes
> tests/data/acpi/q35/DSDT.ivrs | Bin 8269 -> 8269 bytes
> tests/data/acpi/q35/DSDT.memhp | Bin 9611 -> 9611 bytes
> tests/data/acpi/q35/DSDT.mmio64 | Bin 9382 -> 9382 bytes
> tests/data/acpi/q35/DSDT.multi-bridge | Bin 12545 -> 12545 bytes
> tests/data/acpi/q35/DSDT.nohpet | Bin 8110 -> 8110 bytes
> tests/data/acpi/q35/DSDT.numamem | Bin 8258 -> 8258 bytes
> tests/data/acpi/q35/DSDT.pvpanic-isa | Bin 8353 -> 8353 bytes
> tests/data/acpi/q35/DSDT.tis.tpm12 | Bin 8858 -> 8858 bytes
> tests/data/acpi/q35/DSDT.tis.tpm2 | Bin 8884 -> 8884 bytes
> tests/data/acpi/q35/DSDT.viot | Bin 9361 -> 9377 bytes
this one is unfortunately malformed, and tests fail if I apply it.
> tests/data/acpi/q35/DSDT.xapic | Bin 35615 -> 35615 bytes
> 36 files changed, 35 deletions(-)
>
> diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
> index 7e7745db39..dfb8523c8b 100644
> --- a/tests/qtest/bios-tables-test-allowed-diff.h
> +++ b/tests/qtest/bios-tables-test-allowed-diff.h
> @@ -1,36 +1 @@
> /* List of comma-separated changed AML files to ignore */
> -"tests/data/acpi/pc/DSDT",
> -"tests/data/acpi/pc/DSDT.acpierst",
> -"tests/data/acpi/pc/DSDT.acpihmat",
> -"tests/data/acpi/pc/DSDT.bridge",
> -"tests/data/acpi/pc/DSDT.cphp",
> -"tests/data/acpi/pc/DSDT.dimmpxm",
> -"tests/data/acpi/pc/DSDT.hpbridge",
> -"tests/data/acpi/pc/DSDT.ipmikcs",
> -"tests/data/acpi/pc/DSDT.memhp",
> -"tests/data/acpi/pc/DSDT.nohpet",
> -"tests/data/acpi/pc/DSDT.numamem",
> -"tests/data/acpi/pc/DSDT.roothp",
> -"tests/data/acpi/q35/DSDT",
> -"tests/data/acpi/q35/DSDT.acpierst",
> -"tests/data/acpi/q35/DSDT.acpihmat",
> -"tests/data/acpi/q35/DSDT.acpihmat-noinitiator",
> -"tests/data/acpi/q35/DSDT.applesmc",
> -"tests/data/acpi/q35/DSDT.bridge",
> -"tests/data/acpi/q35/DSDT.core-count2",
> -"tests/data/acpi/q35/DSDT.cphp",
> -"tests/data/acpi/q35/DSDT.cxl",
> -"tests/data/acpi/q35/DSDT.dimmpxm",
> -"tests/data/acpi/q35/DSDT.ipmibt",
> -"tests/data/acpi/q35/DSDT.ipmismbus",
> -"tests/data/acpi/q35/DSDT.ivrs",
> -"tests/data/acpi/q35/DSDT.memhp",
> -"tests/data/acpi/q35/DSDT.mmio64",
> -"tests/data/acpi/q35/DSDT.multi-bridge",
> -"tests/data/acpi/q35/DSDT.nohpet",
> -"tests/data/acpi/q35/DSDT.numamem",
> -"tests/data/acpi/q35/DSDT.pvpanic-isa",
> -"tests/data/acpi/q35/DSDT.tis.tpm12",
> -"tests/data/acpi/q35/DSDT.tis.tpm2",
> -"tests/data/acpi/q35/DSDT.viot",
> -"tests/data/acpi/q35/DSDT.xapic",
> diff --git a/tests/data/acpi/pc/DSDT b/tests/data/acpi/pc/DSDT
> index 0b475fb5a966543fef2cd7672a0b198838a63151..ec133a6d3aabcfd22b7b46019338db2de255da70 100644
> GIT binary patch
> delta 19
> acmca%c*Af*JmcgfMinN8#LcaY!Quc(l?Foq
>
> delta 20
> bcmca%c*Af*JR@@fL*nFkMwQKNj6vc6P%j3t
>
> diff --git a/tests/data/acpi/pc/DSDT.acpierst b/tests/data/acpi/pc/DSDT.acpierst
> index 17ef7caeb6fe4445f1234ff060c3db6809184ef6..2b4b7f31919f360e038e37de713639da753f13aa 100644
> GIT binary patch
> delta 19
> acmeA+>^9sG&p0`WQH6;iadRspn>YYICk0#p
>
> delta 20
> bcmeA+>^9sG&&XWBkT^M>QDt)*Bda(7L?;Ex
>
> diff --git a/tests/data/acpi/pc/DSDT.acpihmat b/tests/data/acpi/pc/DSDT.acpihmat
> index 675b674eaa92d99513ac243a97064d369791ee53..714a123e7a500cf0f862ff6c4e9a3f50a96af056 100644
> GIT binary patch
> delta 19
> acmZp*X|>r9&p0`WQH6;iadRtUgA4#az6Ip~
>
> delta 20
> bcmZp*X|>r9&&XWBkT^M>QDt)*W4#OjMaTwI
>
> diff --git a/tests/data/acpi/pc/DSDT.bridge b/tests/data/acpi/pc/DSDT.bridge
> index c1ce06136619f55c084a34c51997c059c29cb06a..6c0543cf75ad3e02468ed4925fd3369a183e9b45 100644
> GIT binary patch
> delta 19
> acmX?}csy}KJmcgfMinN8#LcaYPWk{%hX#lM
>
> delta 20
> bcmX?}csy}KJR@@fL*nFkMwQKNjE?#MR9^=6
>
> diff --git a/tests/data/acpi/pc/DSDT.cphp b/tests/data/acpi/pc/DSDT.cphp
> index 754ab854dc48fc1af2d335e7269c23a056e66eb8..e1bcb0a4f3ee1269bdd5e949206b40d0e3c076e6 100644
> GIT binary patch
> delta 19
> acmZ2sy25lrJmcgfMinN8#LcaY%8~#={{_7O
>
> delta 20
> bcmZ2sy25lrJR@@fL*nFkMwQKNj7pLKNkIlH
>
> diff --git a/tests/data/acpi/pc/DSDT.dimmpxm b/tests/data/acpi/pc/DSDT.dimmpxm
> index 170503336b3fd94cc7a4356003fa080f0ef57b01..1c90e119c5d3dc7e86d04942114e5cfe40de6039 100644
> GIT binary patch
> delta 19
> acmX?Scg}7@JmcgfMinN8#LcaYCuIRj*#^Y`
>
> delta 20
> bcmX?Scg}7@JR@@fL*nFkMwQKNj3;CPQF#Y5
>
> diff --git a/tests/data/acpi/pc/DSDT.hpbridge b/tests/data/acpi/pc/DSDT.hpbridge
> index 5dea100bc9492bb2367aac8660522201785c1efb..04e1c20f63be7c6c574e72590332707ca410852a 100644
> GIT binary patch
> delta 19
> acmdmNxY=++JmcgfMinN8#LcaYdg1^?7X{P+
>
> delta 20
> bcmdmNxY=++JR@@fL*nFkMwQKNjJo0gN@oT_
>
> diff --git a/tests/data/acpi/pc/DSDT.ipmikcs b/tests/data/acpi/pc/DSDT.ipmikcs
> index dd7135602709fc4a361930c74f9bebc6b32e6916..3c2aba132f10b5e4a9931877533a9d8f260b7381 100644
> GIT binary patch
> delta 19
> acmZ2rw7_UXJmcgfMinN8#LcaYv&8{IX9gVr
>
> delta 20
> bcmZ2rw7_UXJR@@fL*nFkMwQKNjI+c6NRtMO
>
> diff --git a/tests/data/acpi/pc/DSDT.memhp b/tests/data/acpi/pc/DSDT.memhp
> index 2f895e9b385c1ae2f58c7ade4de02328b1be7356..811965f42d97adadde6e9ec6d6153e767041bc6d 100644
> GIT binary patch
> delta 19
> acmZ2(v)pDwJmcgfMinN8#LcaYi(~*q$_7gS
>
> delta 20
> bcmZ2(v)pDwJR@@fL*nFkMwQKNj0<G|OBe>Z
>
> diff --git a/tests/data/acpi/pc/DSDT.nohpet b/tests/data/acpi/pc/DSDT.nohpet
> index c012b63ace2f359eec0368ed22ef507ee3905c78..bbf73023ade329770ff9f9ac5c897218764182b5 100644
> GIT binary patch
> delta 19
> acmX?QaLQmqJmcgfMinN8#LcaYN5ue0UIvx`
>
> delta 20
> bcmX?QaLQmqJR@@fL*nFkMwQKNj7P)(PTB_q
>
> diff --git a/tests/data/acpi/pc/DSDT.numamem b/tests/data/acpi/pc/DSDT.numamem
> index f2ef4b97290cc58c514c3ce7fd45cb08214d7138..c5d93366a417ad1a92c01659f1db9c159caa7132 100644
> GIT binary patch
> delta 19
> acmca-c+YS{JmcgfMinN8#LcaYk>UVKc?MMg
>
> delta 20
> bcmca-c+YS{JR@@fL*nFkMwQKNj1l4hQ6C1w
>
> diff --git a/tests/data/acpi/pc/DSDT.roothp b/tests/data/acpi/pc/DSDT.roothp
> index 657c8263f0c649abc806a67576fd74cb32af60c3..9e3d482366bd800cf987044801eebc814629b15b 100644
> GIT binary patch
> delta 19
> acmbQ}Gtp;5JmcgfMinN8#LcaYJt_c0t_Cpx
>
> delta 20
> bcmbQ}Gtp;5JR@@fL*nFkMwQKNjNK{#N$>`r
>
> diff --git a/tests/data/acpi/q35/DSDT b/tests/data/acpi/q35/DSDT
> index d68c472b460e4609a64ea67de3c4cebfca76164d..c304e15e366d7317fd0e9db0a144f02e0437d7a1 100644
> GIT binary patch
> delta 19
> acmdnvu*YG864PW=CKV=z#LXT|Ut|G790nW!
>
> delta 20
> bcmdnvu*YG85)*R)L*is5CY8;eOrK=|NfZW(
>
> diff --git a/tests/data/acpi/q35/DSDT.acpierst b/tests/data/acpi/q35/DSDT.acpierst
> index de7ae27125f9667d7aa7a7cc0e8210773b61a2e2..3aa5c4b3193d32bb8263a1fe06c05b714541c532 100644
> GIT binary patch
> delta 19
> acmX@>aModi64PW=CKV=z#LXT|ta1QCqXkd^
>
> delta 20
> bcmX@>aModi5)*R)L*is5CY8;eOe}H$NxcQW
>
> diff --git a/tests/data/acpi/q35/DSDT.acpihmat b/tests/data/acpi/q35/DSDT.acpihmat
> index 48e2862257ac614b5fd6391c4ec425106c48afb1..3ffbf8f83f64144ace17ff5f06bcb4fec9df33d9 100644
> GIT binary patch
> delta 19
> acmaFq_0nsD64PW=CKV=z#LXT|ipl^;Bn7<y
>
> delta 20
> bcmaFq_0nsD5)*R)L*is5CY8;eObW^XPl^UB
>
> diff --git a/tests/data/acpi/q35/DSDT.acpihmat-noinitiator b/tests/data/acpi/q35/DSDT.acpihmat-noinitiator
> index 30a4aa2ec8feb6012a64d476ff37b14717d20eaf..ebec32b575d310f98937fe9208f0c60349ca753d 100644
> GIT binary patch
> delta 19
> acmccYblGWx64PW=CKV=z#LXT|-0}cJ%mrrv
>
> delta 20
> bcmccYblGWx5)*R)L*is5CY8;eOkDB+O7;cS
>
> diff --git a/tests/data/acpi/q35/DSDT.applesmc b/tests/data/acpi/q35/DSDT.applesmc
> index 84e2b5cbc4483ae93634f223160253231dcc4932..b0994644ec811b962e80f49e36e122967f5af1d1 100644
> GIT binary patch
> delta 19
> acmaFm@XBF>64PW=CKV=z#LXT|N^$^3@dc*<
>
> delta 20
> bcmaFm@XBF>5)*R)L*is5CY8;eOp0;<PDKV4
>
> diff --git a/tests/data/acpi/q35/DSDT.bridge b/tests/data/acpi/q35/DSDT.bridge
> index e411d40fd1e297879d78dcf15486dd465ab54568..8e11b8ea4862c8ec27376703c9c43e9895ca60eb 100644
> GIT binary patch
> delta 19
> acmcZ^c{6f@64PW=CKV=z#LXT|6SV+H$p$h2
>
> delta 20
> bcmcZ^c{6f@5)*R)L*is5CY8;eOcS&KP%Q?a
>
> diff --git a/tests/data/acpi/q35/DSDT.core-count2 b/tests/data/acpi/q35/DSDT.core-count2
> index 0603db8cc63cfc562f83e55eaf5162e7c29bf4d1..a895599c3c53c0cd0888ec166a30d6c036d26b93 100644
> GIT binary patch
> delta 21
> ccmeD9%h>Ukaf1@mWK|{=CWge#9!w5309TO)+W-In
>
> delta 22
> dcmeD9%h>Ukaf1>Qa{)u*WF;n*&7Ms5H2`0o2T1?`
>
> diff --git a/tests/data/acpi/q35/DSDT.cphp b/tests/data/acpi/q35/DSDT.cphp
> index beeb83c33b385fc8b41d44f299b8d9ba7203d935..725998cb587c02ac963f290bac5c14d665bc85e9 100644
> GIT binary patch
> delta 19
> acmeBi>2cYh#57rzNrj0aakB^05qSVRh6R=Y
>
> delta 20
> bcmeBi>2cYh#Kc^{kT_Y1NoBJq(_wi4LM8?T
>
> diff --git a/tests/data/acpi/q35/DSDT.cxl b/tests/data/acpi/q35/DSDT.cxl
> index 3d18b9672d124a0cf11a79e92c396a1b883d0589..04c2c66a25536854b4305787c8e0b41e96c3c133 100644
> GIT binary patch
> delta 19
> acmaFm^~!6564PW=CKV=z#LXT|O3DC8N(I0G
>
> delta 20
> bcmaFm^~!655)*R)L*is5CY8;eOp3|?PqGFs
>
> diff --git a/tests/data/acpi/q35/DSDT.dimmpxm b/tests/data/acpi/q35/DSDT.dimmpxm
> index 99a93e12a7faac78e9524ad6758f42c5c0df18eb..ef643b4ee02cacb9a55f89b8e7f05524125515a1 100644
> GIT binary patch
> delta 19
> acmdnwyUBNh64PW=CKV=z#LXT|St<ZQVFjN6
>
> delta 20
> bcmdnwyUBNh5)*R)L*is5CY8;eOqnVGNM8mG
>
> diff --git a/tests/data/acpi/q35/DSDT.ipmibt b/tests/data/acpi/q35/DSDT.ipmibt
> index 7f7601dbff820044aa646048c0bfe0e6324b9d0d..b136aea961c89a97db09db9b68809979564d8faf 100644
> GIT binary patch
> delta 19
> acmZp7Y<JwC#57rzNrj0aakB@Ly&M2JVFdsH
>
> delta 20
> bcmZp7Y<JwC#Kc^{kT_Y1NoBJqlbsv@Kk)@_
>
> diff --git a/tests/data/acpi/q35/DSDT.ipmismbus b/tests/data/acpi/q35/DSDT.ipmismbus
> index 6c5d1afe443d9261d3b93801711f8d5b267696f3..0970dbd5896fc0038b1369dbbcc982ead7736ae6 100644
> GIT binary patch
> delta 19
> acmbQ@IK^>;64PW=CKV=z#LXT|K5_s%PX#9c
>
> delta 20
> bcmbQ@IK^>;5)*R)L*is5CY8;eOx|(;LHPxh
>
> diff --git a/tests/data/acpi/q35/DSDT.ivrs b/tests/data/acpi/q35/DSDT.ivrs
> index de7ae27125f9667d7aa7a7cc0e8210773b61a2e2..3aa5c4b3193d32bb8263a1fe06c05b714541c532 100644
> GIT binary patch
> delta 19
> acmX@>aModi64PW=CKV=z#LXT|ta1QCqXkd^
>
> delta 20
> bcmX@>aModi5)*R)L*is5CY8;eOe}H$NxcQW
>
> diff --git a/tests/data/acpi/q35/DSDT.memhp b/tests/data/acpi/q35/DSDT.memhp
> index 79bce5c8f0132e72b8e700488ea56c7593737810..9709e5a7a7edcb7509954b553f7bf29a424033db 100644
> GIT binary patch
> delta 19
> acmeD7?)KiG#57rzNrj0aakB@LvoZiXQUxUd
>
> delta 20
> bcmeD7?)KiG#Kc^{kT_Y1NoBJqlan$4LH-4k
>
> diff --git a/tests/data/acpi/q35/DSDT.mmio64 b/tests/data/acpi/q35/DSDT.mmio64
> index c249929add97439ceb9f891d44c425311517ad18..e1cd01f2349bb8c2f7f8badad11441ffe6d57acc 100644
> GIT binary patch
> delta 19
> acmZ4Hxy*Be64PW=CKV=z#LXT|aY_I`4+U`m
>
> delta 20
> bcmZ4Hxy*Be5)*R)L*is5CY8;eOtDG;MePOO
>
> diff --git a/tests/data/acpi/q35/DSDT.multi-bridge b/tests/data/acpi/q35/DSDT.multi-bridge
> index f2f60fdbb3b44ab9adb69bb36e4a80978536af9b..3b9dffb565833cc87bbf08dadfc1f31ac858e93b 100644
> GIT binary patch
> delta 19
> acmZonYE0Uo#57rzNrj0aakB^0PCWoU?*+gB
>
> delta 20
> bcmZonYE0Uo#Kc^{kT_Y1NoBJq(+)iVM70Jk
>
> diff --git a/tests/data/acpi/q35/DSDT.nohpet b/tests/data/acpi/q35/DSDT.nohpet
> index 9ff9983a80a7487470ccd02ce587200444675816..2cf7f6db0fd8de357278f942a4082e714804dca9 100644
> GIT binary patch
> delta 19
> acmZ2yzs`Px64PW=CKV=z#LXT|X|e!5<^^y7
>
> delta 20
> bcmZ2yzs`Px5)*R)L*is5CY8;eOsTQ}MZg8#
>
> diff --git a/tests/data/acpi/q35/DSDT.numamem b/tests/data/acpi/q35/DSDT.numamem
> index 1e7c45ef3ccb000a06f64152622b4bd27916d181..310e3d5053b90863f96c29dd69a514b4999b4a19 100644
> GIT binary patch
> delta 19
> acmX@)aL8eU64PW=CKV=z#LXT|zhnVJ00u4q
>
> delta 20
> bcmX@)aL8eU5)*R)L*is5CY8;eOh07-N(2U+
>
> diff --git a/tests/data/acpi/q35/DSDT.pvpanic-isa b/tests/data/acpi/q35/DSDT.pvpanic-isa
> index ed47451c44e3041e5b7fed55de7b6ef1aca54350..6672b6fa05c8ee30a8ea4ab0931d59c1315a4e9c 100644
> GIT binary patch
> delta 19
> acmZ4JxX^Kf64PW=CKV=z#LXT|k#Yb%Jq1nx
>
> delta 20
> bcmZ4JxX^Kf5)*R)L*is5CY8;eOc8PbL;(f7
>
> diff --git a/tests/data/acpi/q35/DSDT.tis.tpm12 b/tests/data/acpi/q35/DSDT.tis.tpm12
> index efc2efc19f00ca7564467756616da44f5fd71cfe..eae2dc599331516e11632356f05d7831d1fa1e6a 100644
> GIT binary patch
> delta 19
> acmbQ`I?Hu~64PW=CKV=z#LXT|K?(poy#+%6
>
> delta 20
> bcmbQ`I?Hu~5)*R)L*is5CY8;eOo0jjLwg0W
>
> diff --git a/tests/data/acpi/q35/DSDT.tis.tpm2 b/tests/data/acpi/q35/DSDT.tis.tpm2
> index 675339715f72b4400445ce8c0dd12f416aa0efb0..68c6a7d244cfc78efa6b9cd1385f2134ca149ad7 100644
> GIT binary patch
> delta 19
> acmdnuy2W*a64PW=CKV=z#LXT|ISK$knFWym
>
> delta 20
> bcmdnuy2W*a5)*R)L*is5CY8;eOxX$mM~emj
>
> diff --git a/tests/data/acpi/q35/DSDT.viot b/tests/data/acpi/q35/DSDT.viot
> index eeb40b360f7c1de93501e1ddcd7dab306a51113b..4d2937a87c4a39993eaa756f02d59ef35a08f1c2 100644
> GIT binary patch
> delta 118
> zcmbQ}xzLl#CD<iop$Y>7Bf~~6A4W#e$>EGUg}4G-f_-@x_^?gRVki(~W@Jd1tjeTf
> z%#c{%=;;#C+>yh;03;Y0k`^dUs-2v~Fgc0mKM*j~CNd`0CRQ?Xu`@tu*2#rT1{@36
> QCuec7E@9lfkm-XW0I$^}K>z>%
>
> delta 101
> zcmZ4JInk5LCD<ioq6z~8qtiw%A4W!z$>EGUML7dpf_-@xxUfymVki(~W@JbxU`U*-
> z#H6C(=;;#C+>yh;03;Y0k`_o!s-2v~Fgc0mKM*j~CNd`0CRQ?Xu}`jKGT6M4>4PEw
> DoVXuG
>
> diff --git a/tests/data/acpi/q35/DSDT.xapic b/tests/data/acpi/q35/DSDT.xapic
> index 3aa86f07243f0449c7dc245650715d729744e3ee..e9b4881bdc72eb7c59dcf258c1a98363b46bfbcd 100644
> GIT binary patch
> delta 21
> dcmbO~jcNWgrVUC=lU12im>3c_doW$^002#l2H*ey
>
> delta 22
> ecmbO~jcNWgrVUC=%moaIla-iMHhVH%>i_^$`Ug$`
>
> --
> 2.39.1
^ permalink raw reply [flat|nested] 46+ messages in thread
* [PATCH 15/33] tests: acpi: whitelist DSDT before adding EDSM method
2023-02-24 15:37 [PATCH 00/33] pci(pc/q35): acpi-index support on non-hotpluggable slots Igor Mammedov
` (13 preceding siblings ...)
2023-02-24 15:37 ` [PATCH 14/33] tests: acpi: update expected blobs Igor Mammedov
@ 2023-02-24 15:37 ` Igor Mammedov
2023-02-24 15:37 ` [PATCH 16/33] acpi: pci: add EDSM method to DSDT Igor Mammedov
` (18 subsequent siblings)
33 siblings, 0 replies; 46+ messages in thread
From: Igor Mammedov @ 2023-02-24 15:37 UTC (permalink / raw)
To: qemu-devel; +Cc: mst, ani, berrange
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
tests/qtest/bios-tables-test-allowed-diff.h | 37 +++++++++++++++++++++
1 file changed, 37 insertions(+)
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
index dfb8523c8b..8911b10650 100644
--- a/tests/qtest/bios-tables-test-allowed-diff.h
+++ b/tests/qtest/bios-tables-test-allowed-diff.h
@@ -1 +1,38 @@
/* List of comma-separated changed AML files to ignore */
+"tests/data/acpi/pc/DSDT",
+"tests/data/acpi/pc/DSDT.acpierst",
+"tests/data/acpi/pc/DSDT.acpihmat",
+"tests/data/acpi/pc/DSDT.bridge",
+"tests/data/acpi/pc/DSDT.cphp",
+"tests/data/acpi/pc/DSDT.dimmpxm",
+"tests/data/acpi/pc/DSDT.hpbridge",
+"tests/data/acpi/pc/DSDT.hpbrroot",
+"tests/data/acpi/pc/DSDT.ipmikcs",
+"tests/data/acpi/pc/DSDT.memhp",
+"tests/data/acpi/pc/DSDT.nohpet",
+"tests/data/acpi/pc/DSDT.numamem",
+"tests/data/acpi/pc/DSDT.roothp",
+"tests/data/acpi/q35/DSDT",
+"tests/data/acpi/q35/DSDT.acpierst",
+"tests/data/acpi/q35/DSDT.acpihmat",
+"tests/data/acpi/q35/DSDT.acpihmat-noinitiator",
+"tests/data/acpi/q35/DSDT.applesmc",
+"tests/data/acpi/q35/DSDT.bridge",
+"tests/data/acpi/q35/DSDT.core-count2",
+"tests/data/acpi/q35/DSDT.cphp",
+"tests/data/acpi/q35/DSDT.cxl",
+"tests/data/acpi/q35/DSDT.dimmpxm",
+"tests/data/acpi/q35/DSDT.ipmibt",
+"tests/data/acpi/q35/DSDT.ipmismbus",
+"tests/data/acpi/q35/DSDT.ivrs",
+"tests/data/acpi/q35/DSDT.memhp",
+"tests/data/acpi/q35/DSDT.mmio64",
+"tests/data/acpi/q35/DSDT.multi-bridge",
+"tests/data/acpi/q35/DSDT.noacpihp",
+"tests/data/acpi/q35/DSDT.nohpet",
+"tests/data/acpi/q35/DSDT.numamem",
+"tests/data/acpi/q35/DSDT.pvpanic-isa",
+"tests/data/acpi/q35/DSDT.tis.tpm12",
+"tests/data/acpi/q35/DSDT.tis.tpm2",
+"tests/data/acpi/q35/DSDT.viot",
+"tests/data/acpi/q35/DSDT.xapic",
--
2.39.1
^ permalink raw reply related [flat|nested] 46+ messages in thread* [PATCH 16/33] acpi: pci: add EDSM method to DSDT
2023-02-24 15:37 [PATCH 00/33] pci(pc/q35): acpi-index support on non-hotpluggable slots Igor Mammedov
` (14 preceding siblings ...)
2023-02-24 15:37 ` [PATCH 15/33] tests: acpi: whitelist DSDT before adding EDSM method Igor Mammedov
@ 2023-02-24 15:37 ` Igor Mammedov
2023-02-24 15:37 ` [PATCH 17/33] tests: acpi: update expected blobs Igor Mammedov
` (17 subsequent siblings)
33 siblings, 0 replies; 46+ messages in thread
From: Igor Mammedov @ 2023-02-24 15:37 UTC (permalink / raw)
To: qemu-devel; +Cc: mst, ani, berrange
it's a helper method for acpi-index support on PCI buses
that do no support or have disabled ACPI PCI hotplug
or for non-hotpluggble endpoint devices.
(like non-hotpluggble NICs, integrated endpoints and
later for machines that do not support ACPI PCI hotplug)
no functional change, commit adds only EDSM method in DSDT
without any users. (the follow up patches will use it)
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
hw/i386/acpi-build.c | 54 ++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 54 insertions(+)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index cb80b7a318..8db65663fc 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -398,6 +398,58 @@ static void build_append_pci_dsm_func0_common(Aml *ctx, Aml *retvar)
aml_append(ctx, ifctx1);
}
+static Aml *aml_pci_edsm(void)
+{
+ Aml *method, *ifctx;
+ Aml *zero = aml_int(0);
+ Aml *func = aml_arg(2);
+ Aml *ret = aml_local(0);
+ Aml *aidx = aml_local(1);
+ Aml *params = aml_arg(4);
+
+ method = aml_method("EDSM", 5, AML_SERIALIZED);
+
+ /* get supported functions */
+ ifctx = aml_if(aml_equal(func, zero));
+ {
+ /* 1: have supported functions */
+ /* 7: support for function 7 */
+ const uint8_t caps = 1 | BIT(7);
+ build_append_pci_dsm_func0_common(ifctx, ret);
+ aml_append(ifctx, aml_store(aml_int(caps), aml_index(ret, zero)));
+ aml_append(ifctx, aml_return(ret));
+ }
+ aml_append(method, ifctx);
+
+ /* handle specific functions requests */
+ /*
+ * PCI Firmware Specification 3.1
+ * 4.6.7. _DSM for Naming a PCI or PCI Express Device Under
+ * Operating Systems
+ */
+ ifctx = aml_if(aml_equal(func, aml_int(7)));
+ {
+ Aml *pkg = aml_package(2);
+ aml_append(pkg, zero);
+ /* optional, if not impl. should return null string */
+ aml_append(pkg, aml_string("%s", ""));
+ aml_append(ifctx, aml_store(pkg, ret));
+
+ /*
+ * IASL is fine when initializing Package with computational data,
+ * however it makes guest unhappy /it fails to process such AML/.
+ * So use runtime assignment to set acpi-index after initializer
+ * to make OSPM happy.
+ */
+ aml_append(ifctx,
+ aml_store(aml_derefof(aml_index(params, aml_int(0))), aidx));
+ aml_append(ifctx, aml_store(aidx, aml_index(ret, zero)));
+ aml_append(ifctx, aml_return(ret));
+ }
+ aml_append(method, ifctx);
+
+ return method;
+}
static void build_append_pcihp_notify_entry(Aml *method, int slot)
{
@@ -1397,6 +1449,7 @@ build_dsdt(GArray *table_data, BIOSLinker *linker,
aml_append(dev, aml_name_decl("_HID", aml_eisaid("PNP0A03")));
aml_append(dev, aml_name_decl("_ADR", aml_int(0)));
aml_append(dev, aml_name_decl("_UID", aml_int(pcmc->pci_root_uid)));
+ aml_append(dev, aml_pci_edsm());
aml_append(sb_scope, dev);
aml_append(dsdt, sb_scope);
@@ -1412,6 +1465,7 @@ build_dsdt(GArray *table_data, BIOSLinker *linker,
aml_append(dev, aml_name_decl("_ADR", aml_int(0)));
aml_append(dev, aml_name_decl("_UID", aml_int(pcmc->pci_root_uid)));
aml_append(dev, build_q35_osc_method(!pm->pcihp_bridge_en));
+ aml_append(dev, aml_pci_edsm());
aml_append(sb_scope, dev);
if (mcfg_valid) {
aml_append(sb_scope, build_q35_dram_controller(&mcfg));
--
2.39.1
^ permalink raw reply related [flat|nested] 46+ messages in thread* [PATCH 17/33] tests: acpi: update expected blobs
2023-02-24 15:37 [PATCH 00/33] pci(pc/q35): acpi-index support on non-hotpluggable slots Igor Mammedov
` (15 preceding siblings ...)
2023-02-24 15:37 ` [PATCH 16/33] acpi: pci: add EDSM method to DSDT Igor Mammedov
@ 2023-02-24 15:37 ` Igor Mammedov
2023-02-24 15:37 ` [PATCH 18/33] tests: acpi: whitelist DSDT before adding device with acpi-index to testcases Igor Mammedov
` (16 subsequent siblings)
33 siblings, 0 replies; 46+ messages in thread
From: Igor Mammedov @ 2023-02-24 15:37 UTC (permalink / raw)
To: qemu-devel; +Cc: mst, ani, berrange
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
tests/qtest/bios-tables-test-allowed-diff.h | 37 ------------------
tests/data/acpi/pc/DSDT | Bin 6360 -> 6454 bytes
tests/data/acpi/pc/DSDT.acpierst | Bin 6283 -> 6377 bytes
tests/data/acpi/pc/DSDT.acpihmat | Bin 7685 -> 7779 bytes
tests/data/acpi/pc/DSDT.bridge | Bin 12487 -> 12581 bytes
tests/data/acpi/pc/DSDT.cphp | Bin 6824 -> 6918 bytes
tests/data/acpi/pc/DSDT.dimmpxm | Bin 8014 -> 8108 bytes
tests/data/acpi/pc/DSDT.hpbridge | Bin 6323 -> 6417 bytes
tests/data/acpi/pc/DSDT.hpbrroot | Bin 3166 -> 3260 bytes
tests/data/acpi/pc/DSDT.ipmikcs | Bin 6432 -> 6526 bytes
tests/data/acpi/pc/DSDT.memhp | Bin 7719 -> 7813 bytes
tests/data/acpi/pc/DSDT.nohpet | Bin 6218 -> 6312 bytes
tests/data/acpi/pc/DSDT.numamem | Bin 6366 -> 6460 bytes
tests/data/acpi/pc/DSDT.roothp | Bin 9745 -> 9839 bytes
tests/data/acpi/q35/DSDT | Bin 8252 -> 8344 bytes
tests/data/acpi/q35/DSDT.acpierst | Bin 8269 -> 8361 bytes
tests/data/acpi/q35/DSDT.acpihmat | Bin 9577 -> 9669 bytes
tests/data/acpi/q35/DSDT.acpihmat-noinitiator | Bin 8531 -> 8623 bytes
tests/data/acpi/q35/DSDT.applesmc | Bin 8298 -> 8390 bytes
tests/data/acpi/q35/DSDT.bridge | Bin 11481 -> 11573 bytes
tests/data/acpi/q35/DSDT.core-count2 | Bin 32392 -> 32484 bytes
tests/data/acpi/q35/DSDT.cphp | Bin 8716 -> 8808 bytes
tests/data/acpi/q35/DSDT.cxl | Bin 9578 -> 9670 bytes
tests/data/acpi/q35/DSDT.dimmpxm | Bin 9906 -> 9998 bytes
tests/data/acpi/q35/DSDT.ipmibt | Bin 8327 -> 8419 bytes
tests/data/acpi/q35/DSDT.ipmismbus | Bin 8340 -> 8432 bytes
tests/data/acpi/q35/DSDT.ivrs | Bin 8269 -> 8361 bytes
tests/data/acpi/q35/DSDT.memhp | Bin 9611 -> 9703 bytes
tests/data/acpi/q35/DSDT.mmio64 | Bin 9382 -> 9474 bytes
tests/data/acpi/q35/DSDT.multi-bridge | Bin 12545 -> 12637 bytes
tests/data/acpi/q35/DSDT.noacpihp | Bin 8022 -> 8114 bytes
tests/data/acpi/q35/DSDT.nohpet | Bin 8110 -> 8202 bytes
tests/data/acpi/q35/DSDT.numamem | Bin 8258 -> 8350 bytes
tests/data/acpi/q35/DSDT.pvpanic-isa | Bin 8353 -> 8445 bytes
tests/data/acpi/q35/DSDT.tis.tpm12 | Bin 8858 -> 8950 bytes
tests/data/acpi/q35/DSDT.tis.tpm2 | Bin 8884 -> 8976 bytes
tests/data/acpi/q35/DSDT.viot | Bin 9377 -> 9469 bytes
tests/data/acpi/q35/DSDT.xapic | Bin 35615 -> 35707 bytes
38 files changed, 37 deletions(-)
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
index 8911b10650..dfb8523c8b 100644
--- a/tests/qtest/bios-tables-test-allowed-diff.h
+++ b/tests/qtest/bios-tables-test-allowed-diff.h
@@ -1,38 +1 @@
/* List of comma-separated changed AML files to ignore */
-"tests/data/acpi/pc/DSDT",
-"tests/data/acpi/pc/DSDT.acpierst",
-"tests/data/acpi/pc/DSDT.acpihmat",
-"tests/data/acpi/pc/DSDT.bridge",
-"tests/data/acpi/pc/DSDT.cphp",
-"tests/data/acpi/pc/DSDT.dimmpxm",
-"tests/data/acpi/pc/DSDT.hpbridge",
-"tests/data/acpi/pc/DSDT.hpbrroot",
-"tests/data/acpi/pc/DSDT.ipmikcs",
-"tests/data/acpi/pc/DSDT.memhp",
-"tests/data/acpi/pc/DSDT.nohpet",
-"tests/data/acpi/pc/DSDT.numamem",
-"tests/data/acpi/pc/DSDT.roothp",
-"tests/data/acpi/q35/DSDT",
-"tests/data/acpi/q35/DSDT.acpierst",
-"tests/data/acpi/q35/DSDT.acpihmat",
-"tests/data/acpi/q35/DSDT.acpihmat-noinitiator",
-"tests/data/acpi/q35/DSDT.applesmc",
-"tests/data/acpi/q35/DSDT.bridge",
-"tests/data/acpi/q35/DSDT.core-count2",
-"tests/data/acpi/q35/DSDT.cphp",
-"tests/data/acpi/q35/DSDT.cxl",
-"tests/data/acpi/q35/DSDT.dimmpxm",
-"tests/data/acpi/q35/DSDT.ipmibt",
-"tests/data/acpi/q35/DSDT.ipmismbus",
-"tests/data/acpi/q35/DSDT.ivrs",
-"tests/data/acpi/q35/DSDT.memhp",
-"tests/data/acpi/q35/DSDT.mmio64",
-"tests/data/acpi/q35/DSDT.multi-bridge",
-"tests/data/acpi/q35/DSDT.noacpihp",
-"tests/data/acpi/q35/DSDT.nohpet",
-"tests/data/acpi/q35/DSDT.numamem",
-"tests/data/acpi/q35/DSDT.pvpanic-isa",
-"tests/data/acpi/q35/DSDT.tis.tpm12",
-"tests/data/acpi/q35/DSDT.tis.tpm2",
-"tests/data/acpi/q35/DSDT.viot",
-"tests/data/acpi/q35/DSDT.xapic",
diff --git a/tests/data/acpi/pc/DSDT b/tests/data/acpi/pc/DSDT
index ec133a6d3aabcfd22b7b46019338db2de255da70..521062a756d1fcd5939683e41071d29407a45b22 100644
GIT binary patch
delta 111
zcmca%xXp;mCD<jzOp<|tv1=k%s-6Q!e6Uk|bdv{rfU~CoN4$rp3y<RkE@qB+N0%T5
zj`&bd7X}e;R#%r`U)}{~lfxKwRk<2F5*QekBrK4boW;dnAjHbVz{`+O(A<&3z>rvw
L2$9@4(Om)nP{SR3
delta 57
zcmdmHbi<I#CD<k8h6Dox<GG1ksY*)m!A|kfP0|6*o(3H89-b~dju*I?IpQ5%f*3gB
NLp@y>HokY4008b%5ODwi
diff --git a/tests/data/acpi/pc/DSDT.acpierst b/tests/data/acpi/pc/DSDT.acpierst
index 2b4b7f31919f360e038e37de713639da753f13aa..12b9e94bf1449995d460edffd40d1ff7b9f292cc 100644
GIT binary patch
delta 111
zcmeA+d}+w#66_N4Qi6ejk!vDXs-6Q!e6Uk|bdv{rfU~CoN4$rp3y<RkE@qB+N0%T5
zj`&bd7X}e;R#%r`U)}{~lfxKwRk<2F5*QekBrK4boW;dnAjHbVz{`+O(A<&3z>rvw
L2$9@4@s~INTzwuz
delta 57
zcmaE9*loz=66_MvEy2LR=sS@sRY@s6*eO1`NjkvU(|{x1!_$Sw@d6h!N4%p;5Ccbi
MsHY3V#`nL(0md{CIsgCw
diff --git a/tests/data/acpi/pc/DSDT.acpihmat b/tests/data/acpi/pc/DSDT.acpihmat
index 714a123e7a500cf0f862ff6c4e9a3f50a96af056..876d0184d8d56cc2fc9d4c0a619d5d449ba81687 100644
GIT binary patch
delta 111
zcmZp*d2GYw66_L^EXTmW=suAvRnLJVKG-Qfy2*n*z}eG)Bi_T)g~#y%7c)n^qe~D2
zM|`NK3xkL^tE)?}FYf}g$zhDTs$7j72@DKN5*Elz&f;P(5MpIw;AKcCXzs{iU`Q-T
Lgh+0jSRxAmL&P17
delta 57
zcmaEC(`v)z66_MfD#yUU*fo(WRY@s6*eO1`NjkvU(|{x1!_$Sw@d6h!N4%p;5Ccbi
MsHY3V#`h(%0J(t=fdBvi
diff --git a/tests/data/acpi/pc/DSDT.bridge b/tests/data/acpi/pc/DSDT.bridge
index 6c0543cf75ad3e02468ed4925fd3369a183e9b45..219ddba2713015616e41c19f66d891c63b05e4ab 100644
GIT binary patch
delta 111
zcmX?}xHO5&CD<iI)sTUK@zO-DR6Pfd_+Y2_=q3;L0B27Fj(87G7aqq8T+AHtjxIqA
z9Py!^E({{xtgbG>zPt;}CWkTVs&X}UBrq^6Nmw8=Ig5+EK!}xzftMknpt&Q5fg!OV
L5hA&9qL~2zi1!{4
delta 57
zcmZ3QbUcyECD<k8xB&wLqu4~QR3)YOV5j)#Cg}iYPXms44^I~!#|vD{9Py4WK@1%6
Np`I=b8{eB5007;{5Cs4L
diff --git a/tests/data/acpi/pc/DSDT.cphp b/tests/data/acpi/pc/DSDT.cphp
index e1bcb0a4f3ee1269bdd5e949206b40d0e3c076e6..5b5b352a13947a48f98e46409b9ad9664b4de9bc 100644
GIT binary patch
delta 111
zcmZ2s+GfV(66_MfCe6UW_--Oss-6Q!e6Uk|bdv{rfU~CoN4$rp3y<RkE@qB+N0%T5
zj`&bd7X}e;R#%r`U)}{~lfxKwRk<2F5*QekBrK4boW;dnAjHbVz{`+O(A<&3z>rvw
L2$9@4QCtcDJ{uh@
delta 57
zcmZoOTVcxO66_MPLW+Tb(P$!9s*+NCuv2_=lXQTyrvXR2ho=jV;{`5ej(A6xAO?>3
MP)`?zjqk;!0Jqi;ApigX
diff --git a/tests/data/acpi/pc/DSDT.dimmpxm b/tests/data/acpi/pc/DSDT.dimmpxm
index 1c90e119c5d3dc7e86d04942114e5cfe40de6039..fbe755975d94e5e607820bb7acb2fb189b1105ee 100644
GIT binary patch
delta 111
zcmX?Sx5l2!CD<iojXVPb<F1KZsd^3^@xe~<(M=xg0nVNV9Pu8WE<BDGxR^QO9bJML
zIO0P+T^K~XSzTR%eR&s{O%7w!Rpn~zNMK-ClCVH#auyeRfe<Sb1202DL32kA14Cj#
LB1CfI#JzF=m%$#Y
delta 57
zcmZ2uf6k7}CD<jzPo9B+@$W>gR3)YOV5j)#Cg}iYPXms44^I~!#|vD{9Py4WK@1%6
Np`I=b8{hAh0|4L15T5`5
diff --git a/tests/data/acpi/pc/DSDT.hpbridge b/tests/data/acpi/pc/DSDT.hpbridge
index 04e1c20f63be7c6c574e72590332707ca410852a..12d7daf950ba93deaeb67655d303df3960569a64 100644
GIT binary patch
delta 111
zcmdmNIMIm9CD<iIP?CXx@#{pcR6Pfd_+Y2_=q3;L0B27Fj(87G7aqq8T+AHtjxIqA
z9Py!^E({{xtgbG>zPt;}CWkTVs&X}UBrq^6Nmw8=Ig5+EK!}xzftMknpt&Q5fg!OV
L5hA&9qLKsvN_rhr
delta 57
zcmbPewAql$CD<iovjhVJqvb@dR3)YOV5j)#Cg}iYPXms44^I~!#|vD{9Py4WK@1%6
Np`I=b8{aEQ006z=4@dw2
diff --git a/tests/data/acpi/pc/DSDT.hpbrroot b/tests/data/acpi/pc/DSDT.hpbrroot
index 893ab221c2cca1829937a4c26152680313633df4..bfe0bf37180c0f0521d264d3e35b5f51feff2630 100644
GIT binary patch
delta 152
zcmca7u}6~2CD<io4-W$aqyI#%)OrVw_+Y2_=q3;L0B27Fj(87G7aqq8T+AHtjxIqA
z9Py!^E({{xtgbG>zPt;}CTB4e2r@G=BrK4cG&w_1m`mV-`N^ljrd7TZ#b5bK9(ML!
zlCXe%Y9<%cl7s@T#*PFA2B3h<<SZ`s0wGo=2404Qg657K28P6fM6e`d!p4bbxdG~5
BEdl@l
delta 57
zcmdlZc~64NCD<h-j)#GPaneMtR3)YOV5j)#Cg}iYPXms44^I~!#|vD{9Py4WK@1%6
Np`I=b8{ePh1^~nh5CQ-I
diff --git a/tests/data/acpi/pc/DSDT.ipmikcs b/tests/data/acpi/pc/DSDT.ipmikcs
index 3c2aba132f10b5e4a9931877533a9d8f260b7381..3a19ce439825c2aa97adee3a965ac050dec6f2d0 100644
GIT binary patch
delta 111
zcmZ2r^v{UPCD<jTPLhFvk!>PZs-6Q!e6Uk|bdv{rfU~CoN4$rp3y<RkE@qB+N0%T5
zj`&bd7X}e;R#%r`U)}{~lfxKwRk<2F5*QekBrK4boW;dnAjHbVz{`+O(A<&3z>rvw
L2$9@4v0nlJLd_kS
delta 57
zcmexow7`hVCD<iIL6U)i(Q_hKs*+NCuv2_=lXQTyrvXR2ho=jV;{`5ej(A6xAO?>3
MP)`?zjqm#<0J?AwjsO4v
diff --git a/tests/data/acpi/pc/DSDT.memhp b/tests/data/acpi/pc/DSDT.memhp
index 811965f42d97adadde6e9ec6d6153e767041bc6d..8ad5c523fdf76b90286a145f797454dff6da050c 100644
GIT binary patch
delta 111
zcmZ2((`w7*66_MvD#yUUSTm6;RnLJVKG-Qfy2*n*z}eG)Bi_T)g~#y%7c)n^qe~D2
zM|`NK3xkL^tE)?}FYf}g$zhDTs$7j72@DKN5*Elz&f;P(5MpIw;AKcCXzs{iU`Q-T
Lgh+0jI87D+OwAq2
delta 57
zcmZp*U2enW66_M9F2}&YxPKy7s*+NCuv2_=lXQTyrvXR2ho=jV;{`5ej(A6xAO?>3
NP)`?zjqj()0sy<D55E8a
diff --git a/tests/data/acpi/pc/DSDT.nohpet b/tests/data/acpi/pc/DSDT.nohpet
index bbf73023ade329770ff9f9ac5c897218764182b5..4fd4d38e5ffe889fed812b67d3d7b1825325e909 100644
GIT binary patch
delta 111
zcmX?Qu)>hbCD<iog#-fwW5`6VR6Pfd_+Y2_=q3;L0B27Fj(87G7aqq8T+AHtjxIqA
z9Py!^E({{xtgbG>zPt;}CWkTVs&X}UBrq^6Nmw8=Ig5+EK!}xzftMknpt&Q5fg!OV
L5hA&9;!be@T~!_m
delta 57
zcmZ2sc*=mwCD<jzOM-!car#8AR3)YOV5j)#Cg}iYPXms44^I~!#|vD{9Py4WK@1%6
Np`I=b8{h8~2LQy%5B~rF
diff --git a/tests/data/acpi/pc/DSDT.numamem b/tests/data/acpi/pc/DSDT.numamem
index c5d93366a417ad1a92c01659f1db9c159caa7132..4cfb3765c5c5c7cf73732f2d3fd5bf9932399c14 100644
GIT binary patch
delta 111
zcmca-xW|agCD<jzMv{Sn(PSc5s-6Q!e6Uk|bdv{rfU~CoN4$rp3y<RkE@qB+N0%T5
zj`&bd7X}e;R#%r`U)}{~lfxKwRk<2F5*QekBrK4boW;dnAjHbVz{`+O(A<&3z>rvw
L2$9@4(N_WhH^m)3
delta 57
zcmdmEbkC5>CD<k8o&*B}W5q<SR3)YOV5j)#Cg}iYPXms44^I~!#|vD{9Py4WK@1%6
Np`I=b8{hj%0085x5HkP(
diff --git a/tests/data/acpi/pc/DSDT.roothp b/tests/data/acpi/pc/DSDT.roothp
index 9e3d482366bd800cf987044801eebc814629b15b..8b695cca83c04b4123986e1334d0c57ddb22687d 100644
GIT binary patch
delta 111
zcmbQ}^WKNcCD<h-UyXr*QFS6$s-6Q!e6Uk|bdv{rfU~CoN4$rp3y<RkE@qB+N0%T5
zj`&bd7X}e;R#%r`U)}{~lfxKwRk<2F5*QekBrK4boW;dnAjHbVz{`+O(A<&3z>rvw
L2$9@4u|X98R^lDX
delta 57
zcmaFwGtr03CD<iIP>q3sF=HZEs*+NCuv2_=lXQTyrvXR2ho=jV;{`5ej(A6xAO?>3
MP)`?zjqe*&0mH)&zW@LL
diff --git a/tests/data/acpi/q35/DSDT b/tests/data/acpi/q35/DSDT
index c304e15e366d7317fd0e9db0a144f02e0437d7a1..3dadeba912d9133f0ccb6e9b89a22ca7dc43f18f 100644
GIT binary patch
delta 90
zcmdnvFvF3{CD<ioh5`cv<LrrCsa%dC@xe~<(M|sR6Dt>TiFmWRx&-_3E-;%c$)u~w
q)!321z_27?fz0GAF7^T;Rwf2shJ=FVjvNMt#DYYK<Yp;GC3ygdD;U54
delta 37
tcmbQ?xW|FZCD<jzMuCBWaq2{_R4!M(_+Y2_=q6{biIodCmoX~I0|3iS3h@8{
diff --git a/tests/data/acpi/q35/DSDT.acpierst b/tests/data/acpi/q35/DSDT.acpierst
index 3aa5c4b3193d32bb8263a1fe06c05b714541c532..7e43fa88c39737198427744ddb8d902edd517794 100644
GIT binary patch
delta 90
zcmX@>u+ovsCD<ior2+#3qxD3tR4zx6_+Y2_=q7*uiIoevM7&vDU4ngi7nn_!WYSgT
qYV1g0U|5o{KxT3l7khyaD-#1RLqb7wM-Br+VnHHAa<depu{;2M02rhI
delta 37
scmZ4Kc-Dc-CD<jzSAl_n(R3nLDwiu?e6Uk|bdxjJ#L9)6%NUL20m*X;)c^nh
diff --git a/tests/data/acpi/q35/DSDT.acpihmat b/tests/data/acpi/q35/DSDT.acpihmat
index 3ffbf8f83f64144ace17ff5f06bcb4fec9df33d9..7c626642ba1ef231ee4e1353330ca9ae2955f37f 100644
GIT binary patch
delta 90
zcmaFqb<~^7CD<k8s44>kW5h(RR4zx6_+Y2_=q7*uiIoevM7&vDU4ngi7nn_!WYSgT
qYV1g0U|5o{KxT3l7khyaD-#1RLqb7wM-Br+VnHHAa<depzX|}Vof%I6
delta 37
scmX@={nCreCD<h-Q<Z^%F=!%JDwiu?e6Uk|bdxjJ#L9)6%NYGt0NQ>FfB*mh
diff --git a/tests/data/acpi/q35/DSDT.acpihmat-noinitiator b/tests/data/acpi/q35/DSDT.acpihmat-noinitiator
index ebec32b575d310f98937fe9208f0c60349ca753d..631a1048fc01a3c84aadfdea8e0eccc36c68d8a4 100644
GIT binary patch
delta 90
zcmccYwBDJ^CD<ioy&?kxqvAxaR4zx6_+Y2_=q7*uiIoevM7&vDU4ngi7nn_!WYSgT
qYV1g0U|5o{KxT3l7khyaD-#1RLqb7wM-Br+VnHHAa<depr2+tb7Z|7j
delta 37
scmZ4QeA$W1CD<h-SdoE&QF<a*Dwiu?e6Uk|bdxjJ#L9)6%NQ*c0Lm!}*#H0l
diff --git a/tests/data/acpi/q35/DSDT.applesmc b/tests/data/acpi/q35/DSDT.applesmc
index b0994644ec811b962e80f49e36e122967f5af1d1..cb117fd671effe2557a41115015b57df87d7936b 100644
GIT binary patch
delta 90
zcmaFmaLkd*CD<k8m;wU>WA{X^R4zx6_+Y2_=q7*uiIoevM7&vDU4ngi7nn_!WYSgT
qYV1g0U|5o{KxT3l7khyaD-#1RLqb7wM-Br+VnHHAa<dd;fII-QQ5k3e
delta 37
scmX@+_{xFHCD<h-OM!ubv2`L>Dwiu?e6Uk|bdxjJ#L9)6%NPUX0o*YQnE(I)
diff --git a/tests/data/acpi/q35/DSDT.bridge b/tests/data/acpi/q35/DSDT.bridge
index 8e11b8ea4862c8ec27376703c9c43e9895ca60eb..cdfd51ce70d7201fa827bfabfd23e413596b1094 100644
GIT binary patch
delta 90
zcmcZ^xiyN*CD<jzRF{E)k$)mrDwm^3e6Uk|bdx{-#L9(SBHpa7F2TOM3(O`<GU=*v
qHFhL0Ff2(}ATv3Oi@iXIm5G6uA)%nTBZq+@u^<s5xmk*Fzcv7A_!#p5
delta 37
tcmdlQbu*I7CD<k8rVaxGBiBT(R4!M(_+Y2_=q6{biIodCmoe_w1_0rN3?u*m
diff --git a/tests/data/acpi/q35/DSDT.core-count2 b/tests/data/acpi/q35/DSDT.core-count2
index a895599c3c53c0cd0888ec166a30d6c036d26b93..2bf77bb4e1a433eab66d0fdd175344d4f8d6e168 100644
GIT binary patch
delta 92
zcmeD9%lPCkBbQ6COURQt1_s7$6S-2k97W=To#LaL{P`zVF60vNW_5K5_T^n*Hd&HM
sSCy-=BY}ZoNx}k|$yr?N1wyP$47>~p1<f5f3=D|{i4e)nQjB@E09CIW!T<mO
delta 39
vcmaFzm$Bn7BbQ6COGrl@0|VoRiCn2%u6*&qPVv!A&Ri2K7j7<N%&P?e9rF$I
diff --git a/tests/data/acpi/q35/DSDT.cphp b/tests/data/acpi/q35/DSDT.cphp
index 725998cb587c02ac963f290bac5c14d665bc85e9..1837442bd39f1249fb753530ea508d05e8d177f4 100644
GIT binary patch
delta 90
zcmeBidEvt466_L^p~S$z_<tf-Dwm^3e6Uk|bdx{-#L9(SBHpa7F2TOM3(O`<GU=*v
qHFhL0Ff2(}ATv3Oi@iXIm5G6uA)%nTBZq+@u^<s5xmk+wlL7#x^%?E}
delta 37
tcmaFi(&NJA66_Mfqr||#_;VsxDwiu?e6Uk|bdxjJ#L9)6%NRc?007q13?Bdh
diff --git a/tests/data/acpi/q35/DSDT.cxl b/tests/data/acpi/q35/DSDT.cxl
index 04c2c66a25536854b4305787c8e0b41e96c3c133..023da0665f9123943e23fd771725f4b8eb937135 100644
GIT binary patch
delta 90
zcmaFmb<CT~CD<k8m?{GU<CKY9sa%dC@xe~<(M|sR6Dt>TiFmWRx&-_3E-;%c$)u~w
q)!321z_27?fz0GAF7^T;Rwf2shJ=FVjvNMt#DYYK<Yp<x02Kheav6^R
delta 37
scmX@+{mP5WCD<h-OO=6vv2P+*Dwiu?e6Uk|bdxjJ#L9)6%NPSx0N_XqzyJUM
diff --git a/tests/data/acpi/q35/DSDT.dimmpxm b/tests/data/acpi/q35/DSDT.dimmpxm
index ef643b4ee02cacb9a55f89b8e7f05524125515a1..2ad9b1c30e9a583cc43e8efbc1e276b4f221ff28 100644
GIT binary patch
delta 90
zcmdnw+vmsS66_Mfr_R8@cxob7Dwm^3e6Uk|bdx{-#L9(SBHpa7F2TOM3(O`<GU=*v
qHFhL0Ff2(}ATv3Oi@iXIm5G6uA)%nTBZq+@u^<s5xmk*FhAIGWlNjy*
delta 37
tcmeD4+vLmT66_MPNsWPl@#sXZR4!M(_+Y2_=q6{biIodCmod&z1pwaH3?Bdh
diff --git a/tests/data/acpi/q35/DSDT.ipmibt b/tests/data/acpi/q35/DSDT.ipmibt
index b136aea961c89a97db09db9b68809979564d8faf..c552e668983198d077348a57a5b22065d01b40f1 100644
GIT binary patch
delta 90
zcmZp7eC){O66_N4Sb>3o@xVl`R4zx6_+Y2_=q7*uiIoevM7&vDU4ngi7nn_!WYSgT
qYV1g0U|5o{KxT3l7khyaD-#1RLqb7wM-Br+VnHHAa<dd;t~>y;_ZgA^
delta 37
scmaFt*zU;X66_MvuE4;+xN9O;Dwiu?e6Uk|bdxjJ#L9)6%NTRz0ox=C!vFvP
diff --git a/tests/data/acpi/q35/DSDT.ipmismbus b/tests/data/acpi/q35/DSDT.ipmismbus
index 0970dbd5896fc0038b1369dbbcc982ead7736ae6..9fe6d1686a777ffddc2953420cd4838832226bad 100644
GIT binary patch
delta 90
zcmbQ@_`#9OCD<k8g8~Bsqr*h5R4zx6_+Y2_=q7*uiIoevM7&vDU4ngi7nn_!WYSgT
qYV1g0U|5o{KxT3l7khyaD-#1RLqb7wM-Br+VnHHAa<dd;l{^5NI2lF&
delta 37
tcmez1IK`36CD<ioiUI=zqt!&NR4!M(_+Y2_=q6{biIodCmoZk!0|3<03wHnj
diff --git a/tests/data/acpi/q35/DSDT.ivrs b/tests/data/acpi/q35/DSDT.ivrs
index 3aa5c4b3193d32bb8263a1fe06c05b714541c532..7e43fa88c39737198427744ddb8d902edd517794 100644
GIT binary patch
delta 90
zcmX@>u+ovsCD<ior2+#3qxD3tR4zx6_+Y2_=q7*uiIoevM7&vDU4ngi7nn_!WYSgT
qYV1g0U|5o{KxT3l7khyaD-#1RLqb7wM-Br+VnHHAa<depu{;2M02rhI
delta 37
scmZ4Kc-Dc-CD<jzSAl_n(R3nLDwiu?e6Uk|bdxjJ#L9)6%NUL20m*X;)c^nh
diff --git a/tests/data/acpi/q35/DSDT.memhp b/tests/data/acpi/q35/DSDT.memhp
index 9709e5a7a7edcb7509954b553f7bf29a424033db..a98ee8c7731c8aaf383e84fd48b90633e53ef240 100644
GIT binary patch
delta 90
zcmeD7e(ufX66_N4T$O==v3DX@Dwm^3e6Uk|bdx{-#L9(SBHpa7F2TOM3(O`<GU=*v
qHFhL0Ff2(}ATv3Oi@iXIm5G6uA)%nTBZq+@u^<s5xmk*_Pz3<6Tp5i3
delta 37
scmaFv-R;fg66_Mvt;)c_*glafmCKbcKG-Qfy2+VqV&%fkWsHR?0NZa1z5oCK
diff --git a/tests/data/acpi/q35/DSDT.mmio64 b/tests/data/acpi/q35/DSDT.mmio64
index e1cd01f2349bb8c2f7f8badad11441ffe6d57acc..61e994d2651e15e232d9b5930bca32a33fd0b090 100644
GIT binary patch
delta 90
zcmZ4H+2qCL66_Mfq{_g+=rNHimCI2iKG-Qfy2+n^V&y_E5pPykmtbGs1!j{anRHdT
q8aomg7?va~keQst#a<x9%EZ9SkWkRvk;A}{Sda*j+$_b|qYMB!T^KL`
delta 37
scmZqjTIR{+66_MPOof4g(Rm_QDwiu?e6Uk|bdxjJ#L9)6%NTo<0nHH$VE_OC
diff --git a/tests/data/acpi/q35/DSDT.multi-bridge b/tests/data/acpi/q35/DSDT.multi-bridge
index 3b9dffb565833cc87bbf08dadfc1f31ac858e93b..1240cede1a2fedc902b9dc71687880b73170e81b 100644
GIT binary patch
delta 90
zcmZonx|_u166_KZYskRBxM(6*Dwm^3e6Uk|bdx{-#L9(SBHpa7F2TOM3(O`<GU=*v
qHFhL0Ff2(}ATv3Oi@iXIm5G6uA)%nTBZq+@u^<s5xmk+wxjq1xff>I5
delta 37
tcmcbc)R@HO66_MfXvo08IA<bPDwiu?e6Uk|bdxjJ#L9)6%NU>Q0|3+S3-AB{
diff --git a/tests/data/acpi/q35/DSDT.noacpihp b/tests/data/acpi/q35/DSDT.noacpihp
index 4ea982de2df3cf7cd89cb3b4467a350eaf8f5d29..44ee5e74c533f2c7554885b73adb947ed74b421f 100644
GIT binary patch
delta 130
zcmca+x5=K%CD<iolRN_hW86fpR4zx6_+Y2_=q7*uiIoduM7&vDU4ngi7nn`XVki(~
zW@JcMAT?=nhM+K)zy<S@PlHXXd?$*(@|8U7?7Jjk0sGWUE~X_31ze3C2@DKC0h!5J
eT<irxtV|5N3<(9z9XSjPi3N!e$<0!XHgW)B)hHGK
delta 37
scmdmFf6b1|CD<h-OrC*(F=8TDDwiu?e6Uk|bdxjJ#L9)6%NT9s0MCXC761SM
diff --git a/tests/data/acpi/q35/DSDT.nohpet b/tests/data/acpi/q35/DSDT.nohpet
index 2cf7f6db0fd8de357278f942a4082e714804dca9..be3060aa51d67c0f02c70bd0a7d5c028016641a1 100644
GIT binary patch
delta 90
zcmZ2y-{rvN66_MfrNF?zm@<(omCI2iKG-Qfy2+n^V&y_E5pPykmtbGs1!j{anRHdT
q8aomg7?va~keQst#a<x9%EZ9SkWkRvk;A}{Sda*j+$_a7MGgQ#U>HsS
delta 37
tcmeBjSZB}W66_MPPM(2*F@7RfDwiu?e6Uk|bdxjJ#L9)6%NVD~0RYc^3x5Cr
diff --git a/tests/data/acpi/q35/DSDT.numamem b/tests/data/acpi/q35/DSDT.numamem
index 310e3d5053b90863f96c29dd69a514b4999b4a19..5e94a2b61f840c68d27257831cf608d41ee7c154 100644
GIT binary patch
delta 90
zcmX@)Fwc?8CD<ioo&o~{qw7SjR4zx6_+Y2_=q7*uiIoevM7&vDU4ngi7nn_!WYSgT
qYV1g0U|5o{KxT3l7khyaD-#1RLqb7wM-Br+VnHHAa<dephCBdt!5D%7
delta 37
scmbQ|c*udvCD<jzNr8cZ(S9OVDwiu?e6Uk|bdxjJ#L9)6%NRA}0mb(Uvj6}9
diff --git a/tests/data/acpi/q35/DSDT.pvpanic-isa b/tests/data/acpi/q35/DSDT.pvpanic-isa
index 6672b6fa05c8ee30a8ea4ab0931d59c1315a4e9c..0e609a0c48fef371f935f239ebb9620fa116b049 100644
GIT binary patch
delta 90
zcmZ4J_}7ukCD<k8uL1)Dqu)fXR4zx6_+Y2_=q7*uiIoevM7&vDU4ngi7nn_!WYSgT
qYV1g0U|5o{KxT3l7khyaD-#1RLqb7wM-Br+VnHHAa<dd;yF37^p&5t(
delta 37
tcmezCxX_WyCD<iop#lQ~qsK(9R4!M(_+Y2_=q6{biIodCmoc`>0|47X3%LLQ
diff --git a/tests/data/acpi/q35/DSDT.tis.tpm12 b/tests/data/acpi/q35/DSDT.tis.tpm12
index eae2dc599331516e11632356f05d7831d1fa1e6a..fc6cc4585a6b1d955bc80700ec2dc2720b7e4a89 100644
GIT binary patch
delta 90
zcmbQ``puQgCD<k8n-T*9<C%$Esa%dC@xe~<(M|sR6Dt>TiFmWRx&-_3E-;%c$)u~w
q)!321z_27?fz0GAF7^T;Rwf2shJ=FVjvNMt#DYYK<Yp<x21NkPNE!A3
delta 37
tcmez7I?I*ICD<iomJ$O4<FSccsa&pn@xe~<(M`@=6Dt>PE@Ny^1OVk43?~2p
diff --git a/tests/data/acpi/q35/DSDT.tis.tpm2 b/tests/data/acpi/q35/DSDT.tis.tpm2
index 68c6a7d244cfc78efa6b9cd1385f2134ca149ad7..815006e445d0ec44c2f4a7c8d30ead6616a32b32 100644
GIT binary patch
delta 90
zcmdnuI>C+0CD<iIK$(Gov2`L>Dwm^3e6Uk|bdx{-#L9(SBHpa7F2TOM3(O`<GU=*v
qHFhL0Ff2(}ATv3Oi@iXIm5G6uA)%nTBZq+@u^<s5xmk*FmLdRFT^N}F
delta 37
tcmbQ>w#AjpCD<ioixL9^W5YzQR4!M(_+Y2_=q6{biIodCmodOV313(5ch
diff --git a/tests/data/acpi/q35/DSDT.viot b/tests/data/acpi/q35/DSDT.viot
index 4d2937a87c4a39993eaa756f02d59ef35a08f1c2..a53b3135c85b0908a794f93c7f2e5d3720b79a7d 100644
GIT binary patch
delta 90
zcmZ4J`PY-nCD<k8uL=VLBilr-R4zx6_+Y2_=q7*uiIoevM7&vDU4ngi7nn_!WYSgT
qYV1g0U|5o{KxT3l7khyaD-#1RLqb7wM-Br+VnHHAa<dd;yD|Ws1sPZX
delta 44
zcmezCxzLl#CD<iop$Y>7Bf~_lR9;uU_+Y2_=q6{b0B6t1{<5MICw6WwV{BIj04Q7y
Ad;kCd
diff --git a/tests/data/acpi/q35/DSDT.xapic b/tests/data/acpi/q35/DSDT.xapic
index e9b4881bdc72eb7c59dcf258c1a98363b46bfbcd..8cf5b9703d617d0a0b16d41cd713f7883c80fcfe 100644
GIT binary patch
delta 92
zcmbO~jp_F^CN7s?myqgi1_s8!iCn2%jw12FPVv!A{`?aw7jlVsv%0zj`|>U@n=Hws
stIE~bk-)&PBw>Nf<SZ`s0wGo=2404Qg657K28P6fM2O^ODMr>V0OF+@2LJ#7
delta 39
vcmex8jcNWgCN7s?mk{}G1_nm&iCn2%u6*&qPVv!A&Ri2K7j7<NWbFa~^OOuY
--
2.39.1
^ permalink raw reply related [flat|nested] 46+ messages in thread* [PATCH 18/33] tests: acpi: whitelist DSDT before adding device with acpi-index to testcases
2023-02-24 15:37 [PATCH 00/33] pci(pc/q35): acpi-index support on non-hotpluggable slots Igor Mammedov
` (16 preceding siblings ...)
2023-02-24 15:37 ` [PATCH 17/33] tests: acpi: update expected blobs Igor Mammedov
@ 2023-02-24 15:37 ` Igor Mammedov
2023-02-24 15:37 ` [PATCH 19/33] tests: acpi: add device with acpi-index on non-hotpluggble bus Igor Mammedov
` (15 subsequent siblings)
33 siblings, 0 replies; 46+ messages in thread
From: Igor Mammedov @ 2023-02-24 15:37 UTC (permalink / raw)
To: qemu-devel; +Cc: mst, ani, berrange
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
tests/qtest/bios-tables-test-allowed-diff.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
index dfb8523c8b..70244976c9 100644
--- a/tests/qtest/bios-tables-test-allowed-diff.h
+++ b/tests/qtest/bios-tables-test-allowed-diff.h
@@ -1 +1,4 @@
/* List of comma-separated changed AML files to ignore */
+"tests/data/acpi/pc/DSDT.hpbrroot",
+"tests/data/acpi/q35/DSDT.multi-bridge",
+"tests/data/acpi/q35/DSDT.noacpihp",
--
2.39.1
^ permalink raw reply related [flat|nested] 46+ messages in thread* [PATCH 19/33] tests: acpi: add device with acpi-index on non-hotpluggble bus
2023-02-24 15:37 [PATCH 00/33] pci(pc/q35): acpi-index support on non-hotpluggable slots Igor Mammedov
` (17 preceding siblings ...)
2023-02-24 15:37 ` [PATCH 18/33] tests: acpi: whitelist DSDT before adding device with acpi-index to testcases Igor Mammedov
@ 2023-02-24 15:37 ` Igor Mammedov
2023-02-24 15:37 ` [PATCH 20/33] acpi: pci: support acpi-index for non-hotpluggable devices Igor Mammedov
` (14 subsequent siblings)
33 siblings, 0 replies; 46+ messages in thread
From: Igor Mammedov @ 2023-02-24 15:37 UTC (permalink / raw)
To: qemu-devel; +Cc: mst, ani, berrange
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
tests/qtest/bios-tables-test.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
index 638a193e13..88493abc40 100644
--- a/tests/qtest/bios-tables-test.c
+++ b/tests/qtest/bios-tables-test.c
@@ -1060,6 +1060,7 @@ static void test_acpi_q35_multif_bridge(void)
" -device pcie-root-port,id=rphptgt3,port=0x0,chassis=7,addr=2.3"
" -device pci-testdev,bus=pcie.0,addr=2.4"
" -device pci-testdev,bus=pcie.0,addr=5.0"
+ " -device pci-testdev,bus=pcie.0,addr=0xf.0,acpi-index=101"
" -device pci-testdev,bus=rp0,addr=0.0"
" -device pci-testdev,bus=br1"
" -device pcie-root-port,id=rpnohp,chassis=8,addr=0xA.0,hotplug=off"
--
2.39.1
^ permalink raw reply related [flat|nested] 46+ messages in thread* [PATCH 20/33] acpi: pci: support acpi-index for non-hotpluggable devices
2023-02-24 15:37 [PATCH 00/33] pci(pc/q35): acpi-index support on non-hotpluggable slots Igor Mammedov
` (18 preceding siblings ...)
2023-02-24 15:37 ` [PATCH 19/33] tests: acpi: add device with acpi-index on non-hotpluggble bus Igor Mammedov
@ 2023-02-24 15:37 ` Igor Mammedov
2023-02-24 15:38 ` [PATCH 21/33] tests: acpi: update expected blobs Igor Mammedov
` (13 subsequent siblings)
33 siblings, 0 replies; 46+ messages in thread
From: Igor Mammedov @ 2023-02-24 15:37 UTC (permalink / raw)
To: qemu-devel; +Cc: mst, ani, berrange
Inject static _DSM (EDSM) if non-hotpluggable device has
acpi-index configured on it.
It lets use acpi-index non-hotpluggable devices / devices
attached to non-hotpluggable bus.
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
hw/i386/acpi-build.c | 25 +++++++++++++++++++++++++
1 file changed, 25 insertions(+)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 8db65663fc..c33b43a358 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -451,6 +451,25 @@ static Aml *aml_pci_edsm(void)
return method;
}
+static Aml *aml_pci_static_endpoint_dsm(PCIDevice *pdev)
+{
+ Aml *method;
+
+ g_assert(pdev->acpi_index != 0);
+ method = aml_method("_DSM", 4, AML_SERIALIZED);
+ {
+ Aml *params = aml_local(0);
+ Aml *pkg = aml_package(1);
+ aml_append(pkg, aml_int(pdev->acpi_index));
+ aml_append(method, aml_store(pkg, params));
+ aml_append(method,
+ aml_return(aml_call5("EDSM", aml_arg(0), aml_arg(1),
+ aml_arg(2), aml_arg(3), params))
+ );
+ }
+ return method;
+}
+
static void build_append_pcihp_notify_entry(Aml *method, int slot)
{
Aml *if_ctx;
@@ -576,6 +595,12 @@ void build_append_pci_bus_devices(Aml *parent_scope, PCIBus *bus)
aml_append(dev, aml_name_decl("_ADR", aml_int(adr)));
call_dev_aml_func(DEVICE(bus->devices[devfn]), dev);
+ /* add _DSM if device has acpi-index set */
+ if (pdev->acpi_index && !bsel &&
+ !object_property_get_bool(OBJECT(pdev), "hotpluggable",
+ &error_abort)) {
+ aml_append(dev, aml_pci_static_endpoint_dsm(pdev));
+ }
/* device descriptor has been composed, add it into parent context */
aml_append(parent_scope, dev);
--
2.39.1
^ permalink raw reply related [flat|nested] 46+ messages in thread* [PATCH 21/33] tests: acpi: update expected blobs
2023-02-24 15:37 [PATCH 00/33] pci(pc/q35): acpi-index support on non-hotpluggable slots Igor Mammedov
` (19 preceding siblings ...)
2023-02-24 15:37 ` [PATCH 20/33] acpi: pci: support acpi-index for non-hotpluggable devices Igor Mammedov
@ 2023-02-24 15:38 ` Igor Mammedov
2023-02-24 15:38 ` [PATCH 22/33] tests: acpi: whitelist DSDT before exposing non zero functions Igor Mammedov
` (12 subsequent siblings)
33 siblings, 0 replies; 46+ messages in thread
From: Igor Mammedov @ 2023-02-24 15:38 UTC (permalink / raw)
To: qemu-devel; +Cc: mst, ani, berrange
the only chenge is addition of _DSM- > EDSM method
on non-hotpluggable devices with configured acpi-index.
Something like:
+ Method (_DSM, 4, Serialized) // _DSM: Device-Specific Method
+ {
+ Local0 = Package (0x01)
+ {
+ 0x65
+ }
+ Return (EDSM (Arg0, Arg1, Arg2, Arg3, Local0))
+ }
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
tests/qtest/bios-tables-test-allowed-diff.h | 3 ---
tests/data/acpi/pc/DSDT.hpbrroot | Bin 3260 -> 3309 bytes
tests/data/acpi/q35/DSDT.multi-bridge | Bin 12637 -> 12678 bytes
tests/data/acpi/q35/DSDT.noacpihp | Bin 8114 -> 8188 bytes
4 files changed, 3 deletions(-)
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
index 70244976c9..dfb8523c8b 100644
--- a/tests/qtest/bios-tables-test-allowed-diff.h
+++ b/tests/qtest/bios-tables-test-allowed-diff.h
@@ -1,4 +1 @@
/* List of comma-separated changed AML files to ignore */
-"tests/data/acpi/pc/DSDT.hpbrroot",
-"tests/data/acpi/q35/DSDT.multi-bridge",
-"tests/data/acpi/q35/DSDT.noacpihp",
diff --git a/tests/data/acpi/pc/DSDT.hpbrroot b/tests/data/acpi/pc/DSDT.hpbrroot
index bfe0bf37180c0f0521d264d3e35b5f51feff2630..bee88c5ee815f0acf022b278876f0a212b1da84a 100644
GIT binary patch
delta 134
zcmdlZ`Bsw4CD<k8Ee`_&<F1WdHe6ipS~2m#PVoZ%nwtZ-teKM3gN+U1IpQ5%f`Dq+
z7(~S5U4ngi3WQh~xl$9BxB@vDnOWHh(M^`Y#ujje><rOO8o>q#0Y(N938+q1Ms8h3
GB&`7G*&wt4
delta 85
zcmaDWxkr-ACD<io4-W$aqyI)O8!j$4^_cizr+5KBwao!s)=Y-{!Nvyh9Py4WK|nQZ
X4AD&r!NwMF0d}AOf3N{UfRO<Jc*7Ed
diff --git a/tests/data/acpi/q35/DSDT.multi-bridge b/tests/data/acpi/q35/DSDT.multi-bridge
index 1240cede1a2fedc902b9dc71687880b73170e81b..595ab64601ae3deb12bbf18ca463e39ba0a86195 100644
GIT binary patch
delta 81
zcmcbc)RxTU66_MvX2`(67`Tz^t{ita7h_C(uv5H16W8WXax(nt>cQp~@f`7vE<rpD
j4Ezit;_)uQzB~m&ER0;K2}@jooQ%w@?1arcdV$OUo6Hrb
delta 41
xcmZomzMI7566_KZYskRBxM(BST{-S14#t@HV5fM2PWH{8<Yf3ao9p>A0{{}H42A#z
diff --git a/tests/data/acpi/q35/DSDT.noacpihp b/tests/data/acpi/q35/DSDT.noacpihp
index 44ee5e74c533f2c7554885b73adb947ed74b421f..c292c2369b011b779af44d0fa6fd2f7994098b2e 100644
GIT binary patch
delta 199
zcmdmF|Hq!oCD<k8k30hdqtiw%7g;Vpt(f>=r+5K3t;rFx_Uh`vh8FQ0@s2J*JPZuX
z3?kz3F2TM$1wt&0T&W35T!Ea7%&hE$$;)I_EG>hL5NcT&qMI~=4G;p13?dRx&8&>v
lx{S!WU&$(%ng$yq6te?$s{|VuK&(d5`4w5`W;MAUMgVo#G5-Jn
delta 125
zcmexkzsa7<CD<iolRN_hW86kA7g;VBwV3!|r+5J$)yWaE_Wb<8h8FQ0@s2J*JPZuX
z43qcCswgM~8zID48KRr`gAEV@j0}^d<rHLOf{hVk>_A1_!3G8plNdG^$n`J+09-yC
ANdN!<
--
2.39.1
^ permalink raw reply related [flat|nested] 46+ messages in thread* [PATCH 22/33] tests: acpi: whitelist DSDT before exposing non zero functions
2023-02-24 15:37 [PATCH 00/33] pci(pc/q35): acpi-index support on non-hotpluggable slots Igor Mammedov
` (20 preceding siblings ...)
2023-02-24 15:38 ` [PATCH 21/33] tests: acpi: update expected blobs Igor Mammedov
@ 2023-02-24 15:38 ` Igor Mammedov
2023-02-24 15:38 ` [PATCH 23/33] acpi: pci: describe all functions on populated slots Igor Mammedov
` (11 subsequent siblings)
33 siblings, 0 replies; 46+ messages in thread
From: Igor Mammedov @ 2023-02-24 15:38 UTC (permalink / raw)
To: qemu-devel; +Cc: mst, ani, berrange
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
tests/qtest/bios-tables-test-allowed-diff.h | 37 +++++++++++++++++++++
1 file changed, 37 insertions(+)
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
index dfb8523c8b..8911b10650 100644
--- a/tests/qtest/bios-tables-test-allowed-diff.h
+++ b/tests/qtest/bios-tables-test-allowed-diff.h
@@ -1 +1,38 @@
/* List of comma-separated changed AML files to ignore */
+"tests/data/acpi/pc/DSDT",
+"tests/data/acpi/pc/DSDT.acpierst",
+"tests/data/acpi/pc/DSDT.acpihmat",
+"tests/data/acpi/pc/DSDT.bridge",
+"tests/data/acpi/pc/DSDT.cphp",
+"tests/data/acpi/pc/DSDT.dimmpxm",
+"tests/data/acpi/pc/DSDT.hpbridge",
+"tests/data/acpi/pc/DSDT.hpbrroot",
+"tests/data/acpi/pc/DSDT.ipmikcs",
+"tests/data/acpi/pc/DSDT.memhp",
+"tests/data/acpi/pc/DSDT.nohpet",
+"tests/data/acpi/pc/DSDT.numamem",
+"tests/data/acpi/pc/DSDT.roothp",
+"tests/data/acpi/q35/DSDT",
+"tests/data/acpi/q35/DSDT.acpierst",
+"tests/data/acpi/q35/DSDT.acpihmat",
+"tests/data/acpi/q35/DSDT.acpihmat-noinitiator",
+"tests/data/acpi/q35/DSDT.applesmc",
+"tests/data/acpi/q35/DSDT.bridge",
+"tests/data/acpi/q35/DSDT.core-count2",
+"tests/data/acpi/q35/DSDT.cphp",
+"tests/data/acpi/q35/DSDT.cxl",
+"tests/data/acpi/q35/DSDT.dimmpxm",
+"tests/data/acpi/q35/DSDT.ipmibt",
+"tests/data/acpi/q35/DSDT.ipmismbus",
+"tests/data/acpi/q35/DSDT.ivrs",
+"tests/data/acpi/q35/DSDT.memhp",
+"tests/data/acpi/q35/DSDT.mmio64",
+"tests/data/acpi/q35/DSDT.multi-bridge",
+"tests/data/acpi/q35/DSDT.noacpihp",
+"tests/data/acpi/q35/DSDT.nohpet",
+"tests/data/acpi/q35/DSDT.numamem",
+"tests/data/acpi/q35/DSDT.pvpanic-isa",
+"tests/data/acpi/q35/DSDT.tis.tpm12",
+"tests/data/acpi/q35/DSDT.tis.tpm2",
+"tests/data/acpi/q35/DSDT.viot",
+"tests/data/acpi/q35/DSDT.xapic",
--
2.39.1
^ permalink raw reply related [flat|nested] 46+ messages in thread* [PATCH 23/33] acpi: pci: describe all functions on populated slots
2023-02-24 15:37 [PATCH 00/33] pci(pc/q35): acpi-index support on non-hotpluggable slots Igor Mammedov
` (21 preceding siblings ...)
2023-02-24 15:38 ` [PATCH 22/33] tests: acpi: whitelist DSDT before exposing non zero functions Igor Mammedov
@ 2023-02-24 15:38 ` Igor Mammedov
2023-02-24 15:38 ` [PATCH 24/33] tests: acpi: update expected blobs Igor Mammedov
` (10 subsequent siblings)
33 siblings, 0 replies; 46+ messages in thread
From: Igor Mammedov @ 2023-02-24 15:38 UTC (permalink / raw)
To: qemu-devel; +Cc: mst, ani, berrange
describing all present devices on functions other than
0 was complicated when non hotplug and hotplug code
was intermixed. So QEMU has been excluding non zero
functions since they are not supported by hotplug code,
then a condition to whitelist coldplugged bridges was
added and later whitelisting of devices that advertise
presence of their own AML description.
With non hotplug and hotplug code separated, it is
possible to relax rules and allow describing all
non-hotpluggble functions and hence simplify
conditions whether PCI device should be enumerated by
generic (non-hotplug) code.
Price of that simplification is an extra few Device()
descriptors in DSDT exposing built-in chipset functions,
which has no functional effect on guest side.
Apart from that, the enumeration of non zero functions,
allows to attach more NICs with acpi-index enabled
directly on hostbridge (if hotplug is not required).
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
* patch is making acpi-index feature support complete in
the scope of host bridge (support of acpi-index on PXB
is out of scope of this series, and probably should follow
host-bridge clean up)
* follow up patch will add a tests case with acpi-index
enabled PCI device on non zero function to demonstrate
that.
---
hw/i386/acpi-build.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index c33b43a358..7b982b6072 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -493,12 +493,6 @@ static bool is_devfn_ignored_generic(const int devfn, const PCIBus *bus)
if (DEVICE(pdev)->hotplugged) {
return true;
}
- } else if (!get_dev_aml_func(DEVICE(pdev))) {
- /*
- * Ignore all other devices on !0 functions unless they
- * have AML description (i.e have get_dev_aml_func() != 0)
- */
- return true;
}
}
return false;
--
2.39.1
^ permalink raw reply related [flat|nested] 46+ messages in thread* [PATCH 24/33] tests: acpi: update expected blobs
2023-02-24 15:37 [PATCH 00/33] pci(pc/q35): acpi-index support on non-hotpluggable slots Igor Mammedov
` (22 preceding siblings ...)
2023-02-24 15:38 ` [PATCH 23/33] acpi: pci: describe all functions on populated slots Igor Mammedov
@ 2023-02-24 15:38 ` Igor Mammedov
2023-02-24 15:38 ` [PATCH 25/33] tests: acpi: whitelist DSDT before adding non-0 function device with acpi-index to testcases Igor Mammedov
` (9 subsequent siblings)
33 siblings, 0 replies; 46+ messages in thread
From: Igor Mammedov @ 2023-02-24 15:38 UTC (permalink / raw)
To: qemu-devel; +Cc: mst, ani, berrange
in PC machine case piix3-ide and PIIX4_PM get exposed
+ Device (S09)
+ {
+ Name (_ADR, 0x00010001) // _ADR: Address
+ }
+
+ Device (S0B)
+ {
+ Name (_ADR, 0x00010003) // _ADR: Address
+ }
in q35 machine case ich9-ahci gets exposed
+ Device (SFA)
+ {
+ Name (_ADR, 0x001F0002) // _ADR: Address
+ }
and addtional pci-testdev, virtio-balloon exposed in q35 multi-bridge test case
+ Device (S14)
+ {
+ Name (_ADR, 0x00020004) // _ADR: Address
+ }
+
...
+ Device (S22)
+ {
+ Name (_ADR, 0x00040002) // _ADR: Address
+ }
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
tests/qtest/bios-tables-test-allowed-diff.h | 37 ------------------
tests/data/acpi/pc/DSDT | Bin 6454 -> 6488 bytes
tests/data/acpi/pc/DSDT.acpierst | Bin 6377 -> 6411 bytes
tests/data/acpi/pc/DSDT.acpihmat | Bin 7779 -> 7813 bytes
tests/data/acpi/pc/DSDT.bridge | Bin 12581 -> 12615 bytes
tests/data/acpi/pc/DSDT.cphp | Bin 6918 -> 6952 bytes
tests/data/acpi/pc/DSDT.dimmpxm | Bin 8108 -> 8142 bytes
tests/data/acpi/pc/DSDT.hpbridge | Bin 6417 -> 6451 bytes
tests/data/acpi/pc/DSDT.hpbrroot | Bin 3309 -> 3343 bytes
tests/data/acpi/pc/DSDT.ipmikcs | Bin 6526 -> 6560 bytes
tests/data/acpi/pc/DSDT.memhp | Bin 7813 -> 7847 bytes
tests/data/acpi/pc/DSDT.nohpet | Bin 6312 -> 6346 bytes
tests/data/acpi/pc/DSDT.numamem | Bin 6460 -> 6494 bytes
tests/data/acpi/pc/DSDT.roothp | Bin 9839 -> 9873 bytes
tests/data/acpi/q35/DSDT | Bin 8344 -> 8361 bytes
tests/data/acpi/q35/DSDT.acpierst | Bin 8361 -> 8378 bytes
tests/data/acpi/q35/DSDT.acpihmat | Bin 9669 -> 9686 bytes
tests/data/acpi/q35/DSDT.acpihmat-noinitiator | Bin 8623 -> 8640 bytes
tests/data/acpi/q35/DSDT.applesmc | Bin 8390 -> 8407 bytes
tests/data/acpi/q35/DSDT.bridge | Bin 11573 -> 11590 bytes
tests/data/acpi/q35/DSDT.core-count2 | Bin 32484 -> 32501 bytes
tests/data/acpi/q35/DSDT.cphp | Bin 8808 -> 8825 bytes
tests/data/acpi/q35/DSDT.cxl | Bin 9670 -> 9687 bytes
tests/data/acpi/q35/DSDT.dimmpxm | Bin 9998 -> 10015 bytes
tests/data/acpi/q35/DSDT.ipmibt | Bin 8419 -> 8436 bytes
tests/data/acpi/q35/DSDT.ipmismbus | Bin 8432 -> 8449 bytes
tests/data/acpi/q35/DSDT.ivrs | Bin 8361 -> 8378 bytes
tests/data/acpi/q35/DSDT.memhp | Bin 9703 -> 9720 bytes
tests/data/acpi/q35/DSDT.mmio64 | Bin 9474 -> 9491 bytes
tests/data/acpi/q35/DSDT.multi-bridge | Bin 12678 -> 12729 bytes
tests/data/acpi/q35/DSDT.noacpihp | Bin 8188 -> 8205 bytes
tests/data/acpi/q35/DSDT.nohpet | Bin 8202 -> 8219 bytes
tests/data/acpi/q35/DSDT.numamem | Bin 8350 -> 8367 bytes
tests/data/acpi/q35/DSDT.pvpanic-isa | Bin 8445 -> 8462 bytes
tests/data/acpi/q35/DSDT.tis.tpm12 | Bin 8950 -> 8967 bytes
tests/data/acpi/q35/DSDT.tis.tpm2 | Bin 8976 -> 8993 bytes
tests/data/acpi/q35/DSDT.viot | Bin 9469 -> 9486 bytes
tests/data/acpi/q35/DSDT.xapic | Bin 35707 -> 35724 bytes
38 files changed, 37 deletions(-)
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
index 8911b10650..dfb8523c8b 100644
--- a/tests/qtest/bios-tables-test-allowed-diff.h
+++ b/tests/qtest/bios-tables-test-allowed-diff.h
@@ -1,38 +1 @@
/* List of comma-separated changed AML files to ignore */
-"tests/data/acpi/pc/DSDT",
-"tests/data/acpi/pc/DSDT.acpierst",
-"tests/data/acpi/pc/DSDT.acpihmat",
-"tests/data/acpi/pc/DSDT.bridge",
-"tests/data/acpi/pc/DSDT.cphp",
-"tests/data/acpi/pc/DSDT.dimmpxm",
-"tests/data/acpi/pc/DSDT.hpbridge",
-"tests/data/acpi/pc/DSDT.hpbrroot",
-"tests/data/acpi/pc/DSDT.ipmikcs",
-"tests/data/acpi/pc/DSDT.memhp",
-"tests/data/acpi/pc/DSDT.nohpet",
-"tests/data/acpi/pc/DSDT.numamem",
-"tests/data/acpi/pc/DSDT.roothp",
-"tests/data/acpi/q35/DSDT",
-"tests/data/acpi/q35/DSDT.acpierst",
-"tests/data/acpi/q35/DSDT.acpihmat",
-"tests/data/acpi/q35/DSDT.acpihmat-noinitiator",
-"tests/data/acpi/q35/DSDT.applesmc",
-"tests/data/acpi/q35/DSDT.bridge",
-"tests/data/acpi/q35/DSDT.core-count2",
-"tests/data/acpi/q35/DSDT.cphp",
-"tests/data/acpi/q35/DSDT.cxl",
-"tests/data/acpi/q35/DSDT.dimmpxm",
-"tests/data/acpi/q35/DSDT.ipmibt",
-"tests/data/acpi/q35/DSDT.ipmismbus",
-"tests/data/acpi/q35/DSDT.ivrs",
-"tests/data/acpi/q35/DSDT.memhp",
-"tests/data/acpi/q35/DSDT.mmio64",
-"tests/data/acpi/q35/DSDT.multi-bridge",
-"tests/data/acpi/q35/DSDT.noacpihp",
-"tests/data/acpi/q35/DSDT.nohpet",
-"tests/data/acpi/q35/DSDT.numamem",
-"tests/data/acpi/q35/DSDT.pvpanic-isa",
-"tests/data/acpi/q35/DSDT.tis.tpm12",
-"tests/data/acpi/q35/DSDT.tis.tpm2",
-"tests/data/acpi/q35/DSDT.viot",
-"tests/data/acpi/q35/DSDT.xapic",
diff --git a/tests/data/acpi/pc/DSDT b/tests/data/acpi/pc/DSDT
index 521062a756d1fcd5939683e41071d29407a45b22..32d255cfc0a207c89bf8459edaca11fad12979e9 100644
GIT binary patch
delta 72
zcmdmHbi;_tCD<h-LXv@jas5WFtK3|^7h>Xro#F*tFKm9veVS38KiI%Bo+IATC5VTS
WfsrA)2`JzM6<}sy+`N&ul^Xyg{1i$6
delta 40
wcmca%w9SaiCD<jzOp<|tv1=pORc<ctb20J3PVoZH=Qh9OKFzrK8gCOf01c`RDgXcg
diff --git a/tests/data/acpi/pc/DSDT.acpierst b/tests/data/acpi/pc/DSDT.acpierst
index 12b9e94bf1449995d460edffd40d1ff7b9f292cc..33e872b2fae3d974a3dc4ec0401b1f1734db313b 100644
GIT binary patch
delta 72
zcmaE9*lon+66_MfEy=*ZXuFZ?DmRzInV9%sr+5L6)0<y%pJtTj4>quj=ZJT73F2X7
WU}T7H0tz@m1(+EaH*e&%;06Hf%o7j*
delta 40
wcmeA+dTGez66_N4Qi6ejk!vH@Rc<c7lQHqZPVoY6CpW+3KFzrK8m}og01(a%@Bjb+
diff --git a/tests/data/acpi/pc/DSDT.acpihmat b/tests/data/acpi/pc/DSDT.acpihmat
index 876d0184d8d56cc2fc9d4c0a619d5d449ba81687..cd84abc1b1d026e6055057f4c6170146e1921ea6 100644
GIT binary patch
delta 72
zcmaEC(`w7*66_MvD#yUUn6r_KNs!C;LQH(HQ@nudh0S7ury1q>gAFX>IpQ5%f_NAi
V7#X6QfC5fX0cHlq&G&>_xdG9V62Jfe
delta 40
wcmZp*eQd+!66_L^EXTmW=)RGQNs!C?TugkhQ@nulxy@pNrx`ah3pa5C0PMvJp#T5?
diff --git a/tests/data/acpi/pc/DSDT.bridge b/tests/data/acpi/pc/DSDT.bridge
index 219ddba2713015616e41c19f66d891c63b05e4ab..69a73ea2a691de387b82bf85a7ba1a2279c01a0c 100644
GIT binary patch
delta 73
zcmZ3QbUca6CD<jz-H?HSk!>T_Rc`K1Po|joV5fM22G7l}xX&=k^9LJP#&g6wx&-ks
XGB7ekHvt8lpaRScjGH&}7AXS&{T>rr
delta 41
xcmX?}v^0s!CD<iI)sTUK@zO@FtK8h}?o2W9!A|i4eQujyai3w_e1kV%82}z|4m$t<
diff --git a/tests/data/acpi/pc/DSDT.cphp b/tests/data/acpi/pc/DSDT.cphp
index 5b5b352a13947a48f98e46409b9ad9664b4de9bc..20379056b399bf1ad8b8316453eac344f604d3b6 100644
GIT binary patch
delta 72
zcmZoOTVclK66_M9A<e+RD7=wtDKD4rg_!tYr+5L^3!8WHo@SKi4>quj=ZJT73F2X7
WU}T7H0tz@m1(+EaH#hRPasvR%(-NKl
delta 40
wcmZ2s)@H`#66_MfCe6UW_--TDQeH0ab20J3PVoZH=Qi);J<Ygz8GjQu0RBM@egFUf
diff --git a/tests/data/acpi/pc/DSDT.dimmpxm b/tests/data/acpi/pc/DSDT.dimmpxm
index fbe755975d94e5e607820bb7acb2fb189b1105ee..435496e836939eeb767f1a524dc1471740ad917e 100644
GIT binary patch
delta 72
zcmZ2uf6kuECD<k8oIC>q<Nb|X-a=fy7h>Xro#F*tFKmt%I?X80A8cS5&k^tF62!yE
Wz{n8Y1Qc+B3NSM;ZdMm*<puy8sS|Sm
delta 40
wcmX?Szs8=+CD<iojXVPb<F1Wd-a=g7=VIc6o#F+Y&uxwuI?cG*N2G}x01wv<Qvd(}
diff --git a/tests/data/acpi/pc/DSDT.hpbridge b/tests/data/acpi/pc/DSDT.hpbridge
index 12d7daf950ba93deaeb67655d303df3960569a64..b6eafab250d508e1358ea09f81eb1b2a6d96ce32 100644
GIT binary patch
delta 72
zcmbPewAqNuCD<jzSdxK(QF9~LRc<bib20J3PVoW`=Qh9OKFui4A8cS5&k^tF62!yE
Wz{n8Y1Qc+B3NSM;Zr;e7zzqQA3KJp#
delta 40
wcmdmNG|`C5CD<iIP?CXx@#{vetK3{}XJX=mo#F-jPH%q6eVTFeHQrcm00>qN0ssI2
diff --git a/tests/data/acpi/pc/DSDT.hpbrroot b/tests/data/acpi/pc/DSDT.hpbrroot
index bee88c5ee815f0acf022b278876f0a212b1da84a..a4073f36d686201296455e142e3bcbb2f368bbd2 100644
GIT binary patch
delta 71
zcmaDW*)PTA66_Mf&&$BT_;w?g4HuWEPE35TQ@ntq&gKBF(~R=`!3LJ`9Py4WK|G8M
Uj119DKmjMH05b#QWC@<D0D)Ez_W%F@
delta 39
vcmeB|dMnB066_N4mWP3Xao0vJ8!j$)t(f>=r+5K>&CLN^rx_>P@>~J{=n)Io
diff --git a/tests/data/acpi/pc/DSDT.ipmikcs b/tests/data/acpi/pc/DSDT.ipmikcs
index 3a19ce439825c2aa97adee3a965ac050dec6f2d0..06aa7bfdeca40e10ee8411eeda08486599b90e39 100644
GIT binary patch
delta 72
zcmexow7{6lCD<iofg}S1qxMFwtK3|!S7YLXo#F+2uWWwFEzBg(A8cS5&k^tF62!yE
Wz{n8Y1Qc+B3NSM;ZvM&J$_)SnsuQ^Y
delta 40
wcmZ2r{LhHXCD<jTPLhFvk!>T_Rc<cl%Q5l6PVoZXmo~rT7G~Nk$JfLS00Vstng9R*
diff --git a/tests/data/acpi/pc/DSDT.memhp b/tests/data/acpi/pc/DSDT.memhp
index 8ad5c523fdf76b90286a145f797454dff6da050c..10a0e44d610976cd5f08d53ec32c7d5eda064e1c 100644
GIT binary patch
delta 71
zcmZp*U2e<e66_MPT#kW(ap6WT6+tfF3o-G*PVoY+7dBf6o@SKi4>quj=ZJT73F2X7
VU}T7H0tz@m1(+EaHwm|L0|3mt5<&m~
delta 40
wcmZ2(+iJ_@66_MvD#yUUShJB!MUcz;TugkhQ@nulxy=@Wrx`b^3O8{B0P>CuBLDyZ
diff --git a/tests/data/acpi/pc/DSDT.nohpet b/tests/data/acpi/pc/DSDT.nohpet
index 4fd4d38e5ffe889fed812b67d3d7b1825325e909..6905312d827502e8bb5852418cf58290eda8d86b 100644
GIT binary patch
delta 72
zcmZ2sc*>B=CD<k8lmr6<W93FJcWy4<3o-G*PVoY+7dA(8pJtTj4>quj=ZJT73F2X7
WU}T7H0tz@m1(+EaH!JhDasvSLxe~nq
delta 40
wcmX?QxWbUjCD<iog#-fwW5`A>cWy54b20J3PVoZH=Qc-kpJv?b!P~?Q0R2Y{od5s;
diff --git a/tests/data/acpi/pc/DSDT.numamem b/tests/data/acpi/pc/DSDT.numamem
index 4cfb3765c5c5c7cf73732f2d3fd5bf9932399c14..59e31338eeb3a84c39ed3ae63105226ce2ad1125 100644
GIT binary patch
delta 72
zcmdmEbkB&(CD<h-PLhFvF>)i<ZEh~#3o-G*PVoY+7dF4=KFui4A8cS5&k^tF62!yE
Wz{n8Y1Qc+B3NSM;Zr;w@$_)S*rW6<e
delta 40
wcmca-w8x0cCD<jzMv{Sn(PSgnZEh~_b20J3PVoZH=Qh9RKFzrK4sR1T00>kK_y7O^
diff --git a/tests/data/acpi/pc/DSDT.roothp b/tests/data/acpi/pc/DSDT.roothp
index 8b695cca83c04b4123986e1334d0c57ddb22687d..448d596cf413d7e487af114e5c80bc73311d17f9 100644
GIT binary patch
delta 73
zcmaFwGtrmJCD<ioq8bAOqt`~RtK8hZ^BH5}gPr09TIO$l#eIfRo<G>YGM*#e(Itq7
Xk%5sRx(O)Y1QlRrVBEZ!caH=BIGPl>
delta 41
xcmbQ}``(AkCD<h-UyXr*QFSBNRc`L?xr{OK!A|i4O>;ND;y%N;`3CP!2>=@34w(P|
diff --git a/tests/data/acpi/q35/DSDT b/tests/data/acpi/q35/DSDT
index 3dadeba912d9133f0ccb6e9b89a22ca7dc43f18f..720e8cbbbb10d86a458027b5cb47884bf8c5ee78 100644
GIT binary patch
delta 51
zcmbQ?xYCi!CD<ior2+#3<F}1mcjdTTrDNiQo#F+2r8a+*>tp10jOU1VbP3{NVvwI)
HsUQykodFKD
delta 39
vcmZ4KIKz?4CD<ioh5`cv<Lr%GcjdTTq+;TOo#F+2BsYJQ>tmceK|vA#@?8u-
diff --git a/tests/data/acpi/q35/DSDT.acpierst b/tests/data/acpi/q35/DSDT.acpierst
index 7e43fa88c39737198427744ddb8d902edd517794..f26b1f2a19529c508d53ed3f434be0083c18dbab 100644
GIT binary patch
delta 51
zcmZ4KxXY2tCD<iomjVL=<Ft)jcjdU;WMbljo#F-jq&I(*o6pGY7|#*!=n}-k#2`Pp
HOF<q0nqCgB
delta 39
vcmdnxxYCi!CD<ior2+#3qxD9vyK-Ev(lPPDPVoZ1Qky@@&1amvP(cy^@Y)PH
diff --git a/tests/data/acpi/q35/DSDT.acpihmat b/tests/data/acpi/q35/DSDT.acpihmat
index 7c626642ba1ef231ee4e1353330ca9ae2955f37f..86771f17466a85e3c938e86d1a5c6cee7c0ec4b6 100644
GIT binary patch
delta 51
zcmX@=ea)N8CD<k8nkoYW<K~TATq<0y(lPPDPVoZ1Qk&&e`WU$#<2m9TU4nR+8004}
HQ<Vn*hA<7P
delta 39
vcmccSebk%FCD<k8s44>kW5h--E)^~pshId+r+5J$$<1;qeT<X$s!9R?>Szl!
diff --git a/tests/data/acpi/q35/DSDT.acpihmat-noinitiator b/tests/data/acpi/q35/DSDT.acpihmat-noinitiator
index 631a1048fc01a3c84aadfdea8e0eccc36c68d8a4..a894a2d16c81fff8ade2c5ddb20858a03169fd47 100644
GIT binary patch
delta 51
zcmZ4Qe88E@CD<k8fFc6}W6egcFY;Wj(lPPDPVoZ1Qkyvx`WU$#<2m9TU4nR+8005U
HP?QG%igpdo
delta 39
vcmX@$yxy71CD<ioy&?kxqvA%cFY;V2QZeztPVoXhlAAdc`WPoKSCj+*>&6RN
diff --git a/tests/data/acpi/q35/DSDT.applesmc b/tests/data/acpi/q35/DSDT.applesmc
index cb117fd671effe2557a41115015b57df87d7936b..276ae1df511346ccd286216c6de03cd56db410fd 100644
GIT binary patch
delta 51
zcmX@+c-@i9CD<k8x&i|O<Fk!icjdU8<znK4o#F+&WjBA6+r!B17|#*!=n}-k#2`O;
Hxq>_ZxGN8h
delta 39
vcmccac+8Q@CD<k8m;wU>WA{d`yK-DkvN7?&PVoX>GMhij?O~j}PeBp@1)dEU
diff --git a/tests/data/acpi/q35/DSDT.bridge b/tests/data/acpi/q35/DSDT.bridge
index cdfd51ce70d7201fa827bfabfd23e413596b1094..9f8a208aaadc167135e59839eefcd5b594c2f28a 100644
GIT binary patch
delta 51
zcmdlQbu5a@CD<jzO_zazF>52&T{$lAyD{;>PVoZHcQ=2O+rrE37|#*!=n}-k#2`O;
HzRolNyG;<A
delta 39
vcmX>WwKa;%CD<jzRF{E)k$)rCT{$kVJ2COWPVoXxcQ${N+rm3}o6ZCP0o)EI
diff --git a/tests/data/acpi/q35/DSDT.core-count2 b/tests/data/acpi/q35/DSDT.core-count2
index 2bf77bb4e1a433eab66d0fdd175344d4f8d6e168..2ec11fe3c36d635080af05afa32852fcc1bf10be 100644
GIT binary patch
delta 53
zcmaFzm+|XgMlP3NmyoY@3=E8d8@V)Vxm=}V;)9*y1$?D8+t&6may!Oz#5=kK@h~yS
JPd-{F4*>Eb5R3o-
delta 41
xcmezRm+{G8MlP3NmyjoQ3=E9hHgaj!a=A#w#0NXY3;0NGwyo`BoP4KF5&%+z4;KIc
diff --git a/tests/data/acpi/q35/DSDT.cphp b/tests/data/acpi/q35/DSDT.cphp
index 1837442bd39f1249fb753530ea508d05e8d177f4..612c85b1b4c8e4cc642734b1d52f5d5e1e2ec4eb 100644
GIT binary patch
delta 51
zcmaFi^3#ROCD<jTQi*|qF=`{%S_Ljw>6rLnr+5Khsm%u!`WU$#<2m9TU4nR+8005=
HD#-%?l?e_9
delta 39
vcmezA^1_A7CD<h-Ly3Wb@&87ywF+D=QZeztPVoXhlA8}I^f69OP?7`y33LpS
diff --git a/tests/data/acpi/q35/DSDT.cxl b/tests/data/acpi/q35/DSDT.cxl
index 023da0665f9123943e23fd771725f4b8eb937135..ba6e174eee0210e829e4cc1cd6a0e12ba0678cff 100644
GIT binary patch
delta 51
zcmX@+echYOCD<k8x+(($<NJ+VFO|96Wn<!lo#F-jWj6m+-oVK17|#*!=n}-k#2`O;
HxvD$>!FvzT
delta 39
vcmccaeaxH7CD<k8m?{GU<CKkDFO|96WMbljo#F-jq&NRn-oQ9{pQ<DP3<eEb
diff --git a/tests/data/acpi/q35/DSDT.dimmpxm b/tests/data/acpi/q35/DSDT.dimmpxm
index 2ad9b1c30e9a583cc43e8efbc1e276b4f221ff28..23dabeacb06b3ad4360c1ca142c06a173f82ff51 100644
GIT binary patch
delta 51
zcmeD4oA1Zv66_Kpug<{0sJf9WSe46FIwn5YDPF)=YIC}3A0xM8JV(5vOArqegZ$+8
GYVrV37YyA1
delta 39
ucmbR5*XPIO66_Mfr_R8@cxoe8uqu~}R7`xZQ@ntW<mPnMKE}yx>XHE0WeRBk
diff --git a/tests/data/acpi/q35/DSDT.ipmibt b/tests/data/acpi/q35/DSDT.ipmibt
index c552e668983198d077348a57a5b22065d01b40f1..541bb70522e72dd477f72cba2f71a336f6978de4 100644
GIT binary patch
delta 78
zcmaFt_{EXSCD<k8ivj}!qt-^QyK-C(3Ni7)PVoXB@|!=(-DK2qjOU1VbP3{NVvuKu
bZsHGibAk#m0|f+l;@tyWMcCq94Gb9ojA9e<
delta 39
vcmez3_}G!lCD<k8u>u1F<AIG_cjdVJ<znK4o#F-D<u-qmyU95Dwt^%87|spr
diff --git a/tests/data/acpi/q35/DSDT.ipmismbus b/tests/data/acpi/q35/DSDT.ipmismbus
index 9fe6d1686a777ffddc2953420cd4838832226bad..e2d57a331873ada2fcbcdc1f0f7a244f235d7447 100644
GIT binary patch
delta 54
zcmez1*yzON66_MfsK~&;IBO%<T{$jag_!tYr+5KZh0P!3x*7TSgWVkCIpQ5%f_Ru1
K<R@1ulmh^&!w&8M
delta 39
vcmZp4`rydr66_N4L4kpR(P1OkT{$iv`Iz`%r+5Ju`OP2Yx)~?;DwF^K`=$)e
diff --git a/tests/data/acpi/q35/DSDT.ivrs b/tests/data/acpi/q35/DSDT.ivrs
index 7e43fa88c39737198427744ddb8d902edd517794..f26b1f2a19529c508d53ed3f434be0083c18dbab 100644
GIT binary patch
delta 51
zcmZ4KxXY2tCD<iomjVL=<Ft)jcjdU;WMbljo#F-jq&I(*o6pGY7|#*!=n}-k#2`Pp
HOF<q0nqCgB
delta 39
vcmdnxxYCi!CD<ior2+#3qxD9vyK-Ev(lPPDPVoZ1Qky@@&1amvP(cy^@Y)PH
diff --git a/tests/data/acpi/q35/DSDT.memhp b/tests/data/acpi/q35/DSDT.memhp
index a98ee8c7731c8aaf383e84fd48b90633e53ef240..809d7e2f0fc15351abc99031a118b4012822deea 100644
GIT binary patch
delta 51
zcmaFv{llBfCD<k8hbjXD<BN@4Ix1YQ(lPPDPVoZ1QkxxA`WU$#<2m9TU4nR+8006P
HP?ZM&s7DT~
delta 39
vcmez2{oI?&CD<k8xhew#WA8>T9ThGYshId+r+5J$$;}QbeT<Xut4aa@0vZf9
diff --git a/tests/data/acpi/q35/DSDT.mmio64 b/tests/data/acpi/q35/DSDT.mmio64
index 61e994d2651e15e232d9b5930bca32a33fd0b090..ab3fe3c1b56a35d1312779412978cc1d51f05d33 100644
GIT binary patch
delta 78
zcmZqjn(W2p66_KptjfT^xOgL%nKGA~OiX;RQ@ntm^ky&R`HWhQ@f`7vE<rp@4Dt-o
bP5i-bPEY}6pnw2RynBGF2wS|Xfgu9`?2Hj)
delta 61
zcmbR2)#SzH66_Mfq{_g+=&_N@Oqt77Iwn5YDPF)=YO|N}d`3y9c#e2SmmnTy26+Yn
Qo_O~FR}r>&R|7)^0KR|?Qvd(}
diff --git a/tests/data/acpi/q35/DSDT.multi-bridge b/tests/data/acpi/q35/DSDT.multi-bridge
index 595ab64601ae3deb12bbf18ca463e39ba0a86195..4e4b5229502000550f169948393ba8cbc7a793d5 100644
GIT binary patch
delta 92
zcmZom-kHqh66_MP(~yCI@$N>hyK>xpyo@pN!A|i4t-PB*$r&^8^9LK6#B;<ux&-mC
kFfcJ}R#uGU;W2`WFfp(&Y%bU3XX18*i^y+o&}U-;0Gh`ZV*mgE
delta 50
zcmdm)+?LGc66_MvX2`(67`Tz^t{ita7h_C(uv5H16W8WXa>h)X%@o6VHqX=LVp_aY
Gp9uhq*bim^
diff --git a/tests/data/acpi/q35/DSDT.noacpihp b/tests/data/acpi/q35/DSDT.noacpihp
index c292c2369b011b779af44d0fa6fd2f7994098b2e..1c17aa30f7f0155a81988aa43c56e2f71530b4e4 100644
GIT binary patch
delta 65
zcmexk-|N8T66_MftH8j(IA<f5i!7JFc1(P*Q@nt?_T~uL8BDT{@f`7vE<rp@4Dt-o
OP5i-bPEY}6pa1|e`43qD
delta 48
zcmeBm_+!uI66_N4N1lO!(P<->i!7I)R!n@bQ@nti*5(M=8B9D*@f`7vE<rrZ4Dt*B
DSgj05
diff --git a/tests/data/acpi/q35/DSDT.nohpet b/tests/data/acpi/q35/DSDT.nohpet
index be3060aa51d67c0f02c70bd0a7d5c028016641a1..becb5f7cad68361463b30be80095ab10966d7c88 100644
GIT binary patch
delta 51
zcmeBjnC-yj66_Kpt-!#*xPK#;zZ{pVbWD7(Q@nt$)aGQlK1OcGc#e2SmmnS{2KmXa
G<>dieNDU_d
delta 39
ucmbR3(B;7866_MfrNF?zn6i<}UyjQ~DkeVIDPF)wa&xj=ALC>u1xWzKnhCQ2
diff --git a/tests/data/acpi/q35/DSDT.numamem b/tests/data/acpi/q35/DSDT.numamem
index 5e94a2b61f840c68d27257831cf608d41ee7c154..0cdec0b4c53b2b0e38cd019caab552f66f7728e7 100644
GIT binary patch
delta 51
zcmbQ|xZaV=CD<ioy#fOR<ARM`kL9>rrDNiQo#F+2r8a+;>tp10jOU1VbP3{NVvwI)
HuOJTql|2rF
delta 39
vcmZ4QIM0#GCD<ioo&o~{qw7Yl$8uaQQZeztPVoXhlAFKF^)XJKrXUFb?Kun%
diff --git a/tests/data/acpi/q35/DSDT.pvpanic-isa b/tests/data/acpi/q35/DSDT.pvpanic-isa
index 0e609a0c48fef371f935f239ebb9620fa116b049..6a9904ec947e373520e0135a89c559cb4f57fa7d 100644
GIT binary patch
delta 51
zcmezC*yqIM66_Mfr^vv-xMCyMT{$i<#hCbDr+5J;#myh(J~MJV#&g6wx&-ksG00E8
Hryvgikk1b3
delta 39
vcmeBk`s>K$66_N4SAl_n(QhNyT{$jKg_!tYr+5KJh0P!3J~K}Ksvrpf1%wTB
diff --git a/tests/data/acpi/q35/DSDT.tis.tpm12 b/tests/data/acpi/q35/DSDT.tis.tpm12
index fc6cc4585a6b1d955bc80700ec2dc2720b7e4a89..628bf628f6891f906bf872f8916692ba0ccb6877 100644
GIT binary patch
delta 51
zcmez7+U~~X66_MfuFSx|sJ4;or5u;LLri?IQ@nt`{pP=N516?f<2m9TU4nR+8005k
HSCR(+ghURd
delta 39
vcmZp7`{v5!66_N4O^Jbl@ytf9mvUTg_A&9nPVoYMcANjoJz$>vPDv5~6zvW$
diff --git a/tests/data/acpi/q35/DSDT.tis.tpm2 b/tests/data/acpi/q35/DSDT.tis.tpm2
index 815006e445d0ec44c2f4a7c8d30ead6616a32b32..35c6b08068d4d2fb0353802dc2460cc2912c129c 100644
GIT binary patch
delta 51
zcmbQ>w$P2sCD<iIQJH~(@xex}mvUT=PBHPpPVoYsj+_6={bJ^JjOU1VbP3{NVvwKw
HQAr*Em5L8q
delta 61
zcmZ4JHo=X{CD<iIK$(Gov2`QYOF1qF$C&tFr+5Jmhs}TGelbfr#dE|vx&-ksGsrUt
R@Wi_ZxQejFyBZiW000)M532wG
diff --git a/tests/data/acpi/q35/DSDT.viot b/tests/data/acpi/q35/DSDT.viot
index a53b3135c85b0908a794f93c7f2e5d3720b79a7d..b4d8dfd96730c1bdc8e1110ada909ec1dcee6d30 100644
GIT binary patch
delta 51
zcmezC+2_UO66_Mfr^>*<n6Q!SpAwg+d`x_>Q@ntq{AMBLON`u(@f`7vE<rp@4Dyrj
HsmKEWdkhWT
delta 39
vcmeD4`s>N%66_N4SA~Irk!>T_KP4^?xtRE1r+5Jexy?e#ml!91RgnY${BjIv
diff --git a/tests/data/acpi/q35/DSDT.xapic b/tests/data/acpi/q35/DSDT.xapic
index 8cf5b9703d617d0a0b16d41cd713f7883c80fcfe..d4a34e23512c295f73abbe5ef1370fac7a1a06cd 100644
GIT binary patch
delta 53
zcmex8jj3lk6PHV{OGr;Q0|Volja&yhxm=}V;)9*y1$?D8U+L^)<aUhbh<9`e;$dQt
JpB&RI4*=r85SRb}
delta 41
xcmeB~&h&d46PHV{OGtG$0|R5=My>;$TrN^E@xe~<0zQ(PuXOe?PA=}21OOw$4kG{n
--
2.39.1
^ permalink raw reply related [flat|nested] 46+ messages in thread* [PATCH 25/33] tests: acpi: whitelist DSDT before adding non-0 function device with acpi-index to testcases
2023-02-24 15:37 [PATCH 00/33] pci(pc/q35): acpi-index support on non-hotpluggable slots Igor Mammedov
` (23 preceding siblings ...)
2023-02-24 15:38 ` [PATCH 24/33] tests: acpi: update expected blobs Igor Mammedov
@ 2023-02-24 15:38 ` Igor Mammedov
2023-02-24 15:38 ` [PATCH 26/33] tests: acpi: add non zero function device with acpi-index on non-hotpluggble bus Igor Mammedov
` (8 subsequent siblings)
33 siblings, 0 replies; 46+ messages in thread
From: Igor Mammedov @ 2023-02-24 15:38 UTC (permalink / raw)
To: qemu-devel; +Cc: mst, ani, berrange
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
tests/qtest/bios-tables-test-allowed-diff.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
index dfb8523c8b..ad2b429de8 100644
--- a/tests/qtest/bios-tables-test-allowed-diff.h
+++ b/tests/qtest/bios-tables-test-allowed-diff.h
@@ -1 +1,3 @@
/* List of comma-separated changed AML files to ignore */
+"tests/data/acpi/q35/DSDT.multi-bridge",
+"tests/data/acpi/q35/DSDT.noacpihp",
--
2.39.1
^ permalink raw reply related [flat|nested] 46+ messages in thread* [PATCH 26/33] tests: acpi: add non zero function device with acpi-index on non-hotpluggble bus
2023-02-24 15:37 [PATCH 00/33] pci(pc/q35): acpi-index support on non-hotpluggable slots Igor Mammedov
` (24 preceding siblings ...)
2023-02-24 15:38 ` [PATCH 25/33] tests: acpi: whitelist DSDT before adding non-0 function device with acpi-index to testcases Igor Mammedov
@ 2023-02-24 15:38 ` Igor Mammedov
2023-02-24 15:38 ` [PATCH 27/33] tests: acpi: update expected blobs Igor Mammedov
` (7 subsequent siblings)
33 siblings, 0 replies; 46+ messages in thread
From: Igor Mammedov @ 2023-02-24 15:38 UTC (permalink / raw)
To: qemu-devel; +Cc: mst, ani, berrange
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
tests/qtest/bios-tables-test.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest/bios-tables-test.c
index 88493abc40..259405724e 100644
--- a/tests/qtest/bios-tables-test.c
+++ b/tests/qtest/bios-tables-test.c
@@ -1028,10 +1028,11 @@ static void test_acpi_q35_tcg_no_acpi_hotplug(void)
"addr=7.0"
" -device pci-testdev,bus=nohprp,acpi-index=501"
" -device pcie-root-port,id=nohprpint,port=0x0,chassis=3,hotplug=off,"
- "addr=8.0"
+ "multifunction=on,addr=8.0"
+ " -device pci-testdev,bus=nohprpint,acpi-index=601,addr=8.1"
" -device pcie-root-port,id=hprp2,port=0x0,chassis=4,bus=nohprpint,"
"addr=9.0"
- " -device pci-testdev,bus=hprp2,acpi-index=601"
+ " -device pci-testdev,bus=hprp2,acpi-index=602"
, &data);
free_test_data(&data);
}
@@ -1059,6 +1060,7 @@ static void test_acpi_q35_multif_bridge(void)
" -device pcie-root-port,id=rphptgt2,port=0x0,chassis=6,addr=2.2"
" -device pcie-root-port,id=rphptgt3,port=0x0,chassis=7,addr=2.3"
" -device pci-testdev,bus=pcie.0,addr=2.4"
+ " -device pci-testdev,bus=pcie.0,addr=2.5,acpi-index=102"
" -device pci-testdev,bus=pcie.0,addr=5.0"
" -device pci-testdev,bus=pcie.0,addr=0xf.0,acpi-index=101"
" -device pci-testdev,bus=rp0,addr=0.0"
--
2.39.1
^ permalink raw reply related [flat|nested] 46+ messages in thread* [PATCH 27/33] tests: acpi: update expected blobs
2023-02-24 15:37 [PATCH 00/33] pci(pc/q35): acpi-index support on non-hotpluggable slots Igor Mammedov
` (25 preceding siblings ...)
2023-02-24 15:38 ` [PATCH 26/33] tests: acpi: add non zero function device with acpi-index on non-hotpluggble bus Igor Mammedov
@ 2023-02-24 15:38 ` Igor Mammedov
2023-02-24 15:38 ` [PATCH 28/33] pci: move acpi-index uniqueness check to generic PCI device code Igor Mammedov
` (6 subsequent siblings)
33 siblings, 0 replies; 46+ messages in thread
From: Igor Mammedov @ 2023-02-24 15:38 UTC (permalink / raw)
To: qemu-devel; +Cc: mst, ani, berrange
an extra devices at non-zero function address with static
_DSM method get exposed, ex:
+ Device (S15)
+ {
+ Name (_ADR, 0x00020005) // _ADR: Address
+ Method (_DSM, 4, Serialized) // _DSM: Device-Specific Method
+ {
+ Local0 = Package (0x01)
+ {
+ 0x66
+ }
+ Return (EDSM (Arg0, Arg1, Arg2, Arg3, Local0))
+ }
+ }
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
tests/qtest/bios-tables-test-allowed-diff.h | 2 --
tests/data/acpi/q35/DSDT.multi-bridge | Bin 12729 -> 12770 bytes
tests/data/acpi/q35/DSDT.noacpihp | Bin 8205 -> 8248 bytes
3 files changed, 2 deletions(-)
diff --git a/tests/qtest/bios-tables-test-allowed-diff.h b/tests/qtest/bios-tables-test-allowed-diff.h
index ad2b429de8..dfb8523c8b 100644
--- a/tests/qtest/bios-tables-test-allowed-diff.h
+++ b/tests/qtest/bios-tables-test-allowed-diff.h
@@ -1,3 +1 @@
/* List of comma-separated changed AML files to ignore */
-"tests/data/acpi/q35/DSDT.multi-bridge",
-"tests/data/acpi/q35/DSDT.noacpihp",
diff --git a/tests/data/acpi/q35/DSDT.multi-bridge b/tests/data/acpi/q35/DSDT.multi-bridge
index 4e4b5229502000550f169948393ba8cbc7a793d5..9ae8ee0b41738bd8951b9449abcfc67c293fdce1 100644
GIT binary patch
delta 81
zcmdm){3w~rCD<k8ks$*E<D89LcjdU-1sG%EgPr09`uI10l5=5FR}VHcjpvAWbP3{N
kWnf|u5s!BX_T?!MVqxS;OIYFx<YZ)KWhZPlQEU|e0OA}M0RR91
delta 41
xcmaEqyfc~0CD<iory&Ca<K2y1cjdVIco}2jgPr09T6s5rl5=6&9Ix0c001!W4d4I(
diff --git a/tests/data/acpi/q35/DSDT.noacpihp b/tests/data/acpi/q35/DSDT.noacpihp
index 1c17aa30f7f0155a81988aa43c56e2f71530b4e4..6ab1f0e52543fcb7f84a7fd1327fe5aa42010565 100644
GIT binary patch
delta 99
zcmeBm*x|tC66_LUp}@ev=(Ul{MV8A;FD5?NDPF)yZ*zpK6r+^~Yp{tyJV(5vOArqO
v0|!HNlSZ(KAyj}7C?Fyc?-K0GQy|33$Q{X)u*4O}%gD^iPT1Ti*TV<^dqx+F
delta 56
zcmdnt(CfhE66_MftH8j(IA<f5i!7JFc1(P*Q@nt?_T~s#DMo(XU=xFQj(A6xARYz=
L4u;KZ<a!tZl4uQ!
--
2.39.1
^ permalink raw reply related [flat|nested] 46+ messages in thread* [PATCH 28/33] pci: move acpi-index uniqueness check to generic PCI device code
2023-02-24 15:37 [PATCH 00/33] pci(pc/q35): acpi-index support on non-hotpluggable slots Igor Mammedov
` (26 preceding siblings ...)
2023-02-24 15:38 ` [PATCH 27/33] tests: acpi: update expected blobs Igor Mammedov
@ 2023-02-24 15:38 ` Igor Mammedov
2023-02-24 15:38 ` [PATCH 29/33] acpi: pci: drop BSEL usage when deciding that device isn't hotpluggable Igor Mammedov
` (5 subsequent siblings)
33 siblings, 0 replies; 46+ messages in thread
From: Igor Mammedov @ 2023-02-24 15:38 UTC (permalink / raw)
To: qemu-devel; +Cc: mst, ani, berrange
acpi-index is now working with non-hotpluggable buses
(pci/q35 machine hostbridge), it can be used even if
ACPI PCI hotplug is disabled and as result acpi-index
uniqueness check will be omitted (since the check is
done by ACPI PCI hotplug handler, which isn't wired
when ACPI PCI hotplug is disabled).
Move check and related code to generic PCIDevice so it
would be independent of ACPI PCI hotplug.
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
PS: this also one step closer to enabling acpi-index
support for microvm and virt/arm machines.
---
hw/acpi/pcihp.c | 56 ------------------------------------------------
hw/pci/pci.c | 57 +++++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 57 insertions(+), 56 deletions(-)
diff --git a/hw/acpi/pcihp.c b/hw/acpi/pcihp.c
index 5dc7377411..adf45e8443 100644
--- a/hw/acpi/pcihp.c
+++ b/hw/acpi/pcihp.c
@@ -54,21 +54,6 @@ typedef struct AcpiPciHpFind {
PCIBus *bus;
} AcpiPciHpFind;
-static gint g_cmp_uint32(gconstpointer a, gconstpointer b, gpointer user_data)
-{
- return a - b;
-}
-
-static GSequence *pci_acpi_index_list(void)
-{
- static GSequence *used_acpi_index_list;
-
- if (!used_acpi_index_list) {
- used_acpi_index_list = g_sequence_new(NULL);
- }
- return used_acpi_index_list;
-}
-
static int acpi_pcihp_get_bsel(PCIBus *bus)
{
Error *local_err = NULL;
@@ -300,8 +285,6 @@ void acpi_pcihp_reset(AcpiPciHpState *s, bool acpihp_root_off)
acpi_pcihp_update(s);
}
-#define ONBOARD_INDEX_MAX (16 * 1024 - 1)
-
void acpi_pcihp_device_pre_plug_cb(HotplugHandler *hotplug_dev,
DeviceState *dev, Error **errp)
{
@@ -314,34 +297,6 @@ void acpi_pcihp_device_pre_plug_cb(HotplugHandler *hotplug_dev,
ACPI_PCIHP_PROP_BSEL "' set");
return;
}
-
- /*
- * capped by systemd (see: udev-builtin-net_id.c)
- * as it's the only known user honor it to avoid users
- * misconfigure QEMU and then wonder why acpi-index doesn't work
- */
- if (pdev->acpi_index > ONBOARD_INDEX_MAX) {
- error_setg(errp, "acpi-index should be less or equal to %u",
- ONBOARD_INDEX_MAX);
- return;
- }
-
- /*
- * make sure that acpi-index is unique across all present PCI devices
- */
- if (pdev->acpi_index) {
- GSequence *used_indexes = pci_acpi_index_list();
-
- if (g_sequence_lookup(used_indexes, GINT_TO_POINTER(pdev->acpi_index),
- g_cmp_uint32, NULL)) {
- error_setg(errp, "a PCI device with acpi-index = %" PRIu32
- " already exist", pdev->acpi_index);
- return;
- }
- g_sequence_insert_sorted(used_indexes,
- GINT_TO_POINTER(pdev->acpi_index),
- g_cmp_uint32, NULL);
- }
}
void acpi_pcihp_device_plug_cb(HotplugHandler *hotplug_dev, AcpiPciHpState *s,
@@ -401,17 +356,6 @@ void acpi_pcihp_device_unplug_cb(HotplugHandler *hotplug_dev, AcpiPciHpState *s,
trace_acpi_pci_unplug(PCI_SLOT(pdev->devfn),
acpi_pcihp_get_bsel(pci_get_bus(pdev)));
- /*
- * clean up acpi-index so it could reused by another device
- */
- if (pdev->acpi_index) {
- GSequence *used_indexes = pci_acpi_index_list();
-
- g_sequence_remove(g_sequence_lookup(used_indexes,
- GINT_TO_POINTER(pdev->acpi_index),
- g_cmp_uint32, NULL));
- }
-
qdev_unrealize(dev);
}
diff --git a/hw/pci/pci.c b/hw/pci/pci.c
index cc51f98593..d9be0cfca6 100644
--- a/hw/pci/pci.c
+++ b/hw/pci/pci.c
@@ -92,6 +92,21 @@ static const VMStateDescription vmstate_pcibus = {
}
};
+static gint g_cmp_uint32(gconstpointer a, gconstpointer b, gpointer user_data)
+{
+ return a - b;
+}
+
+static GSequence *pci_acpi_index_list(void)
+{
+ static GSequence *used_acpi_index_list;
+
+ if (!used_acpi_index_list) {
+ used_acpi_index_list = g_sequence_new(NULL);
+ }
+ return used_acpi_index_list;
+}
+
static void pci_init_bus_master(PCIDevice *pci_dev)
{
AddressSpace *dma_as = pci_device_iommu_address_space(pci_dev);
@@ -1225,6 +1240,17 @@ static void pci_qdev_unrealize(DeviceState *dev)
do_pci_unregister_device(pci_dev);
pci_dev->msi_trigger = NULL;
+
+ /*
+ * clean up acpi-index so it could reused by another device
+ */
+ if (pci_dev->acpi_index) {
+ GSequence *used_indexes = pci_acpi_index_list();
+
+ g_sequence_remove(g_sequence_lookup(used_indexes,
+ GINT_TO_POINTER(pci_dev->acpi_index),
+ g_cmp_uint32, NULL));
+ }
}
void pci_register_bar(PCIDevice *pci_dev, int region_num,
@@ -1980,6 +2006,8 @@ PCIDevice *pci_find_device(PCIBus *bus, int bus_num, uint8_t devfn)
return bus->devices[devfn];
}
+#define ONBOARD_INDEX_MAX (16 * 1024 - 1)
+
static void pci_qdev_realize(DeviceState *qdev, Error **errp)
{
PCIDevice *pci_dev = (PCIDevice *)qdev;
@@ -1989,6 +2017,35 @@ static void pci_qdev_realize(DeviceState *qdev, Error **errp)
bool is_default_rom;
uint16_t class_id;
+ /*
+ * capped by systemd (see: udev-builtin-net_id.c)
+ * as it's the only known user honor it to avoid users
+ * misconfigure QEMU and then wonder why acpi-index doesn't work
+ */
+ if (pci_dev->acpi_index > ONBOARD_INDEX_MAX) {
+ error_setg(errp, "acpi-index should be less or equal to %u",
+ ONBOARD_INDEX_MAX);
+ return;
+ }
+
+ /*
+ * make sure that acpi-index is unique across all present PCI devices
+ */
+ if (pci_dev->acpi_index) {
+ GSequence *used_indexes = pci_acpi_index_list();
+
+ if (g_sequence_lookup(used_indexes,
+ GINT_TO_POINTER(pci_dev->acpi_index),
+ g_cmp_uint32, NULL)) {
+ error_setg(errp, "a PCI device with acpi-index = %" PRIu32
+ " already exist", pci_dev->acpi_index);
+ return;
+ }
+ g_sequence_insert_sorted(used_indexes,
+ GINT_TO_POINTER(pci_dev->acpi_index),
+ g_cmp_uint32, NULL);
+ }
+
if (pci_dev->romsize != -1 && !is_power_of_2(pci_dev->romsize)) {
error_setg(errp, "ROM size %u is not a power of two", pci_dev->romsize);
return;
--
2.39.1
^ permalink raw reply related [flat|nested] 46+ messages in thread* [PATCH 29/33] acpi: pci: drop BSEL usage when deciding that device isn't hotpluggable
2023-02-24 15:37 [PATCH 00/33] pci(pc/q35): acpi-index support on non-hotpluggable slots Igor Mammedov
` (27 preceding siblings ...)
2023-02-24 15:38 ` [PATCH 28/33] pci: move acpi-index uniqueness check to generic PCI device code Igor Mammedov
@ 2023-02-24 15:38 ` Igor Mammedov
2023-02-24 15:38 ` [PATCH 30/33] acpi: pci: move BSEL into build_append_pcihp_slots() Igor Mammedov
` (4 subsequent siblings)
33 siblings, 0 replies; 46+ messages in thread
From: Igor Mammedov @ 2023-02-24 15:38 UTC (permalink / raw)
To: qemu-devel; +Cc: mst, ani, berrange
previous commit ("pci: fix 'hotplugglable' property behavior") fixed
pcie root port's 'hotpluggable' property to behave consistently.
So we don't need a BSEL crutch anymore to see of device is not
hotpluggable, drop it from 'generic' PCI slots description handling.
BSEL is still used to decide if hotplug part should be called
but that will be moved out of generic code to hotplug one by
followup patches.
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
hw/i386/acpi-build.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 7b982b6072..6b51b7401d 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -590,7 +590,7 @@ void build_append_pci_bus_devices(Aml *parent_scope, PCIBus *bus)
call_dev_aml_func(DEVICE(bus->devices[devfn]), dev);
/* add _DSM if device has acpi-index set */
- if (pdev->acpi_index && !bsel &&
+ if (pdev->acpi_index &&
!object_property_get_bool(OBJECT(pdev), "hotpluggable",
&error_abort)) {
aml_append(dev, aml_pci_static_endpoint_dsm(pdev));
--
2.39.1
^ permalink raw reply related [flat|nested] 46+ messages in thread* [PATCH 30/33] acpi: pci: move BSEL into build_append_pcihp_slots()
2023-02-24 15:37 [PATCH 00/33] pci(pc/q35): acpi-index support on non-hotpluggable slots Igor Mammedov
` (28 preceding siblings ...)
2023-02-24 15:38 ` [PATCH 29/33] acpi: pci: drop BSEL usage when deciding that device isn't hotpluggable Igor Mammedov
@ 2023-02-24 15:38 ` Igor Mammedov
2023-02-24 15:38 ` [PATCH 31/33] acpi: pci: move out ACPI PCI hotplug generator from generic slot generator build_append_pci_bus_devices() Igor Mammedov
` (3 subsequent siblings)
33 siblings, 0 replies; 46+ messages in thread
From: Igor Mammedov @ 2023-02-24 15:38 UTC (permalink / raw)
To: qemu-devel; +Cc: mst, ani, berrange
Generic PCI enumeration code doesn't really need access to
BSEL value, it is only used as means to decide if hotplug
enumerator should be called.
Use stateless object_property_find() to do that, and move
the rest of BSEL handling into build_append_pcihp_slots()
where it belongs.
This cleans up generic code a bit from hotplug stuff
and follow up patch will remove remaining call to
build_append_pcihp_slots() from generic code, making
it possible to use without ACPI PCI hotplug dependencies.
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
hw/i386/acpi-build.c | 15 ++++++---------
1 file changed, 6 insertions(+), 9 deletions(-)
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index 6b51b7401d..d068b0507e 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -519,12 +519,14 @@ static bool is_devfn_ignored_hotplug(const int devfn, const PCIBus *bus)
return false;
}
-static void build_append_pcihp_slots(Aml *parent_scope, PCIBus *bus,
- QObject *bsel)
+static void build_append_pcihp_slots(Aml *parent_scope, PCIBus *bus)
{
int devfn;
Aml *dev, *notify_method = NULL, *method;
+ QObject *bsel = object_property_get_qobject(OBJECT(bus),
+ ACPI_PCIHP_PROP_BSEL, NULL);
uint64_t bsel_val = qnum_get_uint(qobject_to(QNum, bsel));
+ qobject_unref(bsel);
aml_append(parent_scope, aml_name_decl("BSEL", aml_int(bsel_val)));
notify_method = aml_method("DVNT", 2, AML_NOTSERIALIZED);
@@ -569,12 +571,9 @@ static void build_append_pcihp_slots(Aml *parent_scope, PCIBus *bus,
void build_append_pci_bus_devices(Aml *parent_scope, PCIBus *bus)
{
- QObject *bsel;
int devfn;
Aml *dev;
- bsel = object_property_get_qobject(OBJECT(bus), ACPI_PCIHP_PROP_BSEL, NULL);
-
for (devfn = 0; devfn < ARRAY_SIZE(bus->devices); devfn++) {
/* ACPI spec: 1.0b: Table 6-2 _ADR Object Bus Types, PCI type */
int adr = PCI_SLOT(devfn) << 16 | PCI_FUNC(devfn);
@@ -600,11 +599,9 @@ void build_append_pci_bus_devices(Aml *parent_scope, PCIBus *bus)
aml_append(parent_scope, dev);
}
- if (bsel) {
- build_append_pcihp_slots(parent_scope, bus, bsel);
+ if (object_property_find(OBJECT(bus), ACPI_PCIHP_PROP_BSEL)) {
+ build_append_pcihp_slots(parent_scope, bus);
}
-
- qobject_unref(bsel);
}
static bool build_append_notfication_callback(Aml *parent_scope,
--
2.39.1
^ permalink raw reply related [flat|nested] 46+ messages in thread* [PATCH 31/33] acpi: pci: move out ACPI PCI hotplug generator from generic slot generator build_append_pci_bus_devices()
2023-02-24 15:37 [PATCH 00/33] pci(pc/q35): acpi-index support on non-hotpluggable slots Igor Mammedov
` (29 preceding siblings ...)
2023-02-24 15:38 ` [PATCH 30/33] acpi: pci: move BSEL into build_append_pcihp_slots() Igor Mammedov
@ 2023-02-24 15:38 ` Igor Mammedov
2023-02-24 15:38 ` [PATCH 32/33] pcihp: move fields enabling hotplug into AcpiPciHpState Igor Mammedov
` (2 subsequent siblings)
33 siblings, 0 replies; 46+ messages in thread
From: Igor Mammedov @ 2023-02-24 15:38 UTC (permalink / raw)
To: qemu-devel; +Cc: mst, ani, berrange
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
include/hw/acpi/pcihp.h | 2 ++
hw/acpi/pci-bridge.c | 12 +++++++++++-
hw/i386/acpi-build.c | 9 ++++-----
3 files changed, 17 insertions(+), 6 deletions(-)
diff --git a/include/hw/acpi/pcihp.h b/include/hw/acpi/pcihp.h
index 7e268c2c9c..cd18ebdcdc 100644
--- a/include/hw/acpi/pcihp.h
+++ b/include/hw/acpi/pcihp.h
@@ -71,6 +71,8 @@ void acpi_pcihp_device_unplug_request_cb(HotplugHandler *hotplug_dev,
/* Called on reset */
void acpi_pcihp_reset(AcpiPciHpState *s, bool acpihp_root_off);
+void build_append_pcihp_slots(Aml *parent_scope, PCIBus *bus);
+
extern const VMStateDescription vmstate_acpi_pcihp_pci_status;
#define VMSTATE_PCI_HOTPLUG(pcihp, state, test_pcihp, test_acpi_index) \
diff --git a/hw/acpi/pci-bridge.c b/hw/acpi/pci-bridge.c
index 4fbf6da6ad..7baa7034a1 100644
--- a/hw/acpi/pci-bridge.c
+++ b/hw/acpi/pci-bridge.c
@@ -22,6 +22,16 @@ void build_pci_bridge_aml(AcpiDevAmlIf *adev, Aml *scope)
PCIBridge *br = PCI_BRIDGE(adev);
if (!DEVICE(br)->hotplugged) {
- build_append_pci_bus_devices(scope, pci_bridge_get_sec_bus(br));
+ PCIBus *sec_bus = pci_bridge_get_sec_bus(br);
+
+ build_append_pci_bus_devices(scope, sec_bus);
+
+ /*
+ * generate hotplug slots descriptors if
+ * bridge has ACPI PCI hotplug attached,
+ */
+ if (object_property_find(OBJECT(sec_bus), ACPI_PCIHP_PROP_BSEL)) {
+ build_append_pcihp_slots(scope, sec_bus);
+ }
}
}
diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c
index d068b0507e..0c298b5f60 100644
--- a/hw/i386/acpi-build.c
+++ b/hw/i386/acpi-build.c
@@ -519,7 +519,7 @@ static bool is_devfn_ignored_hotplug(const int devfn, const PCIBus *bus)
return false;
}
-static void build_append_pcihp_slots(Aml *parent_scope, PCIBus *bus)
+void build_append_pcihp_slots(Aml *parent_scope, PCIBus *bus)
{
int devfn;
Aml *dev, *notify_method = NULL, *method;
@@ -598,10 +598,6 @@ void build_append_pci_bus_devices(Aml *parent_scope, PCIBus *bus)
/* device descriptor has been composed, add it into parent context */
aml_append(parent_scope, dev);
}
-
- if (object_property_find(OBJECT(bus), ACPI_PCIHP_PROP_BSEL)) {
- build_append_pcihp_slots(parent_scope, bus);
- }
}
static bool build_append_notfication_callback(Aml *parent_scope,
@@ -1790,6 +1786,9 @@ build_dsdt(GArray *table_data, BIOSLinker *linker,
Aml *scope = aml_scope("PCI0");
/* Scan all PCI buses. Generate tables to support hotplug. */
build_append_pci_bus_devices(scope, bus);
+ if (object_property_find(OBJECT(bus), ACPI_PCIHP_PROP_BSEL)) {
+ build_append_pcihp_slots(scope, bus);
+ }
aml_append(sb_scope, scope);
}
}
--
2.39.1
^ permalink raw reply related [flat|nested] 46+ messages in thread* [PATCH 32/33] pcihp: move fields enabling hotplug into AcpiPciHpState
2023-02-24 15:37 [PATCH 00/33] pci(pc/q35): acpi-index support on non-hotpluggable slots Igor Mammedov
` (30 preceding siblings ...)
2023-02-24 15:38 ` [PATCH 31/33] acpi: pci: move out ACPI PCI hotplug generator from generic slot generator build_append_pci_bus_devices() Igor Mammedov
@ 2023-02-24 15:38 ` Igor Mammedov
2023-02-24 15:38 ` [PATCH 33/33] pcihp: add ACPI PCI hotplug specific is_hotpluggable_bus() callback Igor Mammedov
2023-03-02 10:59 ` [PATCH 00/33] pci(pc/q35): acpi-index support on non-hotpluggable slots Michael S. Tsirkin
33 siblings, 0 replies; 46+ messages in thread
From: Igor Mammedov @ 2023-02-24 15:38 UTC (permalink / raw)
To: qemu-devel; +Cc: mst, ani, berrange
... instead of duplicating them in piix4 and lpc and then
trying to pass them to pcihp routines as arguments.
it simplifies call sites and places pcihp specific in
its own structure.
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
include/hw/acpi/pcihp.h | 8 ++++----
include/hw/acpi/piix4.h | 2 --
hw/acpi/acpi-pci-hotplug-stub.c | 5 ++---
hw/acpi/ich9.c | 15 +++++++--------
hw/acpi/pcihp.c | 16 ++++++++--------
hw/acpi/piix4.c | 23 +++++++++++++----------
6 files changed, 34 insertions(+), 35 deletions(-)
diff --git a/include/hw/acpi/pcihp.h b/include/hw/acpi/pcihp.h
index cd18ebdcdc..04c98511a4 100644
--- a/include/hw/acpi/pcihp.h
+++ b/include/hw/acpi/pcihp.h
@@ -49,14 +49,14 @@ typedef struct AcpiPciHpState {
uint32_t acpi_index;
PCIBus *root;
MemoryRegion io;
- bool legacy_piix;
uint16_t io_base;
uint16_t io_len;
+ bool use_acpi_hotplug_bridge;
+ bool use_acpi_root_pci_hotplug;
} AcpiPciHpState;
void acpi_pcihp_init(Object *owner, AcpiPciHpState *, PCIBus *root,
- MemoryRegion *address_space_io, bool bridges_enabled,
- uint16_t io_base);
+ MemoryRegion *address_space_io, uint16_t io_base);
void acpi_pcihp_device_pre_plug_cb(HotplugHandler *hotplug_dev,
DeviceState *dev, Error **errp);
@@ -69,7 +69,7 @@ void acpi_pcihp_device_unplug_request_cb(HotplugHandler *hotplug_dev,
Error **errp);
/* Called on reset */
-void acpi_pcihp_reset(AcpiPciHpState *s, bool acpihp_root_off);
+void acpi_pcihp_reset(AcpiPciHpState *s);
void build_append_pcihp_slots(Aml *parent_scope, PCIBus *bus);
diff --git a/include/hw/acpi/piix4.h b/include/hw/acpi/piix4.h
index be1f8ea80e..eb1c122d80 100644
--- a/include/hw/acpi/piix4.h
+++ b/include/hw/acpi/piix4.h
@@ -57,8 +57,6 @@ struct PIIX4PMState {
Notifier powerdown_notifier;
AcpiPciHpState acpi_pci_hotplug;
- bool use_acpi_hotplug_bridge;
- bool use_acpi_root_pci_hotplug;
bool not_migrate_acpi_index;
uint8_t disable_s3;
diff --git a/hw/acpi/acpi-pci-hotplug-stub.c b/hw/acpi/acpi-pci-hotplug-stub.c
index a43f6dafc9..d1794399f7 100644
--- a/hw/acpi/acpi-pci-hotplug-stub.c
+++ b/hw/acpi/acpi-pci-hotplug-stub.c
@@ -5,8 +5,7 @@
const VMStateDescription vmstate_acpi_pcihp_pci_status;
void acpi_pcihp_init(Object *owner, AcpiPciHpState *s, PCIBus *root_bus,
- MemoryRegion *address_space_io, bool bridges_enabled,
- uint16_t io_base)
+ MemoryRegion *address_space_io, uint16_t io_base)
{
return;
}
@@ -36,7 +35,7 @@ void acpi_pcihp_device_unplug_request_cb(HotplugHandler *hotplug_dev,
return;
}
-void acpi_pcihp_reset(AcpiPciHpState *s, bool acpihp_root_off)
+void acpi_pcihp_reset(AcpiPciHpState *s)
{
return;
}
diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c
index a93c470e9d..34a58fc07c 100644
--- a/hw/acpi/ich9.c
+++ b/hw/acpi/ich9.c
@@ -218,7 +218,7 @@ static bool vmstate_test_use_pcihp(void *opaque)
{
ICH9LPCPMRegs *s = opaque;
- return s->use_acpi_hotplug_bridge;
+ return s->acpi_pci_hotplug.use_acpi_hotplug_bridge;
}
static const VMStateDescription vmstate_pcihp_state = {
@@ -277,8 +277,8 @@ static void pm_reset(void *opaque)
}
pm->smi_en_wmask = ~0;
- if (pm->use_acpi_hotplug_bridge) {
- acpi_pcihp_reset(&pm->acpi_pci_hotplug, true);
+ if (pm->acpi_pci_hotplug.use_acpi_hotplug_bridge) {
+ acpi_pcihp_reset(&pm->acpi_pci_hotplug);
}
acpi_update_sci(&pm->acpi_regs, pm->irq);
@@ -320,12 +320,11 @@ void ich9_pm_init(PCIDevice *lpc_pci, ICH9LPCPMRegs *pm,
acpi_pm_tco_init(&pm->tco_regs, &pm->io);
}
- if (pm->use_acpi_hotplug_bridge) {
+ if (pm->acpi_pci_hotplug.use_acpi_hotplug_bridge) {
acpi_pcihp_init(OBJECT(lpc_pci),
&pm->acpi_pci_hotplug,
pci_get_bus(lpc_pci),
pci_address_space_io(lpc_pci),
- true,
ACPI_PCIHP_ADDR_ICH9);
qbus_set_hotplug_handler(BUS(pci_get_bus(lpc_pci)),
@@ -407,14 +406,14 @@ static bool ich9_pm_get_acpi_pci_hotplug(Object *obj, Error **errp)
{
ICH9LPCState *s = ICH9_LPC_DEVICE(obj);
- return s->pm.use_acpi_hotplug_bridge;
+ return s->pm.acpi_pci_hotplug.use_acpi_hotplug_bridge;
}
static void ich9_pm_set_acpi_pci_hotplug(Object *obj, bool value, Error **errp)
{
ICH9LPCState *s = ICH9_LPC_DEVICE(obj);
- s->pm.use_acpi_hotplug_bridge = value;
+ s->pm.acpi_pci_hotplug.use_acpi_hotplug_bridge = value;
}
static bool ich9_pm_get_keep_pci_slot_hpc(Object *obj, Error **errp)
@@ -439,7 +438,7 @@ void ich9_pm_add_properties(Object *obj, ICH9LPCPMRegs *pm)
pm->disable_s3 = 0;
pm->disable_s4 = 0;
pm->s4_val = 2;
- pm->use_acpi_hotplug_bridge = true;
+ pm->acpi_pci_hotplug.use_acpi_hotplug_bridge = true;
pm->keep_pci_slot_hpc = true;
pm->enable_tco = true;
diff --git a/hw/acpi/pcihp.c b/hw/acpi/pcihp.c
index adf45e8443..34cad061a8 100644
--- a/hw/acpi/pcihp.c
+++ b/hw/acpi/pcihp.c
@@ -276,12 +276,12 @@ static void acpi_pcihp_update(AcpiPciHpState *s)
}
}
-void acpi_pcihp_reset(AcpiPciHpState *s, bool acpihp_root_off)
+void acpi_pcihp_reset(AcpiPciHpState *s)
{
- if (acpihp_root_off) {
+ if (!s->use_acpi_root_pci_hotplug) {
acpi_pcihp_disable_root_bus();
}
- acpi_set_pci_info(!s->legacy_piix);
+ acpi_set_pci_info(s->use_acpi_hotplug_bridge);
acpi_pcihp_update(s);
}
@@ -316,7 +316,7 @@ void acpi_pcihp_device_plug_cb(HotplugHandler *hotplug_dev, AcpiPciHpState *s,
* Overwrite the default hotplug handler with the ACPI PCI one
* for cold plugged bridges only.
*/
- if (!s->legacy_piix &&
+ if (s->use_acpi_hotplug_bridge &&
object_dynamic_cast(OBJECT(dev), TYPE_PCI_BRIDGE)) {
PCIBus *sec = pci_bridge_get_sec_bus(PCI_BRIDGE(pdev));
@@ -398,7 +398,7 @@ static uint64_t pci_read(void *opaque, hwaddr addr, unsigned int size)
switch (addr) {
case PCI_UP_BASE:
val = s->acpi_pcihp_pci_status[bsel].up;
- if (!s->legacy_piix) {
+ if (s->use_acpi_hotplug_bridge) {
s->acpi_pcihp_pci_status[bsel].up = 0;
}
trace_acpi_pci_up_read(val);
@@ -473,7 +473,8 @@ static void pci_write(void *opaque, hwaddr addr, uint64_t data,
trace_acpi_pci_ej_write(addr, data);
break;
case PCI_SEL_BASE:
- s->hotplug_select = s->legacy_piix ? ACPI_PCIHP_BSEL_DEFAULT : data;
+ s->hotplug_select = s->use_acpi_hotplug_bridge ? data :
+ ACPI_PCIHP_BSEL_DEFAULT;
trace_acpi_pci_sel_write(addr, data);
default:
break;
@@ -491,14 +492,13 @@ static const MemoryRegionOps acpi_pcihp_io_ops = {
};
void acpi_pcihp_init(Object *owner, AcpiPciHpState *s, PCIBus *root_bus,
- MemoryRegion *address_space_io, bool bridges_enabled,
+ MemoryRegion *address_space_io,
uint16_t io_base)
{
s->io_len = ACPI_PCIHP_SIZE;
s->io_base = io_base;
s->root = root_bus;
- s->legacy_piix = !bridges_enabled;
memory_region_init_io(&s->io, owner, &acpi_pcihp_io_ops, s,
"acpi-pci-hotplug", s->io_len);
diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c
index 8fc422829a..0a233fa95d 100644
--- a/hw/acpi/piix4.c
+++ b/hw/acpi/piix4.c
@@ -170,14 +170,14 @@ static const VMStateDescription vmstate_pci_status = {
static bool vmstate_test_use_acpi_hotplug_bridge(void *opaque, int version_id)
{
PIIX4PMState *s = opaque;
- return s->use_acpi_hotplug_bridge;
+ return s->acpi_pci_hotplug.use_acpi_hotplug_bridge;
}
static bool vmstate_test_no_use_acpi_hotplug_bridge(void *opaque,
int version_id)
{
PIIX4PMState *s = opaque;
- return !s->use_acpi_hotplug_bridge;
+ return !s->acpi_pci_hotplug.use_acpi_hotplug_bridge;
}
static bool vmstate_test_use_memhp(void *opaque)
@@ -234,7 +234,8 @@ static bool piix4_vmstate_need_smbus(void *opaque, int version_id)
static bool vmstate_test_migrate_acpi_index(void *opaque, int version_id)
{
PIIX4PMState *s = PIIX4_PM(opaque);
- return s->use_acpi_hotplug_bridge && !s->not_migrate_acpi_index;
+ return s->acpi_pci_hotplug.use_acpi_hotplug_bridge &&
+ !s->not_migrate_acpi_index;
}
/* qemu-kvm 1.2 uses version 3 but advertised as 2
@@ -303,8 +304,9 @@ static void piix4_pm_reset(DeviceState *dev)
acpi_update_sci(&s->ar, s->irq);
pm_io_space_update(s);
- if (s->use_acpi_hotplug_bridge || s->use_acpi_root_pci_hotplug) {
- acpi_pcihp_reset(&s->acpi_pci_hotplug, !s->use_acpi_root_pci_hotplug);
+ if (s->acpi_pci_hotplug.use_acpi_hotplug_bridge ||
+ s->acpi_pci_hotplug.use_acpi_root_pci_hotplug) {
+ acpi_pcihp_reset(&s->acpi_pci_hotplug);
}
}
@@ -487,7 +489,7 @@ static void piix4_pm_realize(PCIDevice *dev, Error **errp)
qemu_add_machine_init_done_notifier(&s->machine_ready);
if (xen_enabled()) {
- s->use_acpi_hotplug_bridge = false;
+ s->acpi_pci_hotplug.use_acpi_hotplug_bridge = false;
}
piix4_acpi_system_hot_add_init(pci_address_space_io(dev),
@@ -560,9 +562,10 @@ static void piix4_acpi_system_hot_add_init(MemoryRegion *parent,
"acpi-gpe0", GPE_LEN);
memory_region_add_subregion(parent, GPE_BASE, &s->io_gpe);
- if (s->use_acpi_hotplug_bridge || s->use_acpi_root_pci_hotplug) {
+ if (s->acpi_pci_hotplug.use_acpi_hotplug_bridge ||
+ s->acpi_pci_hotplug.use_acpi_root_pci_hotplug) {
acpi_pcihp_init(OBJECT(s), &s->acpi_pci_hotplug, bus, parent,
- s->use_acpi_hotplug_bridge, ACPI_PCIHP_ADDR_PIIX4);
+ ACPI_PCIHP_ADDR_PIIX4);
qbus_set_hotplug_handler(BUS(pci_get_bus(PCI_DEVICE(s))), OBJECT(s));
}
@@ -602,9 +605,9 @@ static Property piix4_pm_properties[] = {
DEFINE_PROP_UINT8(ACPI_PM_PROP_S4_DISABLED, PIIX4PMState, disable_s4, 0),
DEFINE_PROP_UINT8(ACPI_PM_PROP_S4_VAL, PIIX4PMState, s4_val, 2),
DEFINE_PROP_BOOL(ACPI_PM_PROP_ACPI_PCIHP_BRIDGE, PIIX4PMState,
- use_acpi_hotplug_bridge, true),
+ acpi_pci_hotplug.use_acpi_hotplug_bridge, true),
DEFINE_PROP_BOOL(ACPI_PM_PROP_ACPI_PCI_ROOTHP, PIIX4PMState,
- use_acpi_root_pci_hotplug, true),
+ acpi_pci_hotplug.use_acpi_root_pci_hotplug, true),
DEFINE_PROP_BOOL("memory-hotplug-support", PIIX4PMState,
acpi_memory_hotplug.is_enabled, true),
DEFINE_PROP_BOOL("smm-compat", PIIX4PMState, smm_compat, false),
--
2.39.1
^ permalink raw reply related [flat|nested] 46+ messages in thread* [PATCH 33/33] pcihp: add ACPI PCI hotplug specific is_hotpluggable_bus() callback
2023-02-24 15:37 [PATCH 00/33] pci(pc/q35): acpi-index support on non-hotpluggable slots Igor Mammedov
` (31 preceding siblings ...)
2023-02-24 15:38 ` [PATCH 32/33] pcihp: move fields enabling hotplug into AcpiPciHpState Igor Mammedov
@ 2023-02-24 15:38 ` Igor Mammedov
2023-03-02 10:59 ` [PATCH 00/33] pci(pc/q35): acpi-index support on non-hotpluggable slots Michael S. Tsirkin
33 siblings, 0 replies; 46+ messages in thread
From: Igor Mammedov @ 2023-02-24 15:38 UTC (permalink / raw)
To: qemu-devel; +Cc: mst, ani, berrange
Provide pcihp specific callback to check if bus is hotpluggable
and consolidate its scattered hotplug criteria there.
While at it clean up no longer needed
qbus_set_hotplug_handler(BUS(bus), NULL)
workarounds since callback makes qbus_is_hotpluggable() return
correct answer even if hotplug_handler is set on bus.
PS:
see ("pci: fix 'hotplugglable' property behavior") for details
why callback was introduced.
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
include/hw/acpi/ich9.h | 1 +
include/hw/acpi/pcihp.h | 1 +
hw/acpi/acpi-pci-hotplug-stub.c | 4 ++++
hw/acpi/ich9.c | 6 +++++
hw/acpi/pcihp.c | 42 ++++++++++++++-------------------
hw/acpi/piix4.c | 8 +++++++
hw/isa/lpc_ich9.c | 1 +
7 files changed, 39 insertions(+), 24 deletions(-)
diff --git a/include/hw/acpi/ich9.h b/include/hw/acpi/ich9.h
index d41866a229..d2f980359e 100644
--- a/include/hw/acpi/ich9.h
+++ b/include/hw/acpi/ich9.h
@@ -89,6 +89,7 @@ void ich9_pm_device_unplug_request_cb(HotplugHandler *hotplug_dev,
DeviceState *dev, Error **errp);
void ich9_pm_device_unplug_cb(HotplugHandler *hotplug_dev, DeviceState *dev,
Error **errp);
+bool ich9_pm_is_hotpluggable_bus(HotplugHandler *hotplug_dev, BusState *bus);
void ich9_pm_ospm_status(AcpiDeviceIf *adev, ACPIOSTInfoList ***list);
#endif /* HW_ACPI_ICH9_H */
diff --git a/include/hw/acpi/pcihp.h b/include/hw/acpi/pcihp.h
index 04c98511a4..ef59810c17 100644
--- a/include/hw/acpi/pcihp.h
+++ b/include/hw/acpi/pcihp.h
@@ -58,6 +58,7 @@ typedef struct AcpiPciHpState {
void acpi_pcihp_init(Object *owner, AcpiPciHpState *, PCIBus *root,
MemoryRegion *address_space_io, uint16_t io_base);
+bool acpi_pcihp_is_hotpluggbale_bus(AcpiPciHpState *s, BusState *bus);
void acpi_pcihp_device_pre_plug_cb(HotplugHandler *hotplug_dev,
DeviceState *dev, Error **errp);
void acpi_pcihp_device_plug_cb(HotplugHandler *hotplug_dev, AcpiPciHpState *s,
diff --git a/hw/acpi/acpi-pci-hotplug-stub.c b/hw/acpi/acpi-pci-hotplug-stub.c
index d1794399f7..dcee3ad7a1 100644
--- a/hw/acpi/acpi-pci-hotplug-stub.c
+++ b/hw/acpi/acpi-pci-hotplug-stub.c
@@ -40,3 +40,7 @@ void acpi_pcihp_reset(AcpiPciHpState *s)
return;
}
+bool acpi_pcihp_is_hotpluggbale_bus(AcpiPciHpState *s, BusState *bus)
+{
+ return true;
+}
diff --git a/hw/acpi/ich9.c b/hw/acpi/ich9.c
index 34a58fc07c..e625adbbab 100644
--- a/hw/acpi/ich9.c
+++ b/hw/acpi/ich9.c
@@ -582,6 +582,12 @@ void ich9_pm_device_unplug_cb(HotplugHandler *hotplug_dev, DeviceState *dev,
}
}
+bool ich9_pm_is_hotpluggable_bus(HotplugHandler *hotplug_dev, BusState *bus)
+{
+ ICH9LPCState *lpc = ICH9_LPC_DEVICE(hotplug_dev);
+ return acpi_pcihp_is_hotpluggbale_bus(&lpc->pm.acpi_pci_hotplug, bus);
+}
+
void ich9_pm_ospm_status(AcpiDeviceIf *adev, ACPIOSTInfoList ***list)
{
ICH9LPCState *s = ICH9_LPC_DEVICE(adev);
diff --git a/hw/acpi/pcihp.c b/hw/acpi/pcihp.c
index 34cad061a8..dcfb779a7a 100644
--- a/hw/acpi/pcihp.c
+++ b/hw/acpi/pcihp.c
@@ -121,20 +121,6 @@ static void acpi_set_pci_info(bool has_bridge_hotplug)
}
}
-static void acpi_pcihp_disable_root_bus(void)
-{
- Object *host = acpi_get_i386_pci_host();
- PCIBus *bus;
-
- bus = PCI_HOST_BRIDGE(host)->bus;
- if (bus && qbus_is_hotpluggable(BUS(bus))) {
- /* setting the hotplug handler to NULL makes the bus non-hotpluggable */
- qbus_set_hotplug_handler(BUS(bus), NULL);
- }
-
- return;
-}
-
static void acpi_pcihp_test_hotplug_bus(PCIBus *bus, void *opaque)
{
AcpiPciHpFind *find = opaque;
@@ -278,9 +264,6 @@ static void acpi_pcihp_update(AcpiPciHpState *s)
void acpi_pcihp_reset(AcpiPciHpState *s)
{
- if (!s->use_acpi_root_pci_hotplug) {
- acpi_pcihp_disable_root_bus();
- }
acpi_set_pci_info(s->use_acpi_hotplug_bridge);
acpi_pcihp_update(s);
}
@@ -320,13 +303,6 @@ void acpi_pcihp_device_plug_cb(HotplugHandler *hotplug_dev, AcpiPciHpState *s,
object_dynamic_cast(OBJECT(dev), TYPE_PCI_BRIDGE)) {
PCIBus *sec = pci_bridge_get_sec_bus(PCI_BRIDGE(pdev));
- /* Remove all hot-plug handlers if hot-plug is disabled on slot */
- if (object_dynamic_cast(OBJECT(dev), TYPE_PCIE_SLOT) &&
- !PCIE_SLOT(pdev)->hotplug) {
- qbus_set_hotplug_handler(BUS(sec), NULL);
- return;
- }
-
qbus_set_hotplug_handler(BUS(sec), OBJECT(hotplug_dev));
/* We don't have to overwrite any other hotplug handler yet */
assert(QLIST_EMPTY(&sec->child));
@@ -385,6 +361,24 @@ void acpi_pcihp_device_unplug_request_cb(HotplugHandler *hotplug_dev,
acpi_send_event(DEVICE(hotplug_dev), ACPI_PCI_HOTPLUG_STATUS);
}
+bool acpi_pcihp_is_hotpluggbale_bus(AcpiPciHpState *s, BusState *bus)
+{
+ Object *o = OBJECT(bus->parent);
+
+ if (s->use_acpi_hotplug_bridge &&
+ object_dynamic_cast(o, TYPE_PCI_BRIDGE)) {
+ if (object_dynamic_cast(o, TYPE_PCIE_SLOT) && !PCIE_SLOT(o)->hotplug) {
+ return false;
+ }
+ return true;
+ }
+
+ if (s->use_acpi_root_pci_hotplug) {
+ return true;
+ }
+ return false;
+}
+
static uint64_t pci_read(void *opaque, hwaddr addr, unsigned int size)
{
AcpiPciHpState *s = opaque;
diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c
index 0a233fa95d..63d2113b86 100644
--- a/hw/acpi/piix4.c
+++ b/hw/acpi/piix4.c
@@ -404,6 +404,13 @@ static void piix4_device_unplug_cb(HotplugHandler *hotplug_dev,
}
}
+static bool piix4_is_hotpluggable_bus(HotplugHandler *hotplug_dev,
+ BusState *bus)
+{
+ PIIX4PMState *s = PIIX4_PM(hotplug_dev);
+ return acpi_pcihp_is_hotpluggbale_bus(&s->acpi_pci_hotplug, bus);
+}
+
static void piix4_pm_machine_ready(Notifier *n, void *opaque)
{
PIIX4PMState *s = container_of(n, PIIX4PMState, machine_ready);
@@ -644,6 +651,7 @@ static void piix4_pm_class_init(ObjectClass *klass, void *data)
hc->plug = piix4_device_plug_cb;
hc->unplug_request = piix4_device_unplug_request_cb;
hc->unplug = piix4_device_unplug_cb;
+ hc->is_hotpluggable_bus = piix4_is_hotpluggable_bus;
adevc->ospm_status = piix4_ospm_status;
adevc->send_event = piix4_send_gpe;
adevc->madt_cpu = pc_madt_cpu_entry;
diff --git a/hw/isa/lpc_ich9.c b/hw/isa/lpc_ich9.c
index 1fba3c210c..0e09e6b02c 100644
--- a/hw/isa/lpc_ich9.c
+++ b/hw/isa/lpc_ich9.c
@@ -865,6 +865,7 @@ static void ich9_lpc_class_init(ObjectClass *klass, void *data)
hc->plug = ich9_pm_device_plug_cb;
hc->unplug_request = ich9_pm_device_unplug_request_cb;
hc->unplug = ich9_pm_device_unplug_cb;
+ hc->is_hotpluggable_bus = ich9_pm_is_hotpluggable_bus;
adevc->ospm_status = ich9_pm_ospm_status;
adevc->send_event = ich9_send_gpe;
adevc->madt_cpu = pc_madt_cpu_entry;
--
2.39.1
^ permalink raw reply related [flat|nested] 46+ messages in thread* Re: [PATCH 00/33] pci(pc/q35): acpi-index support on non-hotpluggable slots
2023-02-24 15:37 [PATCH 00/33] pci(pc/q35): acpi-index support on non-hotpluggable slots Igor Mammedov
` (32 preceding siblings ...)
2023-02-24 15:38 ` [PATCH 33/33] pcihp: add ACPI PCI hotplug specific is_hotpluggable_bus() callback Igor Mammedov
@ 2023-03-02 10:59 ` Michael S. Tsirkin
2023-03-02 12:05 ` Jonathan Cameron via
2023-03-02 12:07 ` Igor Mammedov
33 siblings, 2 replies; 46+ messages in thread
From: Michael S. Tsirkin @ 2023-03-02 10:59 UTC (permalink / raw)
To: Igor Mammedov; +Cc: qemu-devel, ani, berrange
On Fri, Feb 24, 2023 at 04:37:39PM +0100, Igor Mammedov wrote:
> Series extends acpi-index support to host-bridge(s) and bridges
> with disabled hotplug (either explicitly or implicitly).
> Whats new (it is still limited to 'pc' and 'q35' machines),
> acpi-index now works for non-hotpluggable slots/nics:
> * q35: host-bridge
> * pc: host-bridge with disabled hotplug
> 'PIIX4_PM.acpi-root-pci-hotplug=off'
> * non-hotpluggable multifunction nics
> * on non-hotpluggable slots with native hotplug (i.e. without ACPI PCI hotplug)
> PIIX4_PM.acpi-pci-hotplug-with-bridge-support=off
> ICH9-LPC.acpi-pci-hotplug-with-bridge-support=off
> + pcie-root-port,hotplug=off | pci-bridge,shpc=off
>
> where it doesn't work (and never will):
> * on hotplugged ports/bridges
> * on hotpluggable ports/bridges with native hotplug
>
> 1-11/33: fixes for bugs or odd behavior
> 13-23/33: non-hotplug/multifunction acpi-index enabling
> 28-33/33: cleanups
> all of that is peppered by extra acpi tests or extensions to existing ones
dropped because viot was wrong.
Pls rebase fix up and repost.
Apropos I still think we should split up DSDT to several
SSDTs, in a way that multiple tests share some SSDTs.
This way it will be more common than a change only affects one table
and it's easier to merge things.
For example, how about moving CXL things to an SSDT?
> Somewhat tested with RHEL9.0 and WS2022.
>
> What's in queue:
> * PXB support
> * microvm and arm/virt support
> all of above only for non-hotpluggable slots as I don't really want to
> pull there complicated APCI PCI hotplug.
>
> gitlab tree: https://gitlab.com/imammedo/qemu/-/tree/acpi_index_non_hotplug
> CI: https://gitlab.com/imammedo/qemu/-/pipelines/787263630
> it's red but only due to unrelated curl breakage in msys* targets,
> the rest is green
>
> Igor Mammedov (33):
> tests: acpi: whitelist new q35.noacpihp test and pc.hpbrroot
> tests: acpi: add test_acpi_q35_tcg_no_acpi_hotplug test and extend
> test_acpi_piix4_no_acpi_pci_hotplug
> tests: acpi: update expected blobs
> tests: acpi: whitelist q35/DSDT.multi-bridge before extending testcase
> tests: acpi: extend multi-bridge case with case
> 'root-port,id=HOHP,hotplug=off root-port,bus=NOHP'
> x86: pcihp: fix missing PCNT callchain when intermediate root-port has
> 'hotplug=off' set
> tests: acpi: whitelist pc/DSDT.hpbrroot and pc/DSDT.hpbridge tests
> x86: pcihp: fix missing bridge AML when intermediate root-port has
> 'hotplug=off' set
> tests: acpi: update expected blobs
> pcihp: piix4: do not redirect hotplug controller to piix4 when ACPI
> hotplug is disabled
> pci: fix 'hotplugglable' property behavior
> tests: acpi: whitelist DSDT blobs before isolating PCI _DSM func 0
> prolog
> pcihp: move PCI _DSM function 0 prolog into separate function
> tests: acpi: update expected blobs
> tests: acpi: whitelist DSDT before adding EDSM method
> acpi: pci: add EDSM method to DSDT
> tests: acpi: update expected blobs
> tests: acpi: whitelist DSDT before adding device with acpi-index to
> testcases
> tests: acpi: add device with acpi-index on non-hotpluggble bus
> acpi: pci: support acpi-index for non-hotpluggable devices
> tests: acpi: update expected blobs
> tests: acpi: whitelist DSDT before exposing non zero functions
> acpi: pci: describe all functions on populated slots
> tests: acpi: update expected blobs
> tests: acpi: whitelist DSDT before adding non-0 function device with
> acpi-index to testcases
> tests: acpi: add non zero function device with acpi-index on
> non-hotpluggble bus
> tests: acpi: update expected blobs
> pci: move acpi-index uniqueness check to generic PCI device code
> acpi: pci: drop BSEL usage when deciding that device isn't
> hotpluggable
> acpi: pci: move BSEL into build_append_pcihp_slots()
> acpi: pci: move out ACPI PCI hotplug generator from generic slot
> generator build_append_pci_bus_devices()
> pcihp: move fields enabling hotplug into AcpiPciHpState
> pcihp: add ACPI PCI hotplug specific is_hotpluggable_bus() callback
>
> include/hw/acpi/ich9.h | 1 +
> include/hw/acpi/pcihp.h | 11 +-
> include/hw/acpi/piix4.h | 2 -
> include/hw/hotplug.h | 2 +
> include/hw/qdev-core.h | 13 +-
> hw/acpi/acpi-pci-hotplug-stub.c | 9 +-
> hw/acpi/ich9.c | 21 +-
> hw/acpi/pci-bridge.c | 14 +-
> hw/acpi/pcihp.c | 112 +++--------
> hw/acpi/piix4.c | 33 ++--
> hw/i386/acpi-build.c | 179 +++++++++++++-----
> hw/isa/lpc_ich9.c | 1 +
> hw/pci/pci.c | 57 ++++++
> hw/pci/pcie_port.c | 8 +
> tests/data/acpi/pc/DSDT | Bin 6360 -> 6488 bytes
> tests/data/acpi/pc/DSDT.acpierst | Bin 6283 -> 6411 bytes
> tests/data/acpi/pc/DSDT.acpihmat | Bin 7685 -> 7813 bytes
> tests/data/acpi/pc/DSDT.bridge | Bin 12487 -> 12615 bytes
> tests/data/acpi/pc/DSDT.cphp | Bin 6824 -> 6952 bytes
> tests/data/acpi/pc/DSDT.dimmpxm | Bin 8014 -> 8142 bytes
> tests/data/acpi/pc/DSDT.hpbridge | Bin 6289 -> 6451 bytes
> tests/data/acpi/pc/DSDT.hpbrroot | Bin 3081 -> 3343 bytes
> tests/data/acpi/pc/DSDT.ipmikcs | Bin 6432 -> 6560 bytes
> tests/data/acpi/pc/DSDT.memhp | Bin 7719 -> 7847 bytes
> tests/data/acpi/pc/DSDT.nohpet | Bin 6218 -> 6346 bytes
> tests/data/acpi/pc/DSDT.numamem | Bin 6366 -> 6494 bytes
> tests/data/acpi/pc/DSDT.roothp | Bin 9745 -> 9873 bytes
> tests/data/acpi/q35/DSDT | Bin 8252 -> 8361 bytes
> tests/data/acpi/q35/DSDT.acpierst | Bin 8269 -> 8378 bytes
> tests/data/acpi/q35/DSDT.acpihmat | Bin 9577 -> 9686 bytes
> tests/data/acpi/q35/DSDT.acpihmat-noinitiator | Bin 8531 -> 8640 bytes
> tests/data/acpi/q35/DSDT.applesmc | Bin 8298 -> 8407 bytes
> tests/data/acpi/q35/DSDT.bridge | Bin 11481 -> 11590 bytes
> tests/data/acpi/q35/DSDT.core-count2 | Bin 32392 -> 32501 bytes
> tests/data/acpi/q35/DSDT.cphp | Bin 8716 -> 8825 bytes
> tests/data/acpi/q35/DSDT.cxl | Bin 9578 -> 9687 bytes
> tests/data/acpi/q35/DSDT.dimmpxm | Bin 9906 -> 10015 bytes
> tests/data/acpi/q35/DSDT.ipmibt | Bin 8327 -> 8436 bytes
> tests/data/acpi/q35/DSDT.ipmismbus | Bin 8340 -> 8449 bytes
> tests/data/acpi/q35/DSDT.ivrs | Bin 8269 -> 8378 bytes
> tests/data/acpi/q35/DSDT.memhp | Bin 9611 -> 9720 bytes
> tests/data/acpi/q35/DSDT.mmio64 | Bin 9382 -> 9491 bytes
> tests/data/acpi/q35/DSDT.multi-bridge | Bin 12337 -> 12770 bytes
> tests/data/acpi/q35/DSDT.noacpihp | Bin 0 -> 8248 bytes
> tests/data/acpi/q35/DSDT.nohpet | Bin 8110 -> 8219 bytes
> tests/data/acpi/q35/DSDT.numamem | Bin 8258 -> 8367 bytes
> tests/data/acpi/q35/DSDT.pvpanic-isa | Bin 8353 -> 8462 bytes
> tests/data/acpi/q35/DSDT.tis.tpm12 | Bin 8858 -> 8967 bytes
> tests/data/acpi/q35/DSDT.tis.tpm2 | Bin 8884 -> 8993 bytes
> tests/data/acpi/q35/DSDT.viot | Bin 9361 -> 9486 bytes
> tests/data/acpi/q35/DSDT.xapic | Bin 35615 -> 35724 bytes
> tests/qtest/bios-tables-test.c | 50 ++++-
> 52 files changed, 341 insertions(+), 172 deletions(-)
> create mode 100644 tests/data/acpi/q35/DSDT.noacpihp
>
> --
> 2.39.1
^ permalink raw reply [flat|nested] 46+ messages in thread* Re: [PATCH 00/33] pci(pc/q35): acpi-index support on non-hotpluggable slots
2023-03-02 10:59 ` [PATCH 00/33] pci(pc/q35): acpi-index support on non-hotpluggable slots Michael S. Tsirkin
@ 2023-03-02 12:05 ` Jonathan Cameron via
2023-03-02 12:07 ` Igor Mammedov
1 sibling, 0 replies; 46+ messages in thread
From: Jonathan Cameron via @ 2023-03-02 12:05 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: Igor Mammedov, qemu-devel, ani, berrange
On Thu, 2 Mar 2023 05:59:16 -0500
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> On Fri, Feb 24, 2023 at 04:37:39PM +0100, Igor Mammedov wrote:
> > Series extends acpi-index support to host-bridge(s) and bridges
> > with disabled hotplug (either explicitly or implicitly).
> > Whats new (it is still limited to 'pc' and 'q35' machines),
> > acpi-index now works for non-hotpluggable slots/nics:
> > * q35: host-bridge
> > * pc: host-bridge with disabled hotplug
> > 'PIIX4_PM.acpi-root-pci-hotplug=off'
> > * non-hotpluggable multifunction nics
> > * on non-hotpluggable slots with native hotplug (i.e. without ACPI PCI hotplug)
> > PIIX4_PM.acpi-pci-hotplug-with-bridge-support=off
> > ICH9-LPC.acpi-pci-hotplug-with-bridge-support=off
> > + pcie-root-port,hotplug=off | pci-bridge,shpc=off
> >
> > where it doesn't work (and never will):
> > * on hotplugged ports/bridges
> > * on hotpluggable ports/bridges with native hotplug
> >
> > 1-11/33: fixes for bugs or odd behavior
> > 13-23/33: non-hotplug/multifunction acpi-index enabling
> > 28-33/33: cleanups
> > all of that is peppered by extra acpi tests or extensions to existing ones
>
> dropped because viot was wrong.
> Pls rebase fix up and repost.
>
>
> Apropos I still think we should split up DSDT to several
> SSDTs, in a way that multiple tests share some SSDTs.
> This way it will be more common than a change only affects one table
> and it's easier to merge things.
>
> For example, how about moving CXL things to an SSDT?
I'll take a look at that, though given CXL doesn't have that much in DSDT that
is different from pxb-pcie (it is set to grow a bit, but just by one _DSM)
and the code is currently mixed up, it may make more sense to pull out both CXL
and PXB into a single SSDT.
I'm definitely keen on less churn in these files given it's not the
easiest thing to sort out if you care carrying a lot of patches out of
tree as we currently are for CXL.
Jonathan
>
>
> > Somewhat tested with RHEL9.0 and WS2022.
> >
> > What's in queue:
> > * PXB support
> > * microvm and arm/virt support
> > all of above only for non-hotpluggable slots as I don't really want to
> > pull there complicated APCI PCI hotplug.
> >
> > gitlab tree: https://gitlab.com/imammedo/qemu/-/tree/acpi_index_non_hotplug
> > CI: https://gitlab.com/imammedo/qemu/-/pipelines/787263630
> > it's red but only due to unrelated curl breakage in msys* targets,
> > the rest is green
> >
> > Igor Mammedov (33):
> > tests: acpi: whitelist new q35.noacpihp test and pc.hpbrroot
> > tests: acpi: add test_acpi_q35_tcg_no_acpi_hotplug test and extend
> > test_acpi_piix4_no_acpi_pci_hotplug
> > tests: acpi: update expected blobs
> > tests: acpi: whitelist q35/DSDT.multi-bridge before extending testcase
> > tests: acpi: extend multi-bridge case with case
> > 'root-port,id=HOHP,hotplug=off root-port,bus=NOHP'
> > x86: pcihp: fix missing PCNT callchain when intermediate root-port has
> > 'hotplug=off' set
> > tests: acpi: whitelist pc/DSDT.hpbrroot and pc/DSDT.hpbridge tests
> > x86: pcihp: fix missing bridge AML when intermediate root-port has
> > 'hotplug=off' set
> > tests: acpi: update expected blobs
> > pcihp: piix4: do not redirect hotplug controller to piix4 when ACPI
> > hotplug is disabled
> > pci: fix 'hotplugglable' property behavior
> > tests: acpi: whitelist DSDT blobs before isolating PCI _DSM func 0
> > prolog
> > pcihp: move PCI _DSM function 0 prolog into separate function
> > tests: acpi: update expected blobs
> > tests: acpi: whitelist DSDT before adding EDSM method
> > acpi: pci: add EDSM method to DSDT
> > tests: acpi: update expected blobs
> > tests: acpi: whitelist DSDT before adding device with acpi-index to
> > testcases
> > tests: acpi: add device with acpi-index on non-hotpluggble bus
> > acpi: pci: support acpi-index for non-hotpluggable devices
> > tests: acpi: update expected blobs
> > tests: acpi: whitelist DSDT before exposing non zero functions
> > acpi: pci: describe all functions on populated slots
> > tests: acpi: update expected blobs
> > tests: acpi: whitelist DSDT before adding non-0 function device with
> > acpi-index to testcases
> > tests: acpi: add non zero function device with acpi-index on
> > non-hotpluggble bus
> > tests: acpi: update expected blobs
> > pci: move acpi-index uniqueness check to generic PCI device code
> > acpi: pci: drop BSEL usage when deciding that device isn't
> > hotpluggable
> > acpi: pci: move BSEL into build_append_pcihp_slots()
> > acpi: pci: move out ACPI PCI hotplug generator from generic slot
> > generator build_append_pci_bus_devices()
> > pcihp: move fields enabling hotplug into AcpiPciHpState
> > pcihp: add ACPI PCI hotplug specific is_hotpluggable_bus() callback
> >
> > include/hw/acpi/ich9.h | 1 +
> > include/hw/acpi/pcihp.h | 11 +-
> > include/hw/acpi/piix4.h | 2 -
> > include/hw/hotplug.h | 2 +
> > include/hw/qdev-core.h | 13 +-
> > hw/acpi/acpi-pci-hotplug-stub.c | 9 +-
> > hw/acpi/ich9.c | 21 +-
> > hw/acpi/pci-bridge.c | 14 +-
> > hw/acpi/pcihp.c | 112 +++--------
> > hw/acpi/piix4.c | 33 ++--
> > hw/i386/acpi-build.c | 179 +++++++++++++-----
> > hw/isa/lpc_ich9.c | 1 +
> > hw/pci/pci.c | 57 ++++++
> > hw/pci/pcie_port.c | 8 +
> > tests/data/acpi/pc/DSDT | Bin 6360 -> 6488 bytes
> > tests/data/acpi/pc/DSDT.acpierst | Bin 6283 -> 6411 bytes
> > tests/data/acpi/pc/DSDT.acpihmat | Bin 7685 -> 7813 bytes
> > tests/data/acpi/pc/DSDT.bridge | Bin 12487 -> 12615 bytes
> > tests/data/acpi/pc/DSDT.cphp | Bin 6824 -> 6952 bytes
> > tests/data/acpi/pc/DSDT.dimmpxm | Bin 8014 -> 8142 bytes
> > tests/data/acpi/pc/DSDT.hpbridge | Bin 6289 -> 6451 bytes
> > tests/data/acpi/pc/DSDT.hpbrroot | Bin 3081 -> 3343 bytes
> > tests/data/acpi/pc/DSDT.ipmikcs | Bin 6432 -> 6560 bytes
> > tests/data/acpi/pc/DSDT.memhp | Bin 7719 -> 7847 bytes
> > tests/data/acpi/pc/DSDT.nohpet | Bin 6218 -> 6346 bytes
> > tests/data/acpi/pc/DSDT.numamem | Bin 6366 -> 6494 bytes
> > tests/data/acpi/pc/DSDT.roothp | Bin 9745 -> 9873 bytes
> > tests/data/acpi/q35/DSDT | Bin 8252 -> 8361 bytes
> > tests/data/acpi/q35/DSDT.acpierst | Bin 8269 -> 8378 bytes
> > tests/data/acpi/q35/DSDT.acpihmat | Bin 9577 -> 9686 bytes
> > tests/data/acpi/q35/DSDT.acpihmat-noinitiator | Bin 8531 -> 8640 bytes
> > tests/data/acpi/q35/DSDT.applesmc | Bin 8298 -> 8407 bytes
> > tests/data/acpi/q35/DSDT.bridge | Bin 11481 -> 11590 bytes
> > tests/data/acpi/q35/DSDT.core-count2 | Bin 32392 -> 32501 bytes
> > tests/data/acpi/q35/DSDT.cphp | Bin 8716 -> 8825 bytes
> > tests/data/acpi/q35/DSDT.cxl | Bin 9578 -> 9687 bytes
> > tests/data/acpi/q35/DSDT.dimmpxm | Bin 9906 -> 10015 bytes
> > tests/data/acpi/q35/DSDT.ipmibt | Bin 8327 -> 8436 bytes
> > tests/data/acpi/q35/DSDT.ipmismbus | Bin 8340 -> 8449 bytes
> > tests/data/acpi/q35/DSDT.ivrs | Bin 8269 -> 8378 bytes
> > tests/data/acpi/q35/DSDT.memhp | Bin 9611 -> 9720 bytes
> > tests/data/acpi/q35/DSDT.mmio64 | Bin 9382 -> 9491 bytes
> > tests/data/acpi/q35/DSDT.multi-bridge | Bin 12337 -> 12770 bytes
> > tests/data/acpi/q35/DSDT.noacpihp | Bin 0 -> 8248 bytes
> > tests/data/acpi/q35/DSDT.nohpet | Bin 8110 -> 8219 bytes
> > tests/data/acpi/q35/DSDT.numamem | Bin 8258 -> 8367 bytes
> > tests/data/acpi/q35/DSDT.pvpanic-isa | Bin 8353 -> 8462 bytes
> > tests/data/acpi/q35/DSDT.tis.tpm12 | Bin 8858 -> 8967 bytes
> > tests/data/acpi/q35/DSDT.tis.tpm2 | Bin 8884 -> 8993 bytes
> > tests/data/acpi/q35/DSDT.viot | Bin 9361 -> 9486 bytes
> > tests/data/acpi/q35/DSDT.xapic | Bin 35615 -> 35724 bytes
> > tests/qtest/bios-tables-test.c | 50 ++++-
> > 52 files changed, 341 insertions(+), 172 deletions(-)
> > create mode 100644 tests/data/acpi/q35/DSDT.noacpihp
> >
> > --
> > 2.39.1
>
>
^ permalink raw reply [flat|nested] 46+ messages in thread
* Re: [PATCH 00/33] pci(pc/q35): acpi-index support on non-hotpluggable slots
2023-03-02 10:59 ` [PATCH 00/33] pci(pc/q35): acpi-index support on non-hotpluggable slots Michael S. Tsirkin
2023-03-02 12:05 ` Jonathan Cameron via
@ 2023-03-02 12:07 ` Igor Mammedov
2023-03-02 23:21 ` Michael S. Tsirkin
1 sibling, 1 reply; 46+ messages in thread
From: Igor Mammedov @ 2023-03-02 12:07 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: qemu-devel, ani, berrange
On Thu, 2 Mar 2023 05:59:16 -0500
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> On Fri, Feb 24, 2023 at 04:37:39PM +0100, Igor Mammedov wrote:
> > Series extends acpi-index support to host-bridge(s) and bridges
> > with disabled hotplug (either explicitly or implicitly).
> > Whats new (it is still limited to 'pc' and 'q35' machines),
> > acpi-index now works for non-hotpluggable slots/nics:
> > * q35: host-bridge
> > * pc: host-bridge with disabled hotplug
> > 'PIIX4_PM.acpi-root-pci-hotplug=off'
> > * non-hotpluggable multifunction nics
> > * on non-hotpluggable slots with native hotplug (i.e. without ACPI PCI hotplug)
> > PIIX4_PM.acpi-pci-hotplug-with-bridge-support=off
> > ICH9-LPC.acpi-pci-hotplug-with-bridge-support=off
> > + pcie-root-port,hotplug=off | pci-bridge,shpc=off
> >
> > where it doesn't work (and never will):
> > * on hotplugged ports/bridges
> > * on hotpluggable ports/bridges with native hotplug
> >
> > 1-11/33: fixes for bugs or odd behavior
> > 13-23/33: non-hotplug/multifunction acpi-index enabling
> > 28-33/33: cleanups
> > all of that is peppered by extra acpi tests or extensions to existing ones
>
> dropped because viot was wrong.
> Pls rebase fix up and repost.
I'll rebase on top of your recent pull req with c471eb4f4044 commit reverted
to get properly updated tables.
Partial table rebuilds are fragile anyways, should we make rebuild ignore
checks the commit introduced?
PS:
Does the rest of the series look fine to you?
>
>
> Apropos I still think we should split up DSDT to several
> SSDTs, in a way that multiple tests share some SSDTs.
> This way it will be more common than a change only affects one table
> and it's easier to merge things.
>
> For example, how about moving CXL things to an SSDT?
>
>
> > Somewhat tested with RHEL9.0 and WS2022.
> >
> > What's in queue:
> > * PXB support
> > * microvm and arm/virt support
> > all of above only for non-hotpluggable slots as I don't really want to
> > pull there complicated APCI PCI hotplug.
> >
> > gitlab tree: https://gitlab.com/imammedo/qemu/-/tree/acpi_index_non_hotplug
> > CI: https://gitlab.com/imammedo/qemu/-/pipelines/787263630
> > it's red but only due to unrelated curl breakage in msys* targets,
> > the rest is green
> >
> > Igor Mammedov (33):
> > tests: acpi: whitelist new q35.noacpihp test and pc.hpbrroot
> > tests: acpi: add test_acpi_q35_tcg_no_acpi_hotplug test and extend
> > test_acpi_piix4_no_acpi_pci_hotplug
> > tests: acpi: update expected blobs
> > tests: acpi: whitelist q35/DSDT.multi-bridge before extending testcase
> > tests: acpi: extend multi-bridge case with case
> > 'root-port,id=HOHP,hotplug=off root-port,bus=NOHP'
> > x86: pcihp: fix missing PCNT callchain when intermediate root-port has
> > 'hotplug=off' set
> > tests: acpi: whitelist pc/DSDT.hpbrroot and pc/DSDT.hpbridge tests
> > x86: pcihp: fix missing bridge AML when intermediate root-port has
> > 'hotplug=off' set
> > tests: acpi: update expected blobs
> > pcihp: piix4: do not redirect hotplug controller to piix4 when ACPI
> > hotplug is disabled
> > pci: fix 'hotplugglable' property behavior
> > tests: acpi: whitelist DSDT blobs before isolating PCI _DSM func 0
> > prolog
> > pcihp: move PCI _DSM function 0 prolog into separate function
> > tests: acpi: update expected blobs
> > tests: acpi: whitelist DSDT before adding EDSM method
> > acpi: pci: add EDSM method to DSDT
> > tests: acpi: update expected blobs
> > tests: acpi: whitelist DSDT before adding device with acpi-index to
> > testcases
> > tests: acpi: add device with acpi-index on non-hotpluggble bus
> > acpi: pci: support acpi-index for non-hotpluggable devices
> > tests: acpi: update expected blobs
> > tests: acpi: whitelist DSDT before exposing non zero functions
> > acpi: pci: describe all functions on populated slots
> > tests: acpi: update expected blobs
> > tests: acpi: whitelist DSDT before adding non-0 function device with
> > acpi-index to testcases
> > tests: acpi: add non zero function device with acpi-index on
> > non-hotpluggble bus
> > tests: acpi: update expected blobs
> > pci: move acpi-index uniqueness check to generic PCI device code
> > acpi: pci: drop BSEL usage when deciding that device isn't
> > hotpluggable
> > acpi: pci: move BSEL into build_append_pcihp_slots()
> > acpi: pci: move out ACPI PCI hotplug generator from generic slot
> > generator build_append_pci_bus_devices()
> > pcihp: move fields enabling hotplug into AcpiPciHpState
> > pcihp: add ACPI PCI hotplug specific is_hotpluggable_bus() callback
> >
> > include/hw/acpi/ich9.h | 1 +
> > include/hw/acpi/pcihp.h | 11 +-
> > include/hw/acpi/piix4.h | 2 -
> > include/hw/hotplug.h | 2 +
> > include/hw/qdev-core.h | 13 +-
> > hw/acpi/acpi-pci-hotplug-stub.c | 9 +-
> > hw/acpi/ich9.c | 21 +-
> > hw/acpi/pci-bridge.c | 14 +-
> > hw/acpi/pcihp.c | 112 +++--------
> > hw/acpi/piix4.c | 33 ++--
> > hw/i386/acpi-build.c | 179 +++++++++++++-----
> > hw/isa/lpc_ich9.c | 1 +
> > hw/pci/pci.c | 57 ++++++
> > hw/pci/pcie_port.c | 8 +
> > tests/data/acpi/pc/DSDT | Bin 6360 -> 6488 bytes
> > tests/data/acpi/pc/DSDT.acpierst | Bin 6283 -> 6411 bytes
> > tests/data/acpi/pc/DSDT.acpihmat | Bin 7685 -> 7813 bytes
> > tests/data/acpi/pc/DSDT.bridge | Bin 12487 -> 12615 bytes
> > tests/data/acpi/pc/DSDT.cphp | Bin 6824 -> 6952 bytes
> > tests/data/acpi/pc/DSDT.dimmpxm | Bin 8014 -> 8142 bytes
> > tests/data/acpi/pc/DSDT.hpbridge | Bin 6289 -> 6451 bytes
> > tests/data/acpi/pc/DSDT.hpbrroot | Bin 3081 -> 3343 bytes
> > tests/data/acpi/pc/DSDT.ipmikcs | Bin 6432 -> 6560 bytes
> > tests/data/acpi/pc/DSDT.memhp | Bin 7719 -> 7847 bytes
> > tests/data/acpi/pc/DSDT.nohpet | Bin 6218 -> 6346 bytes
> > tests/data/acpi/pc/DSDT.numamem | Bin 6366 -> 6494 bytes
> > tests/data/acpi/pc/DSDT.roothp | Bin 9745 -> 9873 bytes
> > tests/data/acpi/q35/DSDT | Bin 8252 -> 8361 bytes
> > tests/data/acpi/q35/DSDT.acpierst | Bin 8269 -> 8378 bytes
> > tests/data/acpi/q35/DSDT.acpihmat | Bin 9577 -> 9686 bytes
> > tests/data/acpi/q35/DSDT.acpihmat-noinitiator | Bin 8531 -> 8640 bytes
> > tests/data/acpi/q35/DSDT.applesmc | Bin 8298 -> 8407 bytes
> > tests/data/acpi/q35/DSDT.bridge | Bin 11481 -> 11590 bytes
> > tests/data/acpi/q35/DSDT.core-count2 | Bin 32392 -> 32501 bytes
> > tests/data/acpi/q35/DSDT.cphp | Bin 8716 -> 8825 bytes
> > tests/data/acpi/q35/DSDT.cxl | Bin 9578 -> 9687 bytes
> > tests/data/acpi/q35/DSDT.dimmpxm | Bin 9906 -> 10015 bytes
> > tests/data/acpi/q35/DSDT.ipmibt | Bin 8327 -> 8436 bytes
> > tests/data/acpi/q35/DSDT.ipmismbus | Bin 8340 -> 8449 bytes
> > tests/data/acpi/q35/DSDT.ivrs | Bin 8269 -> 8378 bytes
> > tests/data/acpi/q35/DSDT.memhp | Bin 9611 -> 9720 bytes
> > tests/data/acpi/q35/DSDT.mmio64 | Bin 9382 -> 9491 bytes
> > tests/data/acpi/q35/DSDT.multi-bridge | Bin 12337 -> 12770 bytes
> > tests/data/acpi/q35/DSDT.noacpihp | Bin 0 -> 8248 bytes
> > tests/data/acpi/q35/DSDT.nohpet | Bin 8110 -> 8219 bytes
> > tests/data/acpi/q35/DSDT.numamem | Bin 8258 -> 8367 bytes
> > tests/data/acpi/q35/DSDT.pvpanic-isa | Bin 8353 -> 8462 bytes
> > tests/data/acpi/q35/DSDT.tis.tpm12 | Bin 8858 -> 8967 bytes
> > tests/data/acpi/q35/DSDT.tis.tpm2 | Bin 8884 -> 8993 bytes
> > tests/data/acpi/q35/DSDT.viot | Bin 9361 -> 9486 bytes
> > tests/data/acpi/q35/DSDT.xapic | Bin 35615 -> 35724 bytes
> > tests/qtest/bios-tables-test.c | 50 ++++-
> > 52 files changed, 341 insertions(+), 172 deletions(-)
> > create mode 100644 tests/data/acpi/q35/DSDT.noacpihp
> >
> > --
> > 2.39.1
>
^ permalink raw reply [flat|nested] 46+ messages in thread
* Re: [PATCH 00/33] pci(pc/q35): acpi-index support on non-hotpluggable slots
2023-03-02 12:07 ` Igor Mammedov
@ 2023-03-02 23:21 ` Michael S. Tsirkin
2023-03-06 10:49 ` Igor Mammedov
0 siblings, 1 reply; 46+ messages in thread
From: Michael S. Tsirkin @ 2023-03-02 23:21 UTC (permalink / raw)
To: Igor Mammedov; +Cc: qemu-devel, ani, berrange
On Thu, Mar 02, 2023 at 01:07:16PM +0100, Igor Mammedov wrote:
> On Thu, 2 Mar 2023 05:59:16 -0500
> "Michael S. Tsirkin" <mst@redhat.com> wrote:
>
> > On Fri, Feb 24, 2023 at 04:37:39PM +0100, Igor Mammedov wrote:
> > > Series extends acpi-index support to host-bridge(s) and bridges
> > > with disabled hotplug (either explicitly or implicitly).
> > > Whats new (it is still limited to 'pc' and 'q35' machines),
> > > acpi-index now works for non-hotpluggable slots/nics:
> > > * q35: host-bridge
> > > * pc: host-bridge with disabled hotplug
> > > 'PIIX4_PM.acpi-root-pci-hotplug=off'
> > > * non-hotpluggable multifunction nics
> > > * on non-hotpluggable slots with native hotplug (i.e. without ACPI PCI hotplug)
> > > PIIX4_PM.acpi-pci-hotplug-with-bridge-support=off
> > > ICH9-LPC.acpi-pci-hotplug-with-bridge-support=off
> > > + pcie-root-port,hotplug=off | pci-bridge,shpc=off
> > >
> > > where it doesn't work (and never will):
> > > * on hotplugged ports/bridges
> > > * on hotpluggable ports/bridges with native hotplug
> > >
> > > 1-11/33: fixes for bugs or odd behavior
> > > 13-23/33: non-hotplug/multifunction acpi-index enabling
> > > 28-33/33: cleanups
> > > all of that is peppered by extra acpi tests or extensions to existing ones
> >
> > dropped because viot was wrong.
> > Pls rebase fix up and repost.
>
> I'll rebase on top of your recent pull req with c471eb4f4044 commit reverted
> to get properly updated tables.
> Partial table rebuilds are fragile anyways, should we make rebuild ignore
> checks the commit introduced?
Not sure how you mean.
> PS:
> Does the rest of the series look fine to you?
It does, was going to merge.
>
> >
> >
> > Apropos I still think we should split up DSDT to several
> > SSDTs, in a way that multiple tests share some SSDTs.
> > This way it will be more common than a change only affects one table
> > and it's easier to merge things.
> >
> > For example, how about moving CXL things to an SSDT?
> >
> >
> > > Somewhat tested with RHEL9.0 and WS2022.
> > >
> > > What's in queue:
> > > * PXB support
> > > * microvm and arm/virt support
> > > all of above only for non-hotpluggable slots as I don't really want to
> > > pull there complicated APCI PCI hotplug.
> > >
> > > gitlab tree: https://gitlab.com/imammedo/qemu/-/tree/acpi_index_non_hotplug
> > > CI: https://gitlab.com/imammedo/qemu/-/pipelines/787263630
> > > it's red but only due to unrelated curl breakage in msys* targets,
> > > the rest is green
> > >
> > > Igor Mammedov (33):
> > > tests: acpi: whitelist new q35.noacpihp test and pc.hpbrroot
> > > tests: acpi: add test_acpi_q35_tcg_no_acpi_hotplug test and extend
> > > test_acpi_piix4_no_acpi_pci_hotplug
> > > tests: acpi: update expected blobs
> > > tests: acpi: whitelist q35/DSDT.multi-bridge before extending testcase
> > > tests: acpi: extend multi-bridge case with case
> > > 'root-port,id=HOHP,hotplug=off root-port,bus=NOHP'
> > > x86: pcihp: fix missing PCNT callchain when intermediate root-port has
> > > 'hotplug=off' set
> > > tests: acpi: whitelist pc/DSDT.hpbrroot and pc/DSDT.hpbridge tests
> > > x86: pcihp: fix missing bridge AML when intermediate root-port has
> > > 'hotplug=off' set
> > > tests: acpi: update expected blobs
> > > pcihp: piix4: do not redirect hotplug controller to piix4 when ACPI
> > > hotplug is disabled
> > > pci: fix 'hotplugglable' property behavior
> > > tests: acpi: whitelist DSDT blobs before isolating PCI _DSM func 0
> > > prolog
> > > pcihp: move PCI _DSM function 0 prolog into separate function
> > > tests: acpi: update expected blobs
> > > tests: acpi: whitelist DSDT before adding EDSM method
> > > acpi: pci: add EDSM method to DSDT
> > > tests: acpi: update expected blobs
> > > tests: acpi: whitelist DSDT before adding device with acpi-index to
> > > testcases
> > > tests: acpi: add device with acpi-index on non-hotpluggble bus
> > > acpi: pci: support acpi-index for non-hotpluggable devices
> > > tests: acpi: update expected blobs
> > > tests: acpi: whitelist DSDT before exposing non zero functions
> > > acpi: pci: describe all functions on populated slots
> > > tests: acpi: update expected blobs
> > > tests: acpi: whitelist DSDT before adding non-0 function device with
> > > acpi-index to testcases
> > > tests: acpi: add non zero function device with acpi-index on
> > > non-hotpluggble bus
> > > tests: acpi: update expected blobs
> > > pci: move acpi-index uniqueness check to generic PCI device code
> > > acpi: pci: drop BSEL usage when deciding that device isn't
> > > hotpluggable
> > > acpi: pci: move BSEL into build_append_pcihp_slots()
> > > acpi: pci: move out ACPI PCI hotplug generator from generic slot
> > > generator build_append_pci_bus_devices()
> > > pcihp: move fields enabling hotplug into AcpiPciHpState
> > > pcihp: add ACPI PCI hotplug specific is_hotpluggable_bus() callback
> > >
> > > include/hw/acpi/ich9.h | 1 +
> > > include/hw/acpi/pcihp.h | 11 +-
> > > include/hw/acpi/piix4.h | 2 -
> > > include/hw/hotplug.h | 2 +
> > > include/hw/qdev-core.h | 13 +-
> > > hw/acpi/acpi-pci-hotplug-stub.c | 9 +-
> > > hw/acpi/ich9.c | 21 +-
> > > hw/acpi/pci-bridge.c | 14 +-
> > > hw/acpi/pcihp.c | 112 +++--------
> > > hw/acpi/piix4.c | 33 ++--
> > > hw/i386/acpi-build.c | 179 +++++++++++++-----
> > > hw/isa/lpc_ich9.c | 1 +
> > > hw/pci/pci.c | 57 ++++++
> > > hw/pci/pcie_port.c | 8 +
> > > tests/data/acpi/pc/DSDT | Bin 6360 -> 6488 bytes
> > > tests/data/acpi/pc/DSDT.acpierst | Bin 6283 -> 6411 bytes
> > > tests/data/acpi/pc/DSDT.acpihmat | Bin 7685 -> 7813 bytes
> > > tests/data/acpi/pc/DSDT.bridge | Bin 12487 -> 12615 bytes
> > > tests/data/acpi/pc/DSDT.cphp | Bin 6824 -> 6952 bytes
> > > tests/data/acpi/pc/DSDT.dimmpxm | Bin 8014 -> 8142 bytes
> > > tests/data/acpi/pc/DSDT.hpbridge | Bin 6289 -> 6451 bytes
> > > tests/data/acpi/pc/DSDT.hpbrroot | Bin 3081 -> 3343 bytes
> > > tests/data/acpi/pc/DSDT.ipmikcs | Bin 6432 -> 6560 bytes
> > > tests/data/acpi/pc/DSDT.memhp | Bin 7719 -> 7847 bytes
> > > tests/data/acpi/pc/DSDT.nohpet | Bin 6218 -> 6346 bytes
> > > tests/data/acpi/pc/DSDT.numamem | Bin 6366 -> 6494 bytes
> > > tests/data/acpi/pc/DSDT.roothp | Bin 9745 -> 9873 bytes
> > > tests/data/acpi/q35/DSDT | Bin 8252 -> 8361 bytes
> > > tests/data/acpi/q35/DSDT.acpierst | Bin 8269 -> 8378 bytes
> > > tests/data/acpi/q35/DSDT.acpihmat | Bin 9577 -> 9686 bytes
> > > tests/data/acpi/q35/DSDT.acpihmat-noinitiator | Bin 8531 -> 8640 bytes
> > > tests/data/acpi/q35/DSDT.applesmc | Bin 8298 -> 8407 bytes
> > > tests/data/acpi/q35/DSDT.bridge | Bin 11481 -> 11590 bytes
> > > tests/data/acpi/q35/DSDT.core-count2 | Bin 32392 -> 32501 bytes
> > > tests/data/acpi/q35/DSDT.cphp | Bin 8716 -> 8825 bytes
> > > tests/data/acpi/q35/DSDT.cxl | Bin 9578 -> 9687 bytes
> > > tests/data/acpi/q35/DSDT.dimmpxm | Bin 9906 -> 10015 bytes
> > > tests/data/acpi/q35/DSDT.ipmibt | Bin 8327 -> 8436 bytes
> > > tests/data/acpi/q35/DSDT.ipmismbus | Bin 8340 -> 8449 bytes
> > > tests/data/acpi/q35/DSDT.ivrs | Bin 8269 -> 8378 bytes
> > > tests/data/acpi/q35/DSDT.memhp | Bin 9611 -> 9720 bytes
> > > tests/data/acpi/q35/DSDT.mmio64 | Bin 9382 -> 9491 bytes
> > > tests/data/acpi/q35/DSDT.multi-bridge | Bin 12337 -> 12770 bytes
> > > tests/data/acpi/q35/DSDT.noacpihp | Bin 0 -> 8248 bytes
> > > tests/data/acpi/q35/DSDT.nohpet | Bin 8110 -> 8219 bytes
> > > tests/data/acpi/q35/DSDT.numamem | Bin 8258 -> 8367 bytes
> > > tests/data/acpi/q35/DSDT.pvpanic-isa | Bin 8353 -> 8462 bytes
> > > tests/data/acpi/q35/DSDT.tis.tpm12 | Bin 8858 -> 8967 bytes
> > > tests/data/acpi/q35/DSDT.tis.tpm2 | Bin 8884 -> 8993 bytes
> > > tests/data/acpi/q35/DSDT.viot | Bin 9361 -> 9486 bytes
> > > tests/data/acpi/q35/DSDT.xapic | Bin 35615 -> 35724 bytes
> > > tests/qtest/bios-tables-test.c | 50 ++++-
> > > 52 files changed, 341 insertions(+), 172 deletions(-)
> > > create mode 100644 tests/data/acpi/q35/DSDT.noacpihp
> > >
> > > --
> > > 2.39.1
> >
^ permalink raw reply [flat|nested] 46+ messages in thread
* Re: [PATCH 00/33] pci(pc/q35): acpi-index support on non-hotpluggable slots
2023-03-02 23:21 ` Michael S. Tsirkin
@ 2023-03-06 10:49 ` Igor Mammedov
0 siblings, 0 replies; 46+ messages in thread
From: Igor Mammedov @ 2023-03-06 10:49 UTC (permalink / raw)
To: Michael S. Tsirkin; +Cc: qemu-devel, ani, berrange
On Thu, 2 Mar 2023 18:21:28 -0500
"Michael S. Tsirkin" <mst@redhat.com> wrote:
> On Thu, Mar 02, 2023 at 01:07:16PM +0100, Igor Mammedov wrote:
> > On Thu, 2 Mar 2023 05:59:16 -0500
> > "Michael S. Tsirkin" <mst@redhat.com> wrote:
> >
> > > On Fri, Feb 24, 2023 at 04:37:39PM +0100, Igor Mammedov wrote:
> > > > Series extends acpi-index support to host-bridge(s) and bridges
> > > > with disabled hotplug (either explicitly or implicitly).
> > > > Whats new (it is still limited to 'pc' and 'q35' machines),
> > > > acpi-index now works for non-hotpluggable slots/nics:
> > > > * q35: host-bridge
> > > > * pc: host-bridge with disabled hotplug
> > > > 'PIIX4_PM.acpi-root-pci-hotplug=off'
> > > > * non-hotpluggable multifunction nics
> > > > * on non-hotpluggable slots with native hotplug (i.e. without ACPI PCI hotplug)
> > > > PIIX4_PM.acpi-pci-hotplug-with-bridge-support=off
> > > > ICH9-LPC.acpi-pci-hotplug-with-bridge-support=off
> > > > + pcie-root-port,hotplug=off | pci-bridge,shpc=off
> > > >
> > > > where it doesn't work (and never will):
> > > > * on hotplugged ports/bridges
> > > > * on hotpluggable ports/bridges with native hotplug
> > > >
> > > > 1-11/33: fixes for bugs or odd behavior
> > > > 13-23/33: non-hotplug/multifunction acpi-index enabling
> > > > 28-33/33: cleanups
> > > > all of that is peppered by extra acpi tests or extensions to existing ones
> > >
> > > dropped because viot was wrong.
> > > Pls rebase fix up and repost.
> >
> > I'll rebase on top of your recent pull req with c471eb4f4044 commit reverted
> > to get properly updated tables.
> > Partial table rebuilds are fragile anyways, should we make rebuild ignore
> > checks the commit introduced?
>
> Not sure how you mean.
I'm not sure either, but I ended up reverting offending commit
as Fabiano suggested for now and rebasing on top your tree + revert.
Later on if we are to reintroduce selective testcases, we need to
think about how to make tables rebuild force all tests regardless
of it.
>
> > PS:
> > Does the rest of the series look fine to you?
>
> It does, was going to merge.
>
> >
> > >
> > >
> > > Apropos I still think we should split up DSDT to several
> > > SSDTs, in a way that multiple tests share some SSDTs.
> > > This way it will be more common than a change only affects one table
> > > and it's easier to merge things.
> > >
> > > For example, how about moving CXL things to an SSDT?
> > >
> > >
> > > > Somewhat tested with RHEL9.0 and WS2022.
> > > >
> > > > What's in queue:
> > > > * PXB support
> > > > * microvm and arm/virt support
> > > > all of above only for non-hotpluggable slots as I don't really want to
> > > > pull there complicated APCI PCI hotplug.
> > > >
> > > > gitlab tree: https://gitlab.com/imammedo/qemu/-/tree/acpi_index_non_hotplug
> > > > CI: https://gitlab.com/imammedo/qemu/-/pipelines/787263630
> > > > it's red but only due to unrelated curl breakage in msys* targets,
> > > > the rest is green
> > > >
> > > > Igor Mammedov (33):
> > > > tests: acpi: whitelist new q35.noacpihp test and pc.hpbrroot
> > > > tests: acpi: add test_acpi_q35_tcg_no_acpi_hotplug test and extend
> > > > test_acpi_piix4_no_acpi_pci_hotplug
> > > > tests: acpi: update expected blobs
> > > > tests: acpi: whitelist q35/DSDT.multi-bridge before extending testcase
> > > > tests: acpi: extend multi-bridge case with case
> > > > 'root-port,id=HOHP,hotplug=off root-port,bus=NOHP'
> > > > x86: pcihp: fix missing PCNT callchain when intermediate root-port has
> > > > 'hotplug=off' set
> > > > tests: acpi: whitelist pc/DSDT.hpbrroot and pc/DSDT.hpbridge tests
> > > > x86: pcihp: fix missing bridge AML when intermediate root-port has
> > > > 'hotplug=off' set
> > > > tests: acpi: update expected blobs
> > > > pcihp: piix4: do not redirect hotplug controller to piix4 when ACPI
> > > > hotplug is disabled
> > > > pci: fix 'hotplugglable' property behavior
> > > > tests: acpi: whitelist DSDT blobs before isolating PCI _DSM func 0
> > > > prolog
> > > > pcihp: move PCI _DSM function 0 prolog into separate function
> > > > tests: acpi: update expected blobs
> > > > tests: acpi: whitelist DSDT before adding EDSM method
> > > > acpi: pci: add EDSM method to DSDT
> > > > tests: acpi: update expected blobs
> > > > tests: acpi: whitelist DSDT before adding device with acpi-index to
> > > > testcases
> > > > tests: acpi: add device with acpi-index on non-hotpluggble bus
> > > > acpi: pci: support acpi-index for non-hotpluggable devices
> > > > tests: acpi: update expected blobs
> > > > tests: acpi: whitelist DSDT before exposing non zero functions
> > > > acpi: pci: describe all functions on populated slots
> > > > tests: acpi: update expected blobs
> > > > tests: acpi: whitelist DSDT before adding non-0 function device with
> > > > acpi-index to testcases
> > > > tests: acpi: add non zero function device with acpi-index on
> > > > non-hotpluggble bus
> > > > tests: acpi: update expected blobs
> > > > pci: move acpi-index uniqueness check to generic PCI device code
> > > > acpi: pci: drop BSEL usage when deciding that device isn't
> > > > hotpluggable
> > > > acpi: pci: move BSEL into build_append_pcihp_slots()
> > > > acpi: pci: move out ACPI PCI hotplug generator from generic slot
> > > > generator build_append_pci_bus_devices()
> > > > pcihp: move fields enabling hotplug into AcpiPciHpState
> > > > pcihp: add ACPI PCI hotplug specific is_hotpluggable_bus() callback
> > > >
> > > > include/hw/acpi/ich9.h | 1 +
> > > > include/hw/acpi/pcihp.h | 11 +-
> > > > include/hw/acpi/piix4.h | 2 -
> > > > include/hw/hotplug.h | 2 +
> > > > include/hw/qdev-core.h | 13 +-
> > > > hw/acpi/acpi-pci-hotplug-stub.c | 9 +-
> > > > hw/acpi/ich9.c | 21 +-
> > > > hw/acpi/pci-bridge.c | 14 +-
> > > > hw/acpi/pcihp.c | 112 +++--------
> > > > hw/acpi/piix4.c | 33 ++--
> > > > hw/i386/acpi-build.c | 179 +++++++++++++-----
> > > > hw/isa/lpc_ich9.c | 1 +
> > > > hw/pci/pci.c | 57 ++++++
> > > > hw/pci/pcie_port.c | 8 +
> > > > tests/data/acpi/pc/DSDT | Bin 6360 -> 6488 bytes
> > > > tests/data/acpi/pc/DSDT.acpierst | Bin 6283 -> 6411 bytes
> > > > tests/data/acpi/pc/DSDT.acpihmat | Bin 7685 -> 7813 bytes
> > > > tests/data/acpi/pc/DSDT.bridge | Bin 12487 -> 12615 bytes
> > > > tests/data/acpi/pc/DSDT.cphp | Bin 6824 -> 6952 bytes
> > > > tests/data/acpi/pc/DSDT.dimmpxm | Bin 8014 -> 8142 bytes
> > > > tests/data/acpi/pc/DSDT.hpbridge | Bin 6289 -> 6451 bytes
> > > > tests/data/acpi/pc/DSDT.hpbrroot | Bin 3081 -> 3343 bytes
> > > > tests/data/acpi/pc/DSDT.ipmikcs | Bin 6432 -> 6560 bytes
> > > > tests/data/acpi/pc/DSDT.memhp | Bin 7719 -> 7847 bytes
> > > > tests/data/acpi/pc/DSDT.nohpet | Bin 6218 -> 6346 bytes
> > > > tests/data/acpi/pc/DSDT.numamem | Bin 6366 -> 6494 bytes
> > > > tests/data/acpi/pc/DSDT.roothp | Bin 9745 -> 9873 bytes
> > > > tests/data/acpi/q35/DSDT | Bin 8252 -> 8361 bytes
> > > > tests/data/acpi/q35/DSDT.acpierst | Bin 8269 -> 8378 bytes
> > > > tests/data/acpi/q35/DSDT.acpihmat | Bin 9577 -> 9686 bytes
> > > > tests/data/acpi/q35/DSDT.acpihmat-noinitiator | Bin 8531 -> 8640 bytes
> > > > tests/data/acpi/q35/DSDT.applesmc | Bin 8298 -> 8407 bytes
> > > > tests/data/acpi/q35/DSDT.bridge | Bin 11481 -> 11590 bytes
> > > > tests/data/acpi/q35/DSDT.core-count2 | Bin 32392 -> 32501 bytes
> > > > tests/data/acpi/q35/DSDT.cphp | Bin 8716 -> 8825 bytes
> > > > tests/data/acpi/q35/DSDT.cxl | Bin 9578 -> 9687 bytes
> > > > tests/data/acpi/q35/DSDT.dimmpxm | Bin 9906 -> 10015 bytes
> > > > tests/data/acpi/q35/DSDT.ipmibt | Bin 8327 -> 8436 bytes
> > > > tests/data/acpi/q35/DSDT.ipmismbus | Bin 8340 -> 8449 bytes
> > > > tests/data/acpi/q35/DSDT.ivrs | Bin 8269 -> 8378 bytes
> > > > tests/data/acpi/q35/DSDT.memhp | Bin 9611 -> 9720 bytes
> > > > tests/data/acpi/q35/DSDT.mmio64 | Bin 9382 -> 9491 bytes
> > > > tests/data/acpi/q35/DSDT.multi-bridge | Bin 12337 -> 12770 bytes
> > > > tests/data/acpi/q35/DSDT.noacpihp | Bin 0 -> 8248 bytes
> > > > tests/data/acpi/q35/DSDT.nohpet | Bin 8110 -> 8219 bytes
> > > > tests/data/acpi/q35/DSDT.numamem | Bin 8258 -> 8367 bytes
> > > > tests/data/acpi/q35/DSDT.pvpanic-isa | Bin 8353 -> 8462 bytes
> > > > tests/data/acpi/q35/DSDT.tis.tpm12 | Bin 8858 -> 8967 bytes
> > > > tests/data/acpi/q35/DSDT.tis.tpm2 | Bin 8884 -> 8993 bytes
> > > > tests/data/acpi/q35/DSDT.viot | Bin 9361 -> 9486 bytes
> > > > tests/data/acpi/q35/DSDT.xapic | Bin 35615 -> 35724 bytes
> > > > tests/qtest/bios-tables-test.c | 50 ++++-
> > > > 52 files changed, 341 insertions(+), 172 deletions(-)
> > > > create mode 100644 tests/data/acpi/q35/DSDT.noacpihp
> > > >
> > > > --
> > > > 2.39.1
> > >
>
^ permalink raw reply [flat|nested] 46+ messages in thread