From: "Eugenio Pérez" <eperezma@redhat.com>
To: qemu-devel@nongnu.org
Cc: Laurent Vivier <lvivier@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Gautam Dawar <gdawar@xilinx.com>, Lei Yang <leiyang@redhat.com>,
Harpreet Singh Anand <hanand@xilinx.com>,
Shannon Nelson <snelson@pensando.io>,
Liuxiangdong <liuxiangdong5@huawei.com>,
Cindy Lu <lulu@redhat.com>, Parav Pandit <parav@mellanox.com>,
Zhu Lingshan <lingshan.zhu@intel.com>,
virtualization@lists.linux-foundation.org,
Eli Cohen <eli@mellanox.com>,
si-wei.liu@oracle.com, longpeng2@huawei.com,
Jason Wang <jasowang@redhat.com>,
alvaro.karsz@solid-run.com, Stefan Hajnoczi <stefanha@redhat.com>,
Stefano Garzarella <sgarzare@redhat.com>,
"Gonglei (Arei)" <arei.gonglei@huawei.com>
Subject: [PATCH v5 12/14] vdpa: block migration if SVQ does not admit a feature
Date: Fri, 3 Mar 2023 18:24:43 +0100 [thread overview]
Message-ID: <20230303172445.1089785-13-eperezma@redhat.com> (raw)
In-Reply-To: <20230303172445.1089785-1-eperezma@redhat.com>
Next patches enable devices to be migrated even if vdpa netdev has not
been started with x-svq. However, not all devices are migratable, so we
need to block migration if we detect that.
Block migration if we detect the device expose a feature SVQ does not
know how to work with.
Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
---
hw/virtio/vhost-vdpa.c | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
index e9167977d5..48ffb67a34 100644
--- a/hw/virtio/vhost-vdpa.c
+++ b/hw/virtio/vhost-vdpa.c
@@ -443,6 +443,21 @@ static int vhost_vdpa_init(struct vhost_dev *dev, void *opaque, Error **errp)
return 0;
}
+ /*
+ * If dev->shadow_vqs_enabled at initialization that means the device has
+ * been started with x-svq=on, so don't block migration
+ */
+ if (dev->migration_blocker == NULL && !v->shadow_vqs_enabled) {
+ /* We don't have dev->features yet */
+ uint64_t features;
+ ret = vhost_vdpa_get_dev_features(dev, &features);
+ if (unlikely(ret)) {
+ error_setg_errno(errp, -ret, "Could not get device features");
+ return ret;
+ }
+ vhost_svq_valid_features(features, &dev->migration_blocker);
+ }
+
/*
* Similar to VFIO, we end up pinning all guest memory and have to
* disable discarding of RAM.
--
2.31.1
next prev parent reply other threads:[~2023-03-03 17:28 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-03 17:24 [PATCH v5 00/14] Dynamically switch to vhost shadow virtqueues at vdpa net migration Eugenio Pérez
2023-03-03 17:24 ` [PATCH v5 01/14] vdpa net: move iova tree creation from init to start Eugenio Pérez
2023-03-03 17:24 ` [PATCH v5 02/14] vdpa: Remember last call fd set Eugenio Pérez
2023-03-03 17:24 ` [PATCH v5 03/14] vdpa: Negotiate _F_SUSPEND feature Eugenio Pérez
2023-03-03 17:24 ` [PATCH v5 04/14] vdpa: rewind at get_base, not set_base Eugenio Pérez
2023-03-03 17:24 ` [PATCH v5 05/14] vdpa: add vhost_vdpa->suspended parameter Eugenio Pérez
2023-03-03 17:24 ` [PATCH v5 06/14] vdpa: add vhost_vdpa_suspend Eugenio Pérez
2023-03-03 17:24 ` [PATCH v5 07/14] vdpa: move vhost reset after get vring base Eugenio Pérez
2023-03-03 17:24 ` [PATCH v5 08/14] vdpa: add vdpa net migration state notifier Eugenio Pérez
2023-03-03 17:24 ` [PATCH v5 09/14] vdpa: disable RAM block discard only for the first device Eugenio Pérez
2023-03-03 17:24 ` [PATCH v5 10/14] vdpa net: block migration if the device has CVQ Eugenio Pérez
2023-03-03 17:24 ` [PATCH v5 11/14] vdpa: block migration if device has unsupported features Eugenio Pérez
2023-03-03 17:24 ` Eugenio Pérez [this message]
2023-03-03 17:24 ` [PATCH v5 13/14] vdpa net: allow VHOST_F_LOG_ALL Eugenio Pérez
2023-03-03 17:24 ` [PATCH v5 14/14] vdpa: return VHOST_F_LOG_ALL in vhost-vdpa devices Eugenio Pérez
2023-03-07 10:31 ` [PATCH v5 00/14] Dynamically switch to vhost shadow virtqueues at vdpa net migration Lei Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230303172445.1089785-13-eperezma@redhat.com \
--to=eperezma@redhat.com \
--cc=alvaro.karsz@solid-run.com \
--cc=arei.gonglei@huawei.com \
--cc=eli@mellanox.com \
--cc=gdawar@xilinx.com \
--cc=hanand@xilinx.com \
--cc=jasowang@redhat.com \
--cc=leiyang@redhat.com \
--cc=lingshan.zhu@intel.com \
--cc=liuxiangdong5@huawei.com \
--cc=longpeng2@huawei.com \
--cc=lulu@redhat.com \
--cc=lvivier@redhat.com \
--cc=mst@redhat.com \
--cc=parav@mellanox.com \
--cc=qemu-devel@nongnu.org \
--cc=sgarzare@redhat.com \
--cc=si-wei.liu@oracle.com \
--cc=snelson@pensando.io \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).