qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Eugenio Pérez" <eperezma@redhat.com>
To: qemu-devel@nongnu.org
Cc: Laurent Vivier <lvivier@redhat.com>,
	"Michael S. Tsirkin" <mst@redhat.com>,
	Gautam Dawar <gdawar@xilinx.com>, Lei Yang <leiyang@redhat.com>,
	Harpreet Singh Anand <hanand@xilinx.com>,
	Shannon Nelson <snelson@pensando.io>,
	Liuxiangdong <liuxiangdong5@huawei.com>,
	Cindy Lu <lulu@redhat.com>, Parav Pandit <parav@mellanox.com>,
	Zhu Lingshan <lingshan.zhu@intel.com>,
	virtualization@lists.linux-foundation.org,
	Eli Cohen <eli@mellanox.com>,
	si-wei.liu@oracle.com, longpeng2@huawei.com,
	Jason Wang <jasowang@redhat.com>,
	alvaro.karsz@solid-run.com, Stefan Hajnoczi <stefanha@redhat.com>,
	Stefano Garzarella <sgarzare@redhat.com>,
	"Gonglei (Arei)" <arei.gonglei@huawei.com>
Subject: [PATCH v5 05/14] vdpa: add vhost_vdpa->suspended parameter
Date: Fri,  3 Mar 2023 18:24:36 +0100	[thread overview]
Message-ID: <20230303172445.1089785-6-eperezma@redhat.com> (raw)
In-Reply-To: <20230303172445.1089785-1-eperezma@redhat.com>

This allows vhost_vdpa to track if it is safe to get the vring base from
the device or not.  If it is not, vhost can fall back to fetch idx from
the guest buffer again.

No functional change intended in this patch, later patches will use this
field.

Signed-off-by: Eugenio Pérez <eperezma@redhat.com>
---
 include/hw/virtio/vhost-vdpa.h | 2 ++
 hw/virtio/vhost-vdpa.c         | 8 ++++++++
 2 files changed, 10 insertions(+)

diff --git a/include/hw/virtio/vhost-vdpa.h b/include/hw/virtio/vhost-vdpa.h
index 7997f09a8d..4a7d396674 100644
--- a/include/hw/virtio/vhost-vdpa.h
+++ b/include/hw/virtio/vhost-vdpa.h
@@ -42,6 +42,8 @@ typedef struct vhost_vdpa {
     bool shadow_vqs_enabled;
     /* Vdpa must send shadow addresses as IOTLB key for data queues, not GPA */
     bool shadow_data;
+    /* Device suspended successfully */
+    bool suspended;
     /* IOVA mapping used by the Shadow Virtqueue */
     VhostIOVATree *iova_tree;
     GPtrArray *shadow_vqs;
diff --git a/hw/virtio/vhost-vdpa.c b/hw/virtio/vhost-vdpa.c
index 1550b1e26a..517e3cdc8d 100644
--- a/hw/virtio/vhost-vdpa.c
+++ b/hw/virtio/vhost-vdpa.c
@@ -1193,6 +1193,14 @@ static int vhost_vdpa_get_vring_base(struct vhost_dev *dev,
         return 0;
     }
 
+    if (!v->suspended) {
+        /*
+         * Cannot trust in value returned by device, let vhost recover used
+         * idx from guest.
+         */
+        return -1;
+    }
+
     ret = vhost_vdpa_call(dev, VHOST_GET_VRING_BASE, ring);
     trace_vhost_vdpa_get_vring_base(dev, ring->index, ring->num);
     return ret;
-- 
2.31.1



  parent reply	other threads:[~2023-03-03 17:25 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-03 17:24 [PATCH v5 00/14] Dynamically switch to vhost shadow virtqueues at vdpa net migration Eugenio Pérez
2023-03-03 17:24 ` [PATCH v5 01/14] vdpa net: move iova tree creation from init to start Eugenio Pérez
2023-03-03 17:24 ` [PATCH v5 02/14] vdpa: Remember last call fd set Eugenio Pérez
2023-03-03 17:24 ` [PATCH v5 03/14] vdpa: Negotiate _F_SUSPEND feature Eugenio Pérez
2023-03-03 17:24 ` [PATCH v5 04/14] vdpa: rewind at get_base, not set_base Eugenio Pérez
2023-03-03 17:24 ` Eugenio Pérez [this message]
2023-03-03 17:24 ` [PATCH v5 06/14] vdpa: add vhost_vdpa_suspend Eugenio Pérez
2023-03-03 17:24 ` [PATCH v5 07/14] vdpa: move vhost reset after get vring base Eugenio Pérez
2023-03-03 17:24 ` [PATCH v5 08/14] vdpa: add vdpa net migration state notifier Eugenio Pérez
2023-03-03 17:24 ` [PATCH v5 09/14] vdpa: disable RAM block discard only for the first device Eugenio Pérez
2023-03-03 17:24 ` [PATCH v5 10/14] vdpa net: block migration if the device has CVQ Eugenio Pérez
2023-03-03 17:24 ` [PATCH v5 11/14] vdpa: block migration if device has unsupported features Eugenio Pérez
2023-03-03 17:24 ` [PATCH v5 12/14] vdpa: block migration if SVQ does not admit a feature Eugenio Pérez
2023-03-03 17:24 ` [PATCH v5 13/14] vdpa net: allow VHOST_F_LOG_ALL Eugenio Pérez
2023-03-03 17:24 ` [PATCH v5 14/14] vdpa: return VHOST_F_LOG_ALL in vhost-vdpa devices Eugenio Pérez
2023-03-07 10:31 ` [PATCH v5 00/14] Dynamically switch to vhost shadow virtqueues at vdpa net migration Lei Yang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230303172445.1089785-6-eperezma@redhat.com \
    --to=eperezma@redhat.com \
    --cc=alvaro.karsz@solid-run.com \
    --cc=arei.gonglei@huawei.com \
    --cc=eli@mellanox.com \
    --cc=gdawar@xilinx.com \
    --cc=hanand@xilinx.com \
    --cc=jasowang@redhat.com \
    --cc=leiyang@redhat.com \
    --cc=lingshan.zhu@intel.com \
    --cc=liuxiangdong5@huawei.com \
    --cc=longpeng2@huawei.com \
    --cc=lulu@redhat.com \
    --cc=lvivier@redhat.com \
    --cc=mst@redhat.com \
    --cc=parav@mellanox.com \
    --cc=qemu-devel@nongnu.org \
    --cc=sgarzare@redhat.com \
    --cc=si-wei.liu@oracle.com \
    --cc=snelson@pensando.io \
    --cc=stefanha@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).