* [PATCH] target/hexagon/idef-parser: Elide mov in gen_pred_assign
@ 2023-03-06 22:57 Richard Henderson
2023-03-06 23:25 ` Taylor Simpson
2023-03-06 23:42 ` Philippe Mathieu-Daudé
0 siblings, 2 replies; 3+ messages in thread
From: Richard Henderson @ 2023-03-06 22:57 UTC (permalink / raw)
To: qemu-devel; +Cc: Taylor Simpson
Merge mov with andi.
Suggested-by: Taylor Simpson <tsimpson@quicinc.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/hexagon/idef-parser/parser-helpers.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/target/hexagon/idef-parser/parser-helpers.c b/target/hexagon/idef-parser/parser-helpers.c
index e1a55412c8..7b494c2f9e 100644
--- a/target/hexagon/idef-parser/parser-helpers.c
+++ b/target/hexagon/idef-parser/parser-helpers.c
@@ -1722,9 +1722,7 @@ void gen_pred_assign(Context *c, YYLTYPE *locp, HexValue *left_pred,
*left_pred = gen_tmp(c, locp, 32, UNSIGNED);
}
/* Extract first 8 bits, and store new predicate value */
- OUT(c, locp, "tcg_gen_mov_i32(", left_pred, ", ", &r, ");\n");
- OUT(c, locp, "tcg_gen_andi_i32(", left_pred, ", ", left_pred,
- ", 0xff);\n");
+ OUT(c, locp, "tcg_gen_andi_i32(", left_pred, ", ", &r, ", 0xff);\n");
if (is_direct) {
OUT(c, locp, "gen_log_pred_write(ctx, ", pred_id, ", ", left_pred,
");\n");
--
2.34.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [PATCH] target/hexagon/idef-parser: Elide mov in gen_pred_assign
2023-03-06 22:57 [PATCH] target/hexagon/idef-parser: Elide mov in gen_pred_assign Richard Henderson
@ 2023-03-06 23:25 ` Taylor Simpson
2023-03-06 23:42 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Taylor Simpson @ 2023-03-06 23:25 UTC (permalink / raw)
To: Richard Henderson, qemu-devel@nongnu.org
> -----Original Message-----
> From: Richard Henderson <richard.henderson@linaro.org>
> Sent: Monday, March 6, 2023 3:57 PM
> To: qemu-devel@nongnu.org
> Cc: Taylor Simpson <tsimpson@quicinc.com>
> Subject: [PATCH] target/hexagon/idef-parser: Elide mov in gen_pred_assign
>
> Merge mov with andi.
>
> Suggested-by: Taylor Simpson <tsimpson@quicinc.com>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/hexagon/idef-parser/parser-helpers.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/target/hexagon/idef-parser/parser-helpers.c
> b/target/hexagon/idef-parser/parser-helpers.c
> index e1a55412c8..7b494c2f9e 100644
> --- a/target/hexagon/idef-parser/parser-helpers.c
> +++ b/target/hexagon/idef-parser/parser-helpers.c
> @@ -1722,9 +1722,7 @@ void gen_pred_assign(Context *c, YYLTYPE *locp,
> HexValue *left_pred,
> *left_pred = gen_tmp(c, locp, 32, UNSIGNED);
> }
> /* Extract first 8 bits, and store new predicate value */
> - OUT(c, locp, "tcg_gen_mov_i32(", left_pred, ", ", &r, ");\n");
> - OUT(c, locp, "tcg_gen_andi_i32(", left_pred, ", ", left_pred,
> - ", 0xff);\n");
> + OUT(c, locp, "tcg_gen_andi_i32(", left_pred, ", ", &r, ", 0xff);\n");
> if (is_direct) {
> OUT(c, locp, "gen_log_pred_write(ctx, ", pred_id, ", ", left_pred,
> ");\n");
> --
> 2.34.1
Reviewed-by: Taylor Simpson <tsimpson@quicinc.com>
Queued for Hexagon pull request
Thanks,
Taylor
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] target/hexagon/idef-parser: Elide mov in gen_pred_assign
2023-03-06 22:57 [PATCH] target/hexagon/idef-parser: Elide mov in gen_pred_assign Richard Henderson
2023-03-06 23:25 ` Taylor Simpson
@ 2023-03-06 23:42 ` Philippe Mathieu-Daudé
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-03-06 23:42 UTC (permalink / raw)
To: Richard Henderson, qemu-devel; +Cc: Taylor Simpson
On 6/3/23 23:57, Richard Henderson wrote:
> Merge mov with andi.
>
> Suggested-by: Taylor Simpson <tsimpson@quicinc.com>
> Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
> ---
> target/hexagon/idef-parser/parser-helpers.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-06 23:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-06 22:57 [PATCH] target/hexagon/idef-parser: Elide mov in gen_pred_assign Richard Henderson
2023-03-06 23:25 ` Taylor Simpson
2023-03-06 23:42 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).