qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, "Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PULL 03/67] target/mips: Drop tcg_temp_free from mxu_translate.c
Date: Tue,  7 Mar 2023 09:57:44 -0800	[thread overview]
Message-ID: <20230307175848.2508955-4-richard.henderson@linaro.org> (raw)
In-Reply-To: <20230307175848.2508955-1-richard.henderson@linaro.org>

Translators are no longer required to free tcg temporaries.

Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 target/mips/tcg/mxu_translate.c | 51 ---------------------------------
 1 file changed, 51 deletions(-)

diff --git a/target/mips/tcg/mxu_translate.c b/target/mips/tcg/mxu_translate.c
index f52244e1b2..8703b0cef4 100644
--- a/target/mips/tcg/mxu_translate.c
+++ b/target/mips/tcg/mxu_translate.c
@@ -513,8 +513,6 @@ static void gen_mxu_s32i2m(DisasContext *ctx)
     } else if (XRa == 16) {
         gen_store_mxu_cr(t0);
     }
-
-    tcg_temp_free(t0);
 }
 
 /*
@@ -537,8 +535,6 @@ static void gen_mxu_s32m2i(DisasContext *ctx)
     }
 
     gen_store_gpr(t0, Rb);
-
-    tcg_temp_free(t0);
 }
 
 /*
@@ -613,9 +609,6 @@ static void gen_mxu_s8ldd(DisasContext *ctx)
     }
 
     gen_store_mxu_gpr(t0, XRa);
-
-    tcg_temp_free(t0);
-    tcg_temp_free(t1);
 }
 
 /*
@@ -664,11 +657,6 @@ static void gen_mxu_d16mul(DisasContext *ctx)
     }
     gen_store_mxu_gpr(t3, XRa);
     gen_store_mxu_gpr(t2, XRd);
-
-    tcg_temp_free(t0);
-    tcg_temp_free(t1);
-    tcg_temp_free(t2);
-    tcg_temp_free(t3);
 }
 
 /*
@@ -741,11 +729,6 @@ static void gen_mxu_d16mac(DisasContext *ctx)
     }
     gen_store_mxu_gpr(t3, XRa);
     gen_store_mxu_gpr(t2, XRd);
-
-    tcg_temp_free(t0);
-    tcg_temp_free(t1);
-    tcg_temp_free(t2);
-    tcg_temp_free(t3);
 }
 
 /*
@@ -821,15 +804,6 @@ static void gen_mxu_q8mul_q8mulsu(DisasContext *ctx)
 
     gen_store_mxu_gpr(t0, XRd);
     gen_store_mxu_gpr(t1, XRa);
-
-    tcg_temp_free(t0);
-    tcg_temp_free(t1);
-    tcg_temp_free(t2);
-    tcg_temp_free(t3);
-    tcg_temp_free(t4);
-    tcg_temp_free(t5);
-    tcg_temp_free(t6);
-    tcg_temp_free(t7);
 }
 
 /*
@@ -860,9 +834,6 @@ static void gen_mxu_s32ldd_s32lddr(DisasContext *ctx)
     tcg_gen_qemu_ld_tl(t1, t1, ctx->mem_idx, MO_TESL ^ (sel * MO_BSWAP));
 
     gen_store_mxu_gpr(t1, XRa);
-
-    tcg_temp_free(t0);
-    tcg_temp_free(t1);
 }
 
 
@@ -1125,9 +1096,6 @@ static void gen_mxu_D16MAX_D16MIN(DisasContext *ctx)
         tcg_gen_shri_i32(t0, t0, 16);
         /* finally update the destination */
         tcg_gen_or_i32(mxu_gpr[XRa - 1], mxu_gpr[XRa - 1], t0);
-
-        tcg_temp_free(t1);
-        tcg_temp_free(t0);
     } else if (unlikely(XRb == XRc)) {
         /* both operands same -> just set destination to one of them */
         tcg_gen_mov_i32(mxu_gpr[XRa - 1], mxu_gpr[XRb - 1]);
@@ -1161,9 +1129,6 @@ static void gen_mxu_D16MAX_D16MIN(DisasContext *ctx)
         tcg_gen_shri_i32(t0, t0, 16);
         /* finally update the destination */
         tcg_gen_or_i32(mxu_gpr[XRa - 1], mxu_gpr[XRa - 1], t0);
-
-        tcg_temp_free(t1);
-        tcg_temp_free(t0);
     }
 }
 
@@ -1226,9 +1191,6 @@ static void gen_mxu_Q8MAX_Q8MIN(DisasContext *ctx)
             /* finally update the destination */
             tcg_gen_or_i32(mxu_gpr[XRa - 1], mxu_gpr[XRa - 1], t0);
         }
-
-        tcg_temp_free(t1);
-        tcg_temp_free(t0);
     } else if (unlikely(XRb == XRc)) {
         /* both operands same -> just set destination to one of them */
         tcg_gen_mov_i32(mxu_gpr[XRa - 1], mxu_gpr[XRb - 1]);
@@ -1266,9 +1228,6 @@ static void gen_mxu_Q8MAX_Q8MIN(DisasContext *ctx)
             /* finally update the destination */
             tcg_gen_or_i32(mxu_gpr[XRa - 1], mxu_gpr[XRa - 1], t0);
         }
-
-        tcg_temp_free(t1);
-        tcg_temp_free(t0);
     }
 }
 
@@ -1384,9 +1343,6 @@ static void gen_mxu_S32ALNI(DisasContext *ctx)
                 tcg_gen_shri_i32(t1, t1, 24);
 
                 tcg_gen_or_i32(mxu_gpr[XRa - 1], t0, t1);
-
-                tcg_temp_free(t1);
-                tcg_temp_free(t0);
             }
             break;
         case MXU_OPTN3_PTN2:
@@ -1410,9 +1366,6 @@ static void gen_mxu_S32ALNI(DisasContext *ctx)
                 tcg_gen_shri_i32(t1, t1, 16);
 
                 tcg_gen_or_i32(mxu_gpr[XRa - 1], t0, t1);
-
-                tcg_temp_free(t1);
-                tcg_temp_free(t0);
             }
             break;
         case MXU_OPTN3_PTN3:
@@ -1436,9 +1389,6 @@ static void gen_mxu_S32ALNI(DisasContext *ctx)
                 tcg_gen_shri_i32(t1, t1, 8);
 
                 tcg_gen_or_i32(mxu_gpr[XRa - 1], t0, t1);
-
-                tcg_temp_free(t1);
-                tcg_temp_free(t0);
             }
             break;
         case MXU_OPTN3_PTN4:
@@ -1598,7 +1548,6 @@ bool decode_ase_mxu(DisasContext *ctx, uint32_t insn)
         }
 
         gen_set_label(l_exit);
-        tcg_temp_free(t_mxu_cr);
     }
 
     return true;
-- 
2.34.1



  parent reply	other threads:[~2023-03-07 18:02 UTC|newest]

Thread overview: 70+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-07 17:57 [PULL 00/67] tcg patch queue Richard Henderson
2023-03-07 17:57 ` [PULL 01/67] target/mips: Drop tcg_temp_free from micromips_translate.c.inc Richard Henderson
2023-03-07 17:57 ` [PULL 02/67] target/mips: Drop tcg_temp_free from msa_translate.c Richard Henderson
2023-03-07 17:57 ` Richard Henderson [this message]
2023-03-07 17:57 ` [PULL 04/67] target/mips: Drop tcg_temp_free from nanomips_translate.c.inc Richard Henderson
2023-03-07 17:57 ` [PULL 05/67] target/mips: Drop tcg_temp_free from octeon_translate.c Richard Henderson
2023-03-07 17:57 ` [PULL 06/67] target/mips: Drop tcg_temp_free from translate_addr_const.c Richard Henderson
2023-03-07 17:57 ` [PULL 07/67] target/mips: Drop tcg_temp_free from tx79_translate.c Richard Henderson
2023-03-07 17:57 ` [PULL 08/67] target/mips: Drop tcg_temp_free from vr54xx_translate.c Richard Henderson
2023-03-07 17:57 ` [PULL 09/67] target/mips: Drop tcg_temp_free from translate.c Richard Henderson
2023-03-07 17:57 ` [PULL 10/67] target/s390x: Drop free_compare Richard Henderson
2023-03-07 17:57 ` [PULL 11/67] target/s390x: Drop tcg_temp_free from translate_vx.c.inc Richard Henderson
2023-03-07 17:57 ` [PULL 12/67] target/s390x: Drop tcg_temp_free from translate.c Richard Henderson
2023-03-07 17:57 ` [PULL 13/67] target/s390x: Remove assert vs g_in2 Richard Henderson
2023-03-07 17:57 ` [PULL 14/67] target/s390x: Remove g_out, g_out2, g_in1, g_in2 from DisasContext Richard Henderson
2023-03-07 17:57 ` [PULL 15/67] tcg: Create tcg/tcg-temp-internal.h Richard Henderson
2023-03-07 17:57 ` [PULL 16/67] include/exec: Set default `NB_MMU_MODES` to 16 Richard Henderson
2023-03-07 17:57 ` [PULL 17/67] target/alpha: Remove `NB_MMU_MODES` define Richard Henderson
2023-03-07 17:57 ` [PULL 18/67] target/arm: " Richard Henderson
2023-03-07 17:58 ` [PULL 19/67] target/avr: " Richard Henderson
2023-03-07 17:58 ` [PULL 20/67] target/cris: " Richard Henderson
2023-03-07 17:58 ` [PULL 21/67] target/hexagon: " Richard Henderson
2023-03-07 17:58 ` [PULL 22/67] target/hppa: " Richard Henderson
2023-03-07 17:58 ` [PULL 23/67] target/i386: " Richard Henderson
2023-03-07 17:58 ` [PULL 24/67] target/loongarch: " Richard Henderson
2023-03-07 17:58 ` [PULL 25/67] target/m68k: " Richard Henderson
2023-03-09 12:18   ` Laurent Vivier
2023-03-07 17:58 ` [PULL 26/67] target/microblaze: " Richard Henderson
2023-03-07 17:58 ` [PULL 27/67] target/mips: " Richard Henderson
2023-03-07 17:58 ` [PULL 28/67] target/nios2: " Richard Henderson
2023-03-07 17:58 ` [PULL 29/67] target/openrisc: " Richard Henderson
2023-03-07 17:58 ` [PULL 30/67] target/ppc: " Richard Henderson
2023-03-07 17:58 ` [PULL 31/67] target/riscv: " Richard Henderson
2023-03-07 17:58 ` [PULL 32/67] target/rx: " Richard Henderson
2023-03-07 17:58 ` [PULL 33/67] target/s390x: " Richard Henderson
2023-03-07 17:58 ` [PULL 34/67] target/sh4: " Richard Henderson
2023-03-07 17:58 ` [PULL 35/67] target/sparc: " Richard Henderson
2023-03-07 17:58 ` [PULL 36/67] target/tricore: " Richard Henderson
2023-03-07 17:58 ` [PULL 37/67] target/xtensa: " Richard Henderson
2023-03-07 17:58 ` [PULL 38/67] include/exec: Remove guards around `NB_MMU_MODES` Richard Henderson
2023-03-07 17:58 ` [PULL 39/67] target/avr: Avoid use of tcg_const_i32 in SBIC, SBIS Richard Henderson
2023-03-07 17:58 ` [PULL 40/67] target/avr: Avoid use of tcg_const_i32 throughout Richard Henderson
2023-03-07 17:58 ` [PULL 41/67] target/cris: " Richard Henderson
2023-03-07 17:58 ` [PULL 42/67] target/hppa: Avoid tcg_const_i64 in trans_fid_f Richard Henderson
2023-03-07 17:58 ` [PULL 43/67] target/hppa: Avoid use of tcg_const_i32 throughout Richard Henderson
2023-03-07 17:58 ` [PULL 44/67] target/i386: Avoid use of tcg_const_* throughout Richard Henderson
2023-03-07 17:58 ` [PULL 45/67] target/m68k: Avoid tcg_const_i32 when modified Richard Henderson
2023-03-07 17:58 ` [PULL 46/67] target/m68k: Avoid tcg_const_i32 in bfop_reg Richard Henderson
2023-03-07 17:58 ` [PULL 47/67] target/m68k: Avoid tcg_const_* throughout Richard Henderson
2023-03-07 17:58 ` [PULL 48/67] target/mips: Split out gen_lxl Richard Henderson
2023-03-07 17:58 ` [PULL 49/67] target/mips: Split out gen_lxr Richard Henderson
2023-03-07 17:58 ` [PULL 50/67] target/mips: Avoid tcg_const_tl in gen_r6_ld Richard Henderson
2023-03-07 17:58 ` [PULL 51/67] target/mips: Avoid tcg_const_* throughout Richard Henderson
2023-03-07 17:58 ` [PULL 52/67] target/ppc: Split out gen_vx_vmul10 Richard Henderson
2023-03-07 17:58 ` [PULL 53/67] target/ppc: Avoid tcg_const_i64 in do_vector_shift_quad Richard Henderson
2023-03-07 17:58 ` [PULL 54/67] target/rx: Use tcg_gen_abs_i32 Richard Henderson
2023-03-07 17:58 ` [PULL 55/67] target/rx: Use cpu_psw_z as temp in flags computation Richard Henderson
2023-03-07 17:58 ` [PULL 56/67] target/rx: Avoid tcg_const_i32 when new temp needed Richard Henderson
2023-03-07 17:58 ` [PULL 57/67] target/rx: Avoid tcg_const_i32 Richard Henderson
2023-03-07 17:58 ` [PULL 58/67] target/s390x: Avoid tcg_const_i64 Richard Henderson
2023-03-07 17:58 ` [PULL 59/67] target/sh4: Avoid tcg_const_i32 for TAS.B Richard Henderson
2023-03-07 17:58 ` [PULL 60/67] target/sh4: Avoid tcg_const_i32 Richard Henderson
2023-03-07 17:58 ` [PULL 61/67] tcg/sparc: Avoid tcg_const_tl in gen_edge Richard Henderson
2023-03-07 17:58 ` [PULL 62/67] target/tricore: Split t_n as constant from temp as variable Richard Henderson
2023-03-07 17:58 ` [PULL 63/67] target/tricore: Rename t_off10 and use tcg_constant_i32 Richard Henderson
2023-03-07 17:58 ` [PULL 64/67] target/tricore: Use setcondi instead of explicit allocation Richard Henderson
2023-03-07 17:58 ` [PULL 65/67] target/tricore: Drop some temp initialization Richard Henderson
2023-03-07 17:58 ` [PULL 66/67] target/tricore: Avoid tcg_const_i32 Richard Henderson
2023-03-07 17:58 ` [PULL 67/67] tcg: Replace tcg_const_i64 in tcg-op.c Richard Henderson
2023-03-09 13:14 ` [PULL 00/67] tcg patch queue Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230307175848.2508955-4-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).