qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, "Alex Bennée" <alex.bennee@linaro.org>,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Paolo Bonzini" <pbonzini@redhat.com>
Subject: [PULL 24/30] include: split target_long definition from cpu-defs
Date: Tue,  7 Mar 2023 21:21:33 +0000	[thread overview]
Message-ID: <20230307212139.883112-25-alex.bennee@linaro.org> (raw)
In-Reply-To: <20230307212139.883112-1-alex.bennee@linaro.org>

While we will continue to include this via cpu-defs it is useful to be
able to define this separately for 32 and 64 bit versions of an
otherwise target independent compilation unit.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>

Message-Id: <20230302190846.2593720-25-alex.bennee@linaro.org>
Message-Id: <20230303025805.625589-25-richard.henderson@linaro.org>

diff --git a/MAINTAINERS b/MAINTAINERS
index 04857c71fa..f403619a84 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -137,6 +137,7 @@ F: docs/devel/tcg*
 F: include/exec/cpu*.h
 F: include/exec/exec-all.h
 F: include/exec/tb-flush.h
+F: include/exec/target_long.h
 F: include/exec/helper*.h
 F: include/sysemu/cpus.h
 F: include/sysemu/tcg.h
diff --git a/include/exec/cpu-defs.h b/include/exec/cpu-defs.h
index be920d4208..cd8aa177cc 100644
--- a/include/exec/cpu-defs.h
+++ b/include/exec/cpu-defs.h
@@ -55,24 +55,7 @@
 # endif
 #endif
 
-#define TARGET_LONG_SIZE (TARGET_LONG_BITS / 8)
-
-/* target_ulong is the type of a virtual address */
-#if TARGET_LONG_SIZE == 4
-typedef int32_t target_long;
-typedef uint32_t target_ulong;
-#define TARGET_FMT_lx "%08x"
-#define TARGET_FMT_ld "%d"
-#define TARGET_FMT_lu "%u"
-#elif TARGET_LONG_SIZE == 8
-typedef int64_t target_long;
-typedef uint64_t target_ulong;
-#define TARGET_FMT_lx "%016" PRIx64
-#define TARGET_FMT_ld "%" PRId64
-#define TARGET_FMT_lu "%" PRIu64
-#else
-#error TARGET_LONG_SIZE undefined
-#endif
+#include "exec/target_long.h"
 
 #if !defined(CONFIG_USER_ONLY) && defined(CONFIG_TCG)
 
diff --git a/include/exec/target_long.h b/include/exec/target_long.h
new file mode 100644
index 0000000000..93c9472971
--- /dev/null
+++ b/include/exec/target_long.h
@@ -0,0 +1,42 @@
+/*
+ * Target Long Definitions
+ *
+ * Copyright (c) 2003 Fabrice Bellard
+ * Copyright (c) 2023 Linaro Ltd
+ *
+ * SPDX-License-Identifier: GPL-2.0-or-later
+ */
+
+#ifndef _TARGET_LONG_H_
+#define _TARGET_LONG_H_
+
+/*
+ * Usually this should only be included via cpu-defs.h however for
+ * certain cases where we want to build only two versions of a binary
+ * object we can include directly. However the build-system must
+ * ensure TARGET_LONG_BITS is defined directly.
+ */
+#ifndef TARGET_LONG_BITS
+#error TARGET_LONG_BITS not defined
+#endif
+
+#define TARGET_LONG_SIZE (TARGET_LONG_BITS / 8)
+
+/* target_ulong is the type of a virtual address */
+#if TARGET_LONG_SIZE == 4
+typedef int32_t target_long;
+typedef uint32_t target_ulong;
+#define TARGET_FMT_lx "%08x"
+#define TARGET_FMT_ld "%d"
+#define TARGET_FMT_lu "%u"
+#elif TARGET_LONG_SIZE == 8
+typedef int64_t target_long;
+typedef uint64_t target_ulong;
+#define TARGET_FMT_lx "%016" PRIx64
+#define TARGET_FMT_ld "%" PRId64
+#define TARGET_FMT_lu "%" PRIu64
+#else
+#error TARGET_LONG_SIZE undefined
+#endif
+
+#endif /* _TARGET_LONG_H_ */
-- 
2.39.2



  parent reply	other threads:[~2023-03-07 21:32 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-07 21:21 [PULL 00/30] gdbstub refactor for smaller build Alex Bennée
2023-03-07 21:21 ` [PULL 01/30] gdbstub/internals.h: clean up include guard Alex Bennée
2023-03-07 21:21 ` [PULL 02/30] gdbstub: fix-up copyright and license files Alex Bennée
2023-03-07 21:21 ` [PULL 03/30] gdbstub: Make syscall_complete/[gs]et_reg target-agnostic typedefs Alex Bennée
2023-03-07 21:21 ` [PULL 04/30] gdbstub: clean-up indent on gdb_exit Alex Bennée
2023-03-07 21:21 ` [PULL 05/30] gdbstub: define separate user/system structures Alex Bennée
2023-03-07 21:21 ` [PULL 06/30] gdbstub: move GDBState to shared internals header Alex Bennée
2023-03-07 21:21 ` [PULL 07/30] includes: move tb_flush into its own header Alex Bennée
2023-03-07 21:21 ` [PULL 08/30] gdbstub: move fromhex/tohex routines to internals Alex Bennée
2023-03-07 21:21 ` [PULL 09/30] gdbstub: make various helpers visible to the rest of the module Alex Bennée
2023-03-07 21:21 ` [PULL 10/30] gdbstub: move chunk of softmmu functionality to own file Alex Bennée
2023-03-07 21:21 ` [PULL 11/30] gdbstub: move chunks of user code into own files Alex Bennée
2023-03-07 21:21 ` [PULL 12/30] gdbstub: rationalise signal mapping in softmmu Alex Bennée
2023-03-07 21:21 ` [PULL 13/30] gdbstub: abstract target specific details from gdb_put_packet_binary Alex Bennée
2023-03-07 21:21 ` [PULL 14/30] gdbstub: specialise handle_query_attached Alex Bennée
2023-03-07 21:21 ` [PULL 15/30] gdbstub: specialise target_memory_rw_debug Alex Bennée
2023-03-07 21:21 ` [PULL 16/30] gdbstub: introduce gdb_get_max_cpus Alex Bennée
2023-03-07 21:21 ` [PULL 17/30] gdbstub: specialise stub_can_reverse Alex Bennée
2023-03-07 21:21 ` [PULL 18/30] gdbstub: fix address type of gdb_set_cpu_pc Alex Bennée
2023-03-07 21:21 ` [PULL 19/30] gdbstub: don't use target_ulong while handling registers Alex Bennée
2023-03-07 21:21 ` [PULL 20/30] gdbstub: move register helpers into standalone include Alex Bennée
2023-03-07 21:21 ` [PULL 21/30] gdbstub: move syscall handling to new file Alex Bennée
2023-03-07 21:21 ` [PULL 22/30] gdbstub: only compile gdbstub twice for whole build Alex Bennée
2023-03-23 10:05   ` Philippe Mathieu-Daudé
2023-03-29 16:04     ` Philippe Mathieu-Daudé
2023-03-07 21:21 ` [PULL 23/30] testing: probe gdb for supported architectures ahead of time Alex Bennée
2023-03-07 21:21 ` Alex Bennée [this message]
2023-03-07 21:21 ` [PULL 25/30] gdbstub: split out softmmu/user specifics for syscall handling Alex Bennée
2023-03-07 21:21 ` [PULL 26/30] gdbstub: Remove gdb_do_syscallv Alex Bennée
2023-03-07 21:21 ` [PULL 27/30] gdbstub: Adjust gdb_do_syscall to only use uint32_t and uint64_t Alex Bennée
2023-03-07 21:21 ` [PULL 28/30] stubs: split semihosting_get_target from system only stubs Alex Bennée
2023-03-07 21:21 ` [PULL 29/30] gdbstub: Build syscall.c once Alex Bennée
2023-03-07 21:21 ` [PULL 30/30] gdbstub: move update guest debug to accel ops Alex Bennée
2023-03-09 21:50 ` [PULL 00/30] gdbstub refactor for smaller build Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230307212139.883112-25-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=pbonzini@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).