qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org,
	"Richard Henderson" <richard.henderson@linaro.org>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Alex Bennée" <alex.bennee@linaro.org>
Subject: [PULL 29/30] gdbstub: Build syscall.c once
Date: Tue,  7 Mar 2023 21:21:38 +0000	[thread overview]
Message-ID: <20230307212139.883112-30-alex.bennee@linaro.org> (raw)
In-Reply-To: <20230307212139.883112-1-alex.bennee@linaro.org>

From: Richard Henderson <richard.henderson@linaro.org>

There is no longer anything target specific.

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Message-Id: <20230303025805.625589-29-richard.henderson@linaro.org>

diff --git a/gdbstub/syscalls.c b/gdbstub/syscalls.c
index 9f479010b1..02e3a8f74c 100644
--- a/gdbstub/syscalls.c
+++ b/gdbstub/syscalls.c
@@ -2,9 +2,7 @@
  * GDB Syscall Handling
  *
  * GDB can execute syscalls on the guests behalf, currently used by
- * the various semihosting extensions. As this interfaces with a guest
- * ABI we need to build it per-guest (although in reality its a 32 or
- * 64 bit target_ulong that is the only difference).
+ * the various semihosting extensions.
  *
  * Copyright (c) 2003-2005 Fabrice Bellard
  * Copyright (c) 2023 Linaro Ltd
@@ -14,7 +12,6 @@
 
 #include "qemu/osdep.h"
 #include "qemu/error-report.h"
-#include "cpu.h"
 #include "semihosting/semihost.h"
 #include "sysemu/runstate.h"
 #include "gdbstub/user.h"
diff --git a/gdbstub/meson.build b/gdbstub/meson.build
index d679c7ab86..bd5c5cd67d 100644
--- a/gdbstub/meson.build
+++ b/gdbstub/meson.build
@@ -31,8 +31,7 @@ user_ss.add(gdb_user)
 gdb_softmmu = declare_dependency(link_whole: libgdb_softmmu)
 softmmu_ss.add(gdb_softmmu)
 
-# These have to built to the target ABI
-specific_ss.add(files('syscalls.c'))
+common_ss.add(files('syscalls.c'))
 
 # The user-target is specialised by the guest
 specific_ss.add(when: 'CONFIG_USER_ONLY', if_true: files('user-target.c'))
-- 
2.39.2



  parent reply	other threads:[~2023-03-07 21:31 UTC|newest]

Thread overview: 34+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-07 21:21 [PULL 00/30] gdbstub refactor for smaller build Alex Bennée
2023-03-07 21:21 ` [PULL 01/30] gdbstub/internals.h: clean up include guard Alex Bennée
2023-03-07 21:21 ` [PULL 02/30] gdbstub: fix-up copyright and license files Alex Bennée
2023-03-07 21:21 ` [PULL 03/30] gdbstub: Make syscall_complete/[gs]et_reg target-agnostic typedefs Alex Bennée
2023-03-07 21:21 ` [PULL 04/30] gdbstub: clean-up indent on gdb_exit Alex Bennée
2023-03-07 21:21 ` [PULL 05/30] gdbstub: define separate user/system structures Alex Bennée
2023-03-07 21:21 ` [PULL 06/30] gdbstub: move GDBState to shared internals header Alex Bennée
2023-03-07 21:21 ` [PULL 07/30] includes: move tb_flush into its own header Alex Bennée
2023-03-07 21:21 ` [PULL 08/30] gdbstub: move fromhex/tohex routines to internals Alex Bennée
2023-03-07 21:21 ` [PULL 09/30] gdbstub: make various helpers visible to the rest of the module Alex Bennée
2023-03-07 21:21 ` [PULL 10/30] gdbstub: move chunk of softmmu functionality to own file Alex Bennée
2023-03-07 21:21 ` [PULL 11/30] gdbstub: move chunks of user code into own files Alex Bennée
2023-03-07 21:21 ` [PULL 12/30] gdbstub: rationalise signal mapping in softmmu Alex Bennée
2023-03-07 21:21 ` [PULL 13/30] gdbstub: abstract target specific details from gdb_put_packet_binary Alex Bennée
2023-03-07 21:21 ` [PULL 14/30] gdbstub: specialise handle_query_attached Alex Bennée
2023-03-07 21:21 ` [PULL 15/30] gdbstub: specialise target_memory_rw_debug Alex Bennée
2023-03-07 21:21 ` [PULL 16/30] gdbstub: introduce gdb_get_max_cpus Alex Bennée
2023-03-07 21:21 ` [PULL 17/30] gdbstub: specialise stub_can_reverse Alex Bennée
2023-03-07 21:21 ` [PULL 18/30] gdbstub: fix address type of gdb_set_cpu_pc Alex Bennée
2023-03-07 21:21 ` [PULL 19/30] gdbstub: don't use target_ulong while handling registers Alex Bennée
2023-03-07 21:21 ` [PULL 20/30] gdbstub: move register helpers into standalone include Alex Bennée
2023-03-07 21:21 ` [PULL 21/30] gdbstub: move syscall handling to new file Alex Bennée
2023-03-07 21:21 ` [PULL 22/30] gdbstub: only compile gdbstub twice for whole build Alex Bennée
2023-03-23 10:05   ` Philippe Mathieu-Daudé
2023-03-29 16:04     ` Philippe Mathieu-Daudé
2023-03-07 21:21 ` [PULL 23/30] testing: probe gdb for supported architectures ahead of time Alex Bennée
2023-03-07 21:21 ` [PULL 24/30] include: split target_long definition from cpu-defs Alex Bennée
2023-03-07 21:21 ` [PULL 25/30] gdbstub: split out softmmu/user specifics for syscall handling Alex Bennée
2023-03-07 21:21 ` [PULL 26/30] gdbstub: Remove gdb_do_syscallv Alex Bennée
2023-03-07 21:21 ` [PULL 27/30] gdbstub: Adjust gdb_do_syscall to only use uint32_t and uint64_t Alex Bennée
2023-03-07 21:21 ` [PULL 28/30] stubs: split semihosting_get_target from system only stubs Alex Bennée
2023-03-07 21:21 ` Alex Bennée [this message]
2023-03-07 21:21 ` [PULL 30/30] gdbstub: move update guest debug to accel ops Alex Bennée
2023-03-09 21:50 ` [PULL 00/30] gdbstub refactor for smaller build Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230307212139.883112-30-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).