From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4C7A1C64EC4 for ; Fri, 10 Mar 2023 10:50:53 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1paaJs-0006oy-6u; Fri, 10 Mar 2023 05:49:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1paaJq-0006oc-Dn for qemu-devel@nongnu.org; Fri, 10 Mar 2023 05:49:50 -0500 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1paaJo-000073-IO for qemu-devel@nongnu.org; Fri, 10 Mar 2023 05:49:50 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1678445387; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/h77IWS6eV0YY+SKOsLK+Q6qEEAqhxxL0TrkkhNjp0w=; b=I33OO0rOUQsjZGtEENJjj2kvaqfxlytRbgO0x7b8+cfWWrWRkMmV0z/Syuwci1o0on1Okh ON3mZ2jr1uvOZlsLO8nTHeql6cUieF6RkmqqIJa9q/2++9T6dCK5aWqplX1iJj2In+OUm8 JKpnvNHBLGl4iNpS1E8rV+GkOdYCULE= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-133-_a8dPWmHMCaQRfR5ix8IfQ-1; Fri, 10 Mar 2023 05:49:46 -0500 X-MC-Unique: _a8dPWmHMCaQRfR5ix8IfQ-1 Received: by mail-wm1-f72.google.com with SMTP id p22-20020a7bcc96000000b003e2036a1516so3679714wma.7 for ; Fri, 10 Mar 2023 02:49:46 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1678445385; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/h77IWS6eV0YY+SKOsLK+Q6qEEAqhxxL0TrkkhNjp0w=; b=yiZHoEgQPNNL0HL2nwmAOISStu8K29hLvoMMLjNbBMhr2qVEqEGcNH/nbte+o83lip Nxh8qTqN1y4wP6hfUUSU+I1b0WpHUu5hcUo34n5tjaGFBTOkeiaOBocaxS1SGzP3c4LB RQiJkI2RALVAVQyTKbQ6lI/2SgBmx9w6nLPTejiynWs1yntPAp6zTrNbpCdNMAPdEVWg tBLQrQGE1zpeE8CApGvw50UKB3jMJokEHS1S0k9WjLeFpWdXBR8wXQaAtoG9PwCgANID UVFdDXjitOPt7nJBuK2c0TzLP5Rv8thv+JAVh+I6CyKDcsIwedauZ3Y9xtzMsZ+VMJWC Scww== X-Gm-Message-State: AO0yUKUZfKxdH0fxLH1GEYKg+nnwUq3HHEaEeSOneTeXKfSvm+OXh+lm RKuXyOB9ePmhSQe+peUqjg1Om26vr7DeILxmE8lvXj05H8JxMYFgdgrkHmoxcUZwgqIUQMC+s+4 dPBIiF63XHsR8WFI= X-Received: by 2002:a5d:410a:0:b0:2c5:594b:10d6 with SMTP id l10-20020a5d410a000000b002c5594b10d6mr16459794wrp.29.1678445385378; Fri, 10 Mar 2023 02:49:45 -0800 (PST) X-Google-Smtp-Source: AK7set8EQ8Vldz1gjr9RiZW+964qplEukhpvPiqSr391sEPqIm9Gmv/Jjbtro6T+ZupQ8VB2QwOiZQ== X-Received: by 2002:a5d:410a:0:b0:2c5:594b:10d6 with SMTP id l10-20020a5d410a000000b002c5594b10d6mr16459779wrp.29.1678445385078; Fri, 10 Mar 2023 02:49:45 -0800 (PST) Received: from redhat.com ([2.52.9.88]) by smtp.gmail.com with ESMTPSA id i3-20020adfe483000000b002c7b229b1basm1849916wrm.15.2023.03.10.02.49.42 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Mar 2023 02:49:44 -0800 (PST) Date: Fri, 10 Mar 2023 05:49:40 -0500 From: "Michael S. Tsirkin" To: Maxime Coquelin Cc: Eugenio Perez Martin , Jason Wang , Cindy Lu , Stefano Garzarella , qemu-level , Laurent Vivier , Juan Quintela , Eelco Chaudron Subject: Re: Emulating device configuration / max_virtqueue_pairs in vhost-vdpa and vhost-user Message-ID: <20230310054745-mutt-send-email-mst@kernel.org> References: <6684066f-452d-a8b3-58b2-b0db2a3c2015@redhat.com> <20230201061709-mutt-send-email-mst@kernel.org> <6e98c7a2-bab8-e91f-1718-cc8d5d6e8ddf@redhat.com> <20230308071529-mutt-send-email-mst@kernel.org> <29f5522c-c305-9bf5-3283-e096b38261ef@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <29f5522c-c305-9bf5-3283-e096b38261ef@redhat.com> Received-SPF: pass client-ip=170.10.129.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Fri, Mar 10, 2023 at 11:33:42AM +0100, Maxime Coquelin wrote: > > > On 3/8/23 13:15, Michael S. Tsirkin wrote: > > On Wed, Mar 08, 2023 at 11:33:45AM +0100, Maxime Coquelin wrote: > > > Hello Michael, > > > > > > On 2/1/23 12:20, Michael S. Tsirkin wrote: > > > > On Wed, Feb 01, 2023 at 12:14:18PM +0100, Maxime Coquelin wrote: > > > > > Thanks Eugenio for working on this. > > > > > > > > > > On 1/31/23 20:10, Eugenio Perez Martin wrote: > > > > > > Hi, > > > > > > > > > > > > The current approach of offering an emulated CVQ to the guest and map > > > > > > the commands to vhost-user is not scaling well: > > > > > > * Some devices already offer it, so the transformation is redundant. > > > > > > * There is no support for commands with variable length (RSS?) > > > > > > > > > > > > We can solve both of them by offering it through vhost-user the same > > > > > > way as vhost-vdpa do. With this approach qemu needs to track the > > > > > > commands, for similar reasons as vhost-vdpa: qemu needs to track the > > > > > > device status for live migration. vhost-user should use the same SVQ > > > > > > code for this, so we avoid duplications. > > > > > > > > > > > > One of the challenges here is to know what virtqueue to shadow / > > > > > > isolate. The vhost-user device may not have the same queues as the > > > > > > device frontend: > > > > > > * The first depends on the actual vhost-user device, and qemu fetches > > > > > > it with VHOST_USER_GET_QUEUE_NUM at the moment. > > > > > > * The qemu device frontend's is set by netdev queues= cmdline parameter in qemu > > > > > > > > > > > > For the device, the CVQ is the last one it offers, but for the guest > > > > > > it is the last one offered in config space. > > > > > > > > > > > > To create a new vhost-user command to decrease that maximum number of > > > > > > queues may be an option. But we can do it without adding more > > > > > > commands, remapping the CVQ index at virtqueue setup. I think it > > > > > > should be doable using (struct vhost_dev).vq_index and maybe a few > > > > > > adjustments here and there. > > > > > > > > > > > > Thoughts? > > > > > > > > > > I am fine with both proposals. > > > > > I think index remapping will require a bit more rework in the DPDK > > > > > Vhost-user library, but nothing insurmountable. > > > > > > > > > > I am currently working on a PoC adding support for VDUSE in the DPDK > > > > > Vhost library, and recently added control queue support. We can reuse it > > > > > if we want to prototype your proposal. > > > > > > > > > > Maxime > > > > > > > > > > > Thanks! > > > > > > > > > > > > > > > > > > technically backend knows how many vqs are there, last one is cvq... > > > > not sure we need full blown remapping ... > > > > > > > > > > Before VHOST_USER_PROTOCOL_F_STATUS was supported by qemu (very > > > recently, v7.2.0), we had no way for the backend to be sure the > > > frontend won't configure new queue pairs, this not not defined in the > > > spec AFAICT [0]. In DPDK Vhost library, we notify the application it can > > > start to use the device once the first queue pair is setup and enabled, > > > then we notify the application when new queues are ready to be > > > processed. In this case, I think we cannot deduce whether the queue is a > > > data or a control queue when it is setup. > > > > > > When VHOST_USER_PROTOCOL_F_STATUS is supported, we know no more queues > > > will be configured once the DRIVER_OK status is set. In this case, we > > > can deduce the last queue setup will be the control queue at DRIVER_OK > > > time if the number of queues is odd. > > > > > > Using index remapping, we would know directly at queue setup time > > > whether this is a data or control queue based on its index value, > > > i.e. if the index equals to max queue index supported by the backend. > > > But thinking at it again, we may at least back this with a protocol > > > feature to avoid issues with legacy backends. > > > > > > I hope it clarifies, let me know if anything unclear. > > > > > > Thanks, > > > Maxime > > > > > > [0]: > > > https://elixir.bootlin.com/qemu/latest/source/docs/interop/vhost-user.rst > > > > > > OK maybe document this. > > Sure, working on it... But I just found a discrepancy related to > VHOST_USER_GET_QUEUE_NUM between the spec and the frontend/backend > implementations. > > In the spec [0], VHOST_USER_GET_QUEUE_NUM reply is the number of queues. > In Qemu Vhost-user Net frontend [1], VHOST_USER_GET_QUEUE_NUM is handled > as the number of queue *pairs*, and so does the DPDK Vhost library. > Vhost-user-bridge Qemu test application handles it as the number of queues. weird how does Vhost-user-bridge work then? I guess it just ignores the extra queues that were not inited? > Other device types seem to handle it as the number of queues, which > makes sense since they don't have the notion of queue pair. > > Fixing the QEMU and DPDK implementations would require a new protocol > feature bit not to break compatibility with older versions. > > So maybe we should add in the spec that for network devices, > VHOST_USER_GET_QUEUE_NUM reply represents the number of queue pairs, and > also fix vhost-user-bridge to reply with the number of queue pairs? > > Maxime Not sure we need to fix vhost-user-bridge - it seems to work? In any case let's add a protocol feature to fix it for net maybe? > [0]: https://elixir.bootlin.com/qemu/latest/source/docs/interop/vhost-user.rst#L1091 > [1]: https://elixir.bootlin.com/qemu/latest/source/net/vhost-user.c#L69