From: Markus Armbruster <armbru@redhat.com>
To: qemu-devel@nongnu.org
Cc: michael.roth@amd.com, marcandre.lureau@redhat.com,
berrange@redhat.com, eblake@redhat.com, jsnow@redhat.com
Subject: [PATCH 00/14] qapi: Fix minor bugs, require boxed for conditional arguments
Date: Thu, 16 Mar 2023 08:13:11 +0100 [thread overview]
Message-ID: <20230316071325.492471-1-armbru@redhat.com> (raw)
PATCH 01-08 fix a few minor bugs I found on the way. Could be a
separate series, but keeping them here seems simpler.
PATCH 09-12 improve tests for 'if' conditionals.
PATCH 13 fixes a code generation regression, and PATCH 14 rejects uses
conditionals that never worked and aren't worth fixing.
Markus Armbruster (14):
qapi: Fix error message format regression
qapi/schema: Use super()
qapi: Clean up after removal of simple unions
qapi: Split up check_type()
qapi: Improve error message for unexpected array types
qapi: Simplify code a bit after previous commit
qapi: Fix error message when type name or array is expected
qapi: Fix to reject 'data': 'mumble' in struct
tests/qapi-schema: Improve union discriminator coverage
tests/qapi-schema: Rename a few conditionals
tests/qapi-schema: Clean up positive test for conditionals
tests/qapi-schema: Cover optional conditional struct member
qapi: Fix code generated for optional conditional struct member
qapi: Require boxed for conditional command and event arguments
docs/devel/qapi-code-gen.rst | 5 +-
scripts/qapi/commands.py | 1 +
scripts/qapi/expr.py | 115 ++++++++++--------
scripts/qapi/gen.py | 1 +
scripts/qapi/main.py | 2 +-
scripts/qapi/schema.py | 16 ++-
scripts/qapi/visit.py | 2 +
tests/qapi-schema/args-if-implicit.err | 2 +
tests/qapi-schema/args-if-implicit.json | 4 +
tests/qapi-schema/args-if-implicit.out | 0
tests/qapi-schema/args-if-unboxed.err | 2 +
tests/qapi-schema/args-if-unboxed.json | 6 +
tests/qapi-schema/args-if-unboxed.out | 0
tests/qapi-schema/bad-data.err | 2 +-
tests/qapi-schema/event-args-if-unboxed.err | 2 +
tests/qapi-schema/event-args-if-unboxed.json | 4 +
tests/qapi-schema/event-args-if-unboxed.out | 0
tests/qapi-schema/event-nest-struct.err | 2 +-
tests/qapi-schema/meson.build | 3 +
tests/qapi-schema/nested-struct-data.err | 2 +-
tests/qapi-schema/qapi-schema-test.json | 20 +--
tests/qapi-schema/qapi-schema-test.out | 32 ++---
tests/qapi-schema/returns-dict.err | 2 +-
tests/qapi-schema/struct-data-typename.err | 2 +
tests/qapi-schema/struct-data-typename.json | 2 +
tests/qapi-schema/struct-data-typename.out | 0
tests/qapi-schema/struct-member-invalid.err | 2 +-
tests/qapi-schema/union-array-branch.err | 2 +-
.../union-invalid-discriminator.err | 2 +-
.../union-invalid-discriminator.json | 4 +-
30 files changed, 141 insertions(+), 98 deletions(-)
create mode 100644 tests/qapi-schema/args-if-implicit.err
create mode 100644 tests/qapi-schema/args-if-implicit.json
create mode 100644 tests/qapi-schema/args-if-implicit.out
create mode 100644 tests/qapi-schema/args-if-unboxed.err
create mode 100644 tests/qapi-schema/args-if-unboxed.json
create mode 100644 tests/qapi-schema/args-if-unboxed.out
create mode 100644 tests/qapi-schema/event-args-if-unboxed.err
create mode 100644 tests/qapi-schema/event-args-if-unboxed.json
create mode 100644 tests/qapi-schema/event-args-if-unboxed.out
create mode 100644 tests/qapi-schema/struct-data-typename.err
create mode 100644 tests/qapi-schema/struct-data-typename.json
create mode 100644 tests/qapi-schema/struct-data-typename.out
--
2.39.2
next reply other threads:[~2023-03-16 7:15 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-16 7:13 Markus Armbruster [this message]
2023-03-16 7:13 ` [PATCH 01/14] qapi: Fix error message format regression Markus Armbruster
2023-03-16 21:56 ` Eric Blake
2023-03-16 7:13 ` [PATCH 02/14] qapi/schema: Use super() Markus Armbruster
2023-03-16 7:40 ` Philippe Mathieu-Daudé
2023-03-16 7:13 ` [PATCH 03/14] qapi: Clean up after removal of simple unions Markus Armbruster
2023-03-17 0:38 ` Eric Blake
2023-03-16 7:13 ` [PATCH 04/14] qapi: Split up check_type() Markus Armbruster
2023-03-17 0:53 ` Eric Blake
2023-03-17 5:36 ` Markus Armbruster
2023-03-16 7:13 ` [PATCH 05/14] qapi: Improve error message for unexpected array types Markus Armbruster
2023-03-16 7:41 ` Philippe Mathieu-Daudé
2023-03-16 7:13 ` [PATCH 06/14] qapi: Simplify code a bit after previous commit Markus Armbruster
2023-03-17 0:55 ` Eric Blake
2023-03-17 5:42 ` Markus Armbruster
2023-03-16 7:13 ` [PATCH 07/14] qapi: Fix error message when type name or array is expected Markus Armbruster
2023-03-17 0:57 ` Eric Blake
2023-03-16 7:13 ` [PATCH 08/14] qapi: Fix to reject 'data': 'mumble' in struct Markus Armbruster
2023-03-17 1:02 ` Eric Blake
2023-03-17 5:48 ` Markus Armbruster
2023-03-16 7:13 ` [PATCH 09/14] tests/qapi-schema: Improve union discriminator coverage Markus Armbruster
2023-03-17 1:06 ` Eric Blake
2023-03-17 5:51 ` Markus Armbruster
2023-03-16 7:13 ` [PATCH 10/14] tests/qapi-schema: Rename a few conditionals Markus Armbruster
2023-03-16 7:45 ` Philippe Mathieu-Daudé
2023-03-16 7:13 ` [PATCH 11/14] tests/qapi-schema: Clean up positive test for conditionals Markus Armbruster
2023-03-17 1:09 ` Eric Blake
2023-03-17 6:10 ` Markus Armbruster
2023-03-17 12:29 ` Eric Blake
2023-03-17 14:14 ` Markus Armbruster
2023-03-16 7:13 ` [PATCH 12/14] tests/qapi-schema: Cover optional conditional struct member Markus Armbruster
2023-03-16 7:45 ` Philippe Mathieu-Daudé
2023-03-16 7:13 ` [PATCH 13/14] qapi: Fix code generated for " Markus Armbruster
2023-03-17 1:13 ` Eric Blake
2023-03-16 7:13 ` [PATCH 14/14] qapi: Require boxed for conditional command and event arguments Markus Armbruster
2023-03-17 1:17 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230316071325.492471-1-armbru@redhat.com \
--to=armbru@redhat.com \
--cc=berrange@redhat.com \
--cc=eblake@redhat.com \
--cc=jsnow@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=michael.roth@amd.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).