From: Bernhard Beschow <shentey@gmail.com>
To: qemu-devel@nongnu.org
Cc: "Gerd Hoffmann" <kraxel@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Bernhard Beschow" <shentey@gmail.com>
Subject: [PATCH for-8.0] Revert "ui: set cursor position upon listener registration"
Date: Sat, 18 Mar 2023 18:31:32 +0100 [thread overview]
Message-ID: <20230318173132.98068-1-shentey@gmail.com> (raw)
Commit 6effaa16ac98 ("ui: set cursor position upon listener registration")
causes the mouse cursor to be placed into the lower left corner when QEMU
starts. This could be reproduced with just by running
`qemu-system-x86_64`.
This reverts commit 6effaa16ac9846e7d6197ee54a0551fba61aecd7.
Signed-off-by: Bernhard Beschow <shentey@gmail.com>
---
ui/console.c | 7 -------
1 file changed, 7 deletions(-)
diff --git a/ui/console.c b/ui/console.c
index f3783021e5..35f8274aab 100644
--- a/ui/console.c
+++ b/ui/console.c
@@ -95,7 +95,6 @@ struct QemuConsole {
QemuUIInfo ui_info;
QEMUTimer *ui_timer;
QEMUCursor *cursor;
- int cursor_x, cursor_y, cursor_on;
const GraphicHwOps *hw_ops;
void *hw;
@@ -1666,9 +1665,6 @@ void register_displaychangelistener(DisplayChangeListener *dcl)
if (con && con->cursor && dcl->ops->dpy_cursor_define) {
dcl->ops->dpy_cursor_define(dcl, con->cursor);
}
- if (con && dcl->ops->dpy_mouse_set) {
- dcl->ops->dpy_mouse_set(dcl, con->cursor_x, con->cursor_y, con->cursor_on);
- }
text_console_update_cursor(NULL);
}
@@ -1913,9 +1909,6 @@ void dpy_mouse_set(QemuConsole *con, int x, int y, int on)
DisplayState *s = con->ds;
DisplayChangeListener *dcl;
- con->cursor_x = x;
- con->cursor_y = y;
- con->cursor_on = on;
if (!qemu_console_is_visible(con)) {
return;
}
--
2.40.0
next reply other threads:[~2023-03-18 17:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-18 17:31 Bernhard Beschow [this message]
2023-03-19 11:11 ` [PATCH for-8.0] Revert "ui: set cursor position upon listener registration" Marc-André Lureau
2023-03-19 12:24 ` Bernhard Beschow
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230318173132.98068-1-shentey@gmail.com \
--to=shentey@gmail.com \
--cc=kraxel@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).