* [PATCH-for-8.1] target/m68k/fpu_helper: Use FloatRelation enum to hold comparison result
@ 2023-03-21 9:49 Philippe Mathieu-Daudé
2023-03-21 15:01 ` Richard Henderson
0 siblings, 1 reply; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-03-21 9:49 UTC (permalink / raw)
To: qemu-devel
Cc: Laurent Vivier, qemu-trivial, Philippe Mathieu-Daudé,
Cédric Le Goater
Use the FloatRelation enum to hold the comparison result (missed
in commit 71bfd65c5f "softfloat: Name compare relation enum").
Inspired-by: Cédric Le Goater <clg@kaod.org>
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
target/m68k/fpu_helper.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/target/m68k/fpu_helper.c b/target/m68k/fpu_helper.c
index 3a37d8f584..ab120b5f59 100644
--- a/target/m68k/fpu_helper.c
+++ b/target/m68k/fpu_helper.c
@@ -349,7 +349,7 @@ void HELPER(fsgldiv)(CPUM68KState *env, FPReg *res, FPReg *val0, FPReg *val1)
PREC_END();
}
-static int float_comp_to_cc(int float_compare)
+static int float_comp_to_cc(FloatRelation float_compare)
{
switch (float_compare) {
case float_relation_equal:
@@ -367,7 +367,7 @@ static int float_comp_to_cc(int float_compare)
void HELPER(fcmp)(CPUM68KState *env, FPReg *val0, FPReg *val1)
{
- int float_compare;
+ FloatRelation float_compare;
float_compare = floatx80_compare(val1->d, val0->d, &env->fp_status);
env->fpsr = (env->fpsr & ~FPSR_CC_MASK) | float_comp_to_cc(float_compare);
--
2.38.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH-for-8.1] target/m68k/fpu_helper: Use FloatRelation enum to hold comparison result
2023-03-21 9:49 [PATCH-for-8.1] target/m68k/fpu_helper: Use FloatRelation enum to hold comparison result Philippe Mathieu-Daudé
@ 2023-03-21 15:01 ` Richard Henderson
0 siblings, 0 replies; 2+ messages in thread
From: Richard Henderson @ 2023-03-21 15:01 UTC (permalink / raw)
To: Philippe Mathieu-Daudé, qemu-devel
Cc: Laurent Vivier, qemu-trivial, Cédric Le Goater
On 3/21/23 02:49, Philippe Mathieu-Daudé wrote:
> Use the FloatRelation enum to hold the comparison result (missed
> in commit 71bfd65c5f "softfloat: Name compare relation enum").
>
> Inspired-by: Cédric Le Goater<clg@kaod.org>
> Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
> ---
> target/m68k/fpu_helper.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
r~
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-21 15:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-03-21 9:49 [PATCH-for-8.1] target/m68k/fpu_helper: Use FloatRelation enum to hold comparison result Philippe Mathieu-Daudé
2023-03-21 15:01 ` Richard Henderson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).