From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Yonggang Luo" <luoyonggang@gmail.com>,
"Jintao Yin" <nicememory@gmail.com>,
"Thomas Huth" <thuth@redhat.com>,
qemu-trivial@nongnu.org,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PATCH] cirrus.yml: Cover SPICE in the MSYS2 job
Date: Wed, 22 Mar 2023 12:05:21 +0100 [thread overview]
Message-ID: <20230322110521.59949-1-philmd@linaro.org> (raw)
Include the mingw-w64-x86_64-spice package so SPICE is covered:
C compiler for the host machine: cc -m64 -mcx16 (gcc 12.2.0 "cc (Rev10, Built by MSYS2 project) 12.2.0")
...
Run-time dependency spice-protocol found: YES 0.14.4
Run-time dependency spice-server found: YES 0.15.1
In particular this would have helped catching the build issue
reported as https://gitlab.com/qemu-project/qemu/-/issues/1553:
[1851/5253] Compiling C object libcommon.fa.p/ui_spice-core.c.obj
FAILED: libcommon.fa.p/ui_spice-core.c.obj
../ui/spice-core.c: In function 'watch_remove':
../ui/spice-core.c:152:5: error: implicit declaration of function 'qemu_close_to_socket' [-Werror=implicit-function-declaration]
152 | qemu_close_to_socket(watch->fd);
| ^~~~~~~~~~~~~~~~~~~~
../ui/spice-core.c:152:5: error: nested extern declaration of 'qemu_close_to_socket' [-Werror=nested-externs]
Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
See https://cirrus-ci.com/task/6189732569284608?logs=main#L891
Based-on: <20230322075256.2043812-1-marcandre.lureau@redhat.com>
---
.cirrus.yml | 1 +
1 file changed, 1 insertion(+)
diff --git a/.cirrus.yml b/.cirrus.yml
index 5fb00da73d..eb1640814d 100644
--- a/.cirrus.yml
+++ b/.cirrus.yml
@@ -41,6 +41,7 @@ windows_msys2_task:
mingw-w64-x86_64-curl
mingw-w64-x86_64-gnutls
mingw-w64-x86_64-libnfs
+ mingw-w64-x86_64-spice
"
CHERE_INVOKING: 1
msys2_cache:
--
2.38.1
next reply other threads:[~2023-03-22 11:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 11:05 Philippe Mathieu-Daudé [this message]
2023-03-22 11:30 ` [PATCH] cirrus.yml: Cover SPICE in the MSYS2 job Thomas Huth
2023-03-22 12:13 ` Philippe Mathieu-Daudé
2023-03-22 12:21 ` Daniel P. Berrangé
2023-03-22 12:26 ` Thomas Huth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230322110521.59949-1-philmd@linaro.org \
--to=philmd@linaro.org \
--cc=luoyonggang@gmail.com \
--cc=marcandre.lureau@redhat.com \
--cc=nicememory@gmail.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).