From: Florian Westphal <fw@strlen.de>
To: Eric Blake <eblake@redhat.com>
Cc: Florian Westphal <fw@strlen.de>,
libguestfs@redhat.com, qemu-devel@nongnu.org,
qemu-block@nongnu.org, vsementsov@yandex-team.ru
Subject: Re: [Libguestfs] [PATCH 1/1] nbd/server: push pending frames after sending reply
Date: Sat, 25 Mar 2023 00:55:47 +0100 [thread overview]
Message-ID: <20230324235547.GC17250@breakpoint.cc> (raw)
In-Reply-To: <spo7scw4pvcloaoezcfdmssgg34unwqewoavs32tvaxuht3vns@4kjvbzlmuer5>
Eric Blake <eblake@redhat.com> wrote:
> On Fri, Mar 24, 2023 at 02:41:20PM -0500, Eric Blake wrote:
> > On Fri, Mar 24, 2023 at 11:47:20AM +0100, Florian Westphal wrote:
> > > qemu-nbd doesn't set TCP_NODELAY on the tcp socket.
>
> Replying to myself, WHY aren't we setting TCP_NODELAY on the socket?
If the application protocol is strictly or mostly request/response then
I agree that qemu-nbd should turn nagle off as well.
next prev parent reply other threads:[~2023-03-24 23:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-24 10:47 [PATCH 1/1] nbd/server: push pending frames after sending reply Florian Westphal
2023-03-24 17:20 ` Kevin Wolf
2023-03-24 18:20 ` Florian Westphal
2023-03-24 19:43 ` Eric Blake
2023-03-24 19:41 ` Eric Blake
2023-03-24 20:03 ` [Libguestfs] " Eric Blake
2023-03-24 23:55 ` Florian Westphal [this message]
2023-03-27 11:44 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230324235547.GC17250@breakpoint.cc \
--to=fw@strlen.de \
--cc=eblake@redhat.com \
--cc=libguestfs@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).