* [PATCH V2] tracing: install trace events file only if necessary @ 2023-03-27 17:30 casantos 2023-03-27 17:59 ` Daniel P. Berrangé 0 siblings, 1 reply; 3+ messages in thread From: casantos @ 2023-03-27 17:30 UTC (permalink / raw) To: qemu-devel, qemu-trivial; +Cc: Carlos Santos From: Carlos Santos <casantos@redhat.com> It is not useful when configuring with --enable-trace-backends=nop. Signed-off-by: Carlos Santos <casantos@redhat.com> --- Changes v1->v2: Install based on chosen trace backend, not on chosen emulators. --- trace/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/trace/meson.build b/trace/meson.build index 8e80be895c..3d96b4eea0 100644 --- a/trace/meson.build +++ b/trace/meson.build @@ -64,7 +64,7 @@ trace_events_all = custom_target('trace-events-all', input: trace_events_files, command: [ 'cat', '@INPUT@' ], capture: true, - install: true, + install: get_option('trace_backends') != 'nop' install_dir: qemu_datadir) if 'ust' in get_option('trace_backends') -- 2.31.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH V2] tracing: install trace events file only if necessary 2023-03-27 17:30 [PATCH V2] tracing: install trace events file only if necessary casantos @ 2023-03-27 17:59 ` Daniel P. Berrangé 2023-04-08 9:21 ` Carlos Santos 0 siblings, 1 reply; 3+ messages in thread From: Daniel P. Berrangé @ 2023-03-27 17:59 UTC (permalink / raw) To: casantos; +Cc: qemu-devel, qemu-trivial On Mon, Mar 27, 2023 at 02:30:58PM -0300, casantos@redhat.com wrote: > From: Carlos Santos <casantos@redhat.com> > > It is not useful when configuring with --enable-trace-backends=nop. > > Signed-off-by: Carlos Santos <casantos@redhat.com> > --- Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> With regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH V2] tracing: install trace events file only if necessary 2023-03-27 17:59 ` Daniel P. Berrangé @ 2023-04-08 9:21 ` Carlos Santos 0 siblings, 0 replies; 3+ messages in thread From: Carlos Santos @ 2023-04-08 9:21 UTC (permalink / raw) To: Daniel P. Berrangé; +Cc: qemu-devel, qemu-trivial On Mon, Mar 27, 2023 at 2:59 PM Daniel P. Berrangé <berrange@redhat.com> wrote: > > On Mon, Mar 27, 2023 at 02:30:58PM -0300, casantos@redhat.com wrote: > > From: Carlos Santos <casantos@redhat.com> > > > > It is not useful when configuring with --enable-trace-backends=nop. > > > > Signed-off-by: Carlos Santos <casantos@redhat.com> > > --- > > Reviewed-by: Daniel P. Berrangé <berrange@redhat.com> > > > With regards, > Daniel > -- > |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| > |: https://libvirt.org -o- https://fstop138.berrange.com :| > |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :| > I updated the patch to fix the array comparison and add a missing comma. -- Carlos Santos Senior Software Maintenance Engineer Red Hat casantos@redhat.com T: +55-11-3534-6186 ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-08 9:23 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2023-03-27 17:30 [PATCH V2] tracing: install trace events file only if necessary casantos 2023-03-27 17:59 ` Daniel P. Berrangé 2023-04-08 9:21 ` Carlos Santos
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).