From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AD560C761A6 for ; Thu, 30 Mar 2023 14:11:50 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1pht03-00051t-7T; Thu, 30 Mar 2023 10:11:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1pht00-00051g-L8 for qemu-devel@nongnu.org; Thu, 30 Mar 2023 10:11:32 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1phszx-0000vY-UI for qemu-devel@nongnu.org; Thu, 30 Mar 2023 10:11:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680185489; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Q8Oxxlisc2op1A7/MGmyhDOusAtAga3utK3yR7JXwBk=; b=A9OW3PgilDAMuOQczJt+rBbajWzG+UuzjlxW04FH7FF7v/2c/Kt0xwb3afKvOf3RUQFfNE GiU/3j32KOgOjFtI7yG+NYQZetPPQu39EZcggNku4R74T4Z8OU+kiuN4Z8B0ms/oSZsSKh zK9BGclGTh/1Lf/P/MyXLjuEmyQoTuU= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-155-l69ltTj5Mrqj734RXUxAIw-1; Thu, 30 Mar 2023 10:11:28 -0400 X-MC-Unique: l69ltTj5Mrqj734RXUxAIw-1 Received: by mail-wm1-f69.google.com with SMTP id o28-20020a05600c511c00b003ef69894934so6525708wms.6 for ; Thu, 30 Mar 2023 07:11:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; t=1680185487; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Q8Oxxlisc2op1A7/MGmyhDOusAtAga3utK3yR7JXwBk=; b=B7h97sCEMc8cR5GEcdyijCxFjfdMYtI+14WBGFL1n3BMpW4bQbgaQl0p18exQmGG5x 4QDX/O6K/VdRxfO067G4FNV1b2VCKqMFQSpruqsN5AgSKRqV+wApCp0IJ1ycHXKfrB4q gasegoIDNDMzfJCpPABW3ariXl3VeZT/EinpfnDQusy1K56PoQgq1SSXVjBkAJ8X4LkR a5ae/JMsvn1BJviRKk25U/DomO/iTTHYOzxtclmWIIDnKQxtV0pkCuYF9omoFaxItznc pAidQ4kA+qErAR2wsdVfsMhlSH5uMxdompegkp2xaxjFaR0L/bSt0Vmm2UGvziAzDBTK pxCg== X-Gm-Message-State: AAQBX9ezVGYrL8KTPIqrbYvqqon8hhu2YQm9r8Gqte1XJC6Z1CyzjZXY mBGPqB4bhoh1kJKhjAFZWWehh10eDJXLilGekyWBwl0vfPX19Q0v1V1zqYkyVY3eXKGYd3zMoZQ uLD3o1RnQRTse8NU= X-Received: by 2002:a1c:4c18:0:b0:3ef:7584:9896 with SMTP id z24-20020a1c4c18000000b003ef75849896mr7736798wmf.26.1680185486954; Thu, 30 Mar 2023 07:11:26 -0700 (PDT) X-Google-Smtp-Source: AKy350bOEo0qNuIR5V7eVuUNdVdg6nlQ2TDk6p3Fq46nUUpavsHDhIGscXVKPtKss9moECGkBJeBwQ== X-Received: by 2002:a1c:4c18:0:b0:3ef:7584:9896 with SMTP id z24-20020a1c4c18000000b003ef75849896mr7736778wmf.26.1680185486667; Thu, 30 Mar 2023 07:11:26 -0700 (PDT) Received: from redhat.com ([2.52.159.107]) by smtp.gmail.com with ESMTPSA id l32-20020a05600c1d2000b003f0321c22basm4843075wms.12.2023.03.30.07.11.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Mar 2023 07:11:26 -0700 (PDT) Date: Thu, 30 Mar 2023 10:11:22 -0400 From: "Michael S. Tsirkin" To: Ani Sinha Cc: Eric DeVolder , shannon.zhaosl@gmail.com, imammedo@redhat.com, peter.maydell@linaro.org, qemu-arm@nongnu.org, qemu-devel@nongnu.org, marcel.apfelbaum@gmail.com, pbonzini@redhat.com, richard.henderson@linaro.org, eduardo@habkost.net, boris.ostrovsky@oracle.com Subject: Re: [PATCH 0/2] hw/acpi: bump MADT to revision 5 Message-ID: <20230330101052-mutt-send-email-mst@kernel.org> References: <20230328155926.2277-1-eric.devolder@oracle.com> <20230329010406-mutt-send-email-mst@kernel.org> <96144a1b-efa7-ecc2-3e35-56825fcf48c6@oracle.com> <20230329124442-mutt-send-email-mst@kernel.org> <68579d53-cbb5-154a-6c1e-e733f16540@anisinha.ca> <20230330094323-mutt-send-email-mst@kernel.org> <366bb156-f41f-e1c4-fc59-3ecca6eeaba7@anisinha.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <366bb156-f41f-e1c4-fc59-3ecca6eeaba7@anisinha.ca> Received-SPF: pass client-ip=170.10.129.124; envelope-from=mst@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org On Thu, Mar 30, 2023 at 07:32:59PM +0530, Ani Sinha wrote: > > > On Thu, 30 Mar 2023, Michael S. Tsirkin wrote: > > > On Thu, Mar 30, 2023 at 01:06:36PM +0530, Ani Sinha wrote: > > > > > > > > > On Wed, 29 Mar 2023, Michael S. Tsirkin wrote: > > > > > > > On Wed, Mar 29, 2023 at 08:14:37AM -0500, Eric DeVolder wrote: > > > > > > > > > > > > > > > On 3/29/23 00:19, Michael S. Tsirkin wrote: > > > > > > Hmm I don't think we can reasonably make such a change for 8.0. > > > > > > Seems too risky. > > > > > > Also, I feel we want to have an internal (with "x-" prefix") flag to > > > > > > revert to old behaviour, in case of breakage on some guests. and maybe > > > > > > we want to keep old revision for old machine types. > > > > > Ok, what option name, for keeping old behavior, would you like? > > > > > > > > Don't much care. x-madt-rev? > > > > > > > > > > > > > > > > > > > > > > On Tue, Mar 28, 2023 at 11:59:24AM -0400, Eric DeVolder wrote: > > > > > > > The following Linux kernel change broke CPU hotplug for MADT revision > > > > > > > less than 5. > > > > > > > > > > > > > > commit e2869bd7af60 ("x86/acpi/boot: Do not register processors that cannot be onlined for x2APIC") > > > > > > > > > > > > Presumably it's being fixed? Link to discussion? Patch fixing that in > > > > > > Linux? > > > > > > > > > > https://lore.kernel.org/linux-acpi/20230327191026.3454-1-eric.devolder@oracle.com/T/#t > > > > > > > > Great! Maybe stick a Link: tag in the commit log. > > > > > > If the original bug is in the kernel and kernel upstream has accepted both > > > your fix and Mario's patch on the acpi revision mess, I see no urgency to > > > fix this in QEMU. > > > > > > Maybe we can address this in the 8.1 development window. > > > > Why "maybe"? Eric is working on a patch I don't see why we won't > > address it. > > > > I am not opposed to addressing it. I just think it might be too risky for > 8.0 given that we are already past the hard feature freeze date. This does not look to me like a justified change for 8.0. We have rev = 1 for years. -- MST