* [RFC PATCH] hw/intc: don't use target_ulong for LoongArch ipi
@ 2023-04-04 13:27 Alex Bennée
2023-04-04 14:20 ` Philippe Mathieu-Daudé
2023-04-07 2:11 ` gaosong
0 siblings, 2 replies; 3+ messages in thread
From: Alex Bennée @ 2023-04-04 13:27 UTC (permalink / raw)
To: qemu-devel; +Cc: Alex Bennée, Xiaojuan Yang, Song Gao
The calling function is already working with hwaddr and uint64_t so
lets avoid bringing target_ulong in if we don't need to.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
hw/intc/loongarch_ipi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/intc/loongarch_ipi.c b/hw/intc/loongarch_ipi.c
index aa4bf9eb74..bdba0f8107 100644
--- a/hw/intc/loongarch_ipi.c
+++ b/hw/intc/loongarch_ipi.c
@@ -50,7 +50,7 @@ static uint64_t loongarch_ipi_readl(void *opaque, hwaddr addr, unsigned size)
return ret;
}
-static void send_ipi_data(CPULoongArchState *env, target_ulong val, target_ulong addr)
+static void send_ipi_data(CPULoongArchState *env, uint64_t val, hwaddr addr)
{
int i, mask = 0, data = 0;
--
2.39.2
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [RFC PATCH] hw/intc: don't use target_ulong for LoongArch ipi
2023-04-04 13:27 [RFC PATCH] hw/intc: don't use target_ulong for LoongArch ipi Alex Bennée
@ 2023-04-04 14:20 ` Philippe Mathieu-Daudé
2023-04-07 2:11 ` gaosong
1 sibling, 0 replies; 3+ messages in thread
From: Philippe Mathieu-Daudé @ 2023-04-04 14:20 UTC (permalink / raw)
To: Alex Bennée, qemu-devel; +Cc: Xiaojuan Yang, Song Gao
On 4/4/23 15:27, Alex Bennée wrote:
> The calling function is already working with hwaddr and uint64_t so
> lets avoid bringing target_ulong in if we don't need to.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> hw/intc/loongarch_ipi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [RFC PATCH] hw/intc: don't use target_ulong for LoongArch ipi
2023-04-04 13:27 [RFC PATCH] hw/intc: don't use target_ulong for LoongArch ipi Alex Bennée
2023-04-04 14:20 ` Philippe Mathieu-Daudé
@ 2023-04-07 2:11 ` gaosong
1 sibling, 0 replies; 3+ messages in thread
From: gaosong @ 2023-04-07 2:11 UTC (permalink / raw)
To: Alex Bennée, qemu-devel; +Cc: Xiaojuan Yang
在 2023/4/4 下午9:27, Alex Bennée 写道:
> The calling function is already working with hwaddr and uint64_t so
> lets avoid bringing target_ulong in if we don't need to.
>
> Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
> ---
> hw/intc/loongarch_ipi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Song Gao <gaosong@loongson.cn>
Thanks.
Song Gao
> diff --git a/hw/intc/loongarch_ipi.c b/hw/intc/loongarch_ipi.c
> index aa4bf9eb74..bdba0f8107 100644
> --- a/hw/intc/loongarch_ipi.c
> +++ b/hw/intc/loongarch_ipi.c
> @@ -50,7 +50,7 @@ static uint64_t loongarch_ipi_readl(void *opaque, hwaddr addr, unsigned size)
> return ret;
> }
>
> -static void send_ipi_data(CPULoongArchState *env, target_ulong val, target_ulong addr)
> +static void send_ipi_data(CPULoongArchState *env, uint64_t val, hwaddr addr)
> {
> int i, mask = 0, data = 0;
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-04-07 2:12 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2023-04-04 13:27 [RFC PATCH] hw/intc: don't use target_ulong for LoongArch ipi Alex Bennée
2023-04-04 14:20 ` Philippe Mathieu-Daudé
2023-04-07 2:11 ` gaosong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).