From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, "Alex Bennée" <alex.bennee@linaro.org>,
"Warner Losh" <imp@bsdimp.com>,
"Philippe Mathieu-Daudé" <philmd@linaro.org>
Subject: [PULL 03/10] gdbstub: don't report auxv feature unless on Linux
Date: Tue, 4 Apr 2023 15:59:18 +0100 [thread overview]
Message-ID: <20230404145925.2638152-4-alex.bennee@linaro.org> (raw)
In-Reply-To: <20230404145925.2638152-1-alex.bennee@linaro.org>
The later handler if conditionally compiled only for Linux but we
forgot to ensure we don't advertise it lest we confuse our BSD
brethren.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Fixes: 51c623b0de ("gdbstub: add support to Xfer:auxv:read: packet")
Reported-by: Warner Losh <imp@bsdimp.com>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Reviewed-by: Warner Losh <imp@bsdimp.com>
Tested-by: Warner Losh <imp@bsdimp.com>
Message-Id: <20230403134920.2132362-4-alex.bennee@linaro.org>
diff --git a/gdbstub/gdbstub.c b/gdbstub/gdbstub.c
index 2a66371aa5..0760d78685 100644
--- a/gdbstub/gdbstub.c
+++ b/gdbstub/gdbstub.c
@@ -1468,7 +1468,7 @@ static void handle_query_supported(GArray *params, void *user_ctx)
";ReverseStep+;ReverseContinue+");
}
-#ifdef CONFIG_USER_ONLY
+#if defined(CONFIG_USER_ONLY) && defined(CONFIG_LINUX)
if (gdbserver_state.c_cpu->opaque) {
g_string_append(gdbserver_state.str_buf, ";qXfer:auxv:read+");
}
--
2.39.2
next prev parent reply other threads:[~2023-04-04 15:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-04 14:59 [PULL for 8.0 00/10] misc fixes (tests, gdbstub, metadata) Alex Bennée
2023-04-04 14:59 ` [PULL 01/10] scripts/coverage: initial coverage comparison script Alex Bennée
2023-04-04 14:59 ` [PULL 02/10] gdbstub: Only build libgdb_user.fa / libgdb_softmmu.fa if necessary Alex Bennée
2023-04-04 14:59 ` Alex Bennée [this message]
2023-04-04 14:59 ` [PULL 04/10] MAINTAINERS: add a section for policy documents Alex Bennée
2023-04-04 14:59 ` [PULL 05/10] metadata: add .git-blame-ignore-revs Alex Bennée
2023-04-04 14:59 ` [PULL 06/10] Use hexagon toolchain version 16.0.0 Alex Bennée
2023-04-04 14:59 ` [PULL 07/10] tests/qemu-iotests: explicitly invoke 'check' via 'python' Alex Bennée
2023-04-04 14:59 ` [PULL 08/10] tests/vm: use the default system python for NetBSD Alex Bennée
2023-04-04 14:59 ` [PULL 09/10] gitlab: fix typo Alex Bennée
2023-04-04 14:59 ` [PULL 10/10] tests/avocado: Test Xen guest support under KVM Alex Bennée
2023-04-04 18:49 ` [PULL for 8.0 00/10] misc fixes (tests, gdbstub, metadata) Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230404145925.2638152-4-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=imp@bsdimp.com \
--cc=peter.maydell@linaro.org \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).