qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@linaro.org>
To: qemu-devel@nongnu.org
Cc: qemu-s390x@nongnu.org, qemu-riscv@nongnu.org,
	"Alex Bennée" <alex.bennee@linaro.org>,
	qemu-arm@nongnu.org, kvm@vger.kernel.org, qemu-ppc@nongnu.org,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Palmer Dabbelt" <palmer@dabbelt.com>,
	"Alistair Francis" <alistair.francis@wdc.com>,
	"Bin Meng" <bin.meng@windriver.com>,
	"Weiwei Li" <liweiwei@iscas.ac.cn>,
	"Daniel Henrique Barboza" <dbarboza@ventanamicro.com>,
	"Liu Zhiwei" <zhiwei_liu@linux.alibaba.com>
Subject: [RFC PATCH 09/10] target/riscv: Restrict KVM-specific fields from ArchCPU
Date: Wed,  5 Apr 2023 18:04:53 +0200	[thread overview]
Message-ID: <20230405160454.97436-10-philmd@linaro.org> (raw)
In-Reply-To: <20230405160454.97436-1-philmd@linaro.org>

These fields shouldn't be accessed when KVM is not available.

Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
---
RFC: The migration part is likely invalid...

kvmtimer_needed() is defined in target/riscv/machine.c as

  static bool kvmtimer_needed(void *opaque)
  {
      return kvm_enabled();
  }

which depends on a host feature.
---
 target/riscv/cpu.h     | 2 ++
 target/riscv/machine.c | 4 ++++
 2 files changed, 6 insertions(+)

diff --git a/target/riscv/cpu.h b/target/riscv/cpu.h
index 638e47c75a..82939235ab 100644
--- a/target/riscv/cpu.h
+++ b/target/riscv/cpu.h
@@ -377,12 +377,14 @@ struct CPUArchState {
     hwaddr kernel_addr;
     hwaddr fdt_addr;
 
+#ifdef CONFIG_KVM
     /* kvm timer */
     bool kvm_timer_dirty;
     uint64_t kvm_timer_time;
     uint64_t kvm_timer_compare;
     uint64_t kvm_timer_state;
     uint64_t kvm_timer_frequency;
+#endif /* CONFIG_KVM */
 };
 
 OBJECT_DECLARE_CPU_TYPE(RISCVCPU, RISCVCPUClass, RISCV_CPU)
diff --git a/target/riscv/machine.c b/target/riscv/machine.c
index 9c455931d8..e45d564ec3 100644
--- a/target/riscv/machine.c
+++ b/target/riscv/machine.c
@@ -201,10 +201,12 @@ static bool kvmtimer_needed(void *opaque)
 
 static int cpu_post_load(void *opaque, int version_id)
 {
+#ifdef CONFIG_KVM
     RISCVCPU *cpu = opaque;
     CPURISCVState *env = &cpu->env;
 
     env->kvm_timer_dirty = true;
+#endif
     return 0;
 }
 
@@ -215,9 +217,11 @@ static const VMStateDescription vmstate_kvmtimer = {
     .needed = kvmtimer_needed,
     .post_load = cpu_post_load,
     .fields = (VMStateField[]) {
+#ifdef CONFIG_KVM
         VMSTATE_UINT64(env.kvm_timer_time, RISCVCPU),
         VMSTATE_UINT64(env.kvm_timer_compare, RISCVCPU),
         VMSTATE_UINT64(env.kvm_timer_state, RISCVCPU),
+#endif
         VMSTATE_END_OF_LIST()
     }
 };
-- 
2.38.1



  parent reply	other threads:[~2023-04-05 16:07 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-05 16:04 [PATCH 00/10] accel/kvm: Spring cleaning Philippe Mathieu-Daudé
2023-04-05 16:04 ` [PATCH 01/10] sysemu/kvm: Remove unused headers Philippe Mathieu-Daudé
2023-04-06  8:58   ` Alex Bennée
2023-04-08  0:36   ` Richard Henderson
2023-06-06  5:32   ` Philippe Mathieu-Daudé
2023-04-05 16:04 ` [PATCH 02/10] accel/kvm: Declare kvm_direct_msi_allowed in stubs Philippe Mathieu-Daudé
2023-04-06  8:59   ` Alex Bennée
2023-04-08  0:37   ` Richard Henderson
2023-04-05 16:04 ` [PATCH 03/10] hw/intc/arm_gic: Un-inline GIC*/ITS class_name() helpers Philippe Mathieu-Daudé
2023-04-08  4:22   ` Richard Henderson
2023-04-05 16:04 ` [PATCH 04/10] hw/intc/arm_gic: Rename 'first_cpu' argument Philippe Mathieu-Daudé
2023-04-08  4:23   ` Richard Henderson
2023-04-08  4:24     ` Richard Henderson
2023-04-11  7:31   ` Alex Bennée
2023-04-05 16:04 ` [PATCH 05/10] hw/arm/sbsa-ref: Include missing 'sysemu/kvm.h' header Philippe Mathieu-Daudé
2023-04-05 18:23   ` Leif Lindholm
2023-04-08  4:24   ` Richard Henderson
2023-04-05 16:04 ` [PATCH 06/10] target/arm: Reduce QMP header pressure by not including 'kvm_arm.h' Philippe Mathieu-Daudé
2023-04-08  4:25   ` Richard Henderson
2023-04-05 16:04 ` [PATCH 07/10] target/arm: Restrict KVM-specific fields from ArchCPU Philippe Mathieu-Daudé
2023-04-08  4:25   ` Richard Henderson
2023-04-05 16:04 ` [PATCH 08/10] target/ppc: Restrict KVM-specific field " Philippe Mathieu-Daudé
2023-04-05 20:07   ` Daniel Henrique Barboza
2023-04-06 17:46   ` Cédric Le Goater
2023-04-05 16:04 ` Philippe Mathieu-Daudé [this message]
2023-04-05 20:44   ` [RFC PATCH 09/10] target/riscv: Restrict KVM-specific fields " Daniel Henrique Barboza
2023-04-08  4:28   ` Richard Henderson
2023-04-08  4:29     ` Richard Henderson
2023-04-05 16:04 ` [PATCH 10/10] hw/s390x: Rename pv.c -> pv-kvm.c Philippe Mathieu-Daudé
2023-04-06  7:50   ` Thomas Huth
2023-04-06  8:04     ` Janosch Frank
2023-04-06  8:22       ` Philippe Mathieu-Daudé
2023-04-06  8:30         ` Thomas Huth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230405160454.97436-10-philmd@linaro.org \
    --to=philmd@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=alistair.francis@wdc.com \
    --cc=bin.meng@windriver.com \
    --cc=dbarboza@ventanamicro.com \
    --cc=kvm@vger.kernel.org \
    --cc=liweiwei@iscas.ac.cn \
    --cc=palmer@dabbelt.com \
    --cc=qemu-arm@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=qemu-riscv@nongnu.org \
    --cc=qemu-s390x@nongnu.org \
    --cc=zhiwei_liu@linux.alibaba.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).