From: Stefan Hajnoczi <stefanha@redhat.com>
To: Hanna Czenczek <hreitz@redhat.com>
Cc: qemu-block@nongnu.org, qemu-devel@nongnu.org,
Vladimir Sementsov-Ogievskiy <vsementsov@yandex-team.ru>,
Eric Blake <eblake@redhat.com>, Kevin Wolf <kwolf@redhat.com>,
Fam Zheng <fam@euphon.net>
Subject: Re: [PATCH 0/4] block: Split padded I/O vectors exceeding IOV_MAX
Date: Wed, 5 Apr 2023 15:44:35 -0400 [thread overview]
Message-ID: <20230405194435.GC676473@fedora> (raw)
In-Reply-To: <20230317175019.10857-1-hreitz@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 1342 bytes --]
On Fri, Mar 17, 2023 at 06:50:15PM +0100, Hanna Czenczek wrote:
> RFC:
> https://lists.nongnu.org/archive/html/qemu-block/2023-03/msg00446.html
>
> Thanks for the feedback on the RFC! Sounds like we agree that this is
> the right way to fix the bug.
>
> Here in v1, I’ve followed Vladimir’s suggestion to inline the
> functionality of qemu_iovec_init_extended() in block/io.c, which, I
> think (hope), also addresses much of the feedback of Eric and Stefan.
>
> The test is unchanged, the rest is pretty much rewritten (though in
> spirit stays the same).
>
>
> Hanna Czenczek (4):
> util/iov: Make qiov_slice() public
> block: Split padded I/O vectors exceeding IOV_MAX
> util/iov: Remove qemu_iovec_init_extended()
> iotests/iov-padding: New test
>
> include/qemu/iov.h | 8 +-
> block/io.c | 153 +++++++++++++++++++++--
> util/iov.c | 89 +++----------
> tests/qemu-iotests/tests/iov-padding | 85 +++++++++++++
> tests/qemu-iotests/tests/iov-padding.out | 59 +++++++++
> 5 files changed, 306 insertions(+), 88 deletions(-)
> create mode 100755 tests/qemu-iotests/tests/iov-padding
> create mode 100644 tests/qemu-iotests/tests/iov-padding.out
Acked-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2023-04-05 19:45 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-17 17:50 [PATCH 0/4] block: Split padded I/O vectors exceeding IOV_MAX Hanna Czenczek
2023-03-17 17:50 ` [PATCH 1/4] util/iov: Make qiov_slice() public Hanna Czenczek
2023-03-18 12:06 ` Eric Blake
2023-03-20 10:00 ` Vladimir Sementsov-Ogievskiy
2023-03-17 17:50 ` [PATCH 2/4] block: Split padded I/O vectors exceeding IOV_MAX Hanna Czenczek
2023-03-18 12:19 ` Eric Blake
2023-03-20 10:31 ` Vladimir Sementsov-Ogievskiy
2023-04-03 13:33 ` Hanna Czenczek
2023-04-04 8:10 ` Vladimir Sementsov-Ogievskiy
2023-04-04 17:32 ` Hanna Czenczek
2023-04-05 9:59 ` Vladimir Sementsov-Ogievskiy
2023-04-06 16:51 ` Hanna Czenczek
2023-04-06 21:35 ` Vladimir Sementsov-Ogievskiy
2023-03-17 17:50 ` [PATCH 3/4] util/iov: Remove qemu_iovec_init_extended() Hanna Czenczek
2023-03-18 12:22 ` Eric Blake
2023-03-20 11:59 ` Vladimir Sementsov-Ogievskiy
2023-03-17 17:50 ` [PATCH 4/4] iotests/iov-padding: New test Hanna Czenczek
2023-03-18 12:39 ` Eric Blake
2023-04-03 14:23 ` Hanna Czenczek
2023-03-20 12:12 ` Vladimir Sementsov-Ogievskiy
2023-04-05 19:44 ` Stefan Hajnoczi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230405194435.GC676473@fedora \
--to=stefanha@redhat.com \
--cc=eblake@redhat.com \
--cc=fam@euphon.net \
--cc=hreitz@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=vsementsov@yandex-team.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).