From: "Michael S. Tsirkin" <mst@redhat.com>
To: David Turner <digit@google.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [PATCH 1/3] Fix libvhost-user.c compilation.
Date: Fri, 7 Apr 2023 06:01:54 -0400 [thread overview]
Message-ID: <20230407060016-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CACnJMqqte0Y7_SJt9Q3_ZVaj3=46tqNS6EPfp_gg91B_J3VD4A@mail.gmail.com>
On Fri, Apr 07, 2023 at 11:47:50AM +0200, David Turner wrote:
> Digging a little further, the top-level meson.build for qemu has the following:
>
>
> if targetos == 'linux'
> add_project_arguments('-isystem', meson.current_source_dir() /
> 'linux-headers',
> '-isystem', 'linux-headers',
> language: all_languages)
> endif
>
>
> But this does not carry to the subprojects (and there is nothing equivalent in
> subprojects/libvhost-user/meson.build)/
> If I change the above to use add_global_arguments() instead, compilation
> succeeds.
>
> I don´t know if this is going to break other things though, but I'd be happy to
> change the patch to do that instead.
Or just add above lines to libvhost-user. That's probably safer.
--
MST
next prev parent reply other threads:[~2023-04-07 10:02 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-05 17:21 [PATCH v2] Fix QEMU compilation on Debian 10 David 'Digit' Turner
2023-04-05 17:21 ` [PATCH 1/3] Fix libvhost-user.c compilation David 'Digit' Turner
2023-04-07 8:03 ` Michael S. Tsirkin
2023-04-07 9:24 ` David Turner
2023-04-07 9:25 ` David Turner
2023-04-07 9:29 ` David Turner
2023-04-07 9:46 ` Michael S. Tsirkin
2023-04-07 9:49 ` David Turner
2023-04-07 9:47 ` David Turner
2023-04-07 10:01 ` Michael S. Tsirkin [this message]
2023-04-18 8:47 ` Daniel P. Berrangé
2023-04-18 11:04 ` David Turner
2023-04-18 11:47 ` Michael S. Tsirkin
2023-04-05 17:21 ` [PATCH 2/3] update-linux-headers.sh: Add missing kernel headers David 'Digit' Turner
2023-04-05 17:21 ` [PATCH 3/3] Update linux headers to v6.3rc5 David 'Digit' Turner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230407060016-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=digit@google.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).