[PULL 0/1] ppc queue

[PULL 0/1] ppc queue

[Cédric Le Goater]

The following changes since commit c6f3cbca32bde9ee94d9949aa63e8a7ef2d7bc5b:

  Update version for v8.0.0-rc3 release (2023-04-05 17:26:14 +0100)

are available in the Git repository at:

  https://github.com/legoater/qemu/ tags/pull-ppc-20230409

for you to fetch changes up to a253231fbede6e69bf287afd90f67347a7383aab:

  target/ppc: Fix temp usage in gen_op_arith_modw (2023-04-09 19:21:27 +0200)

----------------------------------------------------------------
ppc queue:

* Fix regresion with prefix instructions and pcrel addressing

----------------------------------------------------------------
Richard Henderson (1):
      target/ppc: Fix temp usage in gen_op_arith_modw

 target/ppc/translate.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

[PULL 1/1] target/ppc: Fix temp usage in gen_op_arith_modw

[Cédric Le Goater]

From: Richard Henderson <richard.henderson@linaro.org>

Fix a crash writing to 't3', which is now a constant.
Instead, write the result of the remu to 't0'.

Fixes: 7058ff5231a ("target/ppc: Avoid tcg_const_* in translate.c")
Reported-by: Nicholas Piggin <npiggin@gmail.com>
Reviewed-by: Anton Johansson <anjo@rev.ng>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
[ clg: amend commit log s/t1/t0/ ]
Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
 target/ppc/translate.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/target/ppc/translate.c b/target/ppc/translate.c
index 9d05357d03..f603f1a939 100644
--- a/target/ppc/translate.c
+++ b/target/ppc/translate.c
@@ -1807,8 +1807,8 @@ static inline void gen_op_arith_modw(DisasContext *ctx, TCGv ret, TCGv arg1,
         TCGv_i32 t2 = tcg_constant_i32(1);
         TCGv_i32 t3 = tcg_constant_i32(0);
         tcg_gen_movcond_i32(TCG_COND_EQ, t1, t1, t3, t2, t1);
-        tcg_gen_remu_i32(t3, t0, t1);
-        tcg_gen_extu_i32_tl(ret, t3);
+        tcg_gen_remu_i32(t0, t0, t1);
+        tcg_gen_extu_i32_tl(ret, t0);
     }
 }
 
-- 
2.39.2

Re: [PULL 0/1] ppc queue

[Peter Maydell]

On Sun, 9 Apr 2023 at 22:23, Cédric Le Goater <clg@kaod.org> wrote:
>
> The following changes since commit c6f3cbca32bde9ee94d9949aa63e8a7ef2d7bc5b:
>
>   Update version for v8.0.0-rc3 release (2023-04-05 17:26:14 +0100)
>
> are available in the Git repository at:
>
>   https://github.com/legoater/qemu/ tags/pull-ppc-20230409
>
> for you to fetch changes up to a253231fbede6e69bf287afd90f67347a7383aab:
>
>   target/ppc: Fix temp usage in gen_op_arith_modw (2023-04-09 19:21:27 +0200)
>
> ----------------------------------------------------------------
> ppc queue:
>
> * Fix regresion with prefix instructions and pcrel addressing


Applied, thanks.

Please update the changelog at https://wiki.qemu.org/ChangeLog/8.0
for any user-visible changes.

-- PMM