qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, peter.maydell@linaro.org, qemu-devel@nongnu.org
Subject: [PULL 04/10] block: remove has_variable_length from filters
Date: Tue, 11 Apr 2023 17:01:41 +0200	[thread overview]
Message-ID: <20230411150147.318637-5-kwolf@redhat.com> (raw)
In-Reply-To: <20230411150147.318637-1-kwolf@redhat.com>

From: Paolo Bonzini <pbonzini@redhat.com>

Filters automatically get has_variable_length from their underlying
BlockDriverState.  There is no need to mark them as variable-length
in the BlockDriver.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20230407153303.391121-3-pbonzini@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
 block/copy-on-read.c    | 1 -
 block/filter-compress.c | 1 -
 block/preallocate.c     | 1 -
 block/replication.c     | 1 -
 4 files changed, 4 deletions(-)

diff --git a/block/copy-on-read.c b/block/copy-on-read.c
index cc0f848b0f..b4d6b7efc3 100644
--- a/block/copy-on-read.c
+++ b/block/copy-on-read.c
@@ -259,7 +259,6 @@ static BlockDriver bdrv_copy_on_read = {
     .bdrv_co_eject                      = cor_co_eject,
     .bdrv_co_lock_medium                = cor_co_lock_medium,
 
-    .has_variable_length                = true,
     .is_filter                          = true,
 };
 
diff --git a/block/filter-compress.c b/block/filter-compress.c
index ac285f4b66..320d9576fa 100644
--- a/block/filter-compress.c
+++ b/block/filter-compress.c
@@ -146,7 +146,6 @@ static BlockDriver bdrv_compress = {
     .bdrv_co_eject                      = compress_co_eject,
     .bdrv_co_lock_medium                = compress_co_lock_medium,
 
-    .has_variable_length                = true,
     .is_filter                          = true,
 };
 
diff --git a/block/preallocate.c b/block/preallocate.c
index 71c3601809..4d82125036 100644
--- a/block/preallocate.c
+++ b/block/preallocate.c
@@ -558,7 +558,6 @@ BlockDriver bdrv_preallocate_filter = {
     .bdrv_set_perm = preallocate_set_perm,
     .bdrv_child_perm = preallocate_child_perm,
 
-    .has_variable_length = true,
     .is_filter = true,
 };
 
diff --git a/block/replication.c b/block/replication.c
index de01f96184..ea4bf1aa80 100644
--- a/block/replication.c
+++ b/block/replication.c
@@ -762,7 +762,6 @@ static BlockDriver bdrv_replication = {
 
     .is_filter                  = true,
 
-    .has_variable_length        = true,
     .strong_runtime_opts        = replication_strong_runtime_opts,
 };
 
-- 
2.39.2



  parent reply	other threads:[~2023-04-11 15:04 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-11 15:01 [PULL 00/10] Block layer fixes for 8.0-rc4 Kevin Wolf
2023-04-11 15:01 ` [PULL 01/10] block/vhdx: fix dynamic VHDX BAT corruption Kevin Wolf
2023-04-11 15:01 ` [PULL 02/10] iotests: Regression test for vhdx log corruption Kevin Wolf
2023-04-11 15:01 ` [PULL 03/10] block: move has_variable_length to BlockLimits Kevin Wolf
2023-04-11 15:01 ` Kevin Wolf [this message]
2023-04-11 15:01 ` [PULL 05/10] block: refresh bs->total_sectors on reopen Kevin Wolf
2023-04-11 15:01 ` [PULL 06/10] block: remove has_variable_length from BlockDriver Kevin Wolf
2023-04-11 15:01 ` [PULL 07/10] migration/block: replace uses of blk_nb_sectors that do not check result Kevin Wolf
2023-04-11 15:01 ` [PULL 08/10] block-backend: inline bdrv_co_get_geometry Kevin Wolf
2023-04-11 15:01 ` [PULL 09/10] block-backend: ignore inserted state in blk_co_nb_sectors Kevin Wolf
2023-04-11 15:01 ` [PULL 10/10] block, block-backend: write some hot coroutine wrappers by hand Kevin Wolf
2023-04-12 11:40 ` [PULL 00/10] Block layer fixes for 8.0-rc4 Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230411150147.318637-5-kwolf@redhat.com \
    --to=kwolf@redhat.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).