From: Kevin Wolf <kwolf@redhat.com>
To: qemu-block@nongnu.org
Cc: kwolf@redhat.com, peter.maydell@linaro.org, qemu-devel@nongnu.org
Subject: [PULL 08/10] block-backend: inline bdrv_co_get_geometry
Date: Tue, 11 Apr 2023 17:01:45 +0200 [thread overview]
Message-ID: <20230411150147.318637-9-kwolf@redhat.com> (raw)
In-Reply-To: <20230411150147.318637-1-kwolf@redhat.com>
From: Paolo Bonzini <pbonzini@redhat.com>
bdrv_co_get_geometry is only used in blk_co_get_geometry. Inline it in
there, to reduce the number of wrappers for bs->total_sectors.
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Message-Id: <20230407153303.391121-7-pbonzini@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
Signed-off-by: Kevin Wolf <kwolf@redhat.com>
---
include/block/block-io.h | 3 ---
block.c | 10 ----------
block/block-backend.c | 8 ++++++--
3 files changed, 6 insertions(+), 15 deletions(-)
diff --git a/include/block/block-io.h b/include/block/block-io.h
index dbc034b728..9e2248a295 100644
--- a/include/block/block-io.h
+++ b/include/block/block-io.h
@@ -90,9 +90,6 @@ int64_t co_wrapper bdrv_get_allocated_file_size(BlockDriverState *bs);
BlockMeasureInfo *bdrv_measure(BlockDriver *drv, QemuOpts *opts,
BlockDriverState *in_bs, Error **errp);
-void coroutine_fn GRAPH_RDLOCK
-bdrv_co_get_geometry(BlockDriverState *bs, uint64_t *nb_sectors_ptr);
-
int coroutine_fn GRAPH_RDLOCK
bdrv_co_delete_file(BlockDriverState *bs, Error **errp);
diff --git a/block.c b/block.c
index be7dc5d3e9..e8e08ad668 100644
--- a/block.c
+++ b/block.c
@@ -5879,16 +5879,6 @@ int64_t coroutine_fn bdrv_co_getlength(BlockDriverState *bs)
return ret * BDRV_SECTOR_SIZE;
}
-/* return 0 as number of sectors if no device present or error */
-void coroutine_fn bdrv_co_get_geometry(BlockDriverState *bs,
- uint64_t *nb_sectors_ptr)
-{
- int64_t nb_sectors = bdrv_co_nb_sectors(bs);
- IO_CODE();
-
- *nb_sectors_ptr = nb_sectors < 0 ? 0 : nb_sectors;
-}
-
bool bdrv_is_sg(BlockDriverState *bs)
{
IO_CODE();
diff --git a/block/block-backend.c b/block/block-backend.c
index 2ee39229e4..36e3a67dff 100644
--- a/block/block-backend.c
+++ b/block/block-backend.c
@@ -1615,16 +1615,20 @@ int64_t coroutine_fn blk_co_getlength(BlockBackend *blk)
return bdrv_co_getlength(blk_bs(blk));
}
+/* return 0 as number of sectors if no device present or error */
void coroutine_fn blk_co_get_geometry(BlockBackend *blk,
uint64_t *nb_sectors_ptr)
{
+ BlockDriverState *bs = blk_bs(blk);
+
IO_CODE();
GRAPH_RDLOCK_GUARD();
- if (!blk_bs(blk)) {
+ if (!bs) {
*nb_sectors_ptr = 0;
} else {
- bdrv_co_get_geometry(blk_bs(blk), nb_sectors_ptr);
+ int64_t nb_sectors = bdrv_co_nb_sectors(bs);
+ *nb_sectors_ptr = nb_sectors < 0 ? 0 : nb_sectors;
}
}
--
2.39.2
next prev parent reply other threads:[~2023-04-11 15:04 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-11 15:01 [PULL 00/10] Block layer fixes for 8.0-rc4 Kevin Wolf
2023-04-11 15:01 ` [PULL 01/10] block/vhdx: fix dynamic VHDX BAT corruption Kevin Wolf
2023-04-11 15:01 ` [PULL 02/10] iotests: Regression test for vhdx log corruption Kevin Wolf
2023-04-11 15:01 ` [PULL 03/10] block: move has_variable_length to BlockLimits Kevin Wolf
2023-04-11 15:01 ` [PULL 04/10] block: remove has_variable_length from filters Kevin Wolf
2023-04-11 15:01 ` [PULL 05/10] block: refresh bs->total_sectors on reopen Kevin Wolf
2023-04-11 15:01 ` [PULL 06/10] block: remove has_variable_length from BlockDriver Kevin Wolf
2023-04-11 15:01 ` [PULL 07/10] migration/block: replace uses of blk_nb_sectors that do not check result Kevin Wolf
2023-04-11 15:01 ` Kevin Wolf [this message]
2023-04-11 15:01 ` [PULL 09/10] block-backend: ignore inserted state in blk_co_nb_sectors Kevin Wolf
2023-04-11 15:01 ` [PULL 10/10] block, block-backend: write some hot coroutine wrappers by hand Kevin Wolf
2023-04-12 11:40 ` [PULL 00/10] Block layer fixes for 8.0-rc4 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230411150147.318637-9-kwolf@redhat.com \
--to=kwolf@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).